Issue metadata
Sign in to add a comment
|
Drive files on launcher are small
Reported by
alvarogu...@gmail.com,
May 16 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; CrOS x86_64 9334.58.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.89 Safari/537.36 Platform: 9334.58.0 (Official Build) beta-channel lulu Steps to reproduce the problem: 1. Press the search button to get the launcher displayed 2. Write the name of a file you have on google drive or downloaded 3. See the icon to the left of the result of the file What is the expected behavior? The icon of the type of file should be bigger to tell which file are you opening. What went wrong? The icon is displayed so tiny, that sometimes you don't know which one is the one you are looking for. Did this work before? Yes Cannot remember Chrome version: 58.0.3029.89 Channel: beta OS Version: 9334.58.0 Flash Version: The icons of google forms do not display on the launcher, and on the files app are green instead of purple.
,
May 19 2017
,
Jul 7 2017
,
Jul 7 2017
,
Jul 18 2017
,
Jul 27 2017
Similar issue to issue 748667, the reason might be that we are reusing the assets from omnibox search results, let us customize it for launcher.
,
Jul 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d2ce5fc2424a8a9fb2d866557e2c3acbe0ae7ce commit 5d2ce5fc2424a8a9fb2d866557e2c3acbe0ae7ce Author: Qiang Xu <warx@chromium.org> Date: Mon Jul 31 04:20:14 2017 app_list: resize launcher search icon image to proper size context: In crbug.com/490597 , 2x image is used for HiDPI blur issue. Then there is a CL "Migrate LauncherSearchResult to use SetBadgeIcon", https://codereview.chromium.org/1200543003, which I think it removes the proper handling of the size of this 2x loading. changes: When custom icon is loaded, resize it to proper size. HiDPI screenshot: https://screenshot.googleplex.com/2rWk8akUx99 Test: tested that it works fine now, screenshot: https://screenshot.googleplex.com/u9BapUpenhu Bug: 723021 Change-Id: If18a59e7aaeed48e9a0e88409f8672d057eb986a Reviewed-on: https://chromium-review.googlesource.com/592415 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Yuki Awano <yawano@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#490707} [modify] https://crrev.com/5d2ce5fc2424a8a9fb2d866557e2c3acbe0ae7ce/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader.cc [modify] https://crrev.com/5d2ce5fc2424a8a9fb2d866557e2c3acbe0ae7ce/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_impl.cc
,
Jul 31 2017
,
Jul 31 2017
launcher cl for m61
,
Jul 31 2017
Approving merge to M61 Chrome OS.
,
Aug 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ade4b6f22ff8cb968168f048fc2270d6d60505aa commit ade4b6f22ff8cb968168f048fc2270d6d60505aa Author: Maajid <maajid@chromium.org> Date: Thu Aug 03 21:53:22 2017 app_list: resize launcher search icon image to proper size context: In crbug.com/490597 , 2x image is used for HiDPI blur issue. Then there is a CL "Migrate LauncherSearchResult to use SetBadgeIcon", https://codereview.chromium.org/1200543003, which I think it removes the proper handling of the size of this 2x loading. changes: When custom icon is loaded, resize it to proper size. HiDPI screenshot: https://screenshot.googleplex.com/2rWk8akUx99 TBR=warx@chromium.org (cherry picked from commit 5d2ce5fc2424a8a9fb2d866557e2c3acbe0ae7ce) Test: tested that it works fine now, screenshot: https://screenshot.googleplex.com/u9BapUpenhu Bug: 723021 Change-Id: If18a59e7aaeed48e9a0e88409f8672d057eb986a Reviewed-on: https://chromium-review.googlesource.com/592415 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Yuki Awano <yawano@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#490707} Reviewed-on: https://chromium-review.googlesource.com/600858 Reviewed-by: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#289} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/ade4b6f22ff8cb968168f048fc2270d6d60505aa/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader.cc [modify] https://crrev.com/ade4b6f22ff8cb968168f048fc2270d6d60505aa/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_impl.cc
,
Aug 3 2017
,
Aug 7 2017
I have attached a screenshot for this issue. Please confirm, if this is the expected output. The icon size still appears to be small. And, this displaying of search result happens for only google drive files and not for files under Downloads folder. Please let me know, if this is the expected behavior. If not, I will go forward with raising a bug. Checked on M62 (Chrome OS 9817.0.0, 62.0.3176.0 dev build).
,
Aug 7 2017
It should display the icon size as your image, that is the expected behavior, when searching either on google drive or files app. The size is perfect, even if you might think is small. I will just note again that the Google forms icon is still green and is easily confused by the Google sheet icon. The Google forms icon should be purple.
,
Aug 7 2017
In fact, the google forms icon does not display when searching on the launcher. As you can see on the attached image, the last file with the files app icon is a google form. When you search on the files app, they displays green.
,
Aug 8 2017
Thank you for confirming me on the size. 1. I guess color of Google forms icon can be fixed as part of Issue 753532. I have also captured similar issues as part of this bug. 2. As you said in #16, apart from Google forms, icons like Google site, Gmaps, Gdoc are not displayed while searching on launcher. I guess this needs to be fixed. If not in this bug, I can raise another bug for this issue and fixes can go in there. 3. One more issue I found was- while searching on launcher, displays only files from Google drive and not from Downloads folder (Ref: #1, step 2).Please confirm the behavior on this. Thank you!
,
Aug 9 2017
Thank you for taking care of this bug. 1) Your issue has the correct report for the google forms icon. So let's keep things tidy and let that bug take care of that issue. 2) Yes, those icons are not displayed at all. So please raise a bug. 3) Totally true! I have not even notice! When searching from launcher, the files allocated offline via files app are not being search by the launcher.
,
Aug 9 2017
I have raised bug Issue 753902 to fix No.2 of #18 and No.3 is taken care in Issue 753970. Since the size of the icon looks good and has been verified, can I move ahead in closing this bug? Please do let me know on this. Thank you for your time!
,
Aug 9 2017
Totally. This bug is closed
,
Aug 9 2017
Thank you again!
,
Sep 28 2017
When this bug will be fixed? The icons still displays small.
,
Sep 28 2017
m61
,
Sep 28 2017
Thanks :)
,
Mar 17 2018
I still see the gform icons green. The Issue 753532 is still not assigned. And i keep having this problem of confusing the gforms and its respective gsheet result sheet.
,
Mar 18 2018
That will be addressed in Issue 753902. It seems it hasn't taken actions yet.
,
Mar 18 2018
I cannot see the issue 753902. Hope someone takes it and merge it with Issue 753532 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by alvarogu...@gmail.com
, May 16 201740.5 KB
40.5 KB View Download