New issue
Advanced search Search tips

Issue 723012 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Debug Mac builds with --disable-gpu only show new tiles

Project Member Reported by enne@chromium.org, May 16 2017

Issue description

Running mac debug builds have debug blue color everywhere except on newly updated tiles.  Release builds work fine.
 
Screen Shot 2017-05-16 at 1.48.06 PM.png
103 KB View Download
Owner: ccameron@chromium.org
Status: Assigned (was: Available)
This is an issue with the following sequence of events:

SoftwareOutputDeviceMac::BeginPaint
- copies the front buffer to the back buffer
SoftwareRenderer::ClearFramebuffer
- clears the back buffer
SoftwareOutputDeviceMac::EndPaint
- swaps the front & back buffer

Two issues here
- the clear should happen before the copy
- the copy should be for the full window if we're going to do a clear
Hmm, this was on my bugs-to-look-at-when-I-have-time list, and ... I can't repro this anymore. Trying again.
I think this is fixed. In particular, the call sequence is
- DirectRenderer::DrawRenderPass
  - sets mode to SURFACE_INITIALIZATION_MODE_SCISSORED_CLEAR
- SoftwareRenderer::PrepareSurfaceForPass
  - sets the damage rect in SoftwareRenderer::SetScissorTestRect
- SoftwareRenderer::ClearFramebuffer
  - only clears the scissored rect

I'm pretty sure this was fixed by r477453 (thanks!).
Status: Fixed (was: Assigned)

Sign in to add a comment