New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 723003 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Jun 2017
Cc:
█ sujith...@samsung.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Form reset algorithm does not reset option dirtiness

Project Member Reported by domenic@chromium.org, May 16 2017

Comment 1 by tkent@chromium.org, May 17 2017

Components: -Blink>Forms Blink>Forms>Select
Owner: tkent@chromium.org
Chrome: Fail
Edge: Fail
Firefox: Fail
Safari TP: Pass

AFAIK, Edge and Safari don't have OPTION dirtiness flag.  We need to investigate the root cause.

Comment 2 by tkent@chromium.org, May 17 2017

Owner: ----
Status: Available (was: Untriaged)
Wow, found a silly bug :(

void HTMLOptionElement::SetDirty(bool value) {
  is_dirty_ = true;
}

Safari passes the test because it has no dirtiness flag and option.defaultSelected=false is always same as option.selected=false.

Comment 3 by tkent@chromium.org, May 22 2017

Labels: Hotlist-GoodFirstBug

Comment 4 Deleted

Comment 5 Deleted

Comment 6 Deleted

Comment 7 Deleted

Comment 8 by djmix....@samsung.com, May 27 2017 

Can I take this?

Comment 9 by djmix....@samsung.com, May 27 2017 

I've update patch for this as below.
https://codereview.chromium.org/2913483002/

Comment 10 by tkent@chromium.org, May 28 2017

Cc: sujith...@samsung.com
sujiths.s@samsung.com already started this issue, and posted a patch.  Why did he removed his comments?
https://codereview.chromium.org/2906883002/

Comment 11 Deleted

Comment 12 by tkent@chromium.org, Jun 2 2017

Labels: M-61
Status: Fixed (was: Available)
Fixed by https://codereview.chromium.org/2906883002/.  It had no BUG= line.

Comment 13 Deleted

Comment 14 Deleted

►

Sign in to add a comment