Issue metadata
Sign in to add a comment
|
16kb regression in resource_sizes (MonochromePublic.apk) at 471277:471277 |
||||||||||||||||||||
Issue descriptionCaused by: "Build FreeType with HarfBuzz support" a377e3e1fa4f44a58f70abb2402e6cc79e210945
,
May 16 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8979409135673684768
,
May 16 2017
=== BISECT JOB RESULTS ===
Bisect failed for unknown reasons
Please contact the team (see below) and report the error.
Bisect Details
Configuration: android_nexus7_perf_bisect
Benchmark : resource_sizes
Metric : MonochromePublic.apk_Specifics/normalized apk size
To Run This Test
src/build/android/resource_sizes.py --chromium-output-directory {CHROMIUM_OUTPUT_DIR} --chartjson {CHROMIUM_OUTPUT_DIR}/apks/MonochromePublic.apk
Debug Info
https://chromeperf.appspot.com/buildbucket_job_status/8979409135673684768
Is this bisect wrong?
https://chromeperf.appspot.com/bad_bisect?try_job_id=6270596641456128
| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
| X | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection. Thank you!
,
May 17 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8979393826907411376
,
May 17 2017
=== BISECT JOB RESULTS ===
NO Perf regression found, tests failed to produce values
Bisect Details
Configuration: android_nexus7_perf_bisect
Benchmark : resource_sizes
Metric : MonochromePublic.apk_Specifics/normalized apk size
To Run This Test
src/build/android/resource_sizes.py --chromium-output-directory {CHROMIUM_OUTPUT_DIR} --chartjson {CHROMIUM_OUTPUT_DIR}/apks/MonochromePublic.apk
Debug Info
https://chromeperf.appspot.com/buildbucket_job_status/8979393826907411376
Is this bisect wrong?
https://chromeperf.appspot.com/bad_bisect?try_job_id=6270596641456128
| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
| X | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection. Thank you!
,
May 18 2017
Expected, AFAIK
,
May 18 2017
And just to be extra sure: this is used on Android?
,
May 18 2017
Yes, freetype and harfbuzz both are used on all platforms now, including Android.
,
May 19 2017
The additional binary size originates from additional logic that is getting build in FreeType for autohinting based on HarfBuzz information and the hb-ft-* functions. I believe this is used on Android as well in certain cases, but I'll try to double check it.
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba0e6cd12bf6f5e864e1f60993ceafef3f4a7cae commit ba0e6cd12bf6f5e864e1f60993ceafef3f4a7cae Author: drott <drott@chromium.org> Date: Wed May 24 09:08:34 2017 Do not build FreeType with HarfBuzz support on Android Originally, building FreeType with HarfBuzz, helped improve autohinting on Linux, see issue 617168 . However, the performance impact we observe on Android does not seem to justify running autohinting with HarfBuzz support on Android. BUG= 722980 , 724095 Review-Url: https://codereview.chromium.org/2896203002 Cr-Commit-Position: refs/heads/master@{#474221} [modify] https://crrev.com/ba0e6cd12bf6f5e864e1f60993ceafef3f4a7cae/third_party/freetype/BUILD.gn [modify] https://crrev.com/ba0e6cd12bf6f5e864e1f60993ceafef3f4a7cae/third_party/freetype/include/freetype-custom-config/ftoption.h
,
May 29 2017
ba0e6cd12bf6 reduced this by 4.1kb if I am reading the graphs correctly. Marking as WontFix again, since this a temporary situation and some binary size is recovered for now. We hope to be able to enable this on Android again to fix autohinting issues on Android low resolution displays. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by agrieve@chromium.org
, May 16 2017