gs_offloader should use the same gsutil binary as the the devserver |
||||||||
Issue descriptionInfra team moved to using the gs package installed in chromite which uses a different version of gsutil to preform commands, moblab_rpc has already been converted, move the gs_offloader to use this version of the binary so that all moblab operations use the same gsutil.
,
May 18 2017
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/afc273e26da18cf88013f367e175a789ab167f6f commit afc273e26da18cf88013f367e175a789ab167f6f Author: Keith Haddow <haddowk@chromium.org> Date: Fri May 19 00:21:36 2017 [autotest] move gs_offloader to use the chromite version of gsutil Infra team moved devserver to use the chromite gsutil. Move gs_offloader to be consistent BUG= chromium:722976 TEST=run unit tests. Change-Id: I58a94c29bbefb75d49fc053b7c0db8315d5cf22e Reviewed-on: https://chromium-review.googlesource.com/506604 Commit-Ready: Keith Haddow <haddowk@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Dan Shi <dshi@google.com> (cherry picked from commit 82ad4501ac5d0fca275b4c370231f1c214da7922) Reviewed-on: https://chromium-review.googlesource.com/509009 Reviewed-by: Jinsong Mu <jinsong@google.com> [modify] https://crrev.com/afc273e26da18cf88013f367e175a789ab167f6f/site_utils/gs_offloader_unittest.py [modify] https://crrev.com/afc273e26da18cf88013f367e175a789ab167f6f/site_utils/gs_offloader.py
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/043e626a417e1ef2ea40b02067e1ebb7c42fe3ef commit 043e626a417e1ef2ea40b02067e1ebb7c42fe3ef Author: Keith Haddow <haddowk@chromium.org> Date: Fri May 19 00:50:21 2017 [moblab] Set CROS_CACHE variable so gs_offloader can find gsutil. gs_offloader has moved to using the gsutil that chromite uses, to be able to find the binary the CROS_CACHE directory must be set otherwise the default location is in /tmp which is mounted as noexec on moblab. BUG= chromium:722976 TEST=None Change-Id: I078f6074afb2b0bd92dbd3d45c4d48a676c3962a Reviewed-on: https://chromium-review.googlesource.com/509028 Reviewed-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Jinsong Mu <jinsong@google.com> Commit-Queue: Keith Haddow <haddowk@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> [rename] https://crrev.com/043e626a417e1ef2ea40b02067e1ebb7c42fe3ef/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r56.ebuild [modify] https://crrev.com/043e626a417e1ef2ea40b02067e1ebb7c42fe3ef/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-gsoffloader-init.conf [modify] https://crrev.com/043e626a417e1ef2ea40b02067e1ebb7c42fe3ef/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-gsoffloader_s-init.conf
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/f055a4b1467e7c249105d7c757759fa5dbe0bcd3 commit f055a4b1467e7c249105d7c757759fa5dbe0bcd3 Author: Keith Haddow <haddowk@chromium.org> Date: Fri May 19 01:08:04 2017 [moblab] Set CROS_CACHE variable so gs_offloader can find gsutil. gs_offloader has moved to using the gsutil that chromite uses, to be able to find the binary the CROS_CACHE directory must be set otherwise the default location is in /tmp which is mounted as noexec on moblab. BUG= chromium:722976 TEST=None Change-Id: I078f6074afb2b0bd92dbd3d45c4d48a676c3962a Reviewed-on: https://chromium-review.googlesource.com/506773 Commit-Ready: Keith Haddow <haddowk@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Michael Tang <ntang@chromium.org> [rename] https://crrev.com/f055a4b1467e7c249105d7c757759fa5dbe0bcd3/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r56.ebuild [modify] https://crrev.com/f055a4b1467e7c249105d7c757759fa5dbe0bcd3/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-gsoffloader-init.conf [modify] https://crrev.com/f055a4b1467e7c249105d7c757759fa5dbe0bcd3/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-gsoffloader_s-init.conf
,
May 30 2017
,
Jun 8 2017
Aviv assigning to you to drive the infra decision on which gsutil to use.
,
Jun 9 2017
+dgarret +xixuan: which gsutil are we using on the devserver? +dshi: comments on which gsutil we should be using?
,
Jun 9 2017
Lab should be able to use the one from chromite, after thorough test is done to make sure the lab boto file can work with the chromite gsutil.
,
Jun 9 2017
devserver use gs in chromite/lib/gs.py. See example here: https://cs.corp.google.com/chromeos_public/src/platform/dev/downloader.py?q=downloader&sq=package:%5Echromeos_(internal%7Cpublic)$&l=27
,
Aug 14 2017
,
Jun 8 2018
Hi, this bug has not been updated recently. Please acknowledge the bug and provide status within two weeks (6/22/2018), or the bug will be archived. Thank you.
,
Nov 1
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, May 18 2017