New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 722976 link

Starred by 1 user

Issue metadata

Status: Closed
Owner: ----
Closed: Nov 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

gs_offloader should use the same gsutil binary as the the devserver

Project Member Reported by haddowk@chromium.org, May 16 2017

Issue description


Infra team moved to using the gs package installed in chromite which uses a different version of gsutil to preform commands, moblab_rpc has already been converted, move the gs_offloader to use this version of the binary so that all moblab operations use the same gsutil.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/82ad4501ac5d0fca275b4c370231f1c214da7922

commit 82ad4501ac5d0fca275b4c370231f1c214da7922
Author: Keith Haddow <haddowk@chromium.org>
Date: Thu May 18 02:06:20 2017

[autotest] move gs_offloader to use the chromite version of gsutil

Infra team moved devserver to use the chromite gsutil.

Move gs_offloader to be consistent

BUG= chromium:722976 
TEST=run unit tests.

Change-Id: I58a94c29bbefb75d49fc053b7c0db8315d5cf22e
Reviewed-on: https://chromium-review.googlesource.com/506604
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/82ad4501ac5d0fca275b4c370231f1c214da7922/site_utils/gs_offloader_unittest.py
[modify] https://crrev.com/82ad4501ac5d0fca275b4c370231f1c214da7922/site_utils/gs_offloader.py

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, May 19 2017

Labels: merge-merged-release-R59-9460.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/afc273e26da18cf88013f367e175a789ab167f6f

commit afc273e26da18cf88013f367e175a789ab167f6f
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri May 19 00:21:36 2017

[autotest] move gs_offloader to use the chromite version of gsutil

Infra team moved devserver to use the chromite gsutil.

Move gs_offloader to be consistent

BUG= chromium:722976 
TEST=run unit tests.

Change-Id: I58a94c29bbefb75d49fc053b7c0db8315d5cf22e
Reviewed-on: https://chromium-review.googlesource.com/506604
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>
(cherry picked from commit 82ad4501ac5d0fca275b4c370231f1c214da7922)
Reviewed-on: https://chromium-review.googlesource.com/509009
Reviewed-by: Jinsong Mu <jinsong@google.com>

[modify] https://crrev.com/afc273e26da18cf88013f367e175a789ab167f6f/site_utils/gs_offloader_unittest.py
[modify] https://crrev.com/afc273e26da18cf88013f367e175a789ab167f6f/site_utils/gs_offloader.py

Project Member

Comment 4 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/043e626a417e1ef2ea40b02067e1ebb7c42fe3ef

commit 043e626a417e1ef2ea40b02067e1ebb7c42fe3ef
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri May 19 00:50:21 2017

[moblab] Set CROS_CACHE variable so gs_offloader can find gsutil.

gs_offloader has moved to using the gsutil that chromite uses, to
be able to find the binary the CROS_CACHE directory must be set
otherwise the default location is in /tmp which is mounted as
noexec on moblab.

BUG= chromium:722976 
TEST=None

Change-Id: I078f6074afb2b0bd92dbd3d45c4d48a676c3962a
Reviewed-on: https://chromium-review.googlesource.com/509028
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Jinsong Mu <jinsong@google.com>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[rename] https://crrev.com/043e626a417e1ef2ea40b02067e1ebb7c42fe3ef/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r56.ebuild
[modify] https://crrev.com/043e626a417e1ef2ea40b02067e1ebb7c42fe3ef/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-gsoffloader-init.conf
[modify] https://crrev.com/043e626a417e1ef2ea40b02067e1ebb7c42fe3ef/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-gsoffloader_s-init.conf

Project Member

Comment 5 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/f055a4b1467e7c249105d7c757759fa5dbe0bcd3

commit f055a4b1467e7c249105d7c757759fa5dbe0bcd3
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri May 19 01:08:04 2017

[moblab] Set CROS_CACHE variable so gs_offloader can find gsutil.

gs_offloader has moved to using the gsutil that chromite uses, to
be able to find the binary the CROS_CACHE directory must be set
otherwise the default location is in /tmp which is mounted as
noexec on moblab.

BUG= chromium:722976 
TEST=None

Change-Id: I078f6074afb2b0bd92dbd3d45c4d48a676c3962a
Reviewed-on: https://chromium-review.googlesource.com/506773
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>

[rename] https://crrev.com/f055a4b1467e7c249105d7c757759fa5dbe0bcd3/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r56.ebuild
[modify] https://crrev.com/f055a4b1467e7c249105d7c757759fa5dbe0bcd3/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-gsoffloader-init.conf
[modify] https://crrev.com/f055a4b1467e7c249105d7c757759fa5dbe0bcd3/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-gsoffloader_s-init.conf

Cc: akes...@chromium.org
Owner: ----
Status: Available (was: Fixed)
Owner: akes...@chromium.org
Aviv assigning to you to drive the infra decision on which gsutil to use.
Cc: dgarr...@chromium.org dshi@chromium.org xixuan@chromium.org
+dgarret +xixuan: which gsutil are we using on the devserver?
+dshi: comments on which gsutil we should be using?

Comment 9 by dshi@chromium.org, Jun 9 2017

Lab should be able to use the one from chromite, after thorough test is done to make sure the lab boto file can work with the chromite gsutil.

Components: Infra>Client>ChromeOS
Labels: Hotlist-Fixit
Owner: ----
Hi, this bug has not been updated recently. Please acknowledge the bug and provide status within two weeks (6/22/2018), or the bug will be archived. Thank you.
Status: Closed (was: Available)

Sign in to add a comment