@qyearsley, can you help?

I've seen git-related errors on wpt-exporter as well, has there been a change in the git executable for builders recently?

@hinoka says the bots auto-upgraded to 2.14 which has a bug, they're trying to force downgrade now

Ah, that's good to know!

These failing unit tests are tests where the test is invoking the real git on the real filesystem, and git is complaining about an invalid username... it's possible that these tests are too fragile, but maybe they don't need to be changed.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02e0ec9c924364de9287e06255649674a75493d1

commit 02e0ec9c924364de9287e06255649674a75493d1
Author: qyearsley <qyearsley@chromium.org>
Date: Tue May 16 21:43:46 2017

Temporarily remove unit tests which use real git and real filesystem.

BUG= 722975 
TBR=dpranke
NOTRY=true

Review-Url: https://codereview.chromium.org/2892463002
Cr-Commit-Position: refs/heads/master@{#472223}

[modify] https://crrev.com/02e0ec9c924364de9287e06255649674a75493d1/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_unittest.py

Removing sheriff label, no longer blocking tree

You should be good to go ahead and revert that temporary test disable. Bots in the chromium vlan should all be good to go.

Alright, thanks :-)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3948d50a08e75cd127eea4ae47267adeb1d945bf

commit 3948d50a08e75cd127eea4ae47267adeb1d945bf
Author: qyearsley <qyearsley@chromium.org>
Date: Tue May 16 23:58:03 2017

Revert of Temporarily remove unit tests which use real git and real filesystem. (patchset #1 id:1 of https://codereview.chromium.org/2892463002/ )

Reason for revert:
Should be OK to run these tests again (https://bugs.chromium.org/p/chromium/issues/detail?id=722975#c10)

Original issue's description:
> Temporarily remove unit tests which use real git and real filesystem.
>
> BUG= 722975 
> TBR=dpranke
> NOTRY=true
>
> Review-Url: https://codereview.chromium.org/2892463002
> Cr-Commit-Position: refs/heads/master@{#472223}
> Committed: https://chromium.googlesource.com/chromium/src/+/02e0ec9c924364de9287e06255649674a75493d1

TBR=dmazzoni@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 722975 

Review-Url: https://codereview.chromium.org/2891443003
Cr-Commit-Position: refs/heads/master@{#472256}

[modify] https://crrev.com/3948d50a08e75cd127eea4ae47267adeb1d945bf/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_unittest.py

These tests are failing again, not sure whether due to an infra change or not...

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35981e40fcdc003eec5cd83736b8b455082c4439

commit 35981e40fcdc003eec5cd83736b8b455082c4439
Author: qyearsley <qyearsley@chromium.org>
Date: Fri May 26 01:24:43 2017

Reland of Temporarily remove unit tests which use real git and real filesystem. (patchset #1 id:1 of https://codereview.chromium.org/2891443003/ )

Reason for revert:
These tests are failing again :-/

Possibly something changed with git on the bots again?

Disabling tests for now to avoid making all of the unrelated try jobs red...

Original issue's description:
> Revert of Temporarily remove unit tests which use real git and real filesystem. (patchset #1 id:1 of https://codereview.chromium.org/2892463002/ )
>
> Reason for revert:
> Should be OK to run these tests again (https://bugs.chromium.org/p/chromium/issues/detail?id=722975#c10)
>
> Original issue's description:
> > Temporarily remove unit tests which use real git and real filesystem.
> >
> > BUG= 722975 
> > TBR=dpranke
> > NOTRY=true
> >
> > Review-Url: https://codereview.chromium.org/2892463002
> > Cr-Commit-Position: refs/heads/master@{#472223}
> > Committed: https://chromium.googlesource.com/chromium/src/+/02e0ec9c924364de9287e06255649674a75493d1
>
> TBR=dmazzoni@chromium.org,dpranke@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 722975 
>
> Review-Url: https://codereview.chromium.org/2891443003
> Cr-Commit-Position: refs/heads/master@{#472256}
> Committed: https://chromium.googlesource.com/chromium/src/+/3948d50a08e75cd127eea4ae47267adeb1d945bf

TBR=dmazzoni@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 722975 

Review-Url: https://codereview.chromium.org/2908593004
Cr-Commit-Position: refs/heads/master@{#474866}

[modify] https://crrev.com/35981e40fcdc003eec5cd83736b8b455082c4439/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_unittest.py

Lowering prio since the tests are now disabled again.

To fix this more robustly, those tests should probably set owner/email while running the tests.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f4aaf4f2b979f8968dca6e3ccdb0b8ef7da84e4

commit 3f4aaf4f2b979f8968dca6e3ccdb0b8ef7da84e4
Author: Quinten Yearsley <qyearsley@google.com>
Date: Tue Jun 27 01:55:12 2017

Reenable git tests that use the real filesystem.

This re-adds the tests that were deleted before, with a minor
change to set user.email and user.name in the two temporary
repositories before executing other git commands, so that in
case these config values are required, the tests will still
pass.

Bug:  722975 
Change-Id: I60f781964d7be59e103202df21fc30269ee95779
Reviewed-on: https://chromium-review.googlesource.com/549022
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482511}
[modify] https://crrev.com/3f4aaf4f2b979f8968dca6e3ccdb0b8ef7da84e4/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_unittest.py