power.top_10 and power.top_25, and power.typical_10_mobile_reload should be deleted |
||||
Issue descriptionAs part of Chrome Speed Operations’ effort to decrease the quantity and increase the quality of Chrome benchmarks we run (https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/chromium-dev/PFqPgWLPUQ0/Dy6QEc5sCwAJ), I'm planning on removing power.top_10 and power.top_25. These benchmarks were written years ago by the Chrome Speed team, but have since fallen into disrepair and been supplanted by more realistic benchmarks like the system health suite. I wrote an analysis back in March (https://docs.google.com/document/d/1Sg7Mor2lcNixEEICIcUPAwV1tZDVhAlEhEGyAOP4gBs/edit) that concluded that these benchmarks aren’t worth the cycle time and maintenance costs they impose.
,
May 16 2017
,
May 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d25bb92682c7fb325d1f2b5608832a195fb0dd27 commit d25bb92682c7fb325d1f2b5608832a195fb0dd27 Author: Charlie Andrews <charliea@chromium.org> Date: Thu May 18 17:57:37 2017 Delete power.top_10, power.top_25, and power.typical_10_mobile_reload This is part of a larger effort to trim the overall number and variety of benchmarks that run on Telemetry. These benchmarks were created by the Chrome Speed team several years ago, and have been supplanted by the system health benchmarks. This should reduce the total bot runtime by about 20m on Mac. NOTRY=true BUG= 722968 Change-Id: Idb3aa1000fc5a1e4ea5696436a3d9f5118a3f86d Reviewed-on: https://chromium-review.googlesource.com/508038 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#472872} [modify] https://crrev.com/d25bb92682c7fb325d1f2b5608832a195fb0dd27/testing/buildbot/chromium.perf.fyi.json [modify] https://crrev.com/d25bb92682c7fb325d1f2b5608832a195fb0dd27/testing/buildbot/chromium.perf.json [modify] https://crrev.com/d25bb92682c7fb325d1f2b5608832a195fb0dd27/tools/perf/benchmark.csv [modify] https://crrev.com/d25bb92682c7fb325d1f2b5608832a195fb0dd27/tools/perf/benchmarks/power.py [modify] https://crrev.com/d25bb92682c7fb325d1f2b5608832a195fb0dd27/tools/perf/core/benchmark_sharding_map.json [modify] https://crrev.com/d25bb92682c7fb325d1f2b5608832a195fb0dd27/tools/perf/core/desktop_benchmark_avg_times.json [modify] https://crrev.com/d25bb92682c7fb325d1f2b5608832a195fb0dd27/tools/perf/unowned_benchmarks.txt
,
Jun 7 2017
On https://codereview.chromium.org/2924643002/ I've noted that I'm listed as owner of power.android_acceptance. As far as I know that benchmark is not needed any more. Charlie, do you know of any other users of it? Otherwise it could also be deleted already.
,
Jun 7 2017
Yikes: no, I don't know of any other users of it. I'll file a separate bug and send you a CL. |
||||
►
Sign in to add a comment |
||||
Comment 1 by charliea@chromium.org
, May 16 2017Status: Assigned (was: Untriaged)