Issue metadata
Sign in to add a comment
|
Extension icons in settings menu always render with a white background |
||||||||||||||||||||||
Issue descriptionVersion 60.0.3100.0 (Official Build) dev (64-bit) OS: Ubuntu 14.04 What steps will reproduce the problem? (1) Use the dark Adwaita GTK theme (select this using gnome-tweak-tool) (2) Install some extensions so their icons show up in the toolbar (3) Place your cursor to the right of the location bar and the left of the leftmost extension and drag the extension icons to the right so some of them disappear (4) They should appear in the settings menu with a transparent background, not a white background.
,
May 18 2017
Seems like somewhat recent regression. For reference this is how the menu looks like in M58 and in M60 with GTK+ theme in Chrome. It seems that the menu has started respecting the theme background but the extensions area still don't. Giving it a milestone since it is a visible regression.
,
May 19 2017
Issue 715406 has been merged into this issue.
,
May 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c46717e8d85b283ccb79dd4e305d33ba99b1432 commit 9c46717e8d85b283ccb79dd4e305d33ba99b1432 Author: ananta <ananta@chromium.org> Date: Tue May 23 02:13:21 2017 Fix the white background regression on the Extensions overflow menu. This was a regression introduced by my patch https://codereview.chromium.org/2813353002/ for bugs 665412 , 656198. This patch ensured that the parent views get notified when a child adds a layer. This notification is handled by the scrollview, where we enable layering on the viewport. We need to call SetFillsBoundsOpaquely() on the viewport layer for the scrollview to ensure that transparent views like the overflow menu work correctly. Thanks for timbrown for helping debug on his Linux Box and to sky for the suggestions. BUG= 722965 Review-Url: https://codereview.chromium.org/2895003002 Cr-Commit-Position: refs/heads/master@{#473787} [modify] https://crrev.com/9c46717e8d85b283ccb79dd4e305d33ba99b1432/ui/views/controls/scroll_view.cc [modify] https://crrev.com/9c46717e8d85b283ccb79dd4e305d33ba99b1432/ui/views/view_unittest.cc
,
May 23 2017
,
May 30 2017
Tested the issue on Ubuntu 14.04 using chrome latest Dev M60-60.0.3112.7 by following steps mentioned in the original comment. Observed that extensions are displaying as expected. Hence adding TE-Verified label. Please find the screen shot for reference. Thank you! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by timbrown@chromium.org
, May 17 2017