We need shipping equivalents for the contact info logic in PaymentsProfileComparator. A first step would be to organize by completeness. Less pressing needs would be to filter empty profiles and dedupe substantially similar profiles.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb8d574b98adfcbd3b5ce2eb6e521b83efbb428a commit eb8d574b98adfcbd3b5ce2eb6e521b83efbb428a Author: tmartino <tmartino@chromium.org> Date: Tue May 23 16:21:23 2017 [WebPayments] Adding FilterProfilesForShipping to profile comparator BUG= 722949 Review-Url: https://codereview.chromium.org/2884393002 Cr-Commit-Position: refs/heads/master@{#473929} [modify] https://crrev.com/eb8d574b98adfcbd3b5ce2eb6e521b83efbb428a/chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc [add] https://crrev.com/eb8d574b98adfcbd3b5ce2eb6e521b83efbb428a/chrome/browser/ui/views/payments/profile_list_view_controller_browsertest.cc [modify] https://crrev.com/eb8d574b98adfcbd3b5ce2eb6e521b83efbb428a/chrome/test/BUILD.gn [modify] https://crrev.com/eb8d574b98adfcbd3b5ce2eb6e521b83efbb428a/components/payments/content/payment_request_state.cc [modify] https://crrev.com/eb8d574b98adfcbd3b5ce2eb6e521b83efbb428a/components/payments/core/payments_profile_comparator.cc [modify] https://crrev.com/eb8d574b98adfcbd3b5ce2eb6e521b83efbb428a/components/payments/core/payments_profile_comparator.h [modify] https://crrev.com/eb8d574b98adfcbd3b5ce2eb6e521b83efbb428a/components/payments/core/payments_profile_comparator_unittest.cc [modify] https://crrev.com/eb8d574b98adfcbd3b5ce2eb6e521b83efbb428a/ios/chrome/browser/payments/payment_request.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/427e841ab562c51ccae522bb9149cc5c5c680aa1 commit 427e841ab562c51ccae522bb9149cc5c5c680aa1 Author: mek <mek@chromium.org> Date: Tue May 23 18:17:10 2017 Revert of [WebPayments] Adding FilterProfilesForShipping to profile comparator (patchset #5 id:80001 of https://codereview.chromium.org/2884393002/ ) Reason for revert: Appears to be causing test failures in https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin10_Tests_x64%2F11929%2F%2B%2Frecipes%2Fsteps%2Fbrowser_side_navigation_browser_tests_on_Windows-10-10586%2F0%2Flogs%2FPaymentRequestProfileListTest.PrioritizeCompleteness%2F0 RUN ] PaymentRequestProfileListTest.PrioritizeCompleteness [640:3644:0523/102806.488:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico c:\b\c\b\win\src\chrome\browser\ui\views\payments\profile_list_view_controller_browsertest.cc(46): error: Expected: partial Which is: b5e544d1-6a66-49bf-bd4c-f2eb38671fd3 https://www.example.com/ Jane A. Smith jsmith@example.com ACME 48838 US 13105557889 To be equal to: *profiles[0] Which is: 63b73e74-aacb-4a0e-bde5-a3260918586c http://www.example.com/ John H. Doe johndoe@hades.com Underworld 666 Erebus St. Apt 8 Elysium CA 91111 US 16502111111 c:\b\c\b\win\src\chrome\browser\ui\views\payments\profile_list_view_controller_browsertest.cc(47): error: Expected: complete Which is: 63b73e74-aacb-4a0e-bde5-a3260918586c http://www.example.com/ John H. Doe johndoe@hades.com Underworld 666 Erebus St. Apt 8 Elysium CA 91111 US 16502111111 To be equal to: *profiles[1] Which is: b5e544d1-6a66-49bf-bd4c-f2eb38671fd3 https://www.example.com/ Jane A. Smith jsmith@example.com ACME 48838 US 13105557889 [ FAILED ] PaymentRequestProfileListTest.PrioritizeCompleteness, where TypeParam = and GetParam() = (1292 ms) Original issue's description: > [WebPayments] Adding FilterProfilesForShipping to profile comparator > > BUG= 722949 > > Review-Url: https://codereview.chromium.org/2884393002 > Cr-Commit-Position: refs/heads/master@{#473929} > Committed: https://chromium.googlesource.com/chromium/src/+/eb8d574b98adfcbd3b5ce2eb6e521b83efbb428a TBR=mahmadi@chromium.org,mathp@chromium.org,tmartino@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 722949 Review-Url: https://codereview.chromium.org/2897133002 Cr-Commit-Position: refs/heads/master@{#473982} [modify] https://crrev.com/427e841ab562c51ccae522bb9149cc5c5c680aa1/chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc [delete] https://crrev.com/4b0d987b7671514779538e45f89d630e77d41e39/chrome/browser/ui/views/payments/profile_list_view_controller_browsertest.cc [modify] https://crrev.com/427e841ab562c51ccae522bb9149cc5c5c680aa1/chrome/test/BUILD.gn [modify] https://crrev.com/427e841ab562c51ccae522bb9149cc5c5c680aa1/components/payments/content/payment_request_state.cc [modify] https://crrev.com/427e841ab562c51ccae522bb9149cc5c5c680aa1/components/payments/core/payments_profile_comparator.cc [modify] https://crrev.com/427e841ab562c51ccae522bb9149cc5c5c680aa1/components/payments/core/payments_profile_comparator.h [modify] https://crrev.com/427e841ab562c51ccae522bb9149cc5c5c680aa1/components/payments/core/payments_profile_comparator_unittest.cc [modify] https://crrev.com/427e841ab562c51ccae522bb9149cc5c5c680aa1/ios/chrome/browser/payments/payment_request.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd131b3025061c950f9e406129d5703532f153be commit cd131b3025061c950f9e406129d5703532f153be Author: tmartino <tmartino@chromium.org> Date: Wed May 24 19:40:59 2017 [WebPayments] Adding FilterProfilesForShipping to profile comparator BUG= 722949 Review-Url: https://codereview.chromium.org/2884393002 Cr-Original-Commit-Position: refs/heads/master@{#473929} Committed: https://chromium.googlesource.com/chromium/src/+/eb8d574b98adfcbd3b5ce2eb6e521b83efbb428a Review-Url: https://codereview.chromium.org/2884393002 Cr-Commit-Position: refs/heads/master@{#474392} [modify] https://crrev.com/cd131b3025061c950f9e406129d5703532f153be/chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc [add] https://crrev.com/cd131b3025061c950f9e406129d5703532f153be/chrome/browser/ui/views/payments/profile_list_view_controller_browsertest.cc [modify] https://crrev.com/cd131b3025061c950f9e406129d5703532f153be/chrome/test/BUILD.gn [modify] https://crrev.com/cd131b3025061c950f9e406129d5703532f153be/components/payments/content/payment_request_state.cc [modify] https://crrev.com/cd131b3025061c950f9e406129d5703532f153be/components/payments/core/payments_profile_comparator.cc [modify] https://crrev.com/cd131b3025061c950f9e406129d5703532f153be/components/payments/core/payments_profile_comparator.h [modify] https://crrev.com/cd131b3025061c950f9e406129d5703532f153be/components/payments/core/payments_profile_comparator_unittest.cc [modify] https://crrev.com/cd131b3025061c950f9e406129d5703532f153be/ios/chrome/browser/payments/payment_request.mm
Issue 722459 has been merged into this issue.
Issue 722456 has been merged into this issue.
Issue 719652 has been merged into this issue.
Marking as fixed, since we now organize by completeness. Remaining improvements have been split off into crbug.com/733683
Comment 1 by bugdroid1@chromium.org
, May 23 2017