ProfileSavedWithValidCountryPhone failing on chromium.memory/Linux ASan LSan Tests (1) |
||||
Issue descriptionbrowser_tests failing on chromium.memory/Linux ASan LSan Tests (1) Builders failed on: - Linux ASan LSan Tests (1): https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29
,
May 16 2017
Reverting: https://codereview.chromium.org/2888633002/
,
May 16 2017
Took a quick look at the leaks in https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_ASan_LSan_Tests__1_%2F35789%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Fstdout and all memory seems to be allocated in mojo.
,
May 16 2017
,
May 17 2017
My Comment 3 was wrong. I was looking at a different log file. Unable to reproduce on my workstation. On my local test, the form is being parsed prior to submission via ContentAutofillDriver::FormsSeen -> AutofillManager::OnFormsSeens -> AutofillManager::ParseForms. Perhaps there is a path where the parsing is skipped if the browser does not receive the mojo message?
,
May 17 2017
Removing from sheriff queue since the change was reverted
,
May 18 2017
Sashi kindly offered to take a look, thanks!
,
May 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9b9e4bedcd8c49fdfaf556f538859918c0be26b commit c9b9e4bedcd8c49fdfaf556f538859918c0be26b Author: csashi <csashi@google.com> Date: Thu May 18 22:17:46 2017 Assert that form submission state is not one of the autofill states when we do not have the parse time. BUG= 722947 Review-Url: https://codereview.chromium.org/2887133005 Cr-Commit-Position: refs/heads/master@{#472949} [modify] https://crrev.com/c9b9e4bedcd8c49fdfaf556f538859918c0be26b/components/autofill/core/browser/autofill_metrics.cc
,
May 18 2017
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21107f7aaf8a03530821e5305a9a49edba1eb034 commit 21107f7aaf8a03530821e5305a9a49edba1eb034 Author: csashi <csashi@google.com> Date: Fri May 19 19:37:48 2017 Fix DCHECK to include FILLABLE_FORM_AUTOFILLED_NONE_DID_NOT_SHOW_SUGGESTIONS. BUG= 722947 Review-Url: https://codereview.chromium.org/2893013002 Cr-Commit-Position: refs/heads/master@{#473280} [modify] https://crrev.com/21107f7aaf8a03530821e5305a9a49edba1eb034/components/autofill/core/browser/autofill_metrics.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by dmazz...@chromium.org
, May 16 2017Summary: ProfileSavedWithValidCountryPhone failing on chromium.memory/Linux ASan LSan Tests (1) (was: browser_tests failing on chromium.memory/Linux ASan LSan Tests (1))