Issue 722942 link

Starred by 1 user

Issue metadata

Status:	Assigned
Owner:	mxnguyen@chromium.org
Cc:	sorin@chromium.org waff...@chromium.org
Components:	Internals>Installer>Components
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Feature

Component update client should be extended to support Chrome extensions update request

Project Member Reported by mxnguyen@chromium.org, May 16 2017

Issue description

Currently, the component update client only supports update requests coming from Chrome components, it doesn't have attributes that are available only for Chrome extensions: disabled/enabled, disable reason(s), date last active... 

Changes would need to be made on PersistentData (to support the permanent storage of these new attributes per user profile), UpdateChecker.

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca599fb295cc359134b827564fc105152cc9effe

commit ca599fb295cc359134b827564fc105152cc9effe
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Thu Sep 14 21:10:39 2017

[UpdateClient] Add support for active* states and disable reasons.

Also allows the protocol builder to fall back on days* if date* data
are not available.


Bug: 722942
Change-Id: I94a3f2bad2ca04248c742013ecae8afd97afc980
Reviewed-on: https://chromium-review.googlesource.com/664247
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502041}
[modify] https://crrev.com/ca599fb295cc359134b827564fc105152cc9effe/components/update_client/protocol_builder.cc
[modify] https://crrev.com/ca599fb295cc359134b827564fc105152cc9effe/components/update_client/update_checker.cc
[modify] https://crrev.com/ca599fb295cc359134b827564fc105152cc9effe/components/update_client/update_checker_unittest.cc
[modify] https://crrev.com/ca599fb295cc359134b827564fc105152cc9effe/components/update_client/update_client.h

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c17b398e47f5e39c6ebd296312d6a6e8cf6a250

commit 2c17b398e47f5e39c6ebd296312d6a6e8cf6a250
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Fri Oct 13 18:32:29 2017

Extension: Allow CrxInstaller to install from an unpacked directory.

Also add a callback to CrxInstaller so that the result of an
installation can be relayed back to the caller.

Bug: 722942
Change-Id: I868e72ef6741d4da1c17ac903696ebf6125754ae
Reviewed-on: https://chromium-review.googlesource.com/710580
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508763}
[modify] https://crrev.com/2c17b398e47f5e39c6ebd296312d6a6e8cf6a250/chrome/browser/extensions/crx_installer.cc
[modify] https://crrev.com/2c17b398e47f5e39c6ebd296312d6a6e8cf6a250/chrome/browser/extensions/crx_installer.h
[modify] https://crrev.com/2c17b398e47f5e39c6ebd296312d6a6e8cf6a250/chrome/browser/extensions/crx_installer_browsertest.cc
[modify] https://crrev.com/2c17b398e47f5e39c6ebd296312d6a6e8cf6a250/extensions/browser/extension_system.h

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aafd76331396dd8eeee57029c69796353e5d4230

commit aafd76331396dd8eeee57029c69796353e5d4230
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Thu Oct 19 21:12:35 2017

Component unpacker: Generate public_key when verifying a crx package.

Bug: 722942
Change-Id: If2151274f2cfd1eaddd3a0cbeaf99636b8534a05
Reviewed-on: https://chromium-review.googlesource.com/726976
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510216}
[modify] https://crrev.com/aafd76331396dd8eeee57029c69796353e5d4230/components/component_updater/component_installer_unittest.cc
[modify] https://crrev.com/aafd76331396dd8eeee57029c69796353e5d4230/components/update_client/component.cc
[modify] https://crrev.com/aafd76331396dd8eeee57029c69796353e5d4230/components/update_client/component_unpacker.cc
[modify] https://crrev.com/aafd76331396dd8eeee57029c69796353e5d4230/components/update_client/component_unpacker.h
[modify] https://crrev.com/aafd76331396dd8eeee57029c69796353e5d4230/components/update_client/component_unpacker_unittest.cc
[modify] https://crrev.com/aafd76331396dd8eeee57029c69796353e5d4230/components/update_client/test_configurator.h

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30975340db017def1217499e2ad5ff90c55d286e

commit 30975340db017def1217499e2ad5ff90c55d286e
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Mon Dec 04 22:02:41 2017

[Extension] Implement ExtensionSystem::InstallUpdate.

Note that the signature of InstallUpdate is changed to match with
CrxInstaller::InstallUnpackedCrx.

Bug: 722942
Change-Id: I789c6277458447976d24aa7ba5dcced670c8cc11
Reviewed-on: https://chromium-review.googlesource.com/765095
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521481}
[modify] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/chrome/browser/extensions/crx_installer.cc
[modify] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/chrome/browser/extensions/crx_installer.h
[modify] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/chrome/browser/extensions/crx_installer_browsertest.cc
[modify] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/chrome/browser/extensions/extension_service.cc
[modify] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/chrome/browser/extensions/extension_system_impl.cc
[modify] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/chrome/browser/extensions/extension_system_impl.h
[modify] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/chrome/browser/extensions/test_extension_system.cc
[modify] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/chrome/browser/extensions/test_extension_system.h
[modify] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/extensions/browser/BUILD.gn
[modify] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/extensions/browser/extension_system.h
[modify] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/extensions/browser/mock_extension_system.cc
[modify] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/extensions/browser/mock_extension_system.h
[modify] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/extensions/browser/updater/BUILD.gn
[add] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/extensions/browser/updater/extension_installer.cc
[add] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/extensions/browser/updater/extension_installer.h
[add] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/extensions/browser/updater/extension_installer_unittest.cc
[modify] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/extensions/browser/updater/update_data_provider.cc
[modify] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/extensions/browser/updater/update_data_provider.h
[add] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/extensions/browser/updater/update_data_provider_unittest.cc
[delete] https://crrev.com/b2512873ff07995c20c3aea67df6fbc918116a7c/extensions/browser/updater/update_install_shim.cc
[delete] https://crrev.com/b2512873ff07995c20c3aea67df6fbc918116a7c/extensions/browser/updater/update_install_shim.h
[modify] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/extensions/browser/updater/update_service.cc
[modify] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/extensions/browser/updater/update_service_unittest.cc
[modify] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/extensions/shell/browser/shell_extension_system.cc
[modify] https://crrev.com/30975340db017def1217499e2ad5ff90c55d286e/extensions/shell/browser/shell_extension_system.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95da8275670f8b7dae87de4c663524376357b460

commit 95da8275670f8b7dae87de4c663524376357b460
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Thu Jan 04 02:02:05 2018

[Extension] Prepare UpdateService to connect to ExtensionUpdater.

Bug: 722942
Change-Id: I9b164dda08861749c9d033ff32f4a82391bc0d0e
Reviewed-on: https://chromium-review.googlesource.com/822760
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526896}
[modify] https://crrev.com/95da8275670f8b7dae87de4c663524376357b460/extensions/browser/updater/BUILD.gn
[add] https://crrev.com/95da8275670f8b7dae87de4c663524376357b460/extensions/browser/updater/extension_update_data.cc
[add] https://crrev.com/95da8275670f8b7dae87de4c663524376357b460/extensions/browser/updater/extension_update_data.h
[modify] https://crrev.com/95da8275670f8b7dae87de4c663524376357b460/extensions/browser/updater/update_data_provider.cc
[modify] https://crrev.com/95da8275670f8b7dae87de4c663524376357b460/extensions/browser/updater/update_data_provider.h
[modify] https://crrev.com/95da8275670f8b7dae87de4c663524376357b460/extensions/browser/updater/update_data_provider_unittest.cc
[modify] https://crrev.com/95da8275670f8b7dae87de4c663524376357b460/extensions/browser/updater/update_service.cc
[modify] https://crrev.com/95da8275670f8b7dae87de4c663524376357b460/extensions/browser/updater/update_service.h
[modify] https://crrev.com/95da8275670f8b7dae87de4c663524376357b460/extensions/browser/updater/update_service_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7910197299fa834104315dd177e275a049d586ae

commit 7910197299fa834104315dd177e275a049d586ae
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Thu Feb 01 06:11:10 2018

[Extensions] Add UMA counters to measure extension updater results.

Bug: 722942
Change-Id: I3beee6eb439cc4ed0819771996ee4f9f4f09197f
Reviewed-on: https://chromium-review.googlesource.com/877043
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533587}
[modify] https://crrev.com/7910197299fa834104315dd177e275a049d586ae/chrome/browser/extensions/updater/extension_updater.cc
[modify] https://crrev.com/7910197299fa834104315dd177e275a049d586ae/extensions/browser/updater/extension_downloader.cc
[modify] https://crrev.com/7910197299fa834104315dd177e275a049d586ae/extensions/common/BUILD.gn
[add] https://crrev.com/7910197299fa834104315dd177e275a049d586ae/extensions/common/extension_updater_uma.h
[modify] https://crrev.com/7910197299fa834104315dd177e275a049d586ae/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/7910197299fa834104315dd177e275a049d586ae/tools/metrics/histograms/histograms.xml

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3aa40695086fc6e7fa6093f30ea93a8a4fcfba31

commit 3aa40695086fc6e7fa6093f30ea93a8a4fcfba31
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Wed Mar 28 01:15:59 2018

[Extensions] Hook up component updater to extension updater.

The new extension updater (through component updater) is controlled
by "NewExtensionUpdater" feature, and is disabled by default.


Bug: 722942
Change-Id: Ib366e6bf97770b3a3493a419dd6cc5a5fcc7aac1
Reviewed-on: https://chromium-review.googlesource.com/898031
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546356}
[modify] https://crrev.com/3aa40695086fc6e7fa6093f30ea93a8a4fcfba31/chrome/browser/extensions/test_extension_prefs.cc
[modify] https://crrev.com/3aa40695086fc6e7fa6093f30ea93a8a4fcfba31/chrome/browser/extensions/test_extension_prefs.h
[modify] https://crrev.com/3aa40695086fc6e7fa6093f30ea93a8a4fcfba31/chrome/browser/extensions/updater/extension_updater.cc
[modify] https://crrev.com/3aa40695086fc6e7fa6093f30ea93a8a4fcfba31/chrome/browser/extensions/updater/extension_updater.h
[modify] https://crrev.com/3aa40695086fc6e7fa6093f30ea93a8a4fcfba31/chrome/browser/extensions/updater/extension_updater_unittest.cc
[modify] https://crrev.com/3aa40695086fc6e7fa6093f30ea93a8a4fcfba31/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/3aa40695086fc6e7fa6093f30ea93a8a4fcfba31/components/update_client/update_client.cc
[modify] https://crrev.com/3aa40695086fc6e7fa6093f30ea93a8a4fcfba31/components/update_client/update_client.h
[modify] https://crrev.com/3aa40695086fc6e7fa6093f30ea93a8a4fcfba31/extensions/browser/updater/update_data_provider.cc
[modify] https://crrev.com/3aa40695086fc6e7fa6093f30ea93a8a4fcfba31/extensions/browser/updater/update_service.cc
[modify] https://crrev.com/3aa40695086fc6e7fa6093f30ea93a8a4fcfba31/extensions/browser/updater/update_service.h
[modify] https://crrev.com/3aa40695086fc6e7fa6093f30ea93a8a4fcfba31/extensions/browser/updater/update_service_unittest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c8322610ad7c6d2515d783d867e78020b3323f5

commit 5c8322610ad7c6d2515d783d867e78020b3323f5
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Thu Apr 19 16:10:25 2018

[Extensions] Add a browser test base class for new extension updater.

- Modify extension browser client so that a test configurator can be
  injected, which is needed to control certain behaviors of update
  client.
- Add a small Chrome extra so that network interceptors can be
  created and injected right before the browser starts. Without
  this change, the updater may run and finish even before all the
  setups in a browser test have finished.

Bug: 722942
Change-Id: If0858b030132c541de0a3817a14046b583a8cbd9
Reviewed-on: https://chromium-review.googlesource.com/915102
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552031}
[modify] https://crrev.com/5c8322610ad7c6d2515d783d867e78020b3323f5/chrome/browser/extensions/chrome_extensions_browser_client.cc
[modify] https://crrev.com/5c8322610ad7c6d2515d783d867e78020b3323f5/chrome/browser/extensions/content_verifier_browsertest.cc
[add] https://crrev.com/5c8322610ad7c6d2515d783d867e78020b3323f5/chrome/browser/extensions/content_verifier_test_utils.cc
[add] https://crrev.com/5c8322610ad7c6d2515d783d867e78020b3323f5/chrome/browser/extensions/content_verifier_test_utils.h
[modify] https://crrev.com/5c8322610ad7c6d2515d783d867e78020b3323f5/chrome/browser/extensions/updater/chrome_update_client_config.cc
[modify] https://crrev.com/5c8322610ad7c6d2515d783d867e78020b3323f5/chrome/browser/extensions/updater/chrome_update_client_config.h
[add] https://crrev.com/5c8322610ad7c6d2515d783d867e78020b3323f5/chrome/browser/extensions/updater/extension_update_client_base_browsertest.cc
[add] https://crrev.com/5c8322610ad7c6d2515d783d867e78020b3323f5/chrome/browser/extensions/updater/extension_update_client_base_browsertest.h
[add] https://crrev.com/5c8322610ad7c6d2515d783d867e78020b3323f5/chrome/browser/extensions/updater/update_service_browsertest.cc
[modify] https://crrev.com/5c8322610ad7c6d2515d783d867e78020b3323f5/chrome/test/BUILD.gn
[add] https://crrev.com/5c8322610ad7c6d2515d783d867e78020b3323f5/chrome/test/data/extensions/updater/ping_reply_1.xml
[add] https://crrev.com/5c8322610ad7c6d2515d783d867e78020b3323f5/chrome/test/data/extensions/updater/updatecheck_reply_noupdate_1.xml
[add] https://crrev.com/5c8322610ad7c6d2515d783d867e78020b3323f5/chrome/test/data/extensions/updater/updatecheck_reply_update_1.xml
[add] https://crrev.com/5c8322610ad7c6d2515d783d867e78020b3323f5/chrome/test/data/extensions/updater/v1.crx
[modify] https://crrev.com/5c8322610ad7c6d2515d783d867e78020b3323f5/extensions/browser/mock_external_provider.cc
[modify] https://crrev.com/5c8322610ad7c6d2515d783d867e78020b3323f5/extensions/browser/mock_external_provider.h
[modify] https://crrev.com/5c8322610ad7c6d2515d783d867e78020b3323f5/extensions/browser/updater/update_service.cc
[modify] https://crrev.com/5c8322610ad7c6d2515d783d867e78020b3323f5/extensions/browser/updater/update_service.h

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc16497ea2ff2d60576f76118fa14136f42d068a

commit fc16497ea2ff2d60576f76118fa14136f42d068a
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Tue Apr 24 16:05:35 2018

[update_client] Add installedby (extension manifest location) to update check requests.

Bug: 722942,  727861 , 835936
Change-Id: I256f5b1c54143a0c4ec5dccea668eb669673cc3d
Reviewed-on: https://chromium-review.googlesource.com/1025073
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553145}
[modify] https://crrev.com/fc16497ea2ff2d60576f76118fa14136f42d068a/chrome/browser/extensions/updater/update_service_browsertest.cc
[modify] https://crrev.com/fc16497ea2ff2d60576f76118fa14136f42d068a/components/update_client/protocol_builder.cc
[modify] https://crrev.com/fc16497ea2ff2d60576f76118fa14136f42d068a/components/update_client/update_checker_unittest.cc
[modify] https://crrev.com/fc16497ea2ff2d60576f76118fa14136f42d068a/components/update_client/update_client.h
[modify] https://crrev.com/fc16497ea2ff2d60576f76118fa14136f42d068a/extensions/browser/updater/update_data_provider.cc
[modify] https://crrev.com/fc16497ea2ff2d60576f76118fa14136f42d068a/extensions/browser/updater/update_data_provider_unittest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d

commit 7c22795b024ea3a6ecdcde89fd6c0503c74eba4d
Author: Sorin Jianu <sorin@chromium.org>
Date: Thu Apr 26 22:16:52 2018

Replace CrxComponent with std::unique_ptr<CrxComponent>.

This is a mechanical refactoring. A future CL will change the behavior to
allow injecting nullptr as a CrxComponent when the CRX is uninstalled
during an update check.

Bug:  837371 ,722942

Change-Id: I5f70fdd032a37c08bf35a286c51b109a2ca07ce0
Reviewed-on: https://chromium-review.googlesource.com/1027116
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554166}
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/component_updater/component_updater_service.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/component_updater/component_updater_service_internal.h
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/update_client/action_runner.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/update_client/component.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/update_client/component.h
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/update_client/ping_manager.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/update_client/ping_manager_unittest.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/update_client/protocol_builder.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/update_client/update_checker.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/update_client/update_checker_unittest.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/update_client/update_client.h
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/update_client/update_client_unittest.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/components/update_client/update_engine.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/extensions/browser/updater/update_data_provider.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/extensions/browser/updater/update_data_provider.h
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/extensions/browser/updater/update_data_provider_unittest.cc
[modify] https://crrev.com/7c22795b024ea3a6ecdcde89fd6c0503c74eba4d/extensions/browser/updater/update_service_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af79fb0fbcc29082579b2a6117775c4154aee67e

commit af79fb0fbcc29082579b2a6117775c4154aee67e
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Wed May 02 00:10:21 2018

[Extensions] Partition UpdateService update check requests.

This would help reduce the size of XML POST update check requests generated
by the update client. Without this change, the update client may generate
requests exceeding the size limit of the update server.

Bug: 722942
Change-Id: I1453e615a2271b8fd376b0706574b22b1d36e26d
Reviewed-on: https://chromium-review.googlesource.com/1033539
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555238}
[modify] https://crrev.com/af79fb0fbcc29082579b2a6117775c4154aee67e/extensions/browser/updater/update_service.cc
[modify] https://crrev.com/af79fb0fbcc29082579b2a6117775c4154aee67e/extensions/browser/updater/update_service_unittest.cc

Project Member

Comment 12 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55afbe42e3931c4835c53104ea805e41ac8e0f18

commit 55afbe42e3931c4835c53104ea805e41ac8e0f18
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Fri May 18 22:04:26 2018

[update_client] Separate the command line switches from the configurator.

Bug: 841877, 722942
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I17995c9163537d45ff566158663c7262dd8c2807
Reviewed-on: https://chromium-review.googlesource.com/1057898
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560063}
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/chrome/browser/component_updater/chrome_component_updater_configurator.cc
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/chrome/browser/component_updater/chrome_component_updater_configurator_unittest.cc
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/chrome/browser/extensions/updater/chrome_extension_downloader_factory.cc
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/chrome/browser/extensions/updater/chrome_update_client_config.cc
[add] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/chrome/browser/extensions/updater/extension_update_client_command_line_config_policy.cc
[add] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/chrome/browser/extensions/updater/extension_update_client_command_line_config_policy.h
[add] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/chrome/browser/extensions/updater/extension_update_client_command_line_config_policy_unittest.cc
[add] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/chrome/browser/extensions/updater/extension_updater_switches.cc
[add] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/chrome/browser/extensions/updater/extension_updater_switches.h
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/chrome/test/BUILD.gn
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/components/component_updater/BUILD.gn
[add] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/components/component_updater/component_updater_command_line_config_policy.cc
[add] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/components/component_updater/component_updater_command_line_config_policy.h
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/components/component_updater/configurator_impl.cc
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/components/component_updater/configurator_impl.h
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/components/component_updater/configurator_impl_unittest.cc
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/components/update_client/BUILD.gn
[add] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/components/update_client/command_line_config_policy.cc
[add] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/components/update_client/command_line_config_policy.h
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/ios/chrome/browser/component_updater/ios_component_updater_configurator.cc

Project Member

Comment 13 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4640cb91a4b14cfc99bd2d52edf4e036fee38e5

commit a4640cb91a4b14cfc99bd2d52edf4e036fee38e5
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Wed May 23 21:29:10 2018

[Extensions]: Add more UMA values for ExtensionUpdaterUpdateResult.

Currently, both current and new extension updaters only report a very
generic error when the updater fails. This change would allow break down
the errors in more detail to help us narrow down where the most update
failures come from.

Bug: 722942
Change-Id: I4c6a76be649d0e657fadfb289b26015d67a3c6dc
Reviewed-on: https://chromium-review.googlesource.com/1067889
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561259}
[modify] https://crrev.com/a4640cb91a4b14cfc99bd2d52edf4e036fee38e5/chrome/browser/extensions/updater/extension_updater.cc
[modify] https://crrev.com/a4640cb91a4b14cfc99bd2d52edf4e036fee38e5/components/update_client/component.cc
[modify] https://crrev.com/a4640cb91a4b14cfc99bd2d52edf4e036fee38e5/components/update_client/component.h
[modify] https://crrev.com/a4640cb91a4b14cfc99bd2d52edf4e036fee38e5/components/update_client/crx_update_item.h
[modify] https://crrev.com/a4640cb91a4b14cfc99bd2d52edf4e036fee38e5/components/update_client/ping_manager_unittest.cc
[modify] https://crrev.com/a4640cb91a4b14cfc99bd2d52edf4e036fee38e5/components/update_client/protocol_builder.cc
[modify] https://crrev.com/a4640cb91a4b14cfc99bd2d52edf4e036fee38e5/components/update_client/update_client_unittest.cc
[modify] https://crrev.com/a4640cb91a4b14cfc99bd2d52edf4e036fee38e5/extensions/browser/updater/update_service.cc
[modify] https://crrev.com/a4640cb91a4b14cfc99bd2d52edf4e036fee38e5/extensions/common/extension_updater_uma.h
[modify] https://crrev.com/a4640cb91a4b14cfc99bd2d52edf4e036fee38e5/tools/metrics/histograms/enums.xml

Project Member

Comment 14 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8803f4e6d8313f0395cce999f0dabe2bad86975c

commit 8803f4e6d8313f0395cce999f0dabe2bad86975c
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Fri May 25 01:03:10 2018

[Extension]: Change CRX installer callback to report more error details.

These changes allow the new extension updater to capture more error details,
which would help investigate the significant discrepancies the update
results of the running Finch experiment.

Bug: 722942
Change-Id: I269bbadc71bf736a79e0aa95aed6d1fc78f4e288
Reviewed-on: https://chromium-review.googlesource.com/1065196
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561716}
[modify] https://crrev.com/8803f4e6d8313f0395cce999f0dabe2bad86975c/chrome/browser/extensions/crx_installer.cc
[modify] https://crrev.com/8803f4e6d8313f0395cce999f0dabe2bad86975c/chrome/browser/extensions/crx_installer.h
[modify] https://crrev.com/8803f4e6d8313f0395cce999f0dabe2bad86975c/chrome/browser/extensions/crx_installer_browsertest.cc
[modify] https://crrev.com/8803f4e6d8313f0395cce999f0dabe2bad86975c/chrome/browser/extensions/updater/extension_cache_impl.cc
[modify] https://crrev.com/8803f4e6d8313f0395cce999f0dabe2bad86975c/chrome/browser/extensions/updater/extension_updater_unittest.cc
[modify] https://crrev.com/8803f4e6d8313f0395cce999f0dabe2bad86975c/chrome/browser/infobars/infobars_browsertest.cc
[modify] https://crrev.com/8803f4e6d8313f0395cce999f0dabe2bad86975c/chrome/browser/ui/extensions/installation_error_infobar_delegate.cc
[modify] https://crrev.com/8803f4e6d8313f0395cce999f0dabe2bad86975c/extensions/browser/extension_system.h
[modify] https://crrev.com/8803f4e6d8313f0395cce999f0dabe2bad86975c/extensions/browser/install/BUILD.gn
[add] https://crrev.com/8803f4e6d8313f0395cce999f0dabe2bad86975c/extensions/browser/install/crx_install_error.cc
[modify] https://crrev.com/8803f4e6d8313f0395cce999f0dabe2bad86975c/extensions/browser/install/crx_install_error.h
[add] https://crrev.com/8803f4e6d8313f0395cce999f0dabe2bad86975c/extensions/browser/install/sandboxed_unpacker_failure_reason.h
[modify] https://crrev.com/8803f4e6d8313f0395cce999f0dabe2bad86975c/extensions/browser/sandboxed_unpacker.cc
[modify] https://crrev.com/8803f4e6d8313f0395cce999f0dabe2bad86975c/extensions/browser/sandboxed_unpacker.h
[modify] https://crrev.com/8803f4e6d8313f0395cce999f0dabe2bad86975c/extensions/browser/sandboxed_unpacker_unittest.cc
[modify] https://crrev.com/8803f4e6d8313f0395cce999f0dabe2bad86975c/extensions/browser/updater/update_data_provider.cc
[modify] https://crrev.com/8803f4e6d8313f0395cce999f0dabe2bad86975c/extensions/browser/updater/update_service_unittest.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3d3db3f47c6cb83b9897fb8d33874b958b2a276

commit b3d3db3f47c6cb83b9897fb8d33874b958b2a276
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Mon Jun 04 22:59:56 2018

[Extensions]: Update UMA histograms to investigate finch experiment.

- Modify when Extensions.ExtensionUpdaterUpdateCalls is emitted to match with the old extension
  updater.
- Add Extensions.UnifiedExtensionUpdaterUpdateCalls to measure calls to the new extension updater
  only (because old extension updater is still used for certain extensions, non CWS extensions
  for example).
- Add Extensions.UnifiedExtensionUpdaterUpdateCheckErrors to investigate why the new extension
  updater has more errors in the update check stage than the old extension updater.
- Some other small changes:
  + Don't update extension with empty IDS.
  + Extensions with empty update URLs.
  + Modify unit/browser tests to verify emitted histograms.
  + Add a new browser test for update check error.

Change-Id: I82fed27c0ab1a5e9ede1b98f0d820961d471c8fd
Bug: 722942
Reviewed-on: https://chromium-review.googlesource.com/1079317
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564283}
[modify] https://crrev.com/b3d3db3f47c6cb83b9897fb8d33874b958b2a276/chrome/browser/extensions/updater/update_service_browsertest.cc
[add] https://crrev.com/b3d3db3f47c6cb83b9897fb8d33874b958b2a276/chrome/test/data/extensions/updater/v2.crx
[modify] https://crrev.com/b3d3db3f47c6cb83b9897fb8d33874b958b2a276/extensions/browser/updater/update_service.cc
[modify] https://crrev.com/b3d3db3f47c6cb83b9897fb8d33874b958b2a276/extensions/browser/updater/update_service.h
[modify] https://crrev.com/b3d3db3f47c6cb83b9897fb8d33874b958b2a276/extensions/browser/updater/update_service_unittest.cc
[modify] https://crrev.com/b3d3db3f47c6cb83b9897fb8d33874b958b2a276/tools/metrics/histograms/histograms.xml

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42c0d70648d8d182ed0e458de5a2952fbce09eb2

commit 42c0d70648d8d182ed0e458de5a2952fbce09eb2
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Wed Jun 13 18:23:35 2018

[Extensions]: Add more UMA histograms to help investigate Finch experiment.

The Finch experiment is showing that the experiment group has much more
extensions than the control group. Adding these new histograms may help us
understand more about what's happening.

Bug: 722942
Change-Id: Ia3308e61efeeb533c31638ca0f0ecf500c7e0f9c
Reviewed-on: https://chromium-review.googlesource.com/1091695
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566924}
[modify] https://crrev.com/42c0d70648d8d182ed0e458de5a2952fbce09eb2/chrome/browser/extensions/updater/extension_updater.cc
[modify] https://crrev.com/42c0d70648d8d182ed0e458de5a2952fbce09eb2/chrome/browser/extensions/updater/update_service_browsertest.cc
[modify] https://crrev.com/42c0d70648d8d182ed0e458de5a2952fbce09eb2/extensions/browser/updater/extension_downloader.cc
[modify] https://crrev.com/42c0d70648d8d182ed0e458de5a2952fbce09eb2/extensions/browser/updater/safe_manifest_parser.cc
[modify] https://crrev.com/42c0d70648d8d182ed0e458de5a2952fbce09eb2/extensions/browser/updater/update_service.cc
[modify] https://crrev.com/42c0d70648d8d182ed0e458de5a2952fbce09eb2/extensions/browser/updater/update_service_unittest.cc
[modify] https://crrev.com/42c0d70648d8d182ed0e458de5a2952fbce09eb2/tools/metrics/histograms/histograms.xml

Project Member

Comment 17 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/039eb991af1c1a88dea589ff6aa3ad2b5e72509f

commit 039eb991af1c1a88dea589ff6aa3ad2b5e72509f
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Tue Jun 26 20:12:13 2018

[Extensions] Implement install_immediately logic in the new extension updater.

The new extension updater doesn't implement the updater correctly when
install_immediately is set. By default, it creates a CRX installer with
install_immediately set to false regardless of the user's intention.
This change will fix this behavior.

Bug: 722942
Change-Id: Idca645878587208cde1ed9f23ec8f0facf379868
Reviewed-on: https://chromium-review.googlesource.com/1107042
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570508}
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/chrome/browser/extensions/extension_system_impl.cc
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/chrome/browser/extensions/extension_system_impl.h
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/chrome/browser/extensions/test_extension_system.cc
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/chrome/browser/extensions/test_extension_system.h
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/chrome/browser/extensions/updater/extension_updater.cc
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/chromecast/browser/extensions/cast_extension_system.cc
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/chromecast/browser/extensions/cast_extension_system.h
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/extensions/browser/extension_system.h
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/extensions/browser/mock_extension_system.cc
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/extensions/browser/mock_extension_system.h
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/extensions/browser/updater/extension_installer.cc
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/extensions/browser/updater/extension_installer.h
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/extensions/browser/updater/extension_installer_unittest.cc
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/extensions/browser/updater/extension_update_data.cc
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/extensions/browser/updater/extension_update_data.h
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/extensions/browser/updater/update_data_provider.cc
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/extensions/browser/updater/update_data_provider.h
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/extensions/browser/updater/update_data_provider_unittest.cc
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/extensions/browser/updater/update_service.cc
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/extensions/browser/updater/update_service.h
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/extensions/browser/updater/update_service_unittest.cc
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/extensions/shell/browser/shell_extension_system.cc
[modify] https://crrev.com/039eb991af1c1a88dea589ff6aa3ad2b5e72509f/extensions/shell/browser/shell_extension_system.h

Project Member

Comment 18 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61951be8fe8efa0626fc4eb6e0cd7f827982e430

commit 61951be8fe8efa0626fc4eb6e0cd7f827982e430
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Tue Jul 17 22:40:26 2018

[Extensions] Re-classify extension manifest update results.

This is to correct the way the (old) extension updater determines updates
from the update manifest (|ExtensionDownloader::DetermineUpdates|). It
currently treats extension update errors (e.g. extension not in the update
manifest, invalid update version in the update manifest, ...) as no updates,
which would cause a disparity with the new extension updater running in the
Finch experiment.

Bug: 722942
Change-Id: I4d958fb0d313f2a9cd2456eef3035d2ef5f091fe
Reviewed-on: https://chromium-review.googlesource.com/1123710
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575818}
[modify] https://crrev.com/61951be8fe8efa0626fc4eb6e0cd7f827982e430/chrome/browser/extensions/updater/extension_updater_unittest.cc
[modify] https://crrev.com/61951be8fe8efa0626fc4eb6e0cd7f827982e430/extensions/browser/updater/extension_downloader.cc
[modify] https://crrev.com/61951be8fe8efa0626fc4eb6e0cd7f827982e430/extensions/browser/updater/extension_downloader.h
[modify] https://crrev.com/61951be8fe8efa0626fc4eb6e0cd7f827982e430/extensions/browser/updater/safe_manifest_parser.cc
[modify] https://crrev.com/61951be8fe8efa0626fc4eb6e0cd7f827982e430/extensions/browser/updater/safe_manifest_parser.h
[modify] https://crrev.com/61951be8fe8efa0626fc4eb6e0cd7f827982e430/extensions/browser/updater/safe_manifest_parser_unittest.cc
[modify] https://crrev.com/61951be8fe8efa0626fc4eb6e0cd7f827982e430/tools/metrics/histograms/histograms.xml

Comment 19 by benhenry@chromium.org, Aug 3

Status: Assigned (was: Untriaged)

This bug has an owner, thus, it's been triaged. Changing status to "assigned".

Project Member

Comment 20 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a61bf9be1eacd91434dcacbe5b40c686bf006519

commit a61bf9be1eacd91434dcacbe5b40c686bf006519
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Tue Aug 07 16:06:29 2018

Add field trial config for the NewExtensionUpdaterService feature.

Bug: 828615, 722942
Change-Id: I75766fc9cf91bc0a49e38abdd3dce1e3b1627b85
Reviewed-on: https://chromium-review.googlesource.com/1008830
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581240}
[modify] https://crrev.com/a61bf9be1eacd91434dcacbe5b40c686bf006519/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 21 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1e8afb45d904b39976751aae299515affdf900e

commit e1e8afb45d904b39976751aae299515affdf900e
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Fri Oct 12 17:47:51 2018

Add counters to measure network errors in the  extension updater update check.

Note that these new histograms will help us understand more about the update
check error codes of the unified extension updater Finch experiment currently
running in Beta.


Bug: 722942
Change-Id: Ie20083437c8a06b7649c5ed01e91ac68357d84ca
Reviewed-on: https://chromium-review.googlesource.com/c/1271790
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599278}
[modify] https://crrev.com/e1e8afb45d904b39976751aae299515affdf900e/chrome/browser/extensions/updater/extension_updater_unittest.cc
[modify] https://crrev.com/e1e8afb45d904b39976751aae299515affdf900e/extensions/browser/updater/extension_downloader.cc
[modify] https://crrev.com/e1e8afb45d904b39976751aae299515affdf900e/tools/metrics/histograms/histograms.xml

►

Issue 722942 link

Issue metadata

Component update client should be extended to support Chrome extensions update request

Issue description

Comment 1 by bugdroid1@chromium.org, Sep 14 2017

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Oct 13 2017

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Oct 19 2017

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Dec 4 2017

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Jan 4 2018

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Feb 1 2018

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Mar 28 2018

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Apr 19 2018

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Apr 24 2018

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Apr 26 2018

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, May 2 2018

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, May 18 2018

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, May 23 2018

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, May 25 2018

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Jun 4 2018

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Jun 13 2018

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Jun 26 2018

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, Jul 17

Comment 18 Deleted

Comment 19 by benhenry@chromium.org, Aug 3

Comment 19 Deleted

Comment 20 by bugdroid1@chromium.org, Aug 7

Comment 20 Deleted

Comment 21 by bugdroid1@chromium.org, Oct 12

Comment 21 Deleted

Sign in to add a comment