New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 722935 link

Starred by 12 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Sign in to add a comment

[meta] Determine viz layering

Project Member Reported by fsam...@chromium.org, May 16 2017

Issue description

components/viz will consist of the following layers:

frame_sinks:
   where CompositorFrames (and later ContentFrames) are received.

Includes: FrameSinkManager, CompositorFrameSinkSupport.

surfaces:
   layer beneath frame_sinks where CompositorFrames are stored. Also responsible for aggregation, occlusion, synchronization.

Includes: Surface, SurfaceDependencyTracker, SurfaceManager

display_compositor:
   layer beneath surfaces that takes a CompositorFrame and draws it 

Includes: DirectRenderer, GLRenderer, OutputSurface, etc.

A layer above can know about the layer below, but not vice versa.

In other words, FrameSinkManager can know about SurfaceManager but a SurfaceManager should not know about BeginFrames and FrameSinks.

I think one way to make progress on this layering is to invert the relationship between SurfaceManager and FrameSinkManager.

Currently SurfaceManager has a FrameSinkManager. We should instead have FrameSinkManager have a SurfaceManager.

I'm not sure about "hit_test"'s layering.

Planning spreadsheet: https://docs.google.com/spreadsheets/d/1buIcuS-lgM1eIYChOrBEAo0BdlIkb7p1TF58L2kBAAg/edit#gid=0
 
Showing comments 73 - 172 of 172 Older
Blockedon: 749235
Project Member

Comment 74 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc7c5270751f19435ac4eed95d47ecb77325f494

commit fc7c5270751f19435ac4eed95d47ecb77325f494
Author: danakj <danakj@chromium.org>
Date: Wed Jul 26 20:42:54 2017

Consolidate and add owners/categories to //components/viz/OWNERS

This puts all owners into a top level file like we have with //cc
today. It adds people who expressed interest in doing reviews in this
area as code moves from //cc, and puts people into areas of interest
to help authors and owners find appropriate people to look at a change.

Also, welcome flackr as a math reviewer yay!

R=enne@chromium.org, flackr@chromium.org, kylechar@chromium.org, piman@chromium.org, rjkroege@chromium.org, sadrul@chromium.org, vmpstr@chromium.org, vollick@chromium.org

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I23cd74e2f66b241de36bb557b4932020b9f5025b
Reviewed-on: https://chromium-review.googlesource.com/587298
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489745}
[modify] https://crrev.com/fc7c5270751f19435ac4eed95d47ecb77325f494/cc/OWNERS
[modify] https://crrev.com/fc7c5270751f19435ac4eed95d47ecb77325f494/components/viz/OWNERS
[delete] https://crrev.com/46557add15cad35637dc7565f0d8ba8d9d676114/components/viz/host/OWNERS
[delete] https://crrev.com/46557add15cad35637dc7565f0d8ba8d9d676114/components/viz/host/hit_test/OWNERS
[delete] https://crrev.com/46557add15cad35637dc7565f0d8ba8d9d676114/components/viz/service/display_embedder/OWNERS
[delete] https://crrev.com/46557add15cad35637dc7565f0d8ba8d9d676114/components/viz/service/hit_test/OWNERS

Project Member

Comment 75 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7db4fd1aa935b95c881de8ec0ce78b7c74166eca

commit 7db4fd1aa935b95c881de8ec0ce78b7c74166eca
Author: Fady Samuel <fsamuel@chromium.org>
Date: Wed Jul 26 23:18:11 2017

viz: Fix bad forward declarations

We were forward declaring cc::SurfaceInfo in a bunch of places but that
class is now in Viz.

Bug: 722935
Change-Id: I2d8b20ab8e8e531a43cad747ffb76d355a90791e
Reviewed-on: https://chromium-review.googlesource.com/587460
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489793}
[modify] https://crrev.com/7db4fd1aa935b95c881de8ec0ce78b7c74166eca/components/viz/host/frame_sink_observer.h
[modify] https://crrev.com/7db4fd1aa935b95c881de8ec0ce78b7c74166eca/components/viz/host/host_frame_sink_manager.h
[modify] https://crrev.com/7db4fd1aa935b95c881de8ec0ce78b7c74166eca/ui/aura/mus/window_mus.h

Project Member

Comment 76 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/253392e56f447af1f488ca6c12105d0806e233f3

commit 253392e56f447af1f488ca6c12105d0806e233f3
Author: danakj <danakj@chromium.org>
Date: Thu Jul 27 23:41:58 2017

Add a README.md to components/viz/

Describe what common, client, host, and service directories do. Explains
the dependencies allowed within the service directories. And provides the
agreed-upon naming guidelines used for naming Mojo interfaces, implementations
and client libraries

R=enne@chromium.org, rjkroege@chromium.org

Bug: 722935
Change-Id: I19aa5bd0f9985bb79faddd26a45a5be9b28413e1
Reviewed-on: https://chromium-review.googlesource.com/588069
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490120}
[add] https://crrev.com/253392e56f447af1f488ca6c12105d0806e233f3/components/viz/README.md
[delete] https://crrev.com/c998cf3857d76d0773b330adb2d9098453c53050/components/viz/common/README.md

Project Member

Comment 77 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c80a4a860ea9c7d7a48769d6ad4997aa1695c996

commit c80a4a860ea9c7d7a48769d6ad4997aa1695c996
Author: Fady Samuel <fsamuel@chromium.org>
Date: Fri Jul 28 10:23:36 2017

viz: Move ResourceId to components/viz/common/resources

This is a mechanical CL that moves cc/base/resource_id.h to
components/viz/common/resources and updates all the corresponding
includes, forward declarations, and namespaces

Bug: 722935
TBR: tsepez@chromium.org, sky@chromium.org
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1f73d4888863aa09265310b870c2000662efeb96
Reviewed-on: https://chromium-review.googlesource.com/590169
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490350}
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/android_webview/browser/browser_view_renderer_unittest.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/android_webview/browser/test/rendering_test.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/android_webview/browser/test/rendering_test.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/ash/fast_ink/fast_ink_view.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/base/BUILD.gn
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/ipc/cc_param_traits_unittest.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/ipc/cc_serialization_perftest.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/ipc/struct_traits_unittest.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/layers/heads_up_display_layer_impl.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/layers/layer_impl.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/layers/layer_impl.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/layers/painted_scrollbar_layer_impl.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/layers/picture_layer_impl.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/layers/picture_layer_impl.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/layers/render_surface_impl.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/layers/texture_layer_impl.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/layers/texture_layer_impl.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/layers/texture_layer_unittest.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/layers/ui_resource_layer_impl.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/layers/video_layer_impl.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/output/gl_renderer.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/output/gl_renderer.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/output/gl_renderer_unittest.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/output/overlay_candidate.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/output/overlay_candidate.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/output/overlay_unittest.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/output/renderer_pixeltest.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/output/software_renderer.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/output/software_renderer.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/output/software_renderer_unittest.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/quads/draw_quad.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/quads/draw_quad_perftest.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/quads/draw_quad_unittest.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/quads/nine_patch_generator.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/quads/render_pass_draw_quad.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/quads/render_pass_draw_quad.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/quads/stream_video_draw_quad.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/quads/texture_draw_quad.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/quads/tile_draw_quad.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/quads/yuv_video_draw_quad.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/raster/bitmap_raster_buffer_provider.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/raster/bitmap_raster_buffer_provider.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/raster/gpu_raster_buffer_provider.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/raster/gpu_raster_buffer_provider.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/raster/one_copy_raster_buffer_provider.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/raster/one_copy_raster_buffer_provider.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/raster/raster_buffer_provider.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/raster/zero_copy_raster_buffer_provider.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/raster/zero_copy_raster_buffer_provider.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/resources/resource.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/resources/resource_pool.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/resources/resource_pool.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/resources/resource_provider.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/resources/resource_provider.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/resources/resource_provider_unittest.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/resources/returned_resource.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/resources/transferable_resource.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/resources/video_resource_updater.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/test/fake_mask_layer_impl.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/test/fake_mask_layer_impl.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/test/fake_raster_buffer_provider.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/test/fake_raster_buffer_provider.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/test/fake_ui_resource_layer_tree_host_impl.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/test/fake_ui_resource_layer_tree_host_impl.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/test/render_pass_test_utils.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/test/render_pass_test_utils.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/tiles/tile_draw_info.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/trees/layer_tree_host_unittest_context.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/components/exo/layer_tree_frame_sink_holder.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/components/exo/layer_tree_frame_sink_holder.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/components/viz/common/BUILD.gn
[rename] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/components/viz/common/resources/resource_id.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/components/viz/service/display/surface_aggregator.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/components/viz/service/display/surface_aggregator.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/components/viz/service/frame_sinks/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/components/viz/service/frame_sinks/surface_resource_holder.h
[modify] https://crrev.com/c80a4a860ea9c7d7a48769d6ad4997aa1695c996/components/viz/test/surface_hittest_test_helpers.cc

Project Member

Comment 78 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed320d53e4d25dd458d0d148b9bf02c5a5431d59

commit ed320d53e4d25dd458d0d148b9bf02c5a5431d59
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Fri Jul 28 10:25:02 2017

viz: Move hit_test public API into the right place.

The public mojom API should live in services/viz/public/interfaces.

BUG=722935

Change-Id: Id31eb00e588b9b614e03837bb5fdfd31639b0416
Reviewed-on: https://chromium-review.googlesource.com/590776
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490351}
[modify] https://crrev.com/ed320d53e4d25dd458d0d148b9bf02c5a5431d59/components/viz/host/hit_test/BUILD.gn
[modify] https://crrev.com/ed320d53e4d25dd458d0d148b9bf02c5a5431d59/components/viz/host/hit_test/DEPS
[modify] https://crrev.com/ed320d53e4d25dd458d0d148b9bf02c5a5431d59/components/viz/host/hit_test/hit_test_query.cc
[modify] https://crrev.com/ed320d53e4d25dd458d0d148b9bf02c5a5431d59/components/viz/host/hit_test/hit_test_query.h
[modify] https://crrev.com/ed320d53e4d25dd458d0d148b9bf02c5a5431d59/components/viz/host/hit_test/hit_test_query_unittest.cc
[modify] https://crrev.com/ed320d53e4d25dd458d0d148b9bf02c5a5431d59/components/viz/service/BUILD.gn
[modify] https://crrev.com/ed320d53e4d25dd458d0d148b9bf02c5a5431d59/components/viz/service/hit_test/DEPS
[modify] https://crrev.com/ed320d53e4d25dd458d0d148b9bf02c5a5431d59/components/viz/service/hit_test/hit_test_aggregator.h
[rename] https://crrev.com/ed320d53e4d25dd458d0d148b9bf02c5a5431d59/services/viz/public/interfaces/hit_test/BUILD.gn
[rename] https://crrev.com/ed320d53e4d25dd458d0d148b9bf02c5a5431d59/services/viz/public/interfaces/hit_test/OWNERS
[rename] https://crrev.com/ed320d53e4d25dd458d0d148b9bf02c5a5431d59/services/viz/public/interfaces/hit_test/hit_test_region_list.mojom

Project Member

Comment 79 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f7f0fb33df6420b9ace806fe957d852694c8910

commit 4f7f0fb33df6420b9ace806fe957d852694c8910
Author: Fady Samuel <fsamuel@chromium.org>
Date: Fri Jul 28 15:33:37 2017

viz: Move (Returned|Transferable)Resource to components/viz/common/resources

This is a mechanical move of ReturnedREsource and TransferableResource to
components/viz/common/resources. Includes, namespaces, and forward
declarations are updated appropriately.

Bug: 722935
TBR: junov@chromium.org
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
Change-Id: If4eae4a80ef8722b24f6ca1badd0a25a3339d26b
Reviewed-on: https://chromium-review.googlesource.com/590132
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490400}
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/android_webview/browser/browser_view_renderer.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/android_webview/browser/compositor_frame_consumer.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/android_webview/browser/hardware_renderer.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/android_webview/browser/hardware_renderer.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/android_webview/browser/render_thread_manager.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/android_webview/browser/render_thread_manager.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/android_webview/browser/surfaces_instance.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/android_webview/browser/surfaces_instance.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/android_webview/browser/test/rendering_test.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/ash/fast_ink/fast_ink_view.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/ash/fast_ink/fast_ink_view.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/BUILD.gn
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/ipc/cc_param_traits.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/ipc/cc_param_traits_macros.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/ipc/cc_param_traits_unittest.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/ipc/cc_serialization_perftest.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/ipc/compositor_frame_struct_traits.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/ipc/returned_resource.typemap
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/ipc/returned_resource_struct_traits.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/ipc/struct_traits_unittest.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/ipc/transferable_resource.typemap
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/ipc/transferable_resource_struct_traits.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/ipc/transferable_resource_struct_traits.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/layers/texture_layer_unittest.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/output/compositor_frame.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/output/layer_tree_frame_sink.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/output/layer_tree_frame_sink_client.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/output/output_surface.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/output/output_surface_client.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/resources/resource_provider.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/resources/resource_provider.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/resources/resource_provider_unittest.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/resources/return_callback.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/test/fake_compositor_frame_sink_support_client.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/test/fake_compositor_frame_sink_support_client.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/test/fake_layer_tree_frame_sink.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/test/fake_layer_tree_frame_sink.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/test/fake_layer_tree_frame_sink_client.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/test/fake_output_surface.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/test/mock_compositor_frame_sink_support_client.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/exo/buffer.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/exo/buffer.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/exo/buffer_unittest.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/exo/layer_tree_frame_sink_holder.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/exo/layer_tree_frame_sink_holder.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/exo/surface.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/client/client_layer_tree_frame_sink.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/client/client_layer_tree_frame_sink.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/common/BUILD.gn
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/common/resources/DEPS
[rename] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/common/resources/returned_resource.h
[rename] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/common/resources/transferable_resource.cc
[rename] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/common/resources/transferable_resource.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/service/display/display.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/service/display/surface_aggregator.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/service/display/surface_aggregator.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/service/display/surface_aggregator_perftest.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/service/frame_sinks/compositor_frame_sink_support.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/service/frame_sinks/compositor_frame_sink_support.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/service/frame_sinks/compositor_frame_sink_support_client.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/service/frame_sinks/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/service/frame_sinks/gpu_compositor_frame_sink.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/service/frame_sinks/gpu_compositor_frame_sink.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/service/frame_sinks/gpu_root_compositor_frame_sink.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/service/frame_sinks/gpu_root_compositor_frame_sink.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/service/frame_sinks/surface_resource_holder.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/service/frame_sinks/surface_resource_holder.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/service/frame_sinks/surface_resource_holder_client.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/service/frame_sinks/surface_synchronization_unittest.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/service/surfaces/surface.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/service/surfaces/surface.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/service/surfaces/surface_client.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/test/compositor_frame_helpers.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/test/compositor_frame_helpers.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/test/test_layer_tree_frame_sink.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/components/viz/test/test_layer_tree_frame_sink.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/content/browser/android/synchronous_compositor_host.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/content/browser/android/synchronous_compositor_host.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/content/browser/frame_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/content/browser/renderer_host/delegated_frame_host.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/content/browser/renderer_host/offscreen_canvas_provider_impl_unittest.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/content/common/android/sync_compositor_messages.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/content/public/browser/DEPS
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/content/public/browser/android/synchronous_compositor.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/content/public/test/test_synchronous_compositor_android.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/content/public/test/test_synchronous_compositor_android.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/content/renderer/android/synchronous_layer_tree_frame_sink.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/content/renderer/android/synchronous_layer_tree_frame_sink.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/content/test/fake_renderer_compositor_frame_sink.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/content/test/fake_renderer_compositor_frame_sink.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/services/ui/ws/frame_generator.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/services/ui/ws/frame_generator.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/ui/android/delegated_frame_host_android.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/ui/aura/local/layer_tree_frame_sink_local.cc
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/ui/aura/local/layer_tree_frame_sink_local.h
[modify] https://crrev.com/4f7f0fb33df6420b9ace806fe957d852694c8910/ui/compositor/layer.cc

Project Member

Comment 80 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e65ab0a11b73c8eea0139c0757005432d6dbb0b6

commit e65ab0a11b73c8eea0139c0757005432d6dbb0b6
Author: Fady Samuel <fsamuel@chromium.org>
Date: Fri Jul 28 17:47:25 2017

viz: Move surface sync unit test dependencies to components/viz/test

This is a mechanical refactor: includes, namespaces, and forward
declarations are updated appropriately.

Bug: 722935
TBR: piman@chromium.org
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I63a1807491167b125122b48aa61ec9ba1e19014d
Reviewed-on: https://chromium-review.googlesource.com/591613
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490453}
[modify] https://crrev.com/e65ab0a11b73c8eea0139c0757005432d6dbb0b6/cc/BUILD.gn
[modify] https://crrev.com/e65ab0a11b73c8eea0139c0757005432d6dbb0b6/cc/scheduler/scheduler_unittest.cc
[delete] https://crrev.com/03d70ba9b071ea4c6836ff946e970af1425fba39/cc/test/fake_external_begin_frame_source.h
[delete] https://crrev.com/03d70ba9b071ea4c6836ff946e970af1425fba39/cc/test/fake_surface_observer.cc
[delete] https://crrev.com/03d70ba9b071ea4c6836ff946e970af1425fba39/cc/test/fake_surface_observer.h
[delete] https://crrev.com/03d70ba9b071ea4c6836ff946e970af1425fba39/cc/test/mock_compositor_frame_sink_support_client.h
[modify] https://crrev.com/e65ab0a11b73c8eea0139c0757005432d6dbb0b6/cc/trees/layer_tree_host_unittest_checkerimaging.cc
[modify] https://crrev.com/e65ab0a11b73c8eea0139c0757005432d6dbb0b6/components/exo/surface_unittest.cc
[modify] https://crrev.com/e65ab0a11b73c8eea0139c0757005432d6dbb0b6/components/viz/service/display/display_scheduler_unittest.cc
[modify] https://crrev.com/e65ab0a11b73c8eea0139c0757005432d6dbb0b6/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/e65ab0a11b73c8eea0139c0757005432d6dbb0b6/components/viz/service/frame_sinks/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/e65ab0a11b73c8eea0139c0757005432d6dbb0b6/components/viz/service/frame_sinks/frame_sink_manager_unittest.cc
[modify] https://crrev.com/e65ab0a11b73c8eea0139c0757005432d6dbb0b6/components/viz/service/frame_sinks/surface_synchronization_unittest.cc
[modify] https://crrev.com/e65ab0a11b73c8eea0139c0757005432d6dbb0b6/components/viz/service/surfaces/surface_unittest.cc
[modify] https://crrev.com/e65ab0a11b73c8eea0139c0757005432d6dbb0b6/components/viz/test/BUILD.gn
[rename] https://crrev.com/e65ab0a11b73c8eea0139c0757005432d6dbb0b6/components/viz/test/fake_external_begin_frame_source.cc
[add] https://crrev.com/e65ab0a11b73c8eea0139c0757005432d6dbb0b6/components/viz/test/fake_external_begin_frame_source.h
[add] https://crrev.com/e65ab0a11b73c8eea0139c0757005432d6dbb0b6/components/viz/test/fake_surface_observer.cc
[add] https://crrev.com/e65ab0a11b73c8eea0139c0757005432d6dbb0b6/components/viz/test/fake_surface_observer.h
[rename] https://crrev.com/e65ab0a11b73c8eea0139c0757005432d6dbb0b6/components/viz/test/mock_compositor_frame_sink_support_client.cc
[add] https://crrev.com/e65ab0a11b73c8eea0139c0757005432d6dbb0b6/components/viz/test/mock_compositor_frame_sink_support_client.h
[modify] https://crrev.com/e65ab0a11b73c8eea0139c0757005432d6dbb0b6/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
[modify] https://crrev.com/e65ab0a11b73c8eea0139c0757005432d6dbb0b6/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/e65ab0a11b73c8eea0139c0757005432d6dbb0b6/services/ui/ws/frame_generator_unittest.cc

Project Member

Comment 81 by bugdroid1@chromium.org, Jul 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72f43770fd62825db3b3cdb2150490245b345ac7

commit 72f43770fd62825db3b3cdb2150490245b345ac7
Author: Fady Samuel <fsamuel@chromium.org>
Date: Sat Jul 29 14:15:33 2017

viz: Move GLRenderer to components/viz/service/display

This is a mechanical CL that updates includes, namespaces and forward
declarations accordingly.

Bug: 722935
TBR: dalecurtis@chromium.org, reed@chromium.org
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0c3da1e0236100487f59b7b8c15f5a94452ac607
Reviewed-on: https://chromium-review.googlesource.com/591777
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490651}
[modify] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/cc/BUILD.gn
[modify] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/cc/README.md
[modify] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/cc/output/DEPS
[modify] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/cc/output/color_lut_cache.h
[modify] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/cc/output/dynamic_geometry_binding.h
[delete] https://crrev.com/27548b34fd12fc0c7ec6c020a54f6d3b6f96c961/cc/output/gl_renderer_draw_cache.cc
[modify] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/cc/output/overlay_unittest.cc
[modify] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/cc/output/program_binding.h
[modify] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/cc/output/renderer_pixeltest.cc
[modify] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/cc/output/shader.h
[modify] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/cc/output/static_geometry_binding.h
[modify] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/cc/resources/resource_provider.h
[modify] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/cc/resources/video_resource_updater.cc
[modify] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/cc/test/pixel_test.cc
[modify] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/cc/test/pixel_test.h
[add] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/cc/trees/DEPS
[modify] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/components/viz/service/BUILD.gn
[modify] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/components/viz/service/display/DEPS
[modify] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/components/viz/service/display/display.cc
[rename] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/components/viz/service/display/gl_renderer.cc
[rename] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/components/viz/service/display/gl_renderer.h
[add] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/components/viz/service/display/gl_renderer_draw_cache.cc
[rename] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/components/viz/service/display/gl_renderer_draw_cache.h
[rename] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/components/viz/service/display/gl_renderer_unittest.cc
[modify] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/components/viz/service/display/surface_aggregator_pixeltest.cc
[modify] https://crrev.com/72f43770fd62825db3b3cdb2150490245b345ac7/content/renderer/pepper/video_decoder_shim.cc

Owner: ----
Remove myself from owner since this is a meta bug.
Project Member

Comment 83 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5869915109b829fa885d40caa942aab1c19be941

commit 5869915109b829fa885d40caa942aab1c19be941
Author: Fady Samuel <fsamuel@chromium.org>
Date: Tue Aug 01 05:40:31 2017

viz: Add some comments to viz::Surface.

viz::Surface is lacking a class-level comment. This CL adds one to improve
the collective understanding of what a Surface is.

Bug: 722935
Change-Id: I00c2488e73388ceb2eb8c55d4f2c73a6eebbf9f5
Reviewed-on: https://chromium-review.googlesource.com/594875
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490863}
[modify] https://crrev.com/5869915109b829fa885d40caa942aab1c19be941/components/viz/service/surfaces/surface.h

Project Member

Comment 84 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99aa8b2f4f23695995bb7c6d644bda8451881969

commit 99aa8b2f4f23695995bb7c6d644bda8451881969
Author: Fady Samuel <fsamuel@chromium.org>
Date: Tue Aug 01 06:58:07 2017

viz: Move more of GLRenderer's dependencies to components/viz/service/display

This CL moves the following GLRenderer dependencies to
components/viz/service/display:

color_lut_cache.*
dynamic_geometry_binding.*
geometry_binding.*
program_binding.*
shader*
static_geometry_binding.*

All includes, forward declarations and namespaces are updated appropriately.

Bug: 722935
TBR: piman@chromium.org
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If3a070ff81698c5c7c75a93b5aae36c37b68fc9c
Reviewed-on: https://chromium-review.googlesource.com/592950
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490891}
[modify] https://crrev.com/99aa8b2f4f23695995bb7c6d644bda8451881969/cc/BUILD.gn
[delete] https://crrev.com/304c524c5df38c9f4fe8e523000e8963a56c58bd/cc/output/static_geometry_binding.h
[modify] https://crrev.com/99aa8b2f4f23695995bb7c6d644bda8451881969/components/viz/service/BUILD.gn
[modify] https://crrev.com/99aa8b2f4f23695995bb7c6d644bda8451881969/components/viz/service/display/DEPS
[rename] https://crrev.com/99aa8b2f4f23695995bb7c6d644bda8451881969/components/viz/service/display/color_lut_cache.cc
[rename] https://crrev.com/99aa8b2f4f23695995bb7c6d644bda8451881969/components/viz/service/display/color_lut_cache.h
[rename] https://crrev.com/99aa8b2f4f23695995bb7c6d644bda8451881969/components/viz/service/display/dynamic_geometry_binding.cc
[rename] https://crrev.com/99aa8b2f4f23695995bb7c6d644bda8451881969/components/viz/service/display/dynamic_geometry_binding.h
[rename] https://crrev.com/99aa8b2f4f23695995bb7c6d644bda8451881969/components/viz/service/display/geometry_binding.cc
[rename] https://crrev.com/99aa8b2f4f23695995bb7c6d644bda8451881969/components/viz/service/display/geometry_binding.h
[modify] https://crrev.com/99aa8b2f4f23695995bb7c6d644bda8451881969/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/99aa8b2f4f23695995bb7c6d644bda8451881969/components/viz/service/display/gl_renderer.h
[modify] https://crrev.com/99aa8b2f4f23695995bb7c6d644bda8451881969/components/viz/service/display/gl_renderer_draw_cache.h
[modify] https://crrev.com/99aa8b2f4f23695995bb7c6d644bda8451881969/components/viz/service/display/gl_renderer_unittest.cc
[rename] https://crrev.com/99aa8b2f4f23695995bb7c6d644bda8451881969/components/viz/service/display/program_binding.cc
[rename] https://crrev.com/99aa8b2f4f23695995bb7c6d644bda8451881969/components/viz/service/display/program_binding.h
[rename] https://crrev.com/99aa8b2f4f23695995bb7c6d644bda8451881969/components/viz/service/display/shader.cc
[rename] https://crrev.com/99aa8b2f4f23695995bb7c6d644bda8451881969/components/viz/service/display/shader.h
[rename] https://crrev.com/99aa8b2f4f23695995bb7c6d644bda8451881969/components/viz/service/display/shader_unittest.cc
[rename] https://crrev.com/99aa8b2f4f23695995bb7c6d644bda8451881969/components/viz/service/display/static_geometry_binding.cc
[add] https://crrev.com/99aa8b2f4f23695995bb7c6d644bda8451881969/components/viz/service/display/static_geometry_binding.h

Project Member

Comment 85 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7863b773b4ec71ace9a44adc0ad7150d91d83e3c

commit 7863b773b4ec71ace9a44adc0ad7150d91d83e3c
Author: danakj <danakj@chromium.org>
Date: Tue Aug 01 20:30:55 2017

Add reveman and dcastagna to components/viz/OWNERS

R=reveman@chromium.org

Bug: 722935
Change-Id: Ib412fda34cf0e55529a0f288863decbca7f73616
Reviewed-on: https://chromium-review.googlesource.com/596515
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491099}
[modify] https://crrev.com/7863b773b4ec71ace9a44adc0ad7150d91d83e3c/components/viz/OWNERS

Project Member

Comment 86 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36bc8137da37a643a84ff32c71c0e11d7b2e9717

commit 36bc8137da37a643a84ff32c71c0e11d7b2e9717
Author: Fady Samuel <fsamuel@chromium.org>
Date: Wed Aug 02 19:38:29 2017

Viz: DidReceiveCompositorFrameAck should only be called once per frame.

In order to clarify this requirement, this CL switches the callback to
use base::OnceCallback.

Bug: 722935
Change-Id: I9fb96cfa794e0aa3d5765e533c5a0f9ac34d995f
Reviewed-on: https://chromium-review.googlesource.com/598543
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491469}
[modify] https://crrev.com/36bc8137da37a643a84ff32c71c0e11d7b2e9717/components/viz/service/frame_sinks/compositor_frame_sink_support.cc
[modify] https://crrev.com/36bc8137da37a643a84ff32c71c0e11d7b2e9717/components/viz/service/surfaces/surface.cc
[modify] https://crrev.com/36bc8137da37a643a84ff32c71c0e11d7b2e9717/components/viz/service/surfaces/surface.h

Blockedon: 751814
Project Member

Comment 88 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7839147c2ef53597debd48b0f75f2030c49caf3b

commit 7839147c2ef53597debd48b0f75f2030c49caf3b
Author: Saman Sami <samans@chromium.org>
Date: Fri Aug 04 23:26:19 2017

viz: Move CompositorFrame's mojom from cc to services/viz

TBR=sky@chromium.org
Bug=722935

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1fe2b3ab68a4bce06869ce3ea92ffd1b76dcd289
Reviewed-on: https://chromium-review.googlesource.com/601190
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492170}
[modify] https://crrev.com/7839147c2ef53597debd48b0f75f2030c49caf3b/cc/BUILD.gn
[modify] https://crrev.com/7839147c2ef53597debd48b0f75f2030c49caf3b/cc/ipc/BUILD.gn
[modify] https://crrev.com/7839147c2ef53597debd48b0f75f2030c49caf3b/cc/ipc/DEPS
[modify] https://crrev.com/7839147c2ef53597debd48b0f75f2030c49caf3b/cc/ipc/cc_serialization_perftest.cc
[delete] https://crrev.com/5e1171c8c293d8bcc8cf0eeb53583e7aaaff8c34/cc/ipc/compositor_frame.typemap
[delete] https://crrev.com/5e1171c8c293d8bcc8cf0eeb53583e7aaaff8c34/cc/ipc/compositor_frame_struct_traits.h
[modify] https://crrev.com/7839147c2ef53597debd48b0f75f2030c49caf3b/cc/ipc/struct_traits_unittest.cc
[modify] https://crrev.com/7839147c2ef53597debd48b0f75f2030c49caf3b/cc/ipc/traits_test_service.mojom
[modify] https://crrev.com/7839147c2ef53597debd48b0f75f2030c49caf3b/cc/ipc/typemaps.gni
[modify] https://crrev.com/7839147c2ef53597debd48b0f75f2030c49caf3b/services/ui/ws/server_window_compositor_frame_sink_manager.h
[modify] https://crrev.com/7839147c2ef53597debd48b0f75f2030c49caf3b/services/viz/public/cpp/compositing/BUILD.gn
[modify] https://crrev.com/7839147c2ef53597debd48b0f75f2030c49caf3b/services/viz/public/cpp/compositing/DEPS
[add] https://crrev.com/7839147c2ef53597debd48b0f75f2030c49caf3b/services/viz/public/cpp/compositing/compositor_frame.typemap
[rename] https://crrev.com/7839147c2ef53597debd48b0f75f2030c49caf3b/services/viz/public/cpp/compositing/compositor_frame_for_blink.typemap
[rename] https://crrev.com/7839147c2ef53597debd48b0f75f2030c49caf3b/services/viz/public/cpp/compositing/compositor_frame_struct_traits.cc
[add] https://crrev.com/7839147c2ef53597debd48b0f75f2030c49caf3b/services/viz/public/cpp/compositing/compositor_frame_struct_traits.h
[modify] https://crrev.com/7839147c2ef53597debd48b0f75f2030c49caf3b/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/7839147c2ef53597debd48b0f75f2030c49caf3b/services/viz/public/cpp/compositing/typemaps.gni
[modify] https://crrev.com/7839147c2ef53597debd48b0f75f2030c49caf3b/services/viz/public/interfaces/compositing/BUILD.gn
[rename] https://crrev.com/7839147c2ef53597debd48b0f75f2030c49caf3b/services/viz/public/interfaces/compositing/compositor_frame.mojom
[modify] https://crrev.com/7839147c2ef53597debd48b0f75f2030c49caf3b/services/viz/public/interfaces/compositing/compositor_frame_sink.mojom
[modify] https://crrev.com/7839147c2ef53597debd48b0f75f2030c49caf3b/third_party/WebKit/public/blink_typemaps.gni

Project Member

Comment 89 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/829ffaf32c26a71b88dc5dc4d233c5fffd6bf5ef

commit 829ffaf32c26a71b88dc5dc4d233c5fffd6bf5ef
Author: Saman Sami <samans@chromium.org>
Date: Fri Aug 04 23:49:56 2017

Revert "viz: Move CompositorFrame's mojom from cc to services/viz"

This reverts commit 7839147c2ef53597debd48b0f75f2030c49caf3b.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> viz: Move CompositorFrame's mojom from cc to services/viz
> 
> TBR=sky@chromium.org
> Bug=722935
> 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I1fe2b3ab68a4bce06869ce3ea92ffd1b76dcd289
> Reviewed-on: https://chromium-review.googlesource.com/601190
> Commit-Queue: Saman Sami <samans@chromium.org>
> Reviewed-by: Saman Sami <samans@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#492170}

TBR=rjkroege@chromium.org,sky@chromium.org,tsepez@chromium.org,samans@chromium.org

Change-Id: Ib34b4a8c1c2e564233a86f22a0932a1f4f788e15
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/602741
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492176}
[modify] https://crrev.com/829ffaf32c26a71b88dc5dc4d233c5fffd6bf5ef/cc/BUILD.gn
[modify] https://crrev.com/829ffaf32c26a71b88dc5dc4d233c5fffd6bf5ef/cc/ipc/BUILD.gn
[modify] https://crrev.com/829ffaf32c26a71b88dc5dc4d233c5fffd6bf5ef/cc/ipc/DEPS
[modify] https://crrev.com/829ffaf32c26a71b88dc5dc4d233c5fffd6bf5ef/cc/ipc/cc_serialization_perftest.cc
[rename] https://crrev.com/829ffaf32c26a71b88dc5dc4d233c5fffd6bf5ef/cc/ipc/compositor_frame.mojom
[add] https://crrev.com/829ffaf32c26a71b88dc5dc4d233c5fffd6bf5ef/cc/ipc/compositor_frame.typemap
[rename] https://crrev.com/829ffaf32c26a71b88dc5dc4d233c5fffd6bf5ef/cc/ipc/compositor_frame_for_blink.typemap
[rename] https://crrev.com/829ffaf32c26a71b88dc5dc4d233c5fffd6bf5ef/cc/ipc/compositor_frame_struct_traits.cc
[add] https://crrev.com/829ffaf32c26a71b88dc5dc4d233c5fffd6bf5ef/cc/ipc/compositor_frame_struct_traits.h
[modify] https://crrev.com/829ffaf32c26a71b88dc5dc4d233c5fffd6bf5ef/cc/ipc/struct_traits_unittest.cc
[modify] https://crrev.com/829ffaf32c26a71b88dc5dc4d233c5fffd6bf5ef/cc/ipc/traits_test_service.mojom
[modify] https://crrev.com/829ffaf32c26a71b88dc5dc4d233c5fffd6bf5ef/cc/ipc/typemaps.gni
[modify] https://crrev.com/829ffaf32c26a71b88dc5dc4d233c5fffd6bf5ef/services/ui/ws/server_window_compositor_frame_sink_manager.h
[modify] https://crrev.com/829ffaf32c26a71b88dc5dc4d233c5fffd6bf5ef/services/viz/public/cpp/compositing/BUILD.gn
[modify] https://crrev.com/829ffaf32c26a71b88dc5dc4d233c5fffd6bf5ef/services/viz/public/cpp/compositing/DEPS
[delete] https://crrev.com/a3c3176337d980e3787a2f4e55b0659a38427330/services/viz/public/cpp/compositing/compositor_frame.typemap
[delete] https://crrev.com/a3c3176337d980e3787a2f4e55b0659a38427330/services/viz/public/cpp/compositing/compositor_frame_struct_traits.h
[modify] https://crrev.com/829ffaf32c26a71b88dc5dc4d233c5fffd6bf5ef/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/829ffaf32c26a71b88dc5dc4d233c5fffd6bf5ef/services/viz/public/cpp/compositing/typemaps.gni
[modify] https://crrev.com/829ffaf32c26a71b88dc5dc4d233c5fffd6bf5ef/services/viz/public/interfaces/compositing/BUILD.gn
[modify] https://crrev.com/829ffaf32c26a71b88dc5dc4d233c5fffd6bf5ef/services/viz/public/interfaces/compositing/compositor_frame_sink.mojom
[modify] https://crrev.com/829ffaf32c26a71b88dc5dc4d233c5fffd6bf5ef/third_party/WebKit/public/blink_typemaps.gni

Project Member

Comment 90 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4e59f15f8dadd5ef22278f8e05ff5c62b3af3bd

commit f4e59f15f8dadd5ef22278f8e05ff5c62b3af3bd
Author: Joe Downing <joedow@chromium.org>
Date: Fri Aug 04 23:52:38 2017

Revert "viz: Move CompositorFrame's mojom from cc to services/viz"

This reverts commit 7839147c2ef53597debd48b0f75f2030c49caf3b.

Reason for revert: Culprit CL for build breakage:

Error:
../../cc/ipc/cc_serialization_perftest.cc:11:10: fatal error: 'cc/ipc/compositor_frame.mojom.h' file not found
#include "cc/ipc/compositor_frame.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Original change's description:
> viz: Move CompositorFrame's mojom from cc to services/viz
> 
> TBR=sky@chromium.org
> Bug=722935
> 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I1fe2b3ab68a4bce06869ce3ea92ffd1b76dcd289
> Reviewed-on: https://chromium-review.googlesource.com/601190
> Commit-Queue: Saman Sami <samans@chromium.org>
> Reviewed-by: Saman Sami <samans@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#492170}

TBR=rjkroege@chromium.org,sky@chromium.org,tsepez@chromium.org,samans@chromium.org

Change-Id: I3466865c523f900055bef8440d32016aead83253
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/602742
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492177}

Project Member

Comment 91 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b7fb8ef24900542c041a91b728b43fad98ae122

commit 5b7fb8ef24900542c041a91b728b43fad98ae122
Author: Fady Samuel <fsamuel@chromium.org>
Date: Tue Aug 08 16:58:22 2017

viz: Move SurfaceCreated call from CompositorFrameSinkSupport to Surface

The way we set and reset |seen_first_frame_activation_| in
CompositorFrameSinkSupport has been bugging me for a while and is likely
propone to bugs. This CL moves the bool to viz::Surface and it only gets
flipped once from false to true per Surface now. Also we don't need to
rebuild the SurfaceInfo because Surface has a SurfaceInfo already that
it can pass along.

This CL also renames OnSurfaceCreated to OnFirstSurfaceActivation to
better represent when it's actually called.

Bug: 722935
TBR: junov@chromium.org, sky@chromium.org, tsepez@chromium.org, boliu@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I90702d452a1a18b8c6d4ff6a4b61cdd799a81604
Reviewed-on: https://chromium-review.googlesource.com/600249
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492663}
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/components/viz/host/host_frame_sink_client.h
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/components/viz/host/host_frame_sink_manager.cc
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/components/viz/host/host_frame_sink_manager.h
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/components/viz/host/host_frame_sink_manager_unittests.cc
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/components/viz/service/display/display_scheduler.cc
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/components/viz/service/display/display_scheduler.h
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/components/viz/service/frame_sinks/compositor_frame_sink_support.cc
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/components/viz/service/frame_sinks/compositor_frame_sink_support.h
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/components/viz/service/frame_sinks/frame_sink_manager_impl.cc
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/components/viz/service/frame_sinks/frame_sink_manager_impl.h
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/components/viz/service/hit_test/hit_test_aggregator.h
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/components/viz/service/surfaces/surface.cc
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/components/viz/service/surfaces/surface.h
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/components/viz/service/surfaces/surface_manager.cc
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/components/viz/service/surfaces/surface_manager.h
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/components/viz/service/surfaces/surface_observer.h
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/components/viz/test/fake_surface_observer.cc
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/components/viz/test/fake_surface_observer.h
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/content/browser/frame_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/content/browser/renderer_host/compositor_impl_android.h
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/content/browser/renderer_host/delegated_frame_host.h
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/content/browser/renderer_host/offscreen_canvas_provider_impl_unittest.cc
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/content/browser/renderer_host/offscreen_canvas_surface_impl.cc
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/content/browser/renderer_host/offscreen_canvas_surface_impl.h
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/content/test/test_render_view_host.cc
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/content/test/test_render_view_host.h
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/services/ui/ws/frame_generator.cc
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/services/ui/ws/frame_generator.h
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/services/ui/ws/frame_generator_unittest.cc
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/services/ui/ws/window_server.cc
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/services/ui/ws/window_server.h
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/services/viz/compositing/privileged/interfaces/frame_sink_manager.mojom
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/third_party/WebKit/Source/platform/graphics/SurfaceLayerBridge.cpp
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/third_party/WebKit/Source/platform/graphics/SurfaceLayerBridge.h
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/ui/android/delegated_frame_host_android.h
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/ui/compositor/compositor.cc
[modify] https://crrev.com/5b7fb8ef24900542c041a91b728b43fad98ae122/ui/compositor/compositor.h

Project Member

Comment 92 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/019cfe64ac683141d50b1970a739e8bbdbf2a8c9

commit 019cfe64ac683141d50b1970a739e8bbdbf2a8c9
Author: Saman Sami <samans@chromium.org>
Date: Tue Aug 08 17:08:46 2017

(Reland) viz: Move CompositorFrame's mojom from cc to services/viz

Reland 601190, but also fix cc/ipc/cc_serialization_perftest.cc

TBR=sky@chromium.org,rjkroege@chromium.org,tsepez@chromium.org
Bug=722935

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id17e8ae7d01dd316673ef43bcc7ef85570172a97
Reviewed-on: https://chromium-review.googlesource.com/606087
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492671}
[modify] https://crrev.com/019cfe64ac683141d50b1970a739e8bbdbf2a8c9/cc/BUILD.gn
[modify] https://crrev.com/019cfe64ac683141d50b1970a739e8bbdbf2a8c9/cc/ipc/BUILD.gn
[modify] https://crrev.com/019cfe64ac683141d50b1970a739e8bbdbf2a8c9/cc/ipc/DEPS
[modify] https://crrev.com/019cfe64ac683141d50b1970a739e8bbdbf2a8c9/cc/ipc/cc_serialization_perftest.cc
[delete] https://crrev.com/02b397ffdd9c50ea8ea8f975ddeffef09355af3d/cc/ipc/compositor_frame.typemap
[delete] https://crrev.com/02b397ffdd9c50ea8ea8f975ddeffef09355af3d/cc/ipc/compositor_frame_struct_traits.h
[modify] https://crrev.com/019cfe64ac683141d50b1970a739e8bbdbf2a8c9/cc/ipc/struct_traits_unittest.cc
[modify] https://crrev.com/019cfe64ac683141d50b1970a739e8bbdbf2a8c9/cc/ipc/traits_test_service.mojom
[modify] https://crrev.com/019cfe64ac683141d50b1970a739e8bbdbf2a8c9/cc/ipc/typemaps.gni
[modify] https://crrev.com/019cfe64ac683141d50b1970a739e8bbdbf2a8c9/services/ui/ws/server_window_compositor_frame_sink_manager.h
[modify] https://crrev.com/019cfe64ac683141d50b1970a739e8bbdbf2a8c9/services/viz/public/cpp/compositing/BUILD.gn
[modify] https://crrev.com/019cfe64ac683141d50b1970a739e8bbdbf2a8c9/services/viz/public/cpp/compositing/DEPS
[add] https://crrev.com/019cfe64ac683141d50b1970a739e8bbdbf2a8c9/services/viz/public/cpp/compositing/compositor_frame.typemap
[rename] https://crrev.com/019cfe64ac683141d50b1970a739e8bbdbf2a8c9/services/viz/public/cpp/compositing/compositor_frame_for_blink.typemap
[rename] https://crrev.com/019cfe64ac683141d50b1970a739e8bbdbf2a8c9/services/viz/public/cpp/compositing/compositor_frame_struct_traits.cc
[add] https://crrev.com/019cfe64ac683141d50b1970a739e8bbdbf2a8c9/services/viz/public/cpp/compositing/compositor_frame_struct_traits.h
[modify] https://crrev.com/019cfe64ac683141d50b1970a739e8bbdbf2a8c9/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/019cfe64ac683141d50b1970a739e8bbdbf2a8c9/services/viz/public/cpp/compositing/typemaps.gni
[modify] https://crrev.com/019cfe64ac683141d50b1970a739e8bbdbf2a8c9/services/viz/public/interfaces/compositing/BUILD.gn
[rename] https://crrev.com/019cfe64ac683141d50b1970a739e8bbdbf2a8c9/services/viz/public/interfaces/compositing/compositor_frame.mojom
[modify] https://crrev.com/019cfe64ac683141d50b1970a739e8bbdbf2a8c9/services/viz/public/interfaces/compositing/compositor_frame_sink.mojom
[modify] https://crrev.com/019cfe64ac683141d50b1970a739e8bbdbf2a8c9/third_party/WebKit/public/blink_typemaps.gni

Project Member

Comment 93 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c3f18c5fd02ce7bd3011d861e4414444ce65387

commit 7c3f18c5fd02ce7bd3011d861e4414444ce65387
Author: Gary Klassen <gklassen@chromium.org>
Date: Wed Aug 09 07:27:38 2017

viz: Move ReturnedResource mojom from cc to viz

Move ReturnedResource mojom and associated files from cc to viz as part
of viz restructuring.

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id7e02cdf2efdcec08a81c98dd4ad4d2b7b1ddb65
Reviewed-on: https://chromium-review.googlesource.com/602529
Commit-Queue: Gary Klassen <gklassen@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492886}
[modify] https://crrev.com/7c3f18c5fd02ce7bd3011d861e4414444ce65387/cc/ipc/BUILD.gn
[delete] https://crrev.com/713790eb388de8c037351467a691ee4494f98f5e/cc/ipc/returned_resource.typemap
[modify] https://crrev.com/7c3f18c5fd02ce7bd3011d861e4414444ce65387/cc/ipc/struct_traits_unittest.cc
[modify] https://crrev.com/7c3f18c5fd02ce7bd3011d861e4414444ce65387/cc/ipc/traits_test_service.mojom
[modify] https://crrev.com/7c3f18c5fd02ce7bd3011d861e4414444ce65387/cc/ipc/typemaps.gni
[modify] https://crrev.com/7c3f18c5fd02ce7bd3011d861e4414444ce65387/services/viz/public/cpp/compositing/DEPS
[add] https://crrev.com/7c3f18c5fd02ce7bd3011d861e4414444ce65387/services/viz/public/cpp/compositing/returned_resource.typemap
[rename] https://crrev.com/7c3f18c5fd02ce7bd3011d861e4414444ce65387/services/viz/public/cpp/compositing/returned_resource_struct_traits.h
[modify] https://crrev.com/7c3f18c5fd02ce7bd3011d861e4414444ce65387/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/7c3f18c5fd02ce7bd3011d861e4414444ce65387/services/viz/public/cpp/compositing/typemaps.gni
[modify] https://crrev.com/7c3f18c5fd02ce7bd3011d861e4414444ce65387/services/viz/public/interfaces/compositing/BUILD.gn
[modify] https://crrev.com/7c3f18c5fd02ce7bd3011d861e4414444ce65387/services/viz/public/interfaces/compositing/compositor_frame_sink.mojom
[rename] https://crrev.com/7c3f18c5fd02ce7bd3011d861e4414444ce65387/services/viz/public/interfaces/compositing/returned_resource.mojom
[modify] https://crrev.com/7c3f18c5fd02ce7bd3011d861e4414444ce65387/third_party/WebKit/public/blink_typemaps.gni

Project Member

Comment 94 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3

commit e32a2ca3819f1167a0c37d64bfab2ede2452a8f3
Author: Alex Zhang <staraz@chromium.org>
Date: Wed Aug 09 14:50:30 2017

Move ui/compositor/compositor_util* to components/viz/host

Move ui/compositor/compositor_util* to components/viz/host and rename them to
renderer_settings_creation*. The move allows services/ui to call
CreateRendererSettings before passing the settings to viz.

The rest of the CL moves switches used by the creation to
ui/base/ui_base_switches* so that no dependency rules are violated.

TBR: alokp@chromium.org
Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I69dac8d11d80d30847fabb68c8fb666bf8f3a463
Reviewed-on: https://chromium-review.googlesource.com/594665
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Xingyu Zhang <staraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492977}
[modify] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/cc/base/switches.cc
[modify] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/cc/base/switches.h
[modify] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/chrome/browser/about_flags.cc
[modify] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/components/viz/DEPS
[modify] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/components/viz/host/BUILD.gn
[rename] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/components/viz/host/renderer_settings_creation.cc
[add] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/components/viz/host/renderer_settings_creation.h
[modify] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/components/viz/service/display_embedder/gpu_display_provider.cc
[modify] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/services/ui/ws/server_window_compositor_frame_sink_manager.cc
[modify] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/ui/aura/mus/mus_context_factory.cc
[modify] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/ui/base/ui_base_switches.cc
[modify] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/ui/base/ui_base_switches.h
[modify] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/ui/compositor/BUILD.gn
[modify] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/ui/compositor/compositor.cc
[modify] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/ui/compositor/compositor_switches.cc
[modify] https://crrev.com/e32a2ca3819f1167a0c37d64bfab2ede2452a8f3/ui/compositor/compositor_switches.h
[delete] https://crrev.com/1471bcd67cd24cee282f0b25550820ac732545f9/ui/compositor/compositor_util.h

Project Member

Comment 95 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee64ca81ff93d141a8501ff3e997e222d8c036db

commit ee64ca81ff93d141a8501ff3e997e222d8c036db
Author: Fady Samuel <fsamuel@chromium.org>
Date: Wed Aug 09 14:55:46 2017

viz: Gpu(Root)CompositorFrameSink => (Root)CompositorFrameSinkImpl

This CL renames Gpu(Root)CompositorFrameSink => (Root)CompositorFrameSinkImpl
to match the naming scheme discussd in components/viz/README.md.

Bug: 722935
Change-Id: I22bfad8b0ba2351731aba24e488c50002d7e86b9
Reviewed-on: https://chromium-review.googlesource.com/607589
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492979}
[modify] https://crrev.com/ee64ca81ff93d141a8501ff3e997e222d8c036db/components/viz/service/BUILD.gn
[add] https://crrev.com/ee64ca81ff93d141a8501ff3e997e222d8c036db/components/viz/service/frame_sinks/compositor_frame_sink_impl.cc
[rename] https://crrev.com/ee64ca81ff93d141a8501ff3e997e222d8c036db/components/viz/service/frame_sinks/compositor_frame_sink_impl.h
[modify] https://crrev.com/ee64ca81ff93d141a8501ff3e997e222d8c036db/components/viz/service/frame_sinks/frame_sink_manager_impl.cc
[delete] https://crrev.com/0221b06a2f3e9715551a9d20514d923209aa2347/components/viz/service/frame_sinks/gpu_compositor_frame_sink.cc
[rename] https://crrev.com/ee64ca81ff93d141a8501ff3e997e222d8c036db/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.cc
[rename] https://crrev.com/ee64ca81ff93d141a8501ff3e997e222d8c036db/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.h

Blockedon: 732826
Project Member

Comment 97 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc8167217109c5ec4d0c4a86de90a2e1a36970ab

commit dc8167217109c5ec4d0c4a86de90a2e1a36970ab
Author: Fady Samuel <fsamuel@chromium.org>
Date: Wed Aug 09 16:44:35 2017

viz: Introduce SurfaceObserver::OnSurfaceActivated

HitTestAggregator will need to track CompositorFrame activation in order
to determine when it's possible to clear out old hit test data. This
CL introduces SurfaceObserver::OnSurfaceActivated for this purpose.

This CL also moves the call to SurfaceModified out of CompositorFrameSinkSupport
and into SurfaceManager::SurfaceActivated addressing a TODO. The TODO was to
address the case where the FrameSink goes away but the surface is kept alive
by an embedder. If the surface has a CompositorFrame that activates then it
would not immediately generate a display frame. With this change, a display
frame would be generated. A unit test has been updated to verify this.

Bug: 722935
Change-Id: Ifab3b630419155035caff066a308d5d0af64c1ab
Reviewed-on: https://chromium-review.googlesource.com/607191
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493022}
[modify] https://crrev.com/dc8167217109c5ec4d0c4a86de90a2e1a36970ab/components/viz/service/display/display_scheduler.cc
[modify] https://crrev.com/dc8167217109c5ec4d0c4a86de90a2e1a36970ab/components/viz/service/display/display_scheduler.h
[modify] https://crrev.com/dc8167217109c5ec4d0c4a86de90a2e1a36970ab/components/viz/service/frame_sinks/compositor_frame_sink_support.cc
[modify] https://crrev.com/dc8167217109c5ec4d0c4a86de90a2e1a36970ab/components/viz/service/frame_sinks/frame_sink_manager_impl.cc
[modify] https://crrev.com/dc8167217109c5ec4d0c4a86de90a2e1a36970ab/components/viz/service/frame_sinks/frame_sink_manager_impl.h
[modify] https://crrev.com/dc8167217109c5ec4d0c4a86de90a2e1a36970ab/components/viz/service/frame_sinks/surface_synchronization_unittest.cc
[modify] https://crrev.com/dc8167217109c5ec4d0c4a86de90a2e1a36970ab/components/viz/service/hit_test/hit_test_aggregator.h
[modify] https://crrev.com/dc8167217109c5ec4d0c4a86de90a2e1a36970ab/components/viz/service/surfaces/surface.cc
[modify] https://crrev.com/dc8167217109c5ec4d0c4a86de90a2e1a36970ab/components/viz/service/surfaces/surface_manager.cc
[modify] https://crrev.com/dc8167217109c5ec4d0c4a86de90a2e1a36970ab/components/viz/service/surfaces/surface_observer.h
[modify] https://crrev.com/dc8167217109c5ec4d0c4a86de90a2e1a36970ab/components/viz/test/fake_surface_observer.cc
[modify] https://crrev.com/dc8167217109c5ec4d0c4a86de90a2e1a36970ab/components/viz/test/fake_surface_observer.h

Project Member

Comment 98 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1035e6bde3a7ca9aba2f380717976bb9b378c331

commit 1035e6bde3a7ca9aba2f380717976bb9b378c331
Author: Saman Sami <samans@chromium.org>
Date: Wed Aug 09 17:19:43 2017

viz: Move SurfaceInfo's mojom from cc/ipc to services/viz

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Icbcfda264a4272048877a5e9dfb25c0ea5e5b16a
Reviewed-on: https://chromium-review.googlesource.com/602473
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Alexandre Elias <aelias@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493035}
[modify] https://crrev.com/1035e6bde3a7ca9aba2f380717976bb9b378c331/cc/ipc/BUILD.gn
[delete] https://crrev.com/0a29c3285746c1a80ca039e7887180fc3f3e159c/cc/ipc/surface_info.typemap
[modify] https://crrev.com/1035e6bde3a7ca9aba2f380717976bb9b378c331/cc/ipc/typemaps.gni
[modify] https://crrev.com/1035e6bde3a7ca9aba2f380717976bb9b378c331/components/viz/common/surfaces/surface_info.h
[modify] https://crrev.com/1035e6bde3a7ca9aba2f380717976bb9b378c331/services/ui/public/interfaces/window_tree.mojom
[modify] https://crrev.com/1035e6bde3a7ca9aba2f380717976bb9b378c331/services/viz/compositing/privileged/interfaces/frame_sink_manager.mojom
[modify] https://crrev.com/1035e6bde3a7ca9aba2f380717976bb9b378c331/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[add] https://crrev.com/1035e6bde3a7ca9aba2f380717976bb9b378c331/services/viz/public/cpp/compositing/surface_info.typemap
[rename] https://crrev.com/1035e6bde3a7ca9aba2f380717976bb9b378c331/services/viz/public/cpp/compositing/surface_info_struct_traits.h
[modify] https://crrev.com/1035e6bde3a7ca9aba2f380717976bb9b378c331/services/viz/public/cpp/compositing/typemaps.gni
[modify] https://crrev.com/1035e6bde3a7ca9aba2f380717976bb9b378c331/services/viz/public/interfaces/compositing/BUILD.gn
[rename] https://crrev.com/1035e6bde3a7ca9aba2f380717976bb9b378c331/services/viz/public/interfaces/compositing/surface_info.mojom
[modify] https://crrev.com/1035e6bde3a7ca9aba2f380717976bb9b378c331/third_party/WebKit/public/blink_typemaps.gni
[modify] https://crrev.com/1035e6bde3a7ca9aba2f380717976bb9b378c331/third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom

Project Member

Comment 99 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73fa53c6fb68028b52ab7c6211f94621f032e674

commit 73fa53c6fb68028b52ab7c6211f94621f032e674
Author: Alex Zhang <staraz@chromium.org>
Date: Wed Aug 09 23:00:48 2017

Remove Unnecessary Includes From cc/quad

DrawQuad doesn't need to include its subclasses. Removing these 
includes makes moving cc to viz easier.

DrawPolygon doesn't need BspCompareResult.

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iaf28943c65465b49c3dea8ad844f1b65088c0c2c
Reviewed-on: https://chromium-review.googlesource.com/608865
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Xingyu Zhang <staraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493170}
[modify] https://crrev.com/73fa53c6fb68028b52ab7c6211f94621f032e674/cc/quads/draw_polygon.cc
[modify] https://crrev.com/73fa53c6fb68028b52ab7c6211f94621f032e674/cc/quads/draw_polygon.h
[modify] https://crrev.com/73fa53c6fb68028b52ab7c6211f94621f032e674/cc/quads/draw_quad.cc

Project Member

Comment 100 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95955cbc765c0eadc75d3e74c38ee4e4b034462a

commit 95955cbc765c0eadc75d3e74c38ee4e4b034462a
Author: Saman Sami <samans@chromium.org>
Date: Thu Aug 10 00:05:47 2017

viz: Move SurfaceSequence's mojom from cc/ipc to services/viz

TBR=aelias@chromium.org

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ibaff586055b80c63b6666efe010b3f8a5dfae4a5
Reviewed-on: https://chromium-review.googlesource.com/602485
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493184}
[modify] https://crrev.com/95955cbc765c0eadc75d3e74c38ee4e4b034462a/cc/ipc/BUILD.gn
[modify] https://crrev.com/95955cbc765c0eadc75d3e74c38ee4e4b034462a/cc/ipc/struct_traits_unittest.cc
[delete] https://crrev.com/4033e51d00c3a24e27ad7f109ee74ea89263848f/cc/ipc/surface_sequence.typemap
[modify] https://crrev.com/95955cbc765c0eadc75d3e74c38ee4e4b034462a/cc/ipc/traits_test_service.mojom
[modify] https://crrev.com/95955cbc765c0eadc75d3e74c38ee4e4b034462a/cc/ipc/typemaps.gni
[modify] https://crrev.com/95955cbc765c0eadc75d3e74c38ee4e4b034462a/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[add] https://crrev.com/95955cbc765c0eadc75d3e74c38ee4e4b034462a/services/viz/public/cpp/compositing/surface_sequence.typemap
[rename] https://crrev.com/95955cbc765c0eadc75d3e74c38ee4e4b034462a/services/viz/public/cpp/compositing/surface_sequence_struct_traits.h
[modify] https://crrev.com/95955cbc765c0eadc75d3e74c38ee4e4b034462a/services/viz/public/cpp/compositing/typemaps.gni
[modify] https://crrev.com/95955cbc765c0eadc75d3e74c38ee4e4b034462a/services/viz/public/interfaces/compositing/BUILD.gn
[modify] https://crrev.com/95955cbc765c0eadc75d3e74c38ee4e4b034462a/services/viz/public/interfaces/compositing/compositor_frame_sink.mojom
[rename] https://crrev.com/95955cbc765c0eadc75d3e74c38ee4e4b034462a/services/viz/public/interfaces/compositing/surface_sequence.mojom
[modify] https://crrev.com/95955cbc765c0eadc75d3e74c38ee4e4b034462a/third_party/WebKit/public/blink_typemaps.gni
[modify] https://crrev.com/95955cbc765c0eadc75d3e74c38ee4e4b034462a/third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom

Project Member

Comment 101 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b362bd6056e7f3f21bb60b155311ef863238d2f8

commit b362bd6056e7f3f21bb60b155311ef863238d2f8
Author: Saman Sami <samans@chromium.org>
Date: Thu Aug 10 05:15:26 2017

viz: Move CompositorFrameMetadata's mojom from cc/ipc to services/viz

TBR=tsepez@chromium.org,weiliangc@chromium.org

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I68a3f6da8d69c4d1490ffdd596b79c2211bccba6
Reviewed-on: https://chromium-review.googlesource.com/609029
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493250}
[modify] https://crrev.com/b362bd6056e7f3f21bb60b155311ef863238d2f8/cc/ipc/BUILD.gn
[modify] https://crrev.com/b362bd6056e7f3f21bb60b155311ef863238d2f8/cc/ipc/cc_serialization_perftest.cc
[delete] https://crrev.com/0166bdbcc37c4fc1c6780c3fb5d5ee974b2a2870/cc/ipc/compositor_frame_metadata.typemap
[modify] https://crrev.com/b362bd6056e7f3f21bb60b155311ef863238d2f8/cc/ipc/selection_struct_traits.h
[modify] https://crrev.com/b362bd6056e7f3f21bb60b155311ef863238d2f8/cc/ipc/struct_traits_unittest.cc
[modify] https://crrev.com/b362bd6056e7f3f21bb60b155311ef863238d2f8/cc/ipc/traits_test_service.mojom
[modify] https://crrev.com/b362bd6056e7f3f21bb60b155311ef863238d2f8/cc/ipc/typemaps.gni
[modify] https://crrev.com/b362bd6056e7f3f21bb60b155311ef863238d2f8/services/viz/public/cpp/compositing/compositor_frame_for_blink.typemap
[add] https://crrev.com/b362bd6056e7f3f21bb60b155311ef863238d2f8/services/viz/public/cpp/compositing/compositor_frame_metadata.typemap
[rename] https://crrev.com/b362bd6056e7f3f21bb60b155311ef863238d2f8/services/viz/public/cpp/compositing/compositor_frame_metadata_struct_traits.cc
[rename] https://crrev.com/b362bd6056e7f3f21bb60b155311ef863238d2f8/services/viz/public/cpp/compositing/compositor_frame_metadata_struct_traits.h
[modify] https://crrev.com/b362bd6056e7f3f21bb60b155311ef863238d2f8/services/viz/public/cpp/compositing/compositor_frame_struct_traits.cc
[modify] https://crrev.com/b362bd6056e7f3f21bb60b155311ef863238d2f8/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/b362bd6056e7f3f21bb60b155311ef863238d2f8/services/viz/public/cpp/compositing/typemaps.gni
[modify] https://crrev.com/b362bd6056e7f3f21bb60b155311ef863238d2f8/services/viz/public/interfaces/compositing/BUILD.gn
[modify] https://crrev.com/b362bd6056e7f3f21bb60b155311ef863238d2f8/services/viz/public/interfaces/compositing/compositor_frame.mojom
[rename] https://crrev.com/b362bd6056e7f3f21bb60b155311ef863238d2f8/services/viz/public/interfaces/compositing/compositor_frame_metadata.mojom

Project Member

Comment 102 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/589cc956539eab48fa9784d76a69ffada83c8a52

commit 589cc956539eab48fa9784d76a69ffada83c8a52
Author: Saman Sami <samans@chromium.org>
Date: Fri Aug 11 03:40:06 2017

viz: Move RenderPass's mojom from cc/ipc to services/viz

TBR=tsepez@chromium.org

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I851700cf9fe8af40c045151615c263afed6234f3
Reviewed-on: https://chromium-review.googlesource.com/610838
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493658}
[modify] https://crrev.com/589cc956539eab48fa9784d76a69ffada83c8a52/cc/ipc/BUILD.gn
[modify] https://crrev.com/589cc956539eab48fa9784d76a69ffada83c8a52/cc/ipc/cc_serialization_perftest.cc
[delete] https://crrev.com/1bfabcd3f69e896bb10a7803222fbf3bf75aff19/cc/ipc/render_pass.typemap
[modify] https://crrev.com/589cc956539eab48fa9784d76a69ffada83c8a52/cc/ipc/struct_traits_unittest.cc
[modify] https://crrev.com/589cc956539eab48fa9784d76a69ffada83c8a52/cc/ipc/traits_test_service.mojom
[modify] https://crrev.com/589cc956539eab48fa9784d76a69ffada83c8a52/cc/ipc/typemaps.gni
[modify] https://crrev.com/589cc956539eab48fa9784d76a69ffada83c8a52/services/viz/public/cpp/compositing/compositor_frame_for_blink.typemap
[modify] https://crrev.com/589cc956539eab48fa9784d76a69ffada83c8a52/services/viz/public/cpp/compositing/compositor_frame_struct_traits.cc
[add] https://crrev.com/589cc956539eab48fa9784d76a69ffada83c8a52/services/viz/public/cpp/compositing/render_pass.typemap
[rename] https://crrev.com/589cc956539eab48fa9784d76a69ffada83c8a52/services/viz/public/cpp/compositing/render_pass_struct_traits.cc
[rename] https://crrev.com/589cc956539eab48fa9784d76a69ffada83c8a52/services/viz/public/cpp/compositing/render_pass_struct_traits.h
[modify] https://crrev.com/589cc956539eab48fa9784d76a69ffada83c8a52/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/589cc956539eab48fa9784d76a69ffada83c8a52/services/viz/public/cpp/compositing/typemaps.gni
[modify] https://crrev.com/589cc956539eab48fa9784d76a69ffada83c8a52/services/viz/public/interfaces/compositing/BUILD.gn
[modify] https://crrev.com/589cc956539eab48fa9784d76a69ffada83c8a52/services/viz/public/interfaces/compositing/compositor_frame.mojom
[rename] https://crrev.com/589cc956539eab48fa9784d76a69ffada83c8a52/services/viz/public/interfaces/compositing/render_pass.mojom

Project Member

Comment 103 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b786862777e620a03c795144b9e941ec0f864aef

commit b786862777e620a03c795144b9e941ec0f864aef
Author: Gary Klassen <gklassen@chromium.org>
Date: Fri Aug 11 22:38:13 2017

viz: Move SharedBitmapAllocationNotifier mojom from cc to viz

Part of viz restructuring.

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I881bc119c4f2884a118a36fc65dd83be83194db3
Reviewed-on: https://chromium-review.googlesource.com/608309
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493872}
[modify] https://crrev.com/b786862777e620a03c795144b9e941ec0f864aef/cc/ipc/BUILD.gn
[modify] https://crrev.com/b786862777e620a03c795144b9e941ec0f864aef/components/viz/client/client_shared_bitmap_manager.cc
[modify] https://crrev.com/b786862777e620a03c795144b9e941ec0f864aef/components/viz/client/client_shared_bitmap_manager.h
[modify] https://crrev.com/b786862777e620a03c795144b9e941ec0f864aef/components/viz/service/DEPS
[modify] https://crrev.com/b786862777e620a03c795144b9e941ec0f864aef/components/viz/service/display_embedder/shared_bitmap_allocation_notifier_impl.cc
[modify] https://crrev.com/b786862777e620a03c795144b9e941ec0f864aef/components/viz/service/display_embedder/shared_bitmap_allocation_notifier_impl.h
[modify] https://crrev.com/b786862777e620a03c795144b9e941ec0f864aef/components/viz/service/frame_sinks/DEPS
[modify] https://crrev.com/b786862777e620a03c795144b9e941ec0f864aef/components/viz/service/hit_test/DEPS
[modify] https://crrev.com/b786862777e620a03c795144b9e941ec0f864aef/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/b786862777e620a03c795144b9e941ec0f864aef/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/b786862777e620a03c795144b9e941ec0f864aef/content/common/render_message_filter.mojom
[modify] https://crrev.com/b786862777e620a03c795144b9e941ec0f864aef/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/b786862777e620a03c795144b9e941ec0f864aef/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/b786862777e620a03c795144b9e941ec0f864aef/services/viz/public/interfaces/compositing/BUILD.gn
[rename] https://crrev.com/b786862777e620a03c795144b9e941ec0f864aef/services/viz/public/interfaces/compositing/shared_bitmap_allocation_notifier.mojom

Project Member

Comment 104 by bugdroid1@chromium.org, Aug 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9acdd948ea90e8e97620120300d2a6c08ef79a44

commit 9acdd948ea90e8e97620120300d2a6c08ef79a44
Author: kylechar <kylechar@chromium.org>
Date: Sat Aug 12 04:18:05 2017

Delete components/viz/host/hit_test/BUILD.gn.

The pattern used in components/viz/ is to have the toplevel directory,
eg. components/viz/host/ have the BUILD.gn file. Merge the deleted file
into components/viz/host/BUILD.gn.

Bug: 722935
Change-Id: I2685fc3981969edbbf7625a91d39fc838e69c208
Reviewed-on: https://chromium-review.googlesource.com/612146
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493955}
[modify] https://crrev.com/9acdd948ea90e8e97620120300d2a6c08ef79a44/components/viz/host/BUILD.gn
[delete] https://crrev.com/740b036f23130714493229cb7aa1f0e2b835e345/components/viz/host/hit_test/BUILD.gn
[modify] https://crrev.com/9acdd948ea90e8e97620120300d2a6c08ef79a44/components/viz/host/hit_test/hit_test_query.h
[modify] https://crrev.com/9acdd948ea90e8e97620120300d2a6c08ef79a44/services/ui/ws/BUILD.gn

Project Member

Comment 105 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd188a129c45baa117b4a49269d82af678b64c9e

commit dd188a129c45baa117b4a49269d82af678b64c9e
Author: Alex Zhang <staraz@chromium.org>
Date: Mon Aug 14 18:48:44 2017

Move cc::TracedValue to viz/common

Moving TracedValue to viz enables us to move other cc classes to viz (e.g.
SharedQuadState). The move doesn't not affect other dependencies as cc already
depends on components/viz/common.

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Icc9f6c9862987a57770c16128d1568df023748f9
Reviewed-on: https://chromium-review.googlesource.com/610124
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Xingyu Zhang <staraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494113}
[modify] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/cc/debug/BUILD.gn
[modify] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/cc/debug/rendering_stats.h
[modify] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/cc/layers/layer_impl.cc
[modify] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/cc/layers/picture_layer_impl.cc
[modify] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/cc/quads/draw_quad.cc
[modify] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/cc/quads/nine_patch_generator.cc
[modify] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/cc/quads/render_pass.cc
[modify] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/cc/quads/render_pass_draw_quad.cc
[modify] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/cc/quads/shared_quad_state.cc
[modify] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/cc/raster/bitmap_raster_buffer_provider.cc
[modify] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/cc/raster/raster_source.cc
[modify] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/cc/raster/staging_buffer_pool.cc
[modify] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/cc/raster/zero_copy_raster_buffer_provider.cc
[modify] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/cc/scheduler/scheduler.cc
[modify] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/cc/tiles/frame_viewer_instrumentation.cc
[modify] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/cc/tiles/prioritized_tile.cc
[modify] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/cc/tiles/tile.cc
[modify] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/cc/tiles/tile_manager.cc
[modify] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/components/viz/common/BUILD.gn
[rename] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/components/viz/common/traced_value.cc
[rename] https://crrev.com/dd188a129c45baa117b4a49269d82af678b64c9e/components/viz/common/traced_value.h

Blockedon: 755319
Project Member

Comment 107 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/417352ecbdc0ab9261c82f3b3d5c558e7b73ac1b

commit 417352ecbdc0ab9261c82f3b3d5c558e7b73ac1b
Author: yiyix <yiyix@chromium.org>
Date: Mon Aug 14 22:08:47 2017

viz: Move Selection's mojom from cc/ipc to services/viz

For more details: 
https://docs.google.com/spreadsheets/d/1gHvkSVehWvWvCyCa-V0tZezULNTpiW0T8tLE3DjVgkg

TBR=thakis@chromium.org

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8cf8fe75ff8ef304f1f363df03e3e42c5afa32aa
Reviewed-on: https://chromium-review.googlesource.com/612849
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494199}
[modify] https://crrev.com/417352ecbdc0ab9261c82f3b3d5c558e7b73ac1b/cc/ipc/BUILD.gn
[modify] https://crrev.com/417352ecbdc0ab9261c82f3b3d5c558e7b73ac1b/cc/ipc/cc_serialization_perftest.cc
[delete] https://crrev.com/0155df932113b5d8d9ff25cc2b1b641e5ade7207/cc/ipc/selection.typemap
[delete] https://crrev.com/0155df932113b5d8d9ff25cc2b1b641e5ade7207/cc/ipc/selection_struct_traits.h
[modify] https://crrev.com/417352ecbdc0ab9261c82f3b3d5c558e7b73ac1b/cc/ipc/struct_traits_unittest.cc
[modify] https://crrev.com/417352ecbdc0ab9261c82f3b3d5c558e7b73ac1b/cc/ipc/traits_test_service.mojom
[modify] https://crrev.com/417352ecbdc0ab9261c82f3b3d5c558e7b73ac1b/cc/ipc/typemaps.gni
[modify] https://crrev.com/417352ecbdc0ab9261c82f3b3d5c558e7b73ac1b/services/viz/public/cpp/compositing/DEPS
[modify] https://crrev.com/417352ecbdc0ab9261c82f3b3d5c558e7b73ac1b/services/viz/public/cpp/compositing/compositor_frame_for_blink.typemap
[modify] https://crrev.com/417352ecbdc0ab9261c82f3b3d5c558e7b73ac1b/services/viz/public/cpp/compositing/compositor_frame_metadata_struct_traits.cc
[add] https://crrev.com/417352ecbdc0ab9261c82f3b3d5c558e7b73ac1b/services/viz/public/cpp/compositing/selection.typemap
[add] https://crrev.com/417352ecbdc0ab9261c82f3b3d5c558e7b73ac1b/services/viz/public/cpp/compositing/selection_struct_traits.h
[modify] https://crrev.com/417352ecbdc0ab9261c82f3b3d5c558e7b73ac1b/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/417352ecbdc0ab9261c82f3b3d5c558e7b73ac1b/services/viz/public/cpp/compositing/typemaps.gni
[modify] https://crrev.com/417352ecbdc0ab9261c82f3b3d5c558e7b73ac1b/services/viz/public/interfaces/compositing/BUILD.gn
[modify] https://crrev.com/417352ecbdc0ab9261c82f3b3d5c558e7b73ac1b/services/viz/public/interfaces/compositing/compositor_frame_metadata.mojom
[rename] https://crrev.com/417352ecbdc0ab9261c82f3b3d5c558e7b73ac1b/services/viz/public/interfaces/compositing/selection.mojom
[modify] https://crrev.com/417352ecbdc0ab9261c82f3b3d5c558e7b73ac1b/third_party/WebKit/public/blink_typemaps.gni

Project Member

Comment 108 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d3dbac6fa667f5139f1396a780d71d2c309a166

commit 6d3dbac6fa667f5139f1396a780d71d2c309a166
Author: Saman Sami <samans@chromium.org>
Date: Tue Aug 15 00:11:08 2017

viz: Move quads.mojom from cc to viz

TBR=sadrul@chromium.org

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ief84c1380285d43e2a71556612ae1b746c0b38aa
Reviewed-on: https://chromium-review.googlesource.com/614080
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494257}
[modify] https://crrev.com/6d3dbac6fa667f5139f1396a780d71d2c309a166/cc/ipc/BUILD.gn
[modify] https://crrev.com/6d3dbac6fa667f5139f1396a780d71d2c309a166/cc/ipc/traits_test_service.mojom
[modify] https://crrev.com/6d3dbac6fa667f5139f1396a780d71d2c309a166/services/viz/public/cpp/compositing/compositor_frame_for_blink.typemap
[rename] https://crrev.com/6d3dbac6fa667f5139f1396a780d71d2c309a166/services/viz/public/cpp/compositing/quads_struct_traits.cc
[rename] https://crrev.com/6d3dbac6fa667f5139f1396a780d71d2c309a166/services/viz/public/cpp/compositing/quads_struct_traits.h
[modify] https://crrev.com/6d3dbac6fa667f5139f1396a780d71d2c309a166/services/viz/public/cpp/compositing/render_pass.typemap
[modify] https://crrev.com/6d3dbac6fa667f5139f1396a780d71d2c309a166/services/viz/public/cpp/compositing/render_pass_struct_traits.cc
[modify] https://crrev.com/6d3dbac6fa667f5139f1396a780d71d2c309a166/services/viz/public/cpp/compositing/render_pass_struct_traits.h
[modify] https://crrev.com/6d3dbac6fa667f5139f1396a780d71d2c309a166/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/6d3dbac6fa667f5139f1396a780d71d2c309a166/services/viz/public/interfaces/compositing/BUILD.gn
[rename] https://crrev.com/6d3dbac6fa667f5139f1396a780d71d2c309a166/services/viz/public/interfaces/compositing/quads.mojom
[modify] https://crrev.com/6d3dbac6fa667f5139f1396a780d71d2c309a166/services/viz/public/interfaces/compositing/render_pass.mojom

Project Member

Comment 109 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56ab18c0d0a3e5b380fec5b02720ed293b5af69c

commit 56ab18c0d0a3e5b380fec5b02720ed293b5af69c
Author: Gary Klassen <gklassen@chromium.org>
Date: Tue Aug 15 15:57:26 2017

viz:: Move TransferableResource mojom from cc to viz

Part of viz restructuring.

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I31cafb3edb31937024d713cb3a7add6c8726d0a1
Reviewed-on: https://chromium-review.googlesource.com/613861
Commit-Queue: Gary Klassen <gklassen@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494392}
[modify] https://crrev.com/56ab18c0d0a3e5b380fec5b02720ed293b5af69c/cc/ipc/BUILD.gn
[modify] https://crrev.com/56ab18c0d0a3e5b380fec5b02720ed293b5af69c/cc/ipc/cc_serialization_perftest.cc
[modify] https://crrev.com/56ab18c0d0a3e5b380fec5b02720ed293b5af69c/cc/ipc/struct_traits_unittest.cc
[modify] https://crrev.com/56ab18c0d0a3e5b380fec5b02720ed293b5af69c/cc/ipc/traits_test_service.mojom
[delete] https://crrev.com/ebb64f8e585ffb3923eee174c080f5ead800e6fb/cc/ipc/transferable_resource.typemap
[modify] https://crrev.com/56ab18c0d0a3e5b380fec5b02720ed293b5af69c/cc/ipc/typemaps.gni
[modify] https://crrev.com/56ab18c0d0a3e5b380fec5b02720ed293b5af69c/services/viz/public/cpp/compositing/compositor_frame_for_blink.typemap
[modify] https://crrev.com/56ab18c0d0a3e5b380fec5b02720ed293b5af69c/services/viz/public/cpp/compositing/compositor_frame_struct_traits.cc
[modify] https://crrev.com/56ab18c0d0a3e5b380fec5b02720ed293b5af69c/services/viz/public/cpp/compositing/compositor_frame_struct_traits.h
[modify] https://crrev.com/56ab18c0d0a3e5b380fec5b02720ed293b5af69c/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[add] https://crrev.com/56ab18c0d0a3e5b380fec5b02720ed293b5af69c/services/viz/public/cpp/compositing/transferable_resource.typemap
[rename] https://crrev.com/56ab18c0d0a3e5b380fec5b02720ed293b5af69c/services/viz/public/cpp/compositing/transferable_resource_struct_traits.cc
[rename] https://crrev.com/56ab18c0d0a3e5b380fec5b02720ed293b5af69c/services/viz/public/cpp/compositing/transferable_resource_struct_traits.h
[modify] https://crrev.com/56ab18c0d0a3e5b380fec5b02720ed293b5af69c/services/viz/public/cpp/compositing/typemaps.gni
[modify] https://crrev.com/56ab18c0d0a3e5b380fec5b02720ed293b5af69c/services/viz/public/interfaces/compositing/BUILD.gn
[modify] https://crrev.com/56ab18c0d0a3e5b380fec5b02720ed293b5af69c/services/viz/public/interfaces/compositing/compositor_frame.mojom
[rename] https://crrev.com/56ab18c0d0a3e5b380fec5b02720ed293b5af69c/services/viz/public/interfaces/compositing/transferable_resource.mojom

Project Member

Comment 110 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3677eaee61daa80777be59e388a4620e6c38130

commit f3677eaee61daa80777be59e388a4620e6c38130
Author: Gary Klassen <gklassen@chromium.org>
Date: Tue Aug 15 21:11:38 2017

viz: Move BeginFrameArgs mojom from cc to viz

Part of viz restructuring.

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iaa88f1a13d266997b6e6f3a758e59ff027d08a89
Reviewed-on: https://chromium-review.googlesource.com/612420
Commit-Queue: Gary Klassen <gklassen@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494545}
[modify] https://crrev.com/f3677eaee61daa80777be59e388a4620e6c38130/cc/ipc/BUILD.gn
[delete] https://crrev.com/39ec40095376e8d977decbdc5d7ca28ba7d39cf2/cc/ipc/begin_frame_args.typemap
[delete] https://crrev.com/39ec40095376e8d977decbdc5d7ca28ba7d39cf2/cc/ipc/begin_frame_args_for_blink.typemap
[modify] https://crrev.com/f3677eaee61daa80777be59e388a4620e6c38130/cc/ipc/cc_serialization_perftest.cc
[modify] https://crrev.com/f3677eaee61daa80777be59e388a4620e6c38130/cc/ipc/struct_traits_unittest.cc
[modify] https://crrev.com/f3677eaee61daa80777be59e388a4620e6c38130/cc/ipc/traits_test_service.mojom
[modify] https://crrev.com/f3677eaee61daa80777be59e388a4620e6c38130/cc/ipc/typemaps.gni
[add] https://crrev.com/f3677eaee61daa80777be59e388a4620e6c38130/services/viz/public/cpp/compositing/begin_frame_args.typemap
[add] https://crrev.com/f3677eaee61daa80777be59e388a4620e6c38130/services/viz/public/cpp/compositing/begin_frame_args_for_blink.typemap
[rename] https://crrev.com/f3677eaee61daa80777be59e388a4620e6c38130/services/viz/public/cpp/compositing/begin_frame_args_struct_traits.cc
[rename] https://crrev.com/f3677eaee61daa80777be59e388a4620e6c38130/services/viz/public/cpp/compositing/begin_frame_args_struct_traits.h
[modify] https://crrev.com/f3677eaee61daa80777be59e388a4620e6c38130/services/viz/public/cpp/compositing/compositor_frame_metadata_struct_traits.cc
[modify] https://crrev.com/f3677eaee61daa80777be59e388a4620e6c38130/services/viz/public/cpp/compositing/compositor_frame_metadata_struct_traits.h
[modify] https://crrev.com/f3677eaee61daa80777be59e388a4620e6c38130/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/f3677eaee61daa80777be59e388a4620e6c38130/services/viz/public/cpp/compositing/typemaps.gni
[modify] https://crrev.com/f3677eaee61daa80777be59e388a4620e6c38130/services/viz/public/interfaces/compositing/BUILD.gn
[rename] https://crrev.com/f3677eaee61daa80777be59e388a4620e6c38130/services/viz/public/interfaces/compositing/begin_frame_args.mojom
[modify] https://crrev.com/f3677eaee61daa80777be59e388a4620e6c38130/services/viz/public/interfaces/compositing/compositor_frame_metadata.mojom
[modify] https://crrev.com/f3677eaee61daa80777be59e388a4620e6c38130/services/viz/public/interfaces/compositing/compositor_frame_sink.mojom
[modify] https://crrev.com/f3677eaee61daa80777be59e388a4620e6c38130/third_party/WebKit/public/blink_typemaps.gni

Blockedon: 756113
Project Member

Comment 112 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/975217fb06d0b4368cfad708c0c8b84fccec7c73

commit 975217fb06d0b4368cfad708c0c8b84fccec7c73
Author: kylechar <kylechar@chromium.org>
Date: Thu Aug 17 18:49:58 2017

Fix privileged services/viz paths.

The README file for services/viz paths is not consistent with where
privileged things should go. It uses the following contradictory
locations:

services/viz/{gl, compositing, hit_test}/privileged/interfaces
services/viz/privileged/interfaces/{gl, compositing, hit_test}

Offline discussion with servizes/viz/OWNERS concluded we should use the
second one. This CL fixes the README to be consistent and fixes paths
appropriately.

Bug: 722935
Change-Id: I6c63f4d4f1f3c464a456d607419f307912fec593
Reviewed-on: https://chromium-review.googlesource.com/617882
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495257}
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/components/viz/host/BUILD.gn
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/components/viz/host/DEPS
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/components/viz/host/host_frame_sink_manager.h
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/components/viz/host/host_frame_sink_manager_unittests.cc
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/components/viz/host/server_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/components/viz/host/server_gpu_memory_buffer_manager_unittest.cc
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/components/viz/service/BUILD.gn
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/components/viz/service/DEPS
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/components/viz/service/frame_sinks/DEPS
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/components/viz/service/frame_sinks/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/components/viz/service/frame_sinks/frame_sink_manager_impl.h
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.h
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/components/viz/service/gl/DEPS
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/components/viz/service/gl/gpu_service_impl.h
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/content/browser/gpu/gpu_ipc_browsertests.cc
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/content/gpu/DEPS
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/content/gpu/gpu_child_thread.cc
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/mojo/public/tools/bindings/chromium_bindings_configuration.gni
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/BUILD.gn
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/ui/gpu/DEPS
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/ui/gpu/gpu_main.h
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/ui/gpu/interfaces/BUILD.gn
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/ui/gpu/interfaces/gpu_main.mojom
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/ui/ws/BUILD.gn
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/ui/ws/DEPS
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/ui/ws/compositor_frame_sink_client_binding.h
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/ui/ws/frame_sink_manager_client_binding.h
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/ui/ws/gpu_client.cc
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/ui/ws/gpu_host.h
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/ui/ws/server_window.h
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/ui/ws/server_window_compositor_frame_sink_manager.h
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/ui/ws/test_frame_sink_manager.h
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/ui/ws/window_server.h
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/viz/README.md
[delete] https://crrev.com/a4d523a0de35631166275a4126523e3a13e170e3/services/viz/compositing/privileged/interfaces/BUILD.gn
[delete] https://crrev.com/a4d523a0de35631166275a4126523e3a13e170e3/services/viz/gl/privileged/interfaces/OWNERS
[add] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/viz/privileged/interfaces/BUILD.gn
[rename] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/viz/privileged/interfaces/DEPS
[rename] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/viz/privileged/interfaces/OWNERS
[copy] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/viz/privileged/interfaces/compositing/BUILD.gn
[copy] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/viz/privileged/interfaces/compositing/OWNERS
[rename] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/viz/privileged/interfaces/compositing/frame_sink_manager.mojom
[rename] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/viz/privileged/interfaces/compositing/renderer_settings.mojom
[rename] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/viz/privileged/interfaces/compositing/renderer_settings.typemap
[rename] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/viz/privileged/interfaces/compositing/renderer_settings_struct_traits.cc
[rename] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/viz/privileged/interfaces/compositing/renderer_settings_struct_traits.h
[rename] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/viz/privileged/interfaces/compositing/typemaps.gni
[rename] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/viz/privileged/interfaces/gl/BUILD.gn
[copy] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/viz/privileged/interfaces/gl/OWNERS
[rename] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/viz/privileged/interfaces/gl/gpu_service.mojom
[rename] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/services/viz/privileged/interfaces/struct_traits_unittest.cc
[modify] https://crrev.com/975217fb06d0b4368cfad708c0c8b84fccec7c73/third_party/WebKit/public/BUILD.gn

Project Member

Comment 113 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf8978ee24f1ce39e23997f5d0ced27bd10980ff

commit bf8978ee24f1ce39e23997f5d0ced27bd10980ff
Author: Fady Samuel <fsamuel@chromium.org>
Date: Mon Aug 21 18:04:48 2017

viz: Introduce accessors for DSF and size to CompositorFrames

There are several places in Chromium where we would like to extract
the size and device scale factor of a CompositorFrame. While the data
is available within a CompositorFrame, accessing it is non-trivial
and folks occasionally get it wrong which leads to bugs.

This CL introduces accessors for DSF and size on CompositorFrames
and updates call sites.

Bug: 722935
TBR: sadrul@chromium.org, boliu@chromium.org
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I280e6754c78f466f714596c1bb60a934daaed1d5
Reviewed-on: https://chromium-review.googlesource.com/610833
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495986}
[modify] https://crrev.com/bf8978ee24f1ce39e23997f5d0ced27bd10980ff/android_webview/browser/hardware_renderer.cc
[modify] https://crrev.com/bf8978ee24f1ce39e23997f5d0ced27bd10980ff/cc/output/compositor_frame.h
[modify] https://crrev.com/bf8978ee24f1ce39e23997f5d0ced27bd10980ff/components/viz/client/local_surface_id_provider.cc
[modify] https://crrev.com/bf8978ee24f1ce39e23997f5d0ced27bd10980ff/components/viz/service/frame_sinks/compositor_frame_sink_support.cc
[modify] https://crrev.com/bf8978ee24f1ce39e23997f5d0ced27bd10980ff/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
[modify] https://crrev.com/bf8978ee24f1ce39e23997f5d0ced27bd10980ff/components/viz/service/surfaces/surface.cc
[modify] https://crrev.com/bf8978ee24f1ce39e23997f5d0ced27bd10980ff/components/viz/service/surfaces/surface_manager.cc
[modify] https://crrev.com/bf8978ee24f1ce39e23997f5d0ced27bd10980ff/components/viz/test/test_layer_tree_frame_sink.cc
[modify] https://crrev.com/bf8978ee24f1ce39e23997f5d0ced27bd10980ff/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/bf8978ee24f1ce39e23997f5d0ced27bd10980ff/content/common/render_widget_surface_properties.cc
[modify] https://crrev.com/bf8978ee24f1ce39e23997f5d0ced27bd10980ff/services/ui/ws/compositor_frame_sink_client_binding.cc
[modify] https://crrev.com/bf8978ee24f1ce39e23997f5d0ced27bd10980ff/services/ui/ws/frame_generator.cc
[modify] https://crrev.com/bf8978ee24f1ce39e23997f5d0ced27bd10980ff/ui/aura/local/layer_tree_frame_sink_local.cc

Project Member

Comment 114 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6401cdf5d56f0478044ea1dedfe3f1a626eb67f

commit c6401cdf5d56f0478044ea1dedfe3f1a626eb67f
Author: kylechar <kylechar@chromium.org>
Date: Tue Aug 22 18:30:17 2017

viz: Fix DEPS on ui/gfx.

Everything in components/viz can depend on ui/gfx, remove the current 19
DEPS rules and replace with one rule.

Bug: 722935
Change-Id: I7b39d3818dbb13d2a36ffa212cdfdddc327aa6d3
Reviewed-on: https://chromium-review.googlesource.com/626916
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496377}
[modify] https://crrev.com/c6401cdf5d56f0478044ea1dedfe3f1a626eb67f/components/viz/DEPS
[modify] https://crrev.com/c6401cdf5d56f0478044ea1dedfe3f1a626eb67f/components/viz/client/DEPS
[modify] https://crrev.com/c6401cdf5d56f0478044ea1dedfe3f1a626eb67f/components/viz/common/DEPS
[modify] https://crrev.com/c6401cdf5d56f0478044ea1dedfe3f1a626eb67f/components/viz/common/gpu/DEPS
[delete] https://crrev.com/27b00e37a69572423886c4d551b6a54eaf774d39/components/viz/common/hit_test/DEPS
[modify] https://crrev.com/c6401cdf5d56f0478044ea1dedfe3f1a626eb67f/components/viz/common/quads/DEPS
[modify] https://crrev.com/c6401cdf5d56f0478044ea1dedfe3f1a626eb67f/components/viz/common/resources/DEPS
[modify] https://crrev.com/c6401cdf5d56f0478044ea1dedfe3f1a626eb67f/components/viz/common/surfaces/DEPS
[modify] https://crrev.com/c6401cdf5d56f0478044ea1dedfe3f1a626eb67f/components/viz/host/DEPS
[modify] https://crrev.com/c6401cdf5d56f0478044ea1dedfe3f1a626eb67f/components/viz/host/hit_test/DEPS
[modify] https://crrev.com/c6401cdf5d56f0478044ea1dedfe3f1a626eb67f/components/viz/service/DEPS
[modify] https://crrev.com/c6401cdf5d56f0478044ea1dedfe3f1a626eb67f/components/viz/service/display/DEPS
[modify] https://crrev.com/c6401cdf5d56f0478044ea1dedfe3f1a626eb67f/components/viz/service/display_embedder/DEPS
[modify] https://crrev.com/c6401cdf5d56f0478044ea1dedfe3f1a626eb67f/components/viz/test/DEPS

Project Member

Comment 115 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4

commit 4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4
Author: kylechar <kylechar@chromium.org>
Date: Tue Aug 22 20:30:07 2017

viz: Move TestGpuMemoryBufferManager.

Move from cc to viz.

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If8a0f2545c1dac15395fd85700586ac4b833c976
Reviewed-on: https://chromium-review.googlesource.com/626739
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496426}
[modify] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/cc/BUILD.gn
[modify] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/cc/raster/raster_buffer_provider_perftest.cc
[modify] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/cc/raster/raster_buffer_provider_unittest.cc
[modify] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/cc/resources/resource_provider_unittest.cc
[modify] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/cc/test/fake_layer_tree_frame_sink.h
[modify] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/cc/test/layer_tree_test.cc
[modify] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/cc/test/layer_tree_test.h
[modify] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/cc/test/pixel_test.cc
[modify] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/cc/test/pixel_test.h
[modify] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/cc/test/test_in_process_context_provider.cc
[modify] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/cc/test/test_in_process_context_provider.h
[modify] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/components/viz/service/display_embedder/buffer_queue_unittest.cc
[modify] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/components/viz/service/frame_sinks/direct_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/components/viz/test/BUILD.gn
[modify] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/components/viz/test/DEPS
[rename] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/components/viz/test/test_gpu_memory_buffer_manager.cc
[rename] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/components/viz/test/test_gpu_memory_buffer_manager.h
[modify] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp
[modify] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/third_party/WebKit/Source/platform/graphics/DEPS
[modify] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp
[modify] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/ui/compositor/BUILD.gn
[modify] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/ui/compositor/test/DEPS
[modify] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/ui/compositor/test/fake_context_factory.h
[modify] https://crrev.com/4d2fe9c2ba61cd5117bf8b29cec8dc746429c5e4/ui/compositor/test/in_process_context_factory.h

Project Member

Comment 116 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bccff267b677cf538662bd4d938598671a6dbf4

commit 0bccff267b677cf538662bd4d938598671a6dbf4
Author: Fady Samuel <fsamuel@chromium.org>
Date: Tue Aug 22 23:37:32 2017

viz: ResourceProvider should not include output_surface.h

Currently cc::ResourceProvider includes output_surface.h but it doesn't
use cc::OutputSurface. This CL removes that include and adds additional
includes directly that were included implicitly by output_surface.h.

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I11da4873ecb5fbee20f52191aaa9064601aff02d
Reviewed-on: https://chromium-review.googlesource.com/627416
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496505}
[modify] https://crrev.com/0bccff267b677cf538662bd4d938598671a6dbf4/cc/output/direct_renderer.cc
[modify] https://crrev.com/0bccff267b677cf538662bd4d938598671a6dbf4/cc/resources/display_resource_provider.h
[modify] https://crrev.com/0bccff267b677cf538662bd4d938598671a6dbf4/cc/resources/resource_provider.h
[modify] https://crrev.com/0bccff267b677cf538662bd4d938598671a6dbf4/cc/test/pixel_test.h
[modify] https://crrev.com/0bccff267b677cf538662bd4d938598671a6dbf4/components/viz/service/display/display.cc

Project Member

Comment 117 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f159576bc451d376bfea28062045d76ed79e042

commit 1f159576bc451d376bfea28062045d76ed79e042
Author: Alex Zhang <staraz@chromium.org>
Date: Wed Aug 23 20:14:20 2017

Move VulkanContextProvider and VulkanInProcessContextProvider to viz

This CL moves VulkanContextProvider and VulkanInProcessContextProvider
to viz. All includes, forward declarations and namespaces are updated
accordingly.

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0b7ac21d27364571fb668ae556f43e1d09b869d2
Reviewed-on: https://chromium-review.googlesource.com/621846
Commit-Queue: Xingyu Zhang <staraz@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496784}
[modify] https://crrev.com/1f159576bc451d376bfea28062045d76ed79e042/cc/BUILD.gn
[modify] https://crrev.com/1f159576bc451d376bfea28062045d76ed79e042/cc/output/layer_tree_frame_sink.cc
[modify] https://crrev.com/1f159576bc451d376bfea28062045d76ed79e042/cc/output/layer_tree_frame_sink.h
[modify] https://crrev.com/1f159576bc451d376bfea28062045d76ed79e042/cc/output/output_surface.cc
[modify] https://crrev.com/1f159576bc451d376bfea28062045d76ed79e042/cc/output/output_surface.h
[modify] https://crrev.com/1f159576bc451d376bfea28062045d76ed79e042/components/viz/client/client_layer_tree_frame_sink.cc
[modify] https://crrev.com/1f159576bc451d376bfea28062045d76ed79e042/components/viz/client/client_layer_tree_frame_sink.h
[modify] https://crrev.com/1f159576bc451d376bfea28062045d76ed79e042/components/viz/common/BUILD.gn
[modify] https://crrev.com/1f159576bc451d376bfea28062045d76ed79e042/components/viz/common/gpu/DEPS
[rename] https://crrev.com/1f159576bc451d376bfea28062045d76ed79e042/components/viz/common/gpu/vulkan_context_provider.h
[rename] https://crrev.com/1f159576bc451d376bfea28062045d76ed79e042/components/viz/common/gpu/vulkan_in_process_context_provider.cc
[rename] https://crrev.com/1f159576bc451d376bfea28062045d76ed79e042/components/viz/common/gpu/vulkan_in_process_context_provider.h
[modify] https://crrev.com/1f159576bc451d376bfea28062045d76ed79e042/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
[modify] https://crrev.com/1f159576bc451d376bfea28062045d76ed79e042/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h
[modify] https://crrev.com/1f159576bc451d376bfea28062045d76ed79e042/content/browser/compositor/browser_compositor_output_surface.cc
[modify] https://crrev.com/1f159576bc451d376bfea28062045d76ed79e042/content/browser/compositor/browser_compositor_output_surface.h
[modify] https://crrev.com/1f159576bc451d376bfea28062045d76ed79e042/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/1f159576bc451d376bfea28062045d76ed79e042/content/browser/compositor/gpu_process_transport_factory.h
[modify] https://crrev.com/1f159576bc451d376bfea28062045d76ed79e042/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/1f159576bc451d376bfea28062045d76ed79e042/content/browser/renderer_host/compositor_impl_android.h
[modify] https://crrev.com/1f159576bc451d376bfea28062045d76ed79e042/content/renderer/render_thread_impl.cc

Project Member

Comment 118 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abad229364ba127e44cb4ca6ff8de7eb054fe49b

commit abad229364ba127e44cb4ca6ff8de7eb054fe49b
Author: Alex Zhang <staraz@chromium.org>
Date: Wed Aug 23 21:55:19 2017

Move SharedQuadState to viz

This CL moves cc/quads/shared_quad_state* to
components/viz/common/quads.

Added dependency from components/viz/common to cc/base because
SharedQuadState includes cc/base/math_util.h.

All includes, forward declarations and namespaces are updated
appropriately.

TBR=reveman@chromium.org, jbroman@chromium.org

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I814120d714977778134211a7cce9facc6b7f248b
Reviewed-on: https://chromium-review.googlesource.com/619184
Commit-Queue: Xingyu Zhang <staraz@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496823}
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/android_webview/browser/surfaces_instance.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/ash/fast_ink/fast_ink_view.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/BUILD.gn
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/ipc/cc_param_traits.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/ipc/cc_param_traits_macros.h
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/ipc/cc_param_traits_unittest.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/ipc/cc_serialization_perftest.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/layers/heads_up_display_layer_impl.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/layers/layer_impl.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/layers/layer_impl.h
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/layers/nine_patch_layer_impl.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/layers/painted_overlay_scrollbar_layer_impl.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/layers/painted_scrollbar_layer_impl.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/layers/picture_layer_impl.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/layers/render_surface_impl.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/layers/render_surface_impl.h
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/layers/render_surface_unittest.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/layers/solid_color_layer_impl.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/layers/solid_color_layer_impl.h
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/layers/solid_color_scrollbar_layer_impl.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/layers/surface_layer_impl.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/layers/surface_layer_impl.h
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/layers/surface_layer_impl_unittest.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/layers/texture_layer_impl.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/layers/ui_resource_layer_impl.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/layers/video_layer_impl.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/output/ca_layer_overlay.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/output/dc_layer_overlay.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/output/overlay_unittest.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/output/renderer_pixeltest.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/output/software_renderer_unittest.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/content_draw_quad_base.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/content_draw_quad_base.h
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/debug_border_draw_quad.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/debug_border_draw_quad.h
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/draw_quad.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/draw_quad.h
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/draw_quad_perftest.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/draw_quad_unittest.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/nine_patch_generator.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/nine_patch_generator.h
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/picture_draw_quad.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/picture_draw_quad.h
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/render_pass.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/render_pass.h
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/render_pass_draw_quad.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/render_pass_draw_quad.h
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/render_pass_unittest.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/solid_color_draw_quad.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/solid_color_draw_quad.h
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/stream_video_draw_quad.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/stream_video_draw_quad.h
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/surface_draw_quad.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/surface_draw_quad.h
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/texture_draw_quad.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/texture_draw_quad.h
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/tile_draw_quad.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/tile_draw_quad.h
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/yuv_video_draw_quad.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/quads/yuv_video_draw_quad.h
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/test/render_pass_test_utils.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/components/exo/surface.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/components/viz/common/BUILD.gn
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/components/viz/common/quads/DEPS
[rename] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/components/viz/common/quads/shared_quad_state.cc
[rename] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/components/viz/common/quads/shared_quad_state.h
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/components/viz/service/display/gl_renderer_unittest.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/components/viz/service/display/surface_aggregator.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/components/viz/service/display/surface_aggregator.h
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/components/viz/service/display/surface_aggregator_pixeltest.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/components/viz/test/surface_hittest_test_helpers.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/services/ui/ws/frame_generator.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/services/viz/public/cpp/compositing/quads_struct_traits.h
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/services/viz/public/cpp/compositing/render_pass_struct_traits.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/services/viz/public/cpp/compositing/shared_quad_state.typemap
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/services/viz/public/cpp/compositing/shared_quad_state_struct_traits.h
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/abad229364ba127e44cb4ca6ff8de7eb054fe49b/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp

Project Member

Comment 119 by bugdroid1@chromium.org, Aug 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9239fe592b449dc79b6845ce6b0ed421f564afbe

commit 9239fe592b449dc79b6845ce6b0ed421f564afbe
Author: Saman Sami <samans@chromium.org>
Date: Sat Aug 26 03:22:15 2017

Move SurfaceId's mojom from cc to to viz

Also merge build targets for compositing and hit_test in
services/viz/public/interfaces, otherwise they would form a circular
dependency.

TBR=weiliangc@chromium.org,piman@chromium.org,tsepez@chromium.org,sadrul@chromium.org,thakis@chromium.org

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8bdafceb593367987a85cdf0c5dcedbd4becb221
Reviewed-on: https://chromium-review.googlesource.com/633752
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497647}
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/cc/BUILD.gn
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/cc/ipc/BUILD.gn
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/cc/ipc/cc_serialization_perftest.cc
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/cc/ipc/struct_traits_unittest.cc
[delete] https://crrev.com/60daf8fcc5fb49f2f6392a29b016770ef384b416/cc/ipc/surface_id.typemap
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/cc/ipc/traits_test_service.mojom
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/cc/ipc/typemaps.gni
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/components/viz/client/BUILD.gn
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/components/viz/client/DEPS
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/components/viz/common/surfaces/surface_id.h
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/components/viz/host/BUILD.gn
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/components/viz/host/DEPS
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/components/viz/host/hit_test/DEPS
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/components/viz/service/BUILD.gn
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/content/common/BUILD.gn
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/content/common/DEPS
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/content/test/BUILD.gn
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/content/test/DEPS
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/services/ui/public/interfaces/BUILD.gn
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/services/ui/public/interfaces/window_tree.mojom
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/services/ui/ws/DEPS
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/services/viz/privileged/interfaces/compositing/BUILD.gn
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/services/viz/privileged/interfaces/compositing/frame_sink_manager.mojom
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/services/viz/public/cpp/compositing/BUILD.gn
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/services/viz/public/cpp/compositing/compositor_frame_for_blink.typemap
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/services/viz/public/cpp/compositing/compositor_frame_metadata_struct_traits.cc
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/services/viz/public/cpp/compositing/quads_struct_traits.h
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[add] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/services/viz/public/cpp/compositing/surface_id.typemap
[rename] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/services/viz/public/cpp/compositing/surface_id_struct_traits.h
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/services/viz/public/cpp/compositing/typemaps.gni
[add] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/services/viz/public/interfaces/BUILD.gn
[delete] https://crrev.com/60daf8fcc5fb49f2f6392a29b016770ef384b416/services/viz/public/interfaces/compositing/BUILD.gn
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/services/viz/public/interfaces/compositing/compositor_frame_metadata.mojom
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/services/viz/public/interfaces/compositing/compositor_frame_sink.mojom
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/services/viz/public/interfaces/compositing/quads.mojom
[rename] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/services/viz/public/interfaces/compositing/surface_id.mojom
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/services/viz/public/interfaces/compositing/surface_info.mojom
[delete] https://crrev.com/60daf8fcc5fb49f2f6392a29b016770ef384b416/services/viz/public/interfaces/hit_test/BUILD.gn
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/services/viz/public/interfaces/hit_test/hit_test_region_list.mojom
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/third_party/WebKit/Source/platform/graphics/DEPS
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/third_party/WebKit/public/blink_typemaps.gni
[modify] https://crrev.com/9239fe592b449dc79b6845ce6b0ed421f564afbe/third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom

Project Member

Comment 120 by bugdroid1@chromium.org, Aug 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d6b05567264cacdb02ef4aa2db30c595a17e946

commit 8d6b05567264cacdb02ef4aa2db30c595a17e946
Author: Ian Clelland <iclelland@chromium.org>
Date: Sat Aug 26 03:52:37 2017

Revert "Move SurfaceId's mojom from cc to to viz"

This reverts commit 9239fe592b449dc79b6845ce6b0ed421f564afbe.

Reason for revert: Breaks ChromeOS builder
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/38532


Original change's description:
> Move SurfaceId's mojom from cc to to viz
> 
> Also merge build targets for compositing and hit_test in
> services/viz/public/interfaces, otherwise they would form a circular
> dependency.
> 
> TBR=weiliangc@chromium.org,piman@chromium.org,tsepez@chromium.org,sadrul@chromium.org,thakis@chromium.org
> 
> Bug: 722935
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I8bdafceb593367987a85cdf0c5dcedbd4becb221
> Reviewed-on: https://chromium-review.googlesource.com/633752
> Commit-Queue: Fady Samuel <fsamuel@chromium.org>
> Reviewed-by: Saman Sami <samans@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Reviewed-by: weiliangc <weiliangc@chromium.org>
> Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#497647}

TBR=sadrul@chromium.org,thakis@chromium.org,weiliangc@chromium.org,fsamuel@chromium.org,tsepez@chromium.org,piman@chromium.org,samans@chromium.org

Change-Id: Ib9ec104e3ee50171f6b918dbeece5d73ff153043
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/636006
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497650}
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/cc/BUILD.gn
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/cc/ipc/BUILD.gn
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/cc/ipc/cc_serialization_perftest.cc
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/cc/ipc/struct_traits_unittest.cc
[rename] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/cc/ipc/surface_id.mojom
[add] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/cc/ipc/surface_id.typemap
[rename] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/cc/ipc/surface_id_struct_traits.h
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/cc/ipc/traits_test_service.mojom
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/cc/ipc/typemaps.gni
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/components/viz/client/BUILD.gn
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/components/viz/client/DEPS
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/components/viz/common/surfaces/surface_id.h
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/components/viz/host/BUILD.gn
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/components/viz/host/DEPS
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/components/viz/host/hit_test/DEPS
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/components/viz/service/BUILD.gn
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/content/common/BUILD.gn
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/content/common/DEPS
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/content/test/BUILD.gn
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/content/test/DEPS
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/services/ui/public/interfaces/BUILD.gn
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/services/ui/public/interfaces/window_tree.mojom
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/services/ui/ws/DEPS
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/services/viz/privileged/interfaces/compositing/BUILD.gn
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/services/viz/privileged/interfaces/compositing/frame_sink_manager.mojom
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/services/viz/public/cpp/compositing/BUILD.gn
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/services/viz/public/cpp/compositing/compositor_frame_for_blink.typemap
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/services/viz/public/cpp/compositing/compositor_frame_metadata_struct_traits.cc
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/services/viz/public/cpp/compositing/quads_struct_traits.h
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[delete] https://crrev.com/4d219f851acf0c40ff6ae83105f59d70105c4226/services/viz/public/cpp/compositing/surface_id.typemap
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/services/viz/public/cpp/compositing/typemaps.gni
[delete] https://crrev.com/4d219f851acf0c40ff6ae83105f59d70105c4226/services/viz/public/interfaces/BUILD.gn
[add] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/services/viz/public/interfaces/compositing/BUILD.gn
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/services/viz/public/interfaces/compositing/compositor_frame_metadata.mojom
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/services/viz/public/interfaces/compositing/compositor_frame_sink.mojom
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/services/viz/public/interfaces/compositing/quads.mojom
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/services/viz/public/interfaces/compositing/surface_info.mojom
[add] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/services/viz/public/interfaces/hit_test/BUILD.gn
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/services/viz/public/interfaces/hit_test/hit_test_region_list.mojom
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/third_party/WebKit/Source/platform/graphics/DEPS
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/third_party/WebKit/public/blink_typemaps.gni
[modify] https://crrev.com/8d6b05567264cacdb02ef4aa2db30c595a17e946/third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom

Project Member

Comment 121 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386

commit 1f34578bcd2fa4da8b3fe124c4dcb1e140db7386
Author: Saman Sami <samans@chromium.org>
Date: Mon Aug 28 18:31:56 2017

(Reland) Move SurfaceId's mojom from cc to to viz

Also merge build targets for compositing and hit_test in
services/viz/public/interfaces, otherwise they would form a circular
dependency. This is a reland. The original CL was reverted for
compilation error.

TBR=fsamuel@chromium.org,weiliangc@chromium.org,piman@chromium.org,tsepez@chromium.org,sadrul@chromium.org,thakis@chromium.org

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6a71bdd3f41316838bcbe291c48d50e679d876eb
Reviewed-on: https://chromium-review.googlesource.com/638131
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497812}
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/cc/BUILD.gn
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/cc/ipc/BUILD.gn
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/cc/ipc/cc_serialization_perftest.cc
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/cc/ipc/struct_traits_unittest.cc
[delete] https://crrev.com/a8a5f91aedd4a01136c7080df35dca251ec3cfe7/cc/ipc/surface_id.typemap
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/cc/ipc/traits_test_service.mojom
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/cc/ipc/typemaps.gni
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/components/viz/client/BUILD.gn
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/components/viz/client/DEPS
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/components/viz/common/surfaces/surface_id.h
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/components/viz/host/BUILD.gn
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/components/viz/host/DEPS
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/components/viz/host/hit_test/DEPS
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/components/viz/service/BUILD.gn
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/content/common/BUILD.gn
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/content/common/DEPS
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/content/test/BUILD.gn
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/content/test/DEPS
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/services/ui/public/interfaces/BUILD.gn
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/services/ui/public/interfaces/window_tree.mojom
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/services/ui/ws/DEPS
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/services/ui/ws/window_tree.h
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/services/viz/privileged/interfaces/compositing/BUILD.gn
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/services/viz/privileged/interfaces/compositing/frame_sink_manager.mojom
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/services/viz/public/cpp/compositing/BUILD.gn
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/services/viz/public/cpp/compositing/compositor_frame_for_blink.typemap
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/services/viz/public/cpp/compositing/compositor_frame_metadata_struct_traits.cc
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/services/viz/public/cpp/compositing/quads_struct_traits.h
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[add] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/services/viz/public/cpp/compositing/surface_id.typemap
[rename] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/services/viz/public/cpp/compositing/surface_id_struct_traits.h
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/services/viz/public/cpp/compositing/typemaps.gni
[add] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/services/viz/public/interfaces/BUILD.gn
[delete] https://crrev.com/a8a5f91aedd4a01136c7080df35dca251ec3cfe7/services/viz/public/interfaces/compositing/BUILD.gn
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/services/viz/public/interfaces/compositing/compositor_frame_metadata.mojom
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/services/viz/public/interfaces/compositing/compositor_frame_sink.mojom
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/services/viz/public/interfaces/compositing/quads.mojom
[rename] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/services/viz/public/interfaces/compositing/surface_id.mojom
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/services/viz/public/interfaces/compositing/surface_info.mojom
[delete] https://crrev.com/a8a5f91aedd4a01136c7080df35dca251ec3cfe7/services/viz/public/interfaces/hit_test/BUILD.gn
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/services/viz/public/interfaces/hit_test/hit_test_region_list.mojom
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/third_party/WebKit/Source/platform/graphics/DEPS
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/third_party/WebKit/public/blink_typemaps.gni
[modify] https://crrev.com/1f34578bcd2fa4da8b3fe124c4dcb1e140db7386/third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom

Project Member

Comment 122 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da0d70a21d4fc0fb8daeec09ce23d5f59052cb3e

commit da0d70a21d4fc0fb8daeec09ce23d5f59052cb3e
Author: Gary Klassen <gklassen@chromium.org>
Date: Tue Aug 29 23:04:24 2017

viz: move FilterOperation and FilterOperations mojom from cc to viz

Part of viz restructuring.

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7ce2827e84fd62461ce164f0a47939b3303c6440
Reviewed-on: https://chromium-review.googlesource.com/627417
Commit-Queue: Gary Klassen <gklassen@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498272}
[modify] https://crrev.com/da0d70a21d4fc0fb8daeec09ce23d5f59052cb3e/cc/ipc/BUILD.gn
[delete] https://crrev.com/49a6c20185793324f0d7b356118171a5cc126388/cc/ipc/filter_operation.typemap
[delete] https://crrev.com/49a6c20185793324f0d7b356118171a5cc126388/cc/ipc/filter_operations.typemap
[delete] https://crrev.com/49a6c20185793324f0d7b356118171a5cc126388/cc/ipc/filter_operations_struct_traits.h
[modify] https://crrev.com/da0d70a21d4fc0fb8daeec09ce23d5f59052cb3e/cc/ipc/struct_traits_unittest.cc
[modify] https://crrev.com/da0d70a21d4fc0fb8daeec09ce23d5f59052cb3e/cc/ipc/traits_test_service.mojom
[modify] https://crrev.com/da0d70a21d4fc0fb8daeec09ce23d5f59052cb3e/cc/ipc/typemaps.gni
[modify] https://crrev.com/da0d70a21d4fc0fb8daeec09ce23d5f59052cb3e/services/viz/public/cpp/compositing/BUILD.gn
[modify] https://crrev.com/da0d70a21d4fc0fb8daeec09ce23d5f59052cb3e/services/viz/public/cpp/compositing/DEPS
[modify] https://crrev.com/da0d70a21d4fc0fb8daeec09ce23d5f59052cb3e/services/viz/public/cpp/compositing/compositor_frame_for_blink.typemap
[add] https://crrev.com/da0d70a21d4fc0fb8daeec09ce23d5f59052cb3e/services/viz/public/cpp/compositing/filter_operation.typemap
[rename] https://crrev.com/da0d70a21d4fc0fb8daeec09ce23d5f59052cb3e/services/viz/public/cpp/compositing/filter_operation_struct_traits.h
[add] https://crrev.com/da0d70a21d4fc0fb8daeec09ce23d5f59052cb3e/services/viz/public/cpp/compositing/filter_operations.typemap
[add] https://crrev.com/da0d70a21d4fc0fb8daeec09ce23d5f59052cb3e/services/viz/public/cpp/compositing/filter_operations_struct_traits.h
[modify] https://crrev.com/da0d70a21d4fc0fb8daeec09ce23d5f59052cb3e/services/viz/public/cpp/compositing/quads_struct_traits.h
[modify] https://crrev.com/da0d70a21d4fc0fb8daeec09ce23d5f59052cb3e/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/da0d70a21d4fc0fb8daeec09ce23d5f59052cb3e/services/viz/public/cpp/compositing/typemaps.gni
[modify] https://crrev.com/da0d70a21d4fc0fb8daeec09ce23d5f59052cb3e/services/viz/public/interfaces/BUILD.gn
[rename] https://crrev.com/da0d70a21d4fc0fb8daeec09ce23d5f59052cb3e/services/viz/public/interfaces/compositing/filter_operation.mojom
[rename] https://crrev.com/da0d70a21d4fc0fb8daeec09ce23d5f59052cb3e/services/viz/public/interfaces/compositing/filter_operations.mojom
[modify] https://crrev.com/da0d70a21d4fc0fb8daeec09ce23d5f59052cb3e/services/viz/public/interfaces/compositing/render_pass.mojom

Project Member

Comment 123 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efaef4f59dd05d3e68d203528ce966526dc3a269

commit efaef4f59dd05d3e68d203528ce966526dc3a269
Author: yiyix <yiyix@chromium.org>
Date: Thu Aug 31 02:50:58 2017

viz: Move CopyOutputRequest's mojom from cc/ipc to services/viz

For more details:
https://docs.google.com/spreadsheets/d/1gHvkSVehWvWvCyCa-V0tZezULNTpiW0T8tLE3DjVgkg

TBR=weiliangc@chromium.org

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4c24436fcdf674c475c39e4dbb07f7512f8288ff
Reviewed-on: https://chromium-review.googlesource.com/641960
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498739}
[modify] https://crrev.com/efaef4f59dd05d3e68d203528ce966526dc3a269/cc/ipc/BUILD.gn
[delete] https://crrev.com/d0c686067e44d086cae18f6bd1db7ef83fda85d3/cc/ipc/copy_output_request.typemap
[modify] https://crrev.com/efaef4f59dd05d3e68d203528ce966526dc3a269/cc/ipc/struct_traits_unittest.cc
[modify] https://crrev.com/efaef4f59dd05d3e68d203528ce966526dc3a269/cc/ipc/traits_test_service.mojom
[modify] https://crrev.com/efaef4f59dd05d3e68d203528ce966526dc3a269/cc/ipc/typemaps.gni
[modify] https://crrev.com/efaef4f59dd05d3e68d203528ce966526dc3a269/components/viz/common/quads/copy_output_request.h
[add] https://crrev.com/efaef4f59dd05d3e68d203528ce966526dc3a269/services/viz/public/cpp/compositing/copy_output_request.typemap
[rename] https://crrev.com/efaef4f59dd05d3e68d203528ce966526dc3a269/services/viz/public/cpp/compositing/copy_output_request_struct_traits.cc
[rename] https://crrev.com/efaef4f59dd05d3e68d203528ce966526dc3a269/services/viz/public/cpp/compositing/copy_output_request_struct_traits.h
[modify] https://crrev.com/efaef4f59dd05d3e68d203528ce966526dc3a269/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/efaef4f59dd05d3e68d203528ce966526dc3a269/services/viz/public/cpp/compositing/typemaps.gni
[modify] https://crrev.com/efaef4f59dd05d3e68d203528ce966526dc3a269/services/viz/public/interfaces/BUILD.gn
[modify] https://crrev.com/efaef4f59dd05d3e68d203528ce966526dc3a269/services/viz/public/interfaces/compositing/compositor_frame_sink.mojom
[rename] https://crrev.com/efaef4f59dd05d3e68d203528ce966526dc3a269/services/viz/public/interfaces/compositing/copy_output_request.mojom

Project Member

Comment 124 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa88d3b4fdfb1faf24c1e9a1406b7033a92a6951

commit aa88d3b4fdfb1faf24c1e9a1406b7033a92a6951
Author: Gary Klassen <gklassen@chromium.org>
Date: Tue Sep 05 22:46:27 2017

viz: move FrameSinkId mojom from cc to viz

Part of viz restructuring.

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I185492edf465a84189d25cda6d4da3cc8a851b4a
Reviewed-on: https://chromium-review.googlesource.com/647829
Commit-Queue: Gary Klassen <gklassen@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499774}
[modify] https://crrev.com/aa88d3b4fdfb1faf24c1e9a1406b7033a92a6951/cc/ipc/BUILD.gn
[delete] https://crrev.com/98704abddca163a090a8a582b0f5ebc62b8e01f6/cc/ipc/frame_sink_id.typemap
[delete] https://crrev.com/98704abddca163a090a8a582b0f5ebc62b8e01f6/cc/ipc/frame_sink_id_struct_traits.h
[modify] https://crrev.com/aa88d3b4fdfb1faf24c1e9a1406b7033a92a6951/cc/ipc/typemaps.gni
[modify] https://crrev.com/aa88d3b4fdfb1faf24c1e9a1406b7033a92a6951/services/ui/public/interfaces/window_manager.mojom
[modify] https://crrev.com/aa88d3b4fdfb1faf24c1e9a1406b7033a92a6951/services/ui/public/interfaces/window_tree.mojom
[modify] https://crrev.com/aa88d3b4fdfb1faf24c1e9a1406b7033a92a6951/services/viz/privileged/interfaces/compositing/frame_sink_manager.mojom
[add] https://crrev.com/aa88d3b4fdfb1faf24c1e9a1406b7033a92a6951/services/viz/public/cpp/compositing/frame_sink_id.typemap
[add] https://crrev.com/aa88d3b4fdfb1faf24c1e9a1406b7033a92a6951/services/viz/public/cpp/compositing/frame_sink_id_struct_traits.h
[modify] https://crrev.com/aa88d3b4fdfb1faf24c1e9a1406b7033a92a6951/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/aa88d3b4fdfb1faf24c1e9a1406b7033a92a6951/services/viz/public/cpp/compositing/surface_id_struct_traits.h
[modify] https://crrev.com/aa88d3b4fdfb1faf24c1e9a1406b7033a92a6951/services/viz/public/cpp/compositing/typemaps.gni
[modify] https://crrev.com/aa88d3b4fdfb1faf24c1e9a1406b7033a92a6951/services/viz/public/interfaces/BUILD.gn
[modify] https://crrev.com/aa88d3b4fdfb1faf24c1e9a1406b7033a92a6951/services/viz/public/interfaces/compositing/compositor_frame_sink.mojom
[rename] https://crrev.com/aa88d3b4fdfb1faf24c1e9a1406b7033a92a6951/services/viz/public/interfaces/compositing/frame_sink_id.mojom
[modify] https://crrev.com/aa88d3b4fdfb1faf24c1e9a1406b7033a92a6951/services/viz/public/interfaces/compositing/surface_id.mojom
[modify] https://crrev.com/aa88d3b4fdfb1faf24c1e9a1406b7033a92a6951/services/viz/public/interfaces/compositing/surface_sequence.mojom
[modify] https://crrev.com/aa88d3b4fdfb1faf24c1e9a1406b7033a92a6951/services/viz/public/interfaces/hit_test/hit_test_region_list.mojom
[modify] https://crrev.com/aa88d3b4fdfb1faf24c1e9a1406b7033a92a6951/third_party/WebKit/public/blink_typemaps.gni
[modify] https://crrev.com/aa88d3b4fdfb1faf24c1e9a1406b7033a92a6951/third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom

Project Member

Comment 125 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/428a50e2d67401102545fd57491eef446d9e3ad8

commit 428a50e2d67401102545fd57491eef446d9e3ad8
Author: Alex Zhang <staraz@chromium.org>
Date: Wed Sep 06 23:41:40 2017

Move layer_quad* to components/viz/service/display

Move LayerQuad and its unit tests to components/viz/service/display.
All includes and namespaces are updated accordingly.

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2730f0b9843aa1cdfb2eb5bc8b2cd84e65644ad8
Reviewed-on: https://chromium-review.googlesource.com/647830
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Xingyu Zhang <staraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500120}
[modify] https://crrev.com/428a50e2d67401102545fd57491eef446d9e3ad8/cc/BUILD.gn
[modify] https://crrev.com/428a50e2d67401102545fd57491eef446d9e3ad8/components/viz/service/BUILD.gn
[modify] https://crrev.com/428a50e2d67401102545fd57491eef446d9e3ad8/components/viz/service/display/gl_renderer.cc
[rename] https://crrev.com/428a50e2d67401102545fd57491eef446d9e3ad8/components/viz/service/display/layer_quad.cc
[rename] https://crrev.com/428a50e2d67401102545fd57491eef446d9e3ad8/components/viz/service/display/layer_quad.h
[rename] https://crrev.com/428a50e2d67401102545fd57491eef446d9e3ad8/components/viz/service/display/layer_quad_unittest.cc

Project Member

Comment 126 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50d3571394b63059a4a765cbe9d34367e8c0c709

commit 50d3571394b63059a4a765cbe9d34367e8c0c709
Author: Gary Klassen <gklassen@chromium.org>
Date: Thu Sep 07 01:06:02 2017

viz: move LocalSurfaceId mojom from cc to viz

Part of viz restructuring.

TBR=weiliangc@chromium.org

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1aa1cf8260ce47c42827db32d97ffe32d4255e62
Reviewed-on: https://chromium-review.googlesource.com/650649
Commit-Queue: Gary Klassen <gklassen@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500168}
[modify] https://crrev.com/50d3571394b63059a4a765cbe9d34367e8c0c709/cc/ipc/BUILD.gn
[delete] https://crrev.com/1bd53dae779cedee49f4c1cb37b26b1007556384/cc/ipc/local_surface_id.typemap
[modify] https://crrev.com/50d3571394b63059a4a765cbe9d34367e8c0c709/cc/ipc/typemaps.gni
[modify] https://crrev.com/50d3571394b63059a4a765cbe9d34367e8c0c709/components/viz/common/surfaces/local_surface_id.h
[modify] https://crrev.com/50d3571394b63059a4a765cbe9d34367e8c0c709/services/ui/public/interfaces/window_manager.mojom
[modify] https://crrev.com/50d3571394b63059a4a765cbe9d34367e8c0c709/services/ui/public/interfaces/window_tree.mojom
[modify] https://crrev.com/50d3571394b63059a4a765cbe9d34367e8c0c709/services/viz/privileged/interfaces/compositing/frame_sink_manager.mojom
[add] https://crrev.com/50d3571394b63059a4a765cbe9d34367e8c0c709/services/viz/public/cpp/compositing/local_surface_id.typemap
[rename] https://crrev.com/50d3571394b63059a4a765cbe9d34367e8c0c709/services/viz/public/cpp/compositing/local_surface_id_struct_traits.h
[modify] https://crrev.com/50d3571394b63059a4a765cbe9d34367e8c0c709/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/50d3571394b63059a4a765cbe9d34367e8c0c709/services/viz/public/cpp/compositing/surface_id_struct_traits.h
[modify] https://crrev.com/50d3571394b63059a4a765cbe9d34367e8c0c709/services/viz/public/cpp/compositing/typemaps.gni
[modify] https://crrev.com/50d3571394b63059a4a765cbe9d34367e8c0c709/services/viz/public/interfaces/BUILD.gn
[modify] https://crrev.com/50d3571394b63059a4a765cbe9d34367e8c0c709/services/viz/public/interfaces/compositing/compositor_frame_sink.mojom
[rename] https://crrev.com/50d3571394b63059a4a765cbe9d34367e8c0c709/services/viz/public/interfaces/compositing/local_surface_id.mojom
[modify] https://crrev.com/50d3571394b63059a4a765cbe9d34367e8c0c709/services/viz/public/interfaces/compositing/surface_id.mojom
[modify] https://crrev.com/50d3571394b63059a4a765cbe9d34367e8c0c709/services/viz/public/interfaces/hit_test/hit_test_region_list.mojom
[modify] https://crrev.com/50d3571394b63059a4a765cbe9d34367e8c0c709/third_party/WebKit/public/blink_typemaps.gni

Project Member

Comment 127 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b

commit 1a010682ccfe0dd6654cf65091dbd8d8cab15b1b
Author: danakj <danakj@chromium.org>
Date: Thu Sep 07 20:08:19 2017

Move DrawQuad from cc/ to components/viz/

This moves the DrawQuad base class from cc/quads/ to
components/viz/common/quads/.

R=staraz@chromium.org
TBR=dcheng

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I17be9c08f65bcbec824422544ebd4e8730729695
Reviewed-on: https://chromium-review.googlesource.com/654141
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xingyu Zhang <staraz@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500364}
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/ash/mus/non_client_frame_controller_unittest.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/BUILD.gn
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/ipc/cc_param_traits.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/ipc/cc_param_traits.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/ipc/cc_param_traits_macros.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/ipc/cc_param_traits_unittest.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/layers/layer_impl.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/layers/layer_impl.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/layers/painted_scrollbar_layer_impl_unittest.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/layers/render_surface_impl.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/layers/scrollbar_layer_unittest.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/layers/texture_layer_impl_unittest.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/layers/ui_resource_layer_impl_unittest.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/layers/video_layer_impl_unittest.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/output/bsp_tree_perftest.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/output/bsp_walk_action.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/output/ca_layer_overlay.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/output/dc_layer_overlay.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/output/dc_layer_overlay.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/output/direct_renderer.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/output/direct_renderer.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/output/overlay_candidate.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/output/overlay_candidate.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/output/overlay_processor.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/output/overlay_strategy_fullscreen.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/output/overlay_strategy_single_on_top.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/output/overlay_strategy_underlay.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/output/overlay_strategy_underlay_cast.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/output/overlay_unittest.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/output/renderer_pixeltest.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/output/software_renderer.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/output/software_renderer.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/output/vulkan_renderer.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/output/vulkan_renderer.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/content_draw_quad_base.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/content_draw_quad_base.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/debug_border_draw_quad.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/debug_border_draw_quad.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/draw_polygon.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/draw_polygon.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/draw_quad_perftest.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/draw_quad_unittest.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/picture_draw_quad.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/picture_draw_quad.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/render_pass.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/render_pass.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/render_pass_draw_quad.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/render_pass_draw_quad.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/solid_color_draw_quad.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/solid_color_draw_quad.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/stream_video_draw_quad.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/stream_video_draw_quad.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/surface_draw_quad.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/surface_draw_quad.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/texture_draw_quad.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/texture_draw_quad.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/tile_draw_quad.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/tile_draw_quad.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/yuv_video_draw_quad.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/quads/yuv_video_draw_quad.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/test/layer_test_common.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/cc/trees/single_thread_proxy.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/components/exo/surface_unittest.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/components/viz/common/BUILD.gn
[rename] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/components/viz/common/quads/draw_quad.cc
[rename] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/components/viz/common/quads/draw_quad.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/components/viz/service/display/gl_renderer.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/components/viz/service/display/skia_renderer.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/components/viz/service/display/surface_aggregator.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/components/viz/service/display/surface_aggregator.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/components/viz/service/surfaces/surface_hittest.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/components/viz/service/surfaces/surface_hittest.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/services/viz/public/cpp/compositing/quads_struct_traits.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/services/viz/public/cpp/compositing/quads_struct_traits.h
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/services/viz/public/cpp/compositing/render_pass.typemap
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/services/viz/public/cpp/compositing/render_pass_struct_traits.cc
[modify] https://crrev.com/1a010682ccfe0dd6654cf65091dbd8d8cab15b1b/services/viz/public/cpp/compositing/struct_traits_unittest.cc

Project Member

Comment 128 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15c96cdf8dd836f7198c629945f9dfac1d12d6c0

commit 15c96cdf8dd836f7198c629945f9dfac1d12d6c0
Author: Saman Sami <samans@chromium.org>
Date: Thu Sep 07 20:21:01 2017

viz: Move CopyOutputResult's and TextureMailbox's mojom to services/viz

TBR=reveman@chromium.org,yzshen@chromium.org


Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I48a959d9bf57743b04f85da0997d3bc812ee81fe
Reviewed-on: https://chromium-review.googlesource.com/653039
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500368}
[modify] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/cc/BUILD.gn
[modify] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/cc/ipc/BUILD.gn
[delete] https://crrev.com/e3f1cce3d4d5e89a2cc8ff864217fc66e4a4a96a/cc/ipc/copy_output_result.typemap
[delete] https://crrev.com/e3f1cce3d4d5e89a2cc8ff864217fc66e4a4a96a/cc/ipc/struct_traits_unittest.cc
[delete] https://crrev.com/e3f1cce3d4d5e89a2cc8ff864217fc66e4a4a96a/cc/ipc/texture_mailbox.typemap
[delete] https://crrev.com/e3f1cce3d4d5e89a2cc8ff864217fc66e4a4a96a/cc/ipc/traits_test_service.mojom
[delete] https://crrev.com/e3f1cce3d4d5e89a2cc8ff864217fc66e4a4a96a/cc/ipc/typemaps.gni
[modify] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/components/exo/BUILD.gn
[modify] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/components/viz/client/BUILD.gn
[modify] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/components/viz/common/quads/texture_mailbox.h
[modify] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/components/viz/host/BUILD.gn
[modify] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/components/viz/service/BUILD.gn
[modify] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/content/test/BUILD.gn
[modify] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/mojo/public/tools/bindings/chromium_bindings_configuration.gni
[modify] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/services/ui/gpu/interfaces/BUILD.gn
[modify] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/services/ui/public/interfaces/BUILD.gn
[modify] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/services/ui/ws/BUILD.gn
[modify] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/services/viz/privileged/interfaces/compositing/BUILD.gn
[modify] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/services/viz/public/cpp/compositing/compositor_frame_for_blink.typemap
[modify] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/services/viz/public/cpp/compositing/copy_output_request_struct_traits.cc
[modify] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/services/viz/public/cpp/compositing/copy_output_request_struct_traits.h
[add] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/services/viz/public/cpp/compositing/copy_output_result.typemap
[rename] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/services/viz/public/cpp/compositing/copy_output_result_struct_traits.cc
[rename] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/services/viz/public/cpp/compositing/copy_output_result_struct_traits.h
[modify] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[add] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/services/viz/public/cpp/compositing/texture_mailbox.typemap
[rename] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/services/viz/public/cpp/compositing/texture_mailbox_struct_traits.h
[modify] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/services/viz/public/cpp/compositing/typemaps.gni
[modify] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/services/viz/public/interfaces/BUILD.gn
[modify] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/services/viz/public/interfaces/compositing/copy_output_request.mojom
[rename] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/services/viz/public/interfaces/compositing/copy_output_result.mojom
[rename] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/services/viz/public/interfaces/compositing/texture_mailbox.mojom
[rename] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/services/viz/public/interfaces/compositing/texture_mailbox_releaser.mojom
[modify] https://crrev.com/15c96cdf8dd836f7198c629945f9dfac1d12d6c0/third_party/WebKit/public/BUILD.gn

Blockedon: 763377
Project Member

Comment 130 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edb4eb896d37067f4f1e8a67c7ac61732dc070f0

commit edb4eb896d37067f4f1e8a67c7ac61732dc070f0
Author: Alex Zhang <staraz@chromium.org>
Date: Thu Sep 14 19:48:19 2017

Move VulkanRenderer to components/viz/service/display

This CL moves VulkanRenderer to components/viz/service/display.

Includes and namespaces are updated.

Note that VulkanRenderer is not used in any build or tests. I found that the
methods overriding DirectRenderer are out-of-date. I changed them so they are
up to date with the current DirectRenderer. Without being in any compiling
process, I suspect that it will be forgotten when DirectRenderer is changed the
next time.

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I012c4b70aa346dbe7153d9664ec620f75f57a4c4
Reviewed-on: https://chromium-review.googlesource.com/658061
Commit-Queue: Xingyu Zhang <staraz@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502021}
[modify] https://crrev.com/edb4eb896d37067f4f1e8a67c7ac61732dc070f0/cc/BUILD.gn
[modify] https://crrev.com/edb4eb896d37067f4f1e8a67c7ac61732dc070f0/components/viz/service/BUILD.gn
[modify] https://crrev.com/edb4eb896d37067f4f1e8a67c7ac61732dc070f0/components/viz/service/display/display.cc
[rename] https://crrev.com/edb4eb896d37067f4f1e8a67c7ac61732dc070f0/components/viz/service/display/vulkan_renderer.cc
[rename] https://crrev.com/edb4eb896d37067f4f1e8a67c7ac61732dc070f0/components/viz/service/display/vulkan_renderer.h

Project Member

Comment 131 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4

commit f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4
Author: Alex Zhang <staraz@chromium.org>
Date: Fri Sep 15 13:23:56 2017

Move TextureMailboxDeleter to components/viz/service/display

All includes, namespaces and forward declarations are updated.

TBR=boliu@chromium.org, sadrul@chromium.org

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I9ba89fd5976954f233baf2bafd06179712d2857c
Reviewed-on: https://chromium-review.googlesource.com/655181
Commit-Queue: Xingyu Zhang <staraz@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502239}
[modify] https://crrev.com/f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4/android_webview/browser/surfaces_instance.cc
[modify] https://crrev.com/f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4/cc/BUILD.gn
[delete] https://crrev.com/ae7265ca4bbe7bce5d1f13d8856ec06513883813/cc/output/texture_mailbox_deleter.h
[modify] https://crrev.com/f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4/cc/test/pixel_test.cc
[modify] https://crrev.com/f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4/cc/test/pixel_test.h
[modify] https://crrev.com/f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4/components/viz/service/BUILD.gn
[modify] https://crrev.com/f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4/components/viz/service/display/display.cc
[modify] https://crrev.com/f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4/components/viz/service/display/display.h
[modify] https://crrev.com/f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4/components/viz/service/display/display_unittest.cc
[modify] https://crrev.com/f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4/components/viz/service/display/gl_renderer.h
[modify] https://crrev.com/f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4/components/viz/service/display/gl_renderer_unittest.cc
[rename] https://crrev.com/f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4/components/viz/service/display/texture_mailbox_deleter.cc
[add] https://crrev.com/f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4/components/viz/service/display/texture_mailbox_deleter.h
[rename] https://crrev.com/f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4/components/viz/service/display/texture_mailbox_deleter_unittest.cc
[modify] https://crrev.com/f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4/components/viz/service/display_embedder/gpu_display_provider.cc
[modify] https://crrev.com/f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4/components/viz/service/frame_sinks/direct_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4/components/viz/test/test_layer_tree_frame_sink.cc
[modify] https://crrev.com/f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4/content/renderer/android/synchronous_layer_tree_frame_sink.cc
[modify] https://crrev.com/f8c6f0ed63fc0690b4ed94e002d55bbb9b0744f4/ui/compositor/test/in_process_context_factory.cc

Project Member

Comment 132 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5805be80705ef083ec6b113b27470c04fa239f6

commit e5805be80705ef083ec6b113b27470c04fa239f6
Author: danakj <danakj@chromium.org>
Date: Fri Sep 15 19:24:55 2017

Move DrawQuads to components/viz/

These classes are part of the CompositorFrame shipped over IPC to the viz service and
should be in components/viz/common. This moves all subclasses of viz::DrawQuad from
cc/quads to components/viz/common/quads, and updates headers and namespaces throughout
chromium.

TBR=jam

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ib7ce371cc78304b9147c319987d2d582f3b56978
Reviewed-on: https://chromium-review.googlesource.com/667539
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502329}
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/android_webview/browser/surfaces_instance.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/android_webview/browser/surfaces_instance.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/android_webview/browser/test/rendering_test.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/ash/fast_ink/fast_ink_view.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/ash/mus/non_client_frame_controller_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/ash/test/ash_test_suite.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/BUILD.gn
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/ipc/cc_param_traits.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/ipc/cc_param_traits.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/ipc/cc_param_traits_macros.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/ipc/cc_param_traits_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/ipc/cc_serialization_perftest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/heads_up_display_layer_impl.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/heads_up_display_layer_impl.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/heads_up_display_layer_impl_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/layer_impl.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/layer_impl.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/nine_patch_layer_impl.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/nine_patch_layer_impl.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/nine_patch_layer_impl_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/painted_overlay_scrollbar_layer_impl.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/painted_overlay_scrollbar_layer_impl.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/painted_scrollbar_layer_impl.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/painted_scrollbar_layer_impl.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/painted_scrollbar_layer_impl_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/picture_layer_impl.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/picture_layer_impl.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/picture_layer_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/render_surface_impl.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/render_surface_impl.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/render_surface_impl_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/render_surface_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/scrollbar_layer_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/solid_color_layer_impl.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/solid_color_layer_impl.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/solid_color_layer_impl_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/solid_color_scrollbar_layer_impl.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/solid_color_scrollbar_layer_impl.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/surface_layer_impl.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/surface_layer_impl.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/surface_layer_impl_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/texture_layer_impl.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/texture_layer_impl.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/texture_layer_impl_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/ui_resource_layer_impl.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/ui_resource_layer_impl.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/ui_resource_layer_impl_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/video_layer_impl.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/video_layer_impl.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/layers/video_layer_impl_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/ca_layer_overlay.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/ca_layer_overlay.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/compositor_frame.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/compositor_frame.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/dc_layer_overlay.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/dc_layer_overlay.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/direct_renderer.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/direct_renderer.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/overlay_candidate.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/overlay_candidate.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/overlay_processor.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/overlay_processor.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/overlay_strategy_fullscreen.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/overlay_strategy_fullscreen.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/overlay_strategy_single_on_top.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/overlay_strategy_single_on_top.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/overlay_strategy_underlay.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/overlay_strategy_underlay.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/overlay_strategy_underlay_cast.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/overlay_strategy_underlay_cast.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/overlay_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/renderer_pixeltest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/software_renderer.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/software_renderer.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/output/software_renderer_unittest.cc
[delete] https://crrev.com/2867b7c20908aaf3ff93fc987166422dfa246949/cc/quads/debug_border_draw_quad.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/quads/draw_quad_perftest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/quads/draw_quad_unittest.cc
[delete] https://crrev.com/2867b7c20908aaf3ff93fc987166422dfa246949/cc/quads/largest_draw_quad.cc
[delete] https://crrev.com/2867b7c20908aaf3ff93fc987166422dfa246949/cc/quads/largest_draw_quad.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/quads/nine_patch_generator.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/quads/nine_patch_generator.h
[delete] https://crrev.com/2867b7c20908aaf3ff93fc987166422dfa246949/cc/quads/picture_draw_quad.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/quads/render_pass_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/test/fake_picture_layer_impl.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/test/fake_picture_layer_impl.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/test/layer_test_common.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/test/layer_test_common.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/test/layer_tree_test.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/test/pixel_test.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/test/pixel_test.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/test/render_pass_test_utils.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/test/render_pass_test_utils.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/test/test_hooks.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/trees/layer_tree_host_unittest_copyrequest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/exo/surface.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/exo/surface_tree_host.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/exo/surface_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/BUILD.gn
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/DEPS
[rename] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/content_draw_quad_base.cc
[rename] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/content_draw_quad_base.h
[rename] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/debug_border_draw_quad.cc
[add] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/debug_border_draw_quad.h
[add] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/largest_draw_quad.cc
[add] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/largest_draw_quad.h
[add] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/picture_draw_quad.cc
[rename] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/picture_draw_quad.h
[rename] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/render_pass.cc
[rename] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/render_pass.h
[rename] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/render_pass_draw_quad.cc
[rename] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/render_pass_draw_quad.h
[rename] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/solid_color_draw_quad.cc
[rename] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/solid_color_draw_quad.h
[rename] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/stream_video_draw_quad.cc
[rename] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/stream_video_draw_quad.h
[rename] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/surface_draw_quad.cc
[rename] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/surface_draw_quad.h
[rename] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/texture_draw_quad.cc
[rename] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/texture_draw_quad.h
[rename] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/tile_draw_quad.cc
[rename] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/tile_draw_quad.h
[rename] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/yuv_video_draw_quad.cc
[rename] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/common/quads/yuv_video_draw_quad.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/display/display_client.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/display/display_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/display/gl_renderer.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/display/gl_renderer_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/display/skia_renderer.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/display/surface_aggregator.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/display/surface_aggregator.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/display/surface_aggregator_perftest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/display/surface_aggregator_pixeltest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/frame_sinks/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/frame_sinks/direct_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/surfaces/surface.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/surfaces/surface_hittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/surfaces/surface_hittest.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/surfaces/surface_hittest_delegate.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/surfaces/surface_hittest_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/service/surfaces/surface_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/test/compositor_frame_helpers.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/test/surface_hittest_test_helpers.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/test/surface_hittest_test_helpers.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/test/test_layer_tree_frame_sink.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/components/viz/test/test_layer_tree_frame_sink.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/content/browser/renderer_host/browser_compositor_view_mac.mm
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/content/browser/renderer_host/offscreen_canvas_provider_impl_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/content/browser/renderer_host/render_widget_host_input_event_router.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/content/browser/renderer_host/render_widget_host_input_event_router.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/content/browser/renderer_host/render_widget_host_view_child_frame_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/content/renderer/android/synchronous_layer_tree_frame_sink.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/content/renderer/android/synchronous_layer_tree_frame_sink.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/content/test/layouttest_support.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/services/ui/ws/frame_generator.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/services/ui/ws/frame_generator.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/services/ui/ws/frame_generator_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/services/ui/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/services/viz/public/cpp/compositing/compositor_frame_struct_traits.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/services/viz/public/cpp/compositing/quads_struct_traits.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/services/viz/public/cpp/compositing/quads_struct_traits.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/services/viz/public/cpp/compositing/render_pass.typemap
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/services/viz/public/cpp/compositing/render_pass_struct_traits.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/services/viz/public/cpp/compositing/render_pass_struct_traits.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/services/viz/public/interfaces/compositing/render_pass.mojom
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/third_party/WebKit/Source/platform/graphics/VideoFrameResourceProvider.cpp
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/third_party/WebKit/Source/platform/graphics/VideoFrameResourceProvider.h
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitter.cpp
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/tools/ipc_fuzzer/fuzzer/fuzzer.cc
[modify] https://crrev.com/e5805be80705ef083ec6b113b27470c04fa239f6/ui/android/delegated_frame_host_android.cc

Project Member

Comment 133 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69071425d6201343aaf5a57493dbbe67f7cdbc81

commit 69071425d6201343aaf5a57493dbbe67f7cdbc81
Author: danakj <danakj@chromium.org>
Date: Fri Sep 15 23:04:12 2017

Move the DrawQuad unittests to components/viz/common

The DrawQuad structs are all there now, put the tests where the
production code is.

R=vmpstr@chromium.org

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib151d25a7cacf233271a5b644c61ad99b30ddaf4
Reviewed-on: https://chromium-review.googlesource.com/667898
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502425}
[modify] https://crrev.com/69071425d6201343aaf5a57493dbbe67f7cdbc81/cc/BUILD.gn
[modify] https://crrev.com/69071425d6201343aaf5a57493dbbe67f7cdbc81/components/viz/BUILD.gn
[modify] https://crrev.com/69071425d6201343aaf5a57493dbbe67f7cdbc81/components/viz/common/BUILD.gn
[modify] https://crrev.com/69071425d6201343aaf5a57493dbbe67f7cdbc81/components/viz/common/quads/DEPS
[rename] https://crrev.com/69071425d6201343aaf5a57493dbbe67f7cdbc81/components/viz/common/quads/draw_quad_perftest.cc
[rename] https://crrev.com/69071425d6201343aaf5a57493dbbe67f7cdbc81/components/viz/common/quads/draw_quad_unittest.cc

Blocking: -732396
Project Member

Comment 135 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83d0eb4f472008e5a61b49c965f8c5c73a8886e0

commit 83d0eb4f472008e5a61b49c965f8c5c73a8886e0
Author: danakj <danakj@chromium.org>
Date: Tue Sep 19 17:31:58 2017

Remove the cc/quads/ directory.

The RenderPass unit tests move to viz/common. The nine patch generator
is used from layers making nine patch quads, so it moves to cc/layers/
and the DrawPolygon was actually part of the BSP rendering in
DirectRenderer so it moves to cc/output/.

R=vmpstr@chromium.org
NOTRY=true

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic2fabf8f112a3a9934b8716cdbae5823a3b91775
Reviewed-on: https://chromium-review.googlesource.com/668664
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502878}
[modify] https://crrev.com/83d0eb4f472008e5a61b49c965f8c5c73a8886e0/cc/BUILD.gn
[rename] https://crrev.com/83d0eb4f472008e5a61b49c965f8c5c73a8886e0/cc/layers/nine_patch_generator.cc
[rename] https://crrev.com/83d0eb4f472008e5a61b49c965f8c5c73a8886e0/cc/layers/nine_patch_generator.h
[rename] https://crrev.com/83d0eb4f472008e5a61b49c965f8c5c73a8886e0/cc/layers/nine_patch_generator_unittest.cc
[modify] https://crrev.com/83d0eb4f472008e5a61b49c965f8c5c73a8886e0/cc/layers/nine_patch_layer_impl.h
[modify] https://crrev.com/83d0eb4f472008e5a61b49c965f8c5c73a8886e0/cc/layers/painted_overlay_scrollbar_layer_impl.h
[modify] https://crrev.com/83d0eb4f472008e5a61b49c965f8c5c73a8886e0/cc/output/bsp_tree.cc
[modify] https://crrev.com/83d0eb4f472008e5a61b49c965f8c5c73a8886e0/cc/output/bsp_tree.h
[modify] https://crrev.com/83d0eb4f472008e5a61b49c965f8c5c73a8886e0/cc/output/bsp_tree_perftest.cc
[modify] https://crrev.com/83d0eb4f472008e5a61b49c965f8c5c73a8886e0/cc/output/bsp_tree_unittest.cc
[modify] https://crrev.com/83d0eb4f472008e5a61b49c965f8c5c73a8886e0/cc/output/bsp_walk_action.cc
[modify] https://crrev.com/83d0eb4f472008e5a61b49c965f8c5c73a8886e0/cc/output/bsp_walk_action.h
[rename] https://crrev.com/83d0eb4f472008e5a61b49c965f8c5c73a8886e0/cc/output/draw_polygon.cc
[rename] https://crrev.com/83d0eb4f472008e5a61b49c965f8c5c73a8886e0/cc/output/draw_polygon.h
[rename] https://crrev.com/83d0eb4f472008e5a61b49c965f8c5c73a8886e0/cc/output/draw_polygon_unittest.cc
[modify] https://crrev.com/83d0eb4f472008e5a61b49c965f8c5c73a8886e0/components/viz/common/BUILD.gn
[rename] https://crrev.com/83d0eb4f472008e5a61b49c965f8c5c73a8886e0/components/viz/common/quads/render_pass_unittest.cc
[modify] https://crrev.com/83d0eb4f472008e5a61b49c965f8c5c73a8886e0/components/viz/service/display/DEPS
[modify] https://crrev.com/83d0eb4f472008e5a61b49c965f8c5c73a8886e0/components/viz/service/display/gl_renderer.cc

Project Member

Comment 136 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d162e1b3049bb8bae707936ca1afd2de4fcab87

commit 0d162e1b3049bb8bae707936ca1afd2de4fcab87
Author: danakj <danakj@chromium.org>
Date: Tue Sep 19 17:44:09 2017

Move cc::SoftwareRenderer to viz:: display service.

This is part of the display compositor so belongs in viz not with the
cc layer compositor.

R=staraz@chromium.org

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie8c19de1350375de05172c46b50c816f5d095de6
Reviewed-on: https://chromium-review.googlesource.com/668956
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Xingyu Zhang <staraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502882}
[modify] https://crrev.com/0d162e1b3049bb8bae707936ca1afd2de4fcab87/cc/BUILD.gn
[modify] https://crrev.com/0d162e1b3049bb8bae707936ca1afd2de4fcab87/cc/output/renderer_pixeltest.cc
[modify] https://crrev.com/0d162e1b3049bb8bae707936ca1afd2de4fcab87/cc/test/pixel_test.cc
[modify] https://crrev.com/0d162e1b3049bb8bae707936ca1afd2de4fcab87/cc/test/pixel_test.h
[modify] https://crrev.com/0d162e1b3049bb8bae707936ca1afd2de4fcab87/components/viz/service/BUILD.gn
[modify] https://crrev.com/0d162e1b3049bb8bae707936ca1afd2de4fcab87/components/viz/service/display/display.cc
[modify] https://crrev.com/0d162e1b3049bb8bae707936ca1afd2de4fcab87/components/viz/service/display/display.h
[rename] https://crrev.com/0d162e1b3049bb8bae707936ca1afd2de4fcab87/components/viz/service/display/software_renderer.cc
[rename] https://crrev.com/0d162e1b3049bb8bae707936ca1afd2de4fcab87/components/viz/service/display/software_renderer.h
[rename] https://crrev.com/0d162e1b3049bb8bae707936ca1afd2de4fcab87/components/viz/service/display/software_renderer_unittest.cc

Project Member

Comment 137 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e905a76d1a9123701075e0bcf6075e3f78d523c

commit 3e905a76d1a9123701075e0bcf6075e3f78d523c
Author: danakj <danakj@chromium.org>
Date: Tue Sep 19 20:26:06 2017

Move DirectRenderer and BspTree pieces from cc to viz.

These are part of the viz display service, not the cc layer compositor,
so move them from cc/output to components/viz/service/display.

NOTRY=true

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I72f79828cf353e3d5edbec68b3436806456b05d3
Reviewed-on: https://chromium-review.googlesource.com/669007
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Xingyu Zhang <staraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502937}
[modify] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/cc/BUILD.gn
[modify] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/cc/DEPS
[delete] https://crrev.com/e494fc874f455309c9b025727b40a837bf713971/cc/output/DEPS
[delete] https://crrev.com/e494fc874f455309c9b025727b40a837bf713971/cc/output/bsp_compare_result.h
[modify] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/cc/output/overlay_unittest.cc
[delete] https://crrev.com/e494fc874f455309c9b025727b40a837bf713971/cc/resources/DEPS
[modify] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/cc/test/pixel_test.h
[delete] https://crrev.com/e494fc874f455309c9b025727b40a837bf713971/cc/trees/DEPS
[modify] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/cc/trees/layer_tree_host_unittest_copyrequest.cc
[modify] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/components/viz/service/BUILD.gn
[add] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/components/viz/service/display/bsp_compare_result.h
[rename] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/components/viz/service/display/bsp_tree.cc
[rename] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/components/viz/service/display/bsp_tree.h
[rename] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/components/viz/service/display/bsp_tree_perftest.cc
[rename] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/components/viz/service/display/bsp_tree_unittest.cc
[rename] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/components/viz/service/display/bsp_walk_action.cc
[rename] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/components/viz/service/display/bsp_walk_action.h
[rename] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/components/viz/service/display/direct_renderer.cc
[rename] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/components/viz/service/display/direct_renderer.h
[modify] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/components/viz/service/display/display.cc
[modify] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/components/viz/service/display/display.h
[rename] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/components/viz/service/display/draw_polygon.cc
[rename] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/components/viz/service/display/draw_polygon.h
[rename] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/components/viz/service/display/draw_polygon_unittest.cc
[modify] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/components/viz/service/display/gl_renderer.h
[modify] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/components/viz/service/display/skia_renderer.h
[modify] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/components/viz/service/display/software_renderer.h
[modify] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/components/viz/service/display/vulkan_renderer.cc
[modify] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/components/viz/service/display/vulkan_renderer.h
[modify] https://crrev.com/3e905a76d1a9123701075e0bcf6075e3f78d523c/components/viz/test/test_layer_tree_frame_sink.cc

Project Member

Comment 138 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f

commit 6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f
Author: danakj <danakj@chromium.org>
Date: Tue Sep 19 22:04:23 2017

Move OutputSurface and Overlay code from cc to viz/services/display.

The OutputSurface is the API for dependency injection into the viz
service display compositor, and the overlay code is used by the
display compositor implementation. So these belong in the viz component
instead of cc.

The OverlayCandidate was left in cc/output/ for now because the
DisplayResourceProvider uses it which is in cc still, so we have to
move that first.

TBR=jam

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I92ab5421687ef0c3d2f3feb8f5672d813af712e9
Reviewed-on: https://chromium-review.googlesource.com/669640
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502965}
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/android_webview/browser/parent_output_surface.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/android_webview/browser/parent_output_surface.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/ash/test/ash_test_suite.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/cc/BUILD.gn
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/cc/blink/web_compositor_support_impl.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/cc/layers/texture_layer_impl.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/cc/layers/video_layer_impl_unittest.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/cc/output/layer_tree_frame_sink.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/cc/output/overlay_candidate.h
[delete] https://crrev.com/9278b89f274a38f82683ffe3eb51e7ffc56693fa/cc/output/overlay_strategy_fullscreen.h
[delete] https://crrev.com/9278b89f274a38f82683ffe3eb51e7ffc56693fa/cc/output/overlay_strategy_single_on_top.h
[delete] https://crrev.com/9278b89f274a38f82683ffe3eb51e7ffc56693fa/cc/output/overlay_strategy_underlay.h
[delete] https://crrev.com/9278b89f274a38f82683ffe3eb51e7ffc56693fa/cc/output/overlay_strategy_underlay_cast.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/cc/test/fake_output_surface.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/cc/test/fake_output_surface.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/cc/test/fake_output_surface_client.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/cc/test/layer_tree_pixel_test.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/cc/test/layer_tree_pixel_test.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/cc/test/layer_tree_test.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/cc/test/layer_tree_test.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/cc/test/pixel_test.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/cc/test/pixel_test.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/cc/test/pixel_test_output_surface.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/cc/test/pixel_test_output_surface.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/cc/test/test_hooks.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/cc/trees/layer_tree_host_unittest_copyrequest.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/exo/wayland/clients/client_base.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/BUILD.gn
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/DEPS
[rename] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/ca_layer_overlay.cc
[rename] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/ca_layer_overlay.h
[rename] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/dc_layer_overlay.cc
[rename] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/dc_layer_overlay.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/direct_renderer.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/direct_renderer.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/display.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/display.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/display_scheduler.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/display_unittest.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/gl_renderer.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/gl_renderer_unittest.cc
[rename] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/output_surface.cc
[rename] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/output_surface.h
[rename] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/output_surface_client.h
[rename] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/overlay_candidate_validator.h
[rename] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/overlay_processor.cc
[rename] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/overlay_processor.h
[rename] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/overlay_strategy_fullscreen.cc
[add] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/overlay_strategy_fullscreen.h
[rename] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/overlay_strategy_single_on_top.cc
[add] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/overlay_strategy_single_on_top.h
[rename] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/overlay_strategy_underlay.cc
[add] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/overlay_strategy_underlay.h
[rename] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/overlay_strategy_underlay_cast.cc
[add] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/overlay_strategy_underlay_cast.h
[rename] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/overlay_unittest.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/skia_renderer.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/software_renderer.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/software_renderer.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/vulkan_renderer.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display/vulkan_renderer.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display_embedder/compositor_overlay_candidate_validator.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display_embedder/compositor_overlay_candidate_validator_android.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display_embedder/compositor_overlay_candidate_validator_android.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display_embedder/compositor_overlay_candidate_validator_mac.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display_embedder/compositor_overlay_candidate_validator_mac.mm
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display_embedder/compositor_overlay_candidate_validator_ozone.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display_embedder/compositor_overlay_candidate_validator_ozone.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display_embedder/compositor_overlay_candidate_validator_win.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display_embedder/compositor_overlay_candidate_validator_win.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display_embedder/display_output_surface.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display_embedder/display_output_surface.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display_embedder/display_output_surface_ozone.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display_embedder/display_output_surface_ozone.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/service/display_embedder/gpu_display_provider.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/test/test_layer_tree_frame_sink.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/components/viz/test/test_layer_tree_frame_sink.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/content/browser/compositor/browser_compositor_output_surface.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/content/browser/compositor/browser_compositor_output_surface.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/content/browser/compositor/gpu_browser_compositor_output_surface.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/content/browser/compositor/gpu_browser_compositor_output_surface.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/content/browser/compositor/gpu_output_surface_mac.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/content/browser/compositor/gpu_output_surface_mac.mm
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/content/browser/compositor/offscreen_browser_compositor_output_surface.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/content/browser/compositor/offscreen_browser_compositor_output_surface.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/content/browser/compositor/reflector_impl_unittest.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/content/browser/compositor/software_browser_compositor_output_surface.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/content/browser/compositor/software_browser_compositor_output_surface.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/content/browser/compositor/vulkan_browser_compositor_output_surface.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/content/browser/compositor/vulkan_browser_compositor_output_surface.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/content/browser/renderer_host/compositor_impl_android.h
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/content/renderer/android/synchronous_layer_tree_frame_sink.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/content/test/layouttest_support.cc
[modify] https://crrev.com/6f91dde5f828c3a5e1c9e01eecd8f2e2b4789f6f/ui/compositor/test/in_process_context_factory.cc

Project Member

Comment 139 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba65a0916a9778a03a3376ca7248da22da6403ba

commit ba65a0916a9778a03a3376ca7248da22da6403ba
Author: danakj <danakj@chromium.org>
Date: Thu Sep 21 16:38:42 2017

Move cc/output things that are part of layer compositor API to cc/trees

These are things used in the cc/trees classes, so put them there.

R=enne@chromium.org
TBR=jam

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ifb215909e1ce4c6e1687240634085088d02c541b
Reviewed-on: https://chromium-review.googlesource.com/676227
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503469}
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/android_webview/browser/aw_render_thread_context_provider.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/ash/fast_ink/fast_ink_view.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/ash/fast_ink/fast_ink_view.h
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/BUILD.gn
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/layers/surface_layer.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/layers/texture_layer_impl_unittest.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/test/fake_layer_tree_frame_sink.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/test/fake_layer_tree_frame_sink.h
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/test/fake_layer_tree_frame_sink_client.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/test/fake_layer_tree_frame_sink_client.h
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/test/layer_tree_pixel_resource_test.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/test/test_layer_tree_host_base.h
[rename] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/latency_info_swap_promise.cc
[rename] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/latency_info_swap_promise.h
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/latency_info_swap_promise_monitor.cc
[rename] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/layer_tree_frame_sink.cc
[rename] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/layer_tree_frame_sink.h
[rename] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/layer_tree_frame_sink_client.h
[rename] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/layer_tree_host.h
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/layer_tree_settings.h
[rename] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/managed_memory_policy.cc
[rename] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/managed_memory_policy.h
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/proxy_impl.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/proxy_main.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/scoped_abort_remaining_swap_promises.h
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/single_thread_proxy.cc
[rename] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/swap_promise.h
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/swap_promise_manager.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/cc/trees/swap_promise_manager.h
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/components/exo/layer_tree_frame_sink_holder.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/components/exo/layer_tree_frame_sink_holder.h
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/components/exo/shell_surface.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/components/exo/surface.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/components/exo/surface_tree_host.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/components/viz/client/client_layer_tree_frame_sink.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/components/viz/client/client_layer_tree_frame_sink.h
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/components/viz/test/test_layer_tree_frame_sink.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/components/viz/test/test_layer_tree_frame_sink.h
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/content/renderer/android/synchronous_layer_tree_frame_sink.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/content/renderer/android/synchronous_layer_tree_frame_sink.h
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/content/renderer/gpu/frame_swap_message_queue.h
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/content/renderer/gpu/queue_message_swap_promise.h
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/content/renderer/gpu/queue_message_swap_promise_unittest.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/content/renderer/gpu/render_widget_compositor.h
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/content/renderer/render_widget.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/services/ui/public/cpp/gpu/context_provider_command_buffer.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/third_party/WebKit/public/platform/WebLayerTreeView.h
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/ui/aura/DEPS
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/ui/aura/local/layer_tree_frame_sink_local.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/ui/aura/local/layer_tree_frame_sink_local.h
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/ui/aura/mus/DEPS
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/ui/aura/window.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/ui/aura/window_port_for_shutdown.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/ui/aura/window_unittest.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/ui/compositor/compositor.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/ui/compositor/test/fake_context_factory.cc
[modify] https://crrev.com/ba65a0916a9778a03a3376ca7248da22da6403ba/ui/compositor/test/in_process_context_provider.cc

Project Member

Comment 140 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d248b338cfcc86f87d94ce82f84f96e4e573ca3c

commit d248b338cfcc86f87d94ce82f84f96e4e573ca3c
Author: danakj <danakj@chromium.org>
Date: Thu Sep 21 17:11:14 2017

Move OutputSurfaceFrame to the viz service.

This class is an output of the viz display compositor, so move it
there.

R=enne@chromium.org
TBR=boliu

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib7047bbed87cb5d669e1155d269b47927a76905c
Reviewed-on: https://chromium-review.googlesource.com/676175
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503482}
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/android_webview/browser/parent_output_surface.cc
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/android_webview/browser/parent_output_surface.h
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/cc/BUILD.gn
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/cc/test/fake_output_surface.cc
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/cc/test/fake_output_surface.h
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/cc/test/pixel_test_output_surface.cc
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/cc/test/pixel_test_output_surface.h
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/components/viz/service/BUILD.gn
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/components/viz/service/display/gl_renderer_unittest.cc
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/components/viz/service/display/output_surface.cc
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/components/viz/service/display/output_surface.h
[rename] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/components/viz/service/display/output_surface_frame.cc
[rename] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/components/viz/service/display/output_surface_frame.h
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/components/viz/service/display/overlay_unittest.cc
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/components/viz/service/display/software_renderer.cc
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/components/viz/service/display/vulkan_renderer.cc
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/components/viz/service/display_embedder/display_output_surface.cc
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/components/viz/service/display_embedder/display_output_surface.h
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/components/viz/service/display_embedder/display_output_surface_ozone.cc
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/components/viz/service/display_embedder/display_output_surface_ozone.h
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/content/browser/compositor/gpu_browser_compositor_output_surface.cc
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/content/browser/compositor/gpu_browser_compositor_output_surface.h
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/content/browser/compositor/gpu_output_surface_mac.h
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/content/browser/compositor/gpu_output_surface_mac.mm
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/content/browser/compositor/offscreen_browser_compositor_output_surface.cc
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/content/browser/compositor/offscreen_browser_compositor_output_surface.h
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/content/browser/compositor/reflector_impl_unittest.cc
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/content/browser/compositor/software_browser_compositor_output_surface.cc
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/content/browser/compositor/software_browser_compositor_output_surface.h
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/content/browser/compositor/vulkan_browser_compositor_output_surface.cc
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/content/browser/compositor/vulkan_browser_compositor_output_surface.h
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/content/renderer/android/synchronous_layer_tree_frame_sink.cc
[modify] https://crrev.com/d248b338cfcc86f87d94ce82f84f96e4e573ca3c/ui/compositor/test/in_process_context_factory.cc

Project Member

Comment 141 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d27356f932a3c9b028c8d0ce9a2af55d727c9a9f

commit d27356f932a3c9b028c8d0ce9a2af55d727c9a9f
Author: danakj <danakj@chromium.org>
Date: Thu Sep 21 17:40:05 2017

cc: Move renderer_pixeltest to components/viz/service/display.

This is a test for the GL and Software renderers located in the
viz display compositor, put the test beside them.

R=enne@chromium.org

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ifbfa54ebbf7dce69f1fcfd0379762aa18b00dd13
Reviewed-on: https://chromium-review.googlesource.com/676303
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503496}
[modify] https://crrev.com/d27356f932a3c9b028c8d0ce9a2af55d727c9a9f/cc/BUILD.gn
[modify] https://crrev.com/d27356f932a3c9b028c8d0ce9a2af55d727c9a9f/components/viz/service/BUILD.gn
[rename] https://crrev.com/d27356f932a3c9b028c8d0ce9a2af55d727c9a9f/components/viz/service/display/renderer_pixeltest.cc

Project Member

Comment 142 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4

commit f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4
Author: danakj <danakj@chromium.org>
Date: Thu Sep 21 18:07:54 2017

Move SoftwareOutputDevice to the viz service display compositor.

This interface is used to inject a software backbuffer into the display
compositor, so it should live in the display compositor.

R=enne@chromium.org
TBR=qinmin@chromium.org

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I25caaa777a8815a53f85616bb6886993a044ca9d
Reviewed-on: https://chromium-review.googlesource.com/677463
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503507}
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/cc/BUILD.gn
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/cc/test/fake_layer_tree_frame_sink.h
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/cc/test/fake_output_surface.cc
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/cc/test/fake_output_surface.h
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/cc/test/layer_tree_pixel_test.cc
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/cc/test/pixel_test.cc
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/cc/test/pixel_test_output_surface.cc
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/cc/test/pixel_test_output_surface.h
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/cc/trees/layer_tree_host_unittest_copyrequest.cc
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/components/viz/service/BUILD.gn
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/components/viz/service/display/display_unittest.cc
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/components/viz/service/display/output_surface.cc
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/components/viz/service/display/output_surface.h
[rename] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/components/viz/service/display/software_output_device.cc
[rename] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/components/viz/service/display/software_output_device.h
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/components/viz/service/display/software_renderer.cc
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/components/viz/service/display/software_renderer.h
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/components/viz/service/display/software_renderer_unittest.cc
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/content/browser/compositor/browser_compositor_output_surface.cc
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/content/browser/compositor/browser_compositor_output_surface.h
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/content/browser/compositor/gpu_process_transport_factory.h
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/content/browser/compositor/software_browser_compositor_output_surface.cc
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/content/browser/compositor/software_browser_compositor_output_surface.h
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/content/browser/compositor/software_output_device_mac.h
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/content/browser/compositor/software_output_device_ozone.h
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/content/browser/compositor/software_output_device_win.h
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/content/browser/compositor/software_output_device_x11.h
[modify] https://crrev.com/f75cf44a8e16dd5b40e2bf42c649e1f7a2c927b4/content/renderer/android/synchronous_layer_tree_frame_sink.cc

Project Member

Comment 143 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f007f35812054505cf0e0f987297f308f1cdc59e

commit f007f35812054505cf0e0f987297f308f1cdc59e
Author: danakj <danakj@chromium.org>
Date: Thu Sep 21 21:41:31 2017

Move context_cache_controller_unittest.cc beside the class it tests.

R=enne@chromium.org

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3d6652af46f1d1008e570b0ec1336b69f17d9878
Reviewed-on: https://chromium-review.googlesource.com/677062
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503569}
[modify] https://crrev.com/f007f35812054505cf0e0f987297f308f1cdc59e/cc/BUILD.gn
[modify] https://crrev.com/f007f35812054505cf0e0f987297f308f1cdc59e/components/viz/common/BUILD.gn
[modify] https://crrev.com/f007f35812054505cf0e0f987297f308f1cdc59e/components/viz/common/DEPS
[rename] https://crrev.com/f007f35812054505cf0e0f987297f308f1cdc59e/components/viz/common/gpu/context_cache_controller_unittest.cc

Project Member

Comment 144 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce

commit 5e0a12b98d6c47ebb479877dbc1990cec9cf0dce
Author: danakj <danakj@chromium.org>
Date: Mon Sep 25 17:26:49 2017

Move CompositorFrame{Metadata} to viz/common/quads.

The viz/common/quads/ is the data structures given to viz by clients
for display. The CompositorFrame is the root of that structure, along
with the metadata attached to it, so moves them with the quads that
appear in the structure.

Also moves cc::Selection to viz/common/quads, as it is part of the
CompositorFrame. It's possible it belongs somewhere outside of viz but
it can not live in cc.

NOTRY=true

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I59ea9d6992bb723102dadb8e5bb3c9f9537c69f8
Reviewed-on: https://chromium-review.googlesource.com/676726
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504088}
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/android_webview/browser/browser_view_renderer.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/android_webview/browser/browser_view_renderer_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/android_webview/browser/child_frame.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/android_webview/browser/child_frame.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/android_webview/browser/hardware_renderer.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/android_webview/browser/render_thread_manager.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/android_webview/browser/surfaces_instance.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/android_webview/browser/test/rendering_test.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/android_webview/browser/test/rendering_test.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/ash/fast_ink/fast_ink_view.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/ash/mus/non_client_frame_controller_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/ash/test/ash_test_suite.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/BUILD.gn
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/input/layer_selection_bound.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/ipc/cc_param_traits.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/ipc/cc_param_traits.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/ipc/cc_param_traits_macros.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/ipc/cc_param_traits_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/ipc/cc_serialization_perftest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/layers/surface_layer.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/layers/surface_layer_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/test/fake_layer_tree_frame_sink.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/test/fake_layer_tree_frame_sink.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/test/layer_tree_test.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/test/pixel_test.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/test/test_hooks.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/trees/latency_info_swap_promise.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/trees/latency_info_swap_promise.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/trees/layer_tree_frame_sink.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/trees/layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/trees/layer_tree_impl_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/trees/swap_promise.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/cc/trees/swap_promise_manager_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/exo/surface.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/exo/surface.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/exo/surface_tree_host.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/exo/surface_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/client/client_layer_tree_frame_sink.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/client/client_layer_tree_frame_sink.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/client/local_surface_id_provider.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/client/local_surface_id_provider.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/common/BUILD.gn
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/common/quads/DEPS
[rename] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/common/quads/compositor_frame.cc
[rename] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/common/quads/compositor_frame.h
[rename] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/common/quads/compositor_frame_metadata.cc
[rename] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/common/quads/compositor_frame_metadata.h
[rename] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/common/quads/selection.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/display/display.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/display/display_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/display/software_renderer_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/display/surface_aggregator.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/display/surface_aggregator.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/display/surface_aggregator_perftest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/display/surface_aggregator_pixeltest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/frame_sinks/compositor_frame_sink_impl.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/frame_sinks/compositor_frame_sink_impl.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/frame_sinks/compositor_frame_sink_support.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/frame_sinks/compositor_frame_sink_support.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/frame_sinks/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/frame_sinks/direct_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/frame_sinks/surface_synchronization_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/surfaces/surface.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/surfaces/surface.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/surfaces/surface_dependency_tracker.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/surfaces/surface_dependency_tracker.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/surfaces/surface_hittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/surfaces/surface_hittest_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/surfaces/surface_manager.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/surfaces/surface_manager.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/service/surfaces/surface_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/test/compositor_frame_helpers.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/test/compositor_frame_helpers.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/test/surface_hittest_test_helpers.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/test/surface_hittest_test_helpers.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/test/test_layer_tree_frame_sink.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/components/viz/test/test_layer_tree_frame_sink.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/android/overscroll_controller_android.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/android/overscroll_controller_android.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/android/synchronous_compositor_browser_filter.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/android/synchronous_compositor_browser_filter.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/android/synchronous_compositor_host.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/android/synchronous_compositor_host.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/devtools/devtools_frame_trace_recorder.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/devtools/devtools_frame_trace_recorder.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/devtools/protocol/input_handler.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/devtools/protocol/input_handler.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/devtools/protocol/page_handler.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/frame_host/cross_process_frame_connector.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/frame_host/render_widget_host_view_guest.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/browser_compositor_view_mac.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/browser_compositor_view_mac.mm
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/delegated_frame_host.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/frame_metadata_util.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/frame_metadata_util.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/input/touch_selection_controller_client_child_frame.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/input/touch_selection_controller_client_child_frame.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/offscreen_canvas_provider_impl_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/render_widget_host_view_base.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/render_widget_host_view_child_frame_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/common/android/sync_compositor_messages.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/common/render_widget_surface_properties.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/common/render_widget_surface_properties.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/common/view_messages.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/public/browser/android/synchronous_compositor.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/public/browser/android/synchronous_compositor.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/public/test/DEPS
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/public/test/browser_test_utils.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/public/test/test_synchronous_compositor_android.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/public/test/test_synchronous_compositor_android.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/renderer/android/synchronous_compositor_proxy.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/renderer/android/synchronous_compositor_proxy.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/renderer/android/synchronous_layer_tree_frame_sink.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/renderer/android/synchronous_layer_tree_frame_sink.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/renderer/gpu/queue_message_swap_promise.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/renderer/gpu/queue_message_swap_promise.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/renderer/gpu/queue_message_swap_promise_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/renderer/render_view_impl.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/test/layouttest_support.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/test/test_render_view_host.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/content/test/test_render_view_host.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/services/ui/ws/compositor_frame_sink_client_binding.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/services/ui/ws/compositor_frame_sink_client_binding.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/services/ui/ws/frame_generator.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/services/ui/ws/frame_generator.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/services/ui/ws/frame_generator_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/services/ui/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/services/viz/public/cpp/compositing/compositor_frame.typemap
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/services/viz/public/cpp/compositing/compositor_frame_for_blink.typemap
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/services/viz/public/cpp/compositing/compositor_frame_metadata.typemap
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/services/viz/public/cpp/compositing/compositor_frame_metadata_struct_traits.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/services/viz/public/cpp/compositing/compositor_frame_metadata_struct_traits.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/services/viz/public/cpp/compositing/compositor_frame_struct_traits.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/services/viz/public/cpp/compositing/compositor_frame_struct_traits.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/services/viz/public/cpp/compositing/selection.typemap
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/services/viz/public/cpp/compositing/selection_struct_traits.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/services/viz/public/interfaces/compositing/compositor_frame.mojom
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/services/viz/public/interfaces/compositing/compositor_frame_metadata.mojom
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/services/viz/public/interfaces/compositing/selection.mojom
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitter.cpp
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitterTest.cpp
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/tools/ipc_fuzzer/fuzzer/fuzzer.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/ui/android/delegated_frame_host_android.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/ui/aura/local/layer_tree_frame_sink_local.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/ui/aura/local/layer_tree_frame_sink_local.h
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/ui/compositor/test/fake_context_factory.cc
[modify] https://crrev.com/5e0a12b98d6c47ebb479877dbc1990cec9cf0dce/ui/compositor/test/fake_context_factory.h

Project Member

Comment 145 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f20f4502b6b3507350e0dddb15fc2b7990775f69

commit f20f4502b6b3507350e0dddb15fc2b7990775f69
Author: danakj <danakj@chromium.org>
Date: Tue Sep 26 17:13:31 2017

Move ReleaseCallbacks and CopyOutputRequests out of quads/

ReleaseCallbacks aren't part of CompositorFrames, they are for resource
management in-process, so move them to resources/.

CopyOutputRequests can be in a CompositorFrame atm, but also go to
frame sinks in other ways too, so move them up a level to frame_sinks,
along with the CopyOutputResults which are not part of a
CompositorFrame at all.

TBR=jam
NOTRY=true

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iab8d8268b13d8eb81568dbf4a0222135c4a12d57
Reviewed-on: https://chromium-review.googlesource.com/682760
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504409}
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/ash/rotator/screen_rotation_animator.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/ash/rotator/screen_rotation_animator_unittest.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/layers/layer.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/layers/layer_impl.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/layers/layer_impl_test_properties.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/layers/layer_unittest.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/layers/texture_layer.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/layers/texture_layer_client.h
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/layers/texture_layer_impl.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/layers/video_layer_impl.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/layers/video_layer_impl.h
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/resources/resource_provider.h
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/resources/resource_provider_unittest.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/resources/video_resource_updater.h
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/test/layer_test_common.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/test/layer_tree_pixel_test.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/test/layer_tree_pixel_test.h
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/test/pixel_test.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/trees/layer_tree_host_perftest.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/trees/layer_tree_host_pixeltest_readback.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/trees/layer_tree_host_pixeltest_tiles.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/trees/layer_tree_host_unittest_context.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/trees/layer_tree_host_unittest_copyrequest.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/trees/occlusion_tracker_unittest.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/trees/property_tree.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/exo/buffer.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/exo/buffer_unittest.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/exo/layer_tree_frame_sink_holder.h
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/exo/pointer.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/exo/surface.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/common/BUILD.gn
[add] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/common/frame_sinks/DEPS
[rename] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/common/frame_sinks/copy_output_request.cc
[rename] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/common/frame_sinks/copy_output_request.h
[rename] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/common/frame_sinks/copy_output_result.cc
[rename] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/common/frame_sinks/copy_output_result.h
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/common/quads/render_pass.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/common/quads/render_pass_unittest.cc
[rename] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/common/resources/release_callback.h
[rename] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/common/resources/single_release_callback.cc
[rename] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/common/resources/single_release_callback.h
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/service/display/direct_renderer.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/service/display/display_unittest.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/service/display/gl_renderer_unittest.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/service/display/software_renderer.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/service/display/software_renderer_unittest.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/service/display/texture_mailbox_deleter.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/service/display/texture_mailbox_deleter_unittest.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/service/frame_sinks/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/service/surfaces/surface.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/service/surfaces/surface.h
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/service/surfaces/surface_unittest.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/components/viz/test/test_layer_tree_frame_sink.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/content/browser/compositor/surface_utils.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/content/browser/media/capture/aura_window_capture_machine.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/content/browser/renderer_host/delegated_frame_host.h
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/content/browser/renderer_host/render_widget_host_view_frame_subscriber.h
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/content/renderer/child_frame_compositing_helper.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/content/renderer/gpu/render_widget_compositor_unittest.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/content/renderer/layout_test_dependencies.h
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/content/renderer/render_widget.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/content/test/layouttest_support.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/remoting/host/chromeos/aura_desktop_capturer.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/remoting/host/chromeos/aura_desktop_capturer_unittest.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/services/ui/ws/test_utils.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/services/viz/public/cpp/compositing/copy_output_request.typemap
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/services/viz/public/cpp/compositing/copy_output_request_struct_traits.h
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/services/viz/public/cpp/compositing/copy_output_result.typemap
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/services/viz/public/cpp/compositing/copy_output_result_struct_traits.h
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/services/viz/public/interfaces/compositing/copy_output_request.mojom
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/services/viz/public/interfaces/compositing/copy_output_result.mojom
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferSoftwareRenderingTest.cpp
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/ui/android/delegated_frame_host_android.h
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/ui/android/window_android_compositor.h
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/ui/compositor/layer.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/ui/compositor/layer_unittest.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/ui/snapshot/BUILD.gn
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/ui/snapshot/DEPS
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/ui/snapshot/snapshot_android.cc
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/ui/snapshot/snapshot_async.h
[modify] https://crrev.com/f20f4502b6b3507350e0dddb15fc2b7990775f69/ui/snapshot/snapshot_aura.cc

Blockedon: 719931
Project Member

Comment 147 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/625e74db3a50b8e60ac9da09c15e5fe41bc620d4

commit 625e74db3a50b8e60ac9da09c15e5fe41bc620d4
Author: kylechar <kylechar@chromium.org>
Date: Tue Nov 21 19:05:07 2017

viz: Fix TRACE_EVENTS labels.

Many TRACE_EVENT macros in viz have category "cc" still. Update all of
them to "viz".

Bug: 722935
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ie308de936fc17205321ee419f3f6fa8b54ade9fa
Reviewed-on: https://chromium-review.googlesource.com/782161
Commit-Queue: kylechar <kylechar@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518320}
[modify] https://crrev.com/625e74db3a50b8e60ac9da09c15e5fe41bc620d4/components/viz/common/frame_sinks/delay_based_time_source.cc
[modify] https://crrev.com/625e74db3a50b8e60ac9da09c15e5fe41bc620d4/components/viz/service/display/direct_renderer.cc
[modify] https://crrev.com/625e74db3a50b8e60ac9da09c15e5fe41bc620d4/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/625e74db3a50b8e60ac9da09c15e5fe41bc620d4/components/viz/service/display/program_binding.cc
[modify] https://crrev.com/625e74db3a50b8e60ac9da09c15e5fe41bc620d4/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/625e74db3a50b8e60ac9da09c15e5fe41bc620d4/components/viz/service/display/software_renderer.cc
[modify] https://crrev.com/625e74db3a50b8e60ac9da09c15e5fe41bc620d4/components/viz/service/frame_sinks/compositor_frame_sink_support.cc
[modify] https://crrev.com/625e74db3a50b8e60ac9da09c15e5fe41bc620d4/components/viz/test/ordered_simple_task_runner.cc

Project Member

Comment 148 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41667cff13f61bcd197d16a285be296c0aa95ea3

commit 41667cff13f61bcd197d16a285be296c0aa95ea3
Author: danakj <danakj@chromium.org>
Date: Thu Jan 04 23:40:58 2018

Stop using cc::Resource from viz::GLRenderer

It does not even use all the fields in the struct, just store a
viz::ResourceId and a gfx::Size directly. This drops a dependency
on cc/resources/ stuff that isn't needed for the display compositor.

R=piman@chromium.org
TBR=boliu

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I598c371e2560c7ad8365652e5d6729d9c5e5a849
Reviewed-on: https://chromium-review.googlesource.com/850740
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527148}
[modify] https://crrev.com/41667cff13f61bcd197d16a285be296c0aa95ea3/android_webview/browser/test/rendering_test.h
[modify] https://crrev.com/41667cff13f61bcd197d16a285be296c0aa95ea3/components/viz/service/display/gl_renderer.cc

Description: Show this description
Project Member

Comment 150 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9467960abdb5c4e4ae57d4d795d58bbfc768f2ac

commit 9467960abdb5c4e4ae57d4d795d58bbfc768f2ac
Author: danakj <danakj@chromium.org>
Date: Fri May 18 22:00:45 2018

Move unit tests for viz::ResourceSizes from cc to viz.

They were still called resource_util_unittests in cc, but I moved them
to be in resource_sizes in viz, so also rename the file to match.

R=kylechar@chromium.org

Bug: 722935
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ibb1213d8f4db36d863a644f077c566095ed71af4
Reviewed-on: https://chromium-review.googlesource.com/1066530
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560062}
[modify] https://crrev.com/9467960abdb5c4e4ae57d4d795d58bbfc768f2ac/cc/BUILD.gn
[modify] https://crrev.com/9467960abdb5c4e4ae57d4d795d58bbfc768f2ac/components/viz/common/BUILD.gn
[rename] https://crrev.com/9467960abdb5c4e4ae57d4d795d58bbfc768f2ac/components/viz/common/resources/resource_sizes_unittest.cc

Project Member

Comment 151 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/072d53e63d142e1c4c85488f870420346cee337a

commit 072d53e63d142e1c4c85488f870420346cee337a
Author: danakj <danakj@chromium.org>
Date: Fri May 18 22:20:43 2018

Remove cc::Resource.

No longer used with the ResourcePool refactoring to allocate their
resources directly instead of through ResourceProvider.

R=enne@chromium.org

Bug: 722935
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I102da41042ee74bf7ca2daa0e20d79b45cfb4ae1
Reviewed-on: https://chromium-review.googlesource.com/1066550
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560068}
[modify] https://crrev.com/072d53e63d142e1c4c85488f870420346cee337a/cc/BUILD.gn
[modify] https://crrev.com/072d53e63d142e1c4c85488f870420346cee337a/cc/raster/bitmap_raster_buffer_provider.cc
[modify] https://crrev.com/072d53e63d142e1c4c85488f870420346cee337a/cc/raster/gpu_raster_buffer_provider.cc
[delete] https://crrev.com/fe9c6a943f6dc457069d292c50bb9543d2daaff3/cc/resources/resource.h
[modify] https://crrev.com/072d53e63d142e1c4c85488f870420346cee337a/cc/resources/resource_pool.h

Project Member

Comment 152 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db10add2de5af94369714f34f46a67136fac3d9d

commit db10add2de5af94369714f34f46a67136fac3d9d
Author: danakj <danakj@chromium.org>
Date: Fri May 18 22:30:01 2018

Move cc::ReturnCallback to viz

This is the callback called from viz, passed viz::ReturnedResources, and
it belongs in the viz component.

R=kylechar@chromium.org

Bug: 722935
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0cc555ed448c13100310e388138e3fc031f1b644
Reviewed-on: https://chromium-review.googlesource.com/1066502
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560072}
[modify] https://crrev.com/db10add2de5af94369714f34f46a67136fac3d9d/cc/resources/display_resource_provider.cc
[modify] https://crrev.com/db10add2de5af94369714f34f46a67136fac3d9d/cc/resources/display_resource_provider.h
[modify] https://crrev.com/db10add2de5af94369714f34f46a67136fac3d9d/cc/resources/display_resource_provider_unittest.cc
[modify] https://crrev.com/db10add2de5af94369714f34f46a67136fac3d9d/cc/resources/layer_tree_resource_provider_unittest.cc
[modify] https://crrev.com/db10add2de5af94369714f34f46a67136fac3d9d/cc/resources/resource_provider_unittest.cc
[delete] https://crrev.com/57433cdf17518a724d34b3a65caff8be0e2e0370/cc/resources/return_callback.h
[modify] https://crrev.com/db10add2de5af94369714f34f46a67136fac3d9d/components/viz/common/BUILD.gn
[add] https://crrev.com/db10add2de5af94369714f34f46a67136fac3d9d/components/viz/common/resources/return_callback.h

Project Member

Comment 153 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df0e2e76543c727f1bd622fb5f9cb82da3a64aff

commit df0e2e76543c727f1bd622fb5f9cb82da3a64aff
Author: danakj <danakj@chromium.org>
Date: Wed May 23 02:10:58 2018

Move DisplayResourceProvider and OverlayCandidate from cc to viz

As stated on the tin.

R=piman@chromium.org

Bug: 722935
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia5f9da37b4f9bec72c49900019de3bbdd11e04f0
Reviewed-on: https://chromium-review.googlesource.com/1066510
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560893}
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/cc/BUILD.gn
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/cc/resources/layer_tree_resource_provider.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/cc/resources/resource_provider_unittest.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/cc/test/fake_resource_provider.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/cc/test/pixel_test.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/cc/test/pixel_test.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/cc/test/render_pass_test_utils.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/cc/test/render_pass_test_utils.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/cc/test/resource_provider_test_utils.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/cc/test/resource_provider_test_utils.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/BUILD.gn
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/DEPS
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/ca_layer_overlay.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/ca_layer_overlay.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/dc_layer_overlay.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/dc_layer_overlay.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/direct_renderer.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/direct_renderer.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/display.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/display.h
[rename] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/display_resource_provider.cc
[rename] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/display_resource_provider.h
[rename] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/display_resource_provider_unittest.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/gl_renderer.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/gl_renderer_unittest.cc
[rename] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/overlay_candidate.cc
[rename] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/overlay_candidate.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/overlay_candidate_validator.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/overlay_processor.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/overlay_processor.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/overlay_strategy_fullscreen.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/overlay_strategy_fullscreen.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/overlay_strategy_single_on_top.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/overlay_strategy_single_on_top.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/overlay_strategy_underlay.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/overlay_strategy_underlay.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/overlay_strategy_underlay_cast.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/overlay_strategy_underlay_cast.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/overlay_unittest.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/renderer_pixeltest.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/skia_renderer.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/software_renderer.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/software_renderer.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/software_renderer_unittest.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/surface_aggregator.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/surface_aggregator.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/surface_aggregator_perftest.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/vulkan_renderer.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display/vulkan_renderer.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display_embedder/compositor_overlay_candidate_validator_android.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display_embedder/compositor_overlay_candidate_validator_android.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display_embedder/compositor_overlay_candidate_validator_mac.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display_embedder/compositor_overlay_candidate_validator_mac.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display_embedder/compositor_overlay_candidate_validator_ozone.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display_embedder/compositor_overlay_candidate_validator_ozone.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display_embedder/compositor_overlay_candidate_validator_win.cc
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/components/viz/service/display_embedder/compositor_overlay_candidate_validator_win.h
[modify] https://crrev.com/df0e2e76543c727f1bd622fb5f9cb82da3a64aff/content/browser/compositor/reflector_impl_unittest.cc

Project Member

Comment 154 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc80a210fd3b5677847893a7b817cc47a7012ca9

commit bc80a210fd3b5677847893a7b817cc47a7012ca9
Author: danakj <danakj@chromium.org>
Date: Wed May 23 20:45:29 2018

Move LayerTreeHostImpl-dependent code in viz/client/ to cc/.

Currently there is a HitTestDataProviderSurfaceLayer class in
components/viz/client, which receives a cc::LayerTreeHostImpl* from cc/
and then calls back into cc::LayerTreeHostImpl* to build the
HitTestRegionList from the active tree. This is problematic for these
reasons:

1. cc is-a viz client, so it could depend on viz/client/ code. But the
viz/client/ should not depend back on cc/. The use of the
cc::LayerTreeHostImpl pointer breaks this.

2. The LayerTreeFrameSink implementation can call back to
LayerTreeHostImpl, but it should not do so with the actual LTHI pointer
type. Instead it should use the LayerTreeFrameSinkClient interface,
which LayerTreeHostImpl implements.

3. The order of exection is that cc::LayerTreeHostImpl calls
ClientLayerTreeFrameSink::SubmitCompositorFrame() (through the
LayerTreeFrameSink interface), which then calls back to the
cc::LayerTreeHostImpl class to generate the HitTestRegionList,
creating the A-B-A anti-pattern. We can resolve this by passing
the HitTestRegionList directly to SubmitCompositorFrame(), but to do
so we need ClientLayerTreeFrameSink to not get it from the virtual
HitTestDataProvider interface in this case.

In order to satisfy these things we:

A. Move the implementation of HitTestDataProviderSurfaceLayer into
LayerTreeHostImpl, and move the unit test there.

B. Add a BuildHitTestData() method to LayerTreeFrameSinkClient, which
is implemented in LayerTreeHostImpl as per (A).

C. Move the branching out of the HitTestDataProvider virtuality.
If the HitTestDataProvider in ClientLayerTreeFrameSink is null, then
it uses the LayerTreeFrameSinkClient to ask the LayerTreeHostImpl to
build the HitTestRegionList. This does not break behaviour as the
HitTestDataProvider is created as a HitTestDataProviderDrawQuad
preferably, falling back to HitTestDataProviderSurfaceLayer.
Similarly the HitTestDataProviderDrawQuad would be preferred if the
pointer is not null, falling back to using LayerTreeFrameSinkClient.
(We also leave a TODO that we can just submit the HitTestRegionList
directly to SubmitCompositorFrame.)

This patch would be pretty small.. except..

Because cc/ is building the HitTestRegionList, it can not depend
on services/viz/ which depends back on cc/. So we implement the
viz::mojom::HitTestRegionList and viz::mojom::HitTestRegion as
standard c++ types viz::HitTestRegionList and viz::HitTestRegion
in components/viz/common/hit_test/, which cc/ can make use of. And
we add struct traits to pass these types to mojo and receive them
from mojo.

Then all plumbing code must be changed from the mojom-defined type
to the standard-c++-defined type.

The mojom type was viz::mojom::HitTestRegionListPtr (aka
mojo::StructPtr<viz::mojom::HitTestRegionList>), which is an
optional field in the CompositorFrame, so we must preserve its
ability to be null. We may use a struct traits directly to
viz::HitTestRegionList, and base::Optional<viz::HitTestRegionList>
throughout the plumbing, or we can use a struct traits to a
std::unique_ptr<viz::HitTestRegionList> (which is itself considered
nullable by mojo) and plumb that through directly through
everything. I don't actually know which is preferable here, but
settled on making viz::HitTestRegionList move-only, and using the
former option. This makes most of this patch just type renames.

Lastly, we need LayerTreeHostImpl to not return a HitTestRegionList
in cases where no HitTestDataProvider would have been given to the
ClientLayerTreeFrameSink previously. This is in the case where
features::IsVizHitTestingSurfaceLayerEnabled() returns false. So we
add a field to LayerTreeSettings, which we set to the value of that
feature flag, and have LayerTreeHostImpl return an empty optional
value when the setting is false.

R=gklassen@chromium.org, piman@chromium.org, sadrul@chromium.org

Bug: 722935
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0208c2cbd2ede14a088e4430c9eb75437e763c27
Reviewed-on: https://chromium-review.googlesource.com/1066987
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561244}
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/ash/components/fast_ink/fast_ink_view.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/cc/test/fake_layer_tree_frame_sink_client.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/cc/test/fake_layer_tree_frame_sink_client.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/cc/trees/layer_tree_frame_sink.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/cc/trees/layer_tree_frame_sink_client.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/exo/layer_tree_frame_sink_holder.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/exo/layer_tree_frame_sink_holder.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/client/BUILD.gn
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/client/client_layer_tree_frame_sink.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/client/client_layer_tree_frame_sink.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/client/hit_test_data_provider.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/client/hit_test_data_provider_draw_quad.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/client/hit_test_data_provider_draw_quad.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/client/hit_test_data_provider_draw_quad_unittest.cc
[delete] https://crrev.com/8c4715c6ba139bb46dff26ad0451786b58a3160b/components/viz/client/hit_test_data_provider_surface_layer.cc
[delete] https://crrev.com/8c4715c6ba139bb46dff26ad0451786b58a3160b/components/viz/client/hit_test_data_provider_surface_layer.h
[delete] https://crrev.com/8c4715c6ba139bb46dff26ad0451786b58a3160b/components/viz/client/hit_test_data_provider_surface_layer_unittest.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/common/BUILD.gn
[add] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/common/hit_test/hit_test_region_list.cc
[add] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/common/hit_test/hit_test_region_list.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/host/hit_test/hit_test_query.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/host/hit_test/hit_test_query_unittest.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/service/frame_sinks/compositor_frame_sink_impl.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/service/frame_sinks/compositor_frame_sink_impl.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/service/frame_sinks/compositor_frame_sink_support.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/service/frame_sinks/compositor_frame_sink_support.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/service/frame_sinks/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/service/frame_sinks/direct_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/service/frame_sinks/frame_sink_manager_impl.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/service/frame_sinks/frame_sink_manager_impl.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/service/hit_test/hit_test_aggregator.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/service/hit_test/hit_test_aggregator.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/service/hit_test/hit_test_aggregator_unittest.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/service/hit_test/hit_test_manager.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/service/hit_test/hit_test_manager.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/components/viz/service/hit_test/hit_test_manager_fuzzer.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/browser/renderer_host/delegated_frame_host.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/browser/renderer_host/embedded_frame_sink_provider_impl_unittest.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/browser/renderer_host/render_widget_host_browsertest.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/browser/renderer_host/render_widget_host_input_event_router.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/browser/renderer_host/render_widget_host_view_base.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/browser/renderer_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/browser/renderer_host/render_widget_host_view_child_frame_unittest.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/renderer/mus/renderer_window_tree_client.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/test/test_render_view_host.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/content/test/test_render_view_host.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/services/ui/ws/compositor_frame_sink_client_binding.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/services/ui/ws/compositor_frame_sink_client_binding.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/services/ui/ws/frame_generator.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/services/ui/ws/frame_generator.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/services/ui/ws/frame_generator_unittest.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/services/ui/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/services/ui/ws2/window_tree_client_unittest.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/services/viz/public/cpp/hit_test/BUILD.gn
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/services/viz/public/cpp/hit_test/aggregated_hit_test_region.typemap
[add] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/services/viz/public/cpp/hit_test/aggregated_hit_test_region_struct_traits.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/services/viz/public/cpp/hit_test/aggregated_hit_test_region_struct_traits.h
[add] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/services/viz/public/cpp/hit_test/hit_test_region_list.typemap
[add] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/services/viz/public/cpp/hit_test/hit_test_region_list_struct_traits.cc
[add] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/services/viz/public/cpp/hit_test/hit_test_region_list_struct_traits.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/services/viz/public/cpp/hit_test/struct_traits_unittest.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/services/viz/public/cpp/hit_test/typemaps.gni
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/services/viz/public/interfaces/hit_test/hit_test_region_list.mojom
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/ui/android/delegated_frame_host_android.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/ui/android/delegated_frame_host_android_unittest.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/ui/aura/hit_test_data_provider_aura.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/ui/aura/hit_test_data_provider_aura.h
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/ui/aura/hit_test_data_provider_aura_unittest.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/ui/compositor/compositor.cc
[modify] https://crrev.com/bc80a210fd3b5677847893a7b817cc47a7012ca9/ui/gfx/transform.h

Project Member

Comment 155 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1cb1420ff4125c2d9bf1e24b4e86a7e5e2ef970

commit f1cb1420ff4125c2d9bf1e24b4e86a7e5e2ef970
Author: danakj <danakj@chromium.org>
Date: Wed May 23 22:50:05 2018

Split ResourceProvider tests for LayerTree- vs DisplayResourceProvider

R=piman@chromium.org

Bug: 722935
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I345d86ffc4d2912206766b41fb157b235e4482f8
Reviewed-on: https://chromium-review.googlesource.com/1070560
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561293}
[modify] https://crrev.com/f1cb1420ff4125c2d9bf1e24b4e86a7e5e2ef970/cc/BUILD.gn
[modify] https://crrev.com/f1cb1420ff4125c2d9bf1e24b4e86a7e5e2ef970/cc/resources/layer_tree_resource_provider_unittest.cc
[delete] https://crrev.com/55d02bd6d071bd55e28ffd37877d2a9495a136df/cc/resources/resource_provider_unittest.cc
[modify] https://crrev.com/f1cb1420ff4125c2d9bf1e24b4e86a7e5e2ef970/components/viz/service/display/display_resource_provider_unittest.cc

Project Member

Comment 156 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d69a3e80272b78883e9bb43bb7098e281267aab

commit 7d69a3e80272b78883e9bb43bb7098e281267aab
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Wed May 23 23:05:55 2018

Revert "Move LayerTreeHostImpl-dependent code in viz/client/ to cc/."

This reverts commit bc80a210fd3b5677847893a7b817cc47a7012ca9.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 561244 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2JjODBhMjEwZmQzYjU2Nzc4NDc4OTNhN2I4MTdjYzQ3YTcwMTJjYTkM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/50226

Sample Failed Step: viz_unittests

Original change's description:
> Move LayerTreeHostImpl-dependent code in viz/client/ to cc/.
> 
> Currently there is a HitTestDataProviderSurfaceLayer class in
> components/viz/client, which receives a cc::LayerTreeHostImpl* from cc/
> and then calls back into cc::LayerTreeHostImpl* to build the
> HitTestRegionList from the active tree. This is problematic for these
> reasons:
> 
> 1. cc is-a viz client, so it could depend on viz/client/ code. But the
> viz/client/ should not depend back on cc/. The use of the
> cc::LayerTreeHostImpl pointer breaks this.
> 
> 2. The LayerTreeFrameSink implementation can call back to
> LayerTreeHostImpl, but it should not do so with the actual LTHI pointer
> type. Instead it should use the LayerTreeFrameSinkClient interface,
> which LayerTreeHostImpl implements.
> 
> 3. The order of exection is that cc::LayerTreeHostImpl calls
> ClientLayerTreeFrameSink::SubmitCompositorFrame() (through the
> LayerTreeFrameSink interface), which then calls back to the
> cc::LayerTreeHostImpl class to generate the HitTestRegionList,
> creating the A-B-A anti-pattern. We can resolve this by passing
> the HitTestRegionList directly to SubmitCompositorFrame(), but to do
> so we need ClientLayerTreeFrameSink to not get it from the virtual
> HitTestDataProvider interface in this case.
> 
> In order to satisfy these things we:
> 
> A. Move the implementation of HitTestDataProviderSurfaceLayer into
> LayerTreeHostImpl, and move the unit test there.
> 
> B. Add a BuildHitTestData() method to LayerTreeFrameSinkClient, which
> is implemented in LayerTreeHostImpl as per (A).
> 
> C. Move the branching out of the HitTestDataProvider virtuality.
> If the HitTestDataProvider in ClientLayerTreeFrameSink is null, then
> it uses the LayerTreeFrameSinkClient to ask the LayerTreeHostImpl to
> build the HitTestRegionList. This does not break behaviour as the
> HitTestDataProvider is created as a HitTestDataProviderDrawQuad
> preferably, falling back to HitTestDataProviderSurfaceLayer.
> Similarly the HitTestDataProviderDrawQuad would be preferred if the
> pointer is not null, falling back to using LayerTreeFrameSinkClient.
> (We also leave a TODO that we can just submit the HitTestRegionList
> directly to SubmitCompositorFrame.)
> 
> This patch would be pretty small.. except..
> 
> Because cc/ is building the HitTestRegionList, it can not depend
> on services/viz/ which depends back on cc/. So we implement the
> viz::mojom::HitTestRegionList and viz::mojom::HitTestRegion as
> standard c++ types viz::HitTestRegionList and viz::HitTestRegion
> in components/viz/common/hit_test/, which cc/ can make use of. And
> we add struct traits to pass these types to mojo and receive them
> from mojo.
> 
> Then all plumbing code must be changed from the mojom-defined type
> to the standard-c++-defined type.
> 
> The mojom type was viz::mojom::HitTestRegionListPtr (aka
> mojo::StructPtr<viz::mojom::HitTestRegionList>), which is an
> optional field in the CompositorFrame, so we must preserve its
> ability to be null. We may use a struct traits directly to
> viz::HitTestRegionList, and base::Optional<viz::HitTestRegionList>
> throughout the plumbing, or we can use a struct traits to a
> std::unique_ptr<viz::HitTestRegionList> (which is itself considered
> nullable by mojo) and plumb that through directly through
> everything. I don't actually know which is preferable here, but
> settled on making viz::HitTestRegionList move-only, and using the
> former option. This makes most of this patch just type renames.
> 
> Lastly, we need LayerTreeHostImpl to not return a HitTestRegionList
> in cases where no HitTestDataProvider would have been given to the
> ClientLayerTreeFrameSink previously. This is in the case where
> features::IsVizHitTestingSurfaceLayerEnabled() returns false. So we
> add a field to LayerTreeSettings, which we set to the value of that
> feature flag, and have LayerTreeHostImpl return an empty optional
> value when the setting is false.
> 
> R=gklassen@chromium.org, piman@chromium.org, sadrul@chromium.org
> 
> Bug: 722935
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I0208c2cbd2ede14a088e4430c9eb75437e763c27
> Reviewed-on: https://chromium-review.googlesource.com/1066987
> Commit-Queue: danakj <danakj@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: David Reveman <reveman@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561244}

Change-Id: I9b7c6e16cbd2c74a2d692ccce974e47bfd08cc13
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 722935
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1070879
Cr-Commit-Position: refs/heads/master@{#561299}
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/ash/components/fast_ink/fast_ink_view.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/cc/test/fake_layer_tree_frame_sink_client.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/cc/test/fake_layer_tree_frame_sink_client.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/cc/trees/layer_tree_frame_sink.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/cc/trees/layer_tree_frame_sink_client.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/exo/layer_tree_frame_sink_holder.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/exo/layer_tree_frame_sink_holder.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/client/BUILD.gn
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/client/client_layer_tree_frame_sink.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/client/client_layer_tree_frame_sink.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/client/hit_test_data_provider.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/client/hit_test_data_provider_draw_quad.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/client/hit_test_data_provider_draw_quad.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/client/hit_test_data_provider_draw_quad_unittest.cc
[add] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/client/hit_test_data_provider_surface_layer.cc
[add] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/client/hit_test_data_provider_surface_layer.h
[add] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/client/hit_test_data_provider_surface_layer_unittest.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/common/BUILD.gn
[delete] https://crrev.com/1d1955f522e8d467ab4fe05ef6e8bf0b6932a7bc/components/viz/common/hit_test/hit_test_region_list.cc
[delete] https://crrev.com/1d1955f522e8d467ab4fe05ef6e8bf0b6932a7bc/components/viz/common/hit_test/hit_test_region_list.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/host/hit_test/hit_test_query.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/host/hit_test/hit_test_query_unittest.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/service/frame_sinks/compositor_frame_sink_impl.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/service/frame_sinks/compositor_frame_sink_impl.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/service/frame_sinks/compositor_frame_sink_support.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/service/frame_sinks/compositor_frame_sink_support.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/service/frame_sinks/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/service/frame_sinks/direct_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/service/frame_sinks/frame_sink_manager_impl.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/service/frame_sinks/frame_sink_manager_impl.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/service/hit_test/hit_test_aggregator.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/service/hit_test/hit_test_aggregator.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/service/hit_test/hit_test_aggregator_unittest.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/service/hit_test/hit_test_manager.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/service/hit_test/hit_test_manager.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/components/viz/service/hit_test/hit_test_manager_fuzzer.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/browser/renderer_host/delegated_frame_host.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/browser/renderer_host/embedded_frame_sink_provider_impl_unittest.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/browser/renderer_host/render_widget_host_browsertest.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/browser/renderer_host/render_widget_host_input_event_router.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/browser/renderer_host/render_widget_host_view_base.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/browser/renderer_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/browser/renderer_host/render_widget_host_view_child_frame_unittest.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/renderer/mus/renderer_window_tree_client.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/test/test_render_view_host.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/content/test/test_render_view_host.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/services/ui/ws/compositor_frame_sink_client_binding.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/services/ui/ws/compositor_frame_sink_client_binding.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/services/ui/ws/frame_generator.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/services/ui/ws/frame_generator.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/services/ui/ws/frame_generator_unittest.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/services/ui/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/services/ui/ws2/window_tree_client_unittest.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/services/viz/public/cpp/hit_test/BUILD.gn
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/services/viz/public/cpp/hit_test/aggregated_hit_test_region.typemap
[delete] https://crrev.com/1d1955f522e8d467ab4fe05ef6e8bf0b6932a7bc/services/viz/public/cpp/hit_test/aggregated_hit_test_region_struct_traits.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/services/viz/public/cpp/hit_test/aggregated_hit_test_region_struct_traits.h
[delete] https://crrev.com/1d1955f522e8d467ab4fe05ef6e8bf0b6932a7bc/services/viz/public/cpp/hit_test/hit_test_region_list.typemap
[delete] https://crrev.com/1d1955f522e8d467ab4fe05ef6e8bf0b6932a7bc/services/viz/public/cpp/hit_test/hit_test_region_list_struct_traits.cc
[delete] https://crrev.com/1d1955f522e8d467ab4fe05ef6e8bf0b6932a7bc/services/viz/public/cpp/hit_test/hit_test_region_list_struct_traits.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/services/viz/public/cpp/hit_test/struct_traits_unittest.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/services/viz/public/cpp/hit_test/typemaps.gni
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/services/viz/public/interfaces/hit_test/hit_test_region_list.mojom
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/ui/android/delegated_frame_host_android.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/ui/android/delegated_frame_host_android_unittest.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/ui/aura/hit_test_data_provider_aura.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/ui/aura/hit_test_data_provider_aura.h
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/ui/aura/hit_test_data_provider_aura_unittest.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/ui/compositor/compositor.cc
[modify] https://crrev.com/7d69a3e80272b78883e9bb43bb7098e281267aab/ui/gfx/transform.h

Project Member

Comment 157 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fd59fdae24d26556946d7f2e7ef7cf92223b70c

commit 5fd59fdae24d26556946d7f2e7ef7cf92223b70c
Author: Jinsong Fan <fanjinsong@sogou-inc.com>
Date: Thu May 24 15:20:21 2018

Fix namespaces in viz component

Some code was still using the cc namespace in the viz component.
This CL fixes that. No change to logic.

Bug: 722935
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I534da76538feb6855aab008965e82d056583eaa4
Reviewed-on: https://chromium-review.googlesource.com/1070167
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561508}
[modify] https://crrev.com/5fd59fdae24d26556946d7f2e7ef7cf92223b70c/components/viz/service/display/direct_renderer.h
[modify] https://crrev.com/5fd59fdae24d26556946d7f2e7ef7cf92223b70c/components/viz/service/display/display.h
[modify] https://crrev.com/5fd59fdae24d26556946d7f2e7ef7cf92223b70c/components/viz/service/display/gl_renderer.h
[modify] https://crrev.com/5fd59fdae24d26556946d7f2e7ef7cf92223b70c/components/viz/service/display/software_renderer.h
[modify] https://crrev.com/5fd59fdae24d26556946d7f2e7ef7cf92223b70c/components/viz/service/display/vulkan_renderer.h
[modify] https://crrev.com/5fd59fdae24d26556946d7f2e7ef7cf92223b70c/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h
[modify] https://crrev.com/5fd59fdae24d26556946d7f2e7ef7cf92223b70c/components/viz/service/surfaces/surface_client.h

Cc: -staraz@chromium.org
Project Member

Comment 159 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54af81af521e95e5b51174c87060fa17e3776415

commit 54af81af521e95e5b51174c87060fa17e3776415
Author: danakj <danakj@chromium.org>
Date: Thu May 24 23:59:02 2018

Move LayerTreeHostImpl-dependent code in viz/client/ to cc/.

Reland of https://chromium-review.googlesource.com/c/chromium/src/+/1066987

Currently there is a HitTestDataProviderSurfaceLayer class in
components/viz/client, which receives a cc::LayerTreeHostImpl* from cc/
and then calls back into cc::LayerTreeHostImpl* to build the
HitTestRegionList from the active tree. This is problematic for these
reasons:

1. cc is-a viz client, so it could depend on viz/client/ code. But the
viz/client/ should not depend back on cc/. The use of the
cc::LayerTreeHostImpl pointer breaks this.

2. The LayerTreeFrameSink implementation can call back to
LayerTreeHostImpl, but it should not do so with the actual LTHI pointer
type. Instead it should use the LayerTreeFrameSinkClient interface,
which LayerTreeHostImpl implements.

3. The order of exection is that cc::LayerTreeHostImpl calls
ClientLayerTreeFrameSink::SubmitCompositorFrame() (through the
LayerTreeFrameSink interface), which then calls back to the
cc::LayerTreeHostImpl class to generate the HitTestRegionList,
creating the A-B-A anti-pattern. We can resolve this by passing
the HitTestRegionList directly to SubmitCompositorFrame(), but to do
so we need ClientLayerTreeFrameSink to not get it from the virtual
HitTestDataProvider interface in this case.

In order to satisfy these things we:

A. Move the implementation of HitTestDataProviderSurfaceLayer into
LayerTreeHostImpl, and move the unit test there.

B. Add a BuildHitTestData() method to LayerTreeFrameSinkClient, which
is implemented in LayerTreeHostImpl as per (A).

C. Move the branching out of the HitTestDataProvider virtuality.
If the HitTestDataProvider in ClientLayerTreeFrameSink is null, then
it uses the LayerTreeFrameSinkClient to ask the LayerTreeHostImpl to
build the HitTestRegionList. This does not break behaviour as the
HitTestDataProvider is created as a HitTestDataProviderDrawQuad
preferably, falling back to HitTestDataProviderSurfaceLayer.
Similarly the HitTestDataProviderDrawQuad would be preferred if the
pointer is not null, falling back to using LayerTreeFrameSinkClient.
(We also leave a TODO that we can just submit the HitTestRegionList
directly to SubmitCompositorFrame.)

This patch would be pretty small.. except..

Because cc/ is building the HitTestRegionList, it can not depend
on services/viz/ which depends back on cc/. So we implement the
viz::mojom::HitTestRegionList and viz::mojom::HitTestRegion as
standard c++ types viz::HitTestRegionList and viz::HitTestRegion
in components/viz/common/hit_test/, which cc/ can make use of. And
we add struct traits to pass these types to mojo and receive them
from mojo.

Then all plumbing code must be changed from the mojom-defined type
to the standard-c++-defined type.

The mojom type was viz::mojom::HitTestRegionListPtr (aka
mojo::StructPtr<viz::mojom::HitTestRegionList>), which is an
optional field in the CompositorFrame, so we must preserve its
ability to be null. We may use a struct traits directly to
viz::HitTestRegionList, and base::Optional<viz::HitTestRegionList>
throughout the plumbing, or we can use a struct traits to a
std::unique_ptr<viz::HitTestRegionList> (which is itself considered
nullable by mojo) and plumb that through directly through
everything. I don't actually know which is preferable here, but
settled on making viz::HitTestRegionList move-only, and using the
former option. This makes most of this patch just type renames.

Lastly, we need LayerTreeHostImpl to not return a HitTestRegionList
in cases where no HitTestDataProvider would have been given to the
ClientLayerTreeFrameSink previously. This is in the case where
features::IsVizHitTestingSurfaceLayerEnabled() returns false. So we
add a field to LayerTreeSettings, which we set to the value of that
feature flag, and have LayerTreeHostImpl return an empty optional
value when the setting is false.

TBR=gklassen@chromium.org, sadrul@chromium.org, reveman@chromium.org, avi@chromium.org, dcheng@chromium.org

Bug: 722935
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iba36b0cb12e2e45b80211956fb932c26693d1cd3
Reviewed-on: https://chromium-review.googlesource.com/1072128
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561697}
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/ash/components/fast_ink/fast_ink_view.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/cc/test/fake_layer_tree_frame_sink_client.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/cc/test/fake_layer_tree_frame_sink_client.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/cc/trees/layer_tree_frame_sink.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/cc/trees/layer_tree_frame_sink_client.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/exo/layer_tree_frame_sink_holder.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/exo/layer_tree_frame_sink_holder.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/client/BUILD.gn
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/client/client_layer_tree_frame_sink.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/client/client_layer_tree_frame_sink.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/client/hit_test_data_provider.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/client/hit_test_data_provider_draw_quad.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/client/hit_test_data_provider_draw_quad.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/client/hit_test_data_provider_draw_quad_unittest.cc
[delete] https://crrev.com/376503e22be73f65b54928db45edb1242aed7c1f/components/viz/client/hit_test_data_provider_surface_layer.cc
[delete] https://crrev.com/376503e22be73f65b54928db45edb1242aed7c1f/components/viz/client/hit_test_data_provider_surface_layer.h
[delete] https://crrev.com/376503e22be73f65b54928db45edb1242aed7c1f/components/viz/client/hit_test_data_provider_surface_layer_unittest.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/common/BUILD.gn
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/common/hit_test/aggregated_hit_test_region.h
[add] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/common/hit_test/hit_test_region_list.cc
[add] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/common/hit_test/hit_test_region_list.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/host/hit_test/hit_test_query.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/host/hit_test/hit_test_query_unittest.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/service/frame_sinks/compositor_frame_sink_impl.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/service/frame_sinks/compositor_frame_sink_impl.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/service/frame_sinks/compositor_frame_sink_support.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/service/frame_sinks/compositor_frame_sink_support.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/service/frame_sinks/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/service/frame_sinks/direct_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/service/frame_sinks/frame_sink_manager_impl.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/service/frame_sinks/frame_sink_manager_impl.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/service/hit_test/hit_test_aggregator.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/service/hit_test/hit_test_aggregator.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/service/hit_test/hit_test_aggregator_unittest.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/service/hit_test/hit_test_manager.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/service/hit_test/hit_test_manager.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/components/viz/service/hit_test/hit_test_manager_fuzzer.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/browser/renderer_host/delegated_frame_host.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/browser/renderer_host/embedded_frame_sink_provider_impl_unittest.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/browser/renderer_host/render_widget_host_browsertest.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/browser/renderer_host/render_widget_host_input_event_router.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/browser/renderer_host/render_widget_host_view_base.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/browser/renderer_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/browser/renderer_host/render_widget_host_view_child_frame_unittest.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/renderer/mus/renderer_window_tree_client.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/test/test_render_view_host.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/content/test/test_render_view_host.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/services/ui/ws/compositor_frame_sink_client_binding.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/services/ui/ws/compositor_frame_sink_client_binding.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/services/ui/ws/frame_generator.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/services/ui/ws/frame_generator.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/services/ui/ws/frame_generator_unittest.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/services/ui/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/services/ui/ws2/window_tree_client_unittest.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/services/viz/public/cpp/hit_test/BUILD.gn
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/services/viz/public/cpp/hit_test/aggregated_hit_test_region.typemap
[add] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/services/viz/public/cpp/hit_test/aggregated_hit_test_region_struct_traits.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/services/viz/public/cpp/hit_test/aggregated_hit_test_region_struct_traits.h
[add] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/services/viz/public/cpp/hit_test/hit_test_region_list.typemap
[add] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/services/viz/public/cpp/hit_test/hit_test_region_list_struct_traits.cc
[add] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/services/viz/public/cpp/hit_test/hit_test_region_list_struct_traits.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/services/viz/public/cpp/hit_test/struct_traits_unittest.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/services/viz/public/cpp/hit_test/typemaps.gni
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/services/viz/public/interfaces/hit_test/hit_test_region_list.mojom
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/ui/android/delegated_frame_host_android.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/ui/android/delegated_frame_host_android_unittest.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/ui/aura/hit_test_data_provider_aura.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/ui/aura/hit_test_data_provider_aura.h
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/ui/aura/hit_test_data_provider_aura_unittest.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/ui/compositor/compositor.cc
[modify] https://crrev.com/54af81af521e95e5b51174c87060fa17e3776415/ui/gfx/transform.h

Project Member

Comment 160 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b631be2a32b3981b8c9160a5335372e4149e706

commit 7b631be2a32b3981b8c9160a5335372e4149e706
Author: danakj <danakj@chromium.org>
Date: Fri May 25 19:14:20 2018

Allow cc to depend on viz/client, instead of vice-versa.

After this viz/client/ does not use cc/ (only cc/base/), and does not
include any mojo-bindings-specific code. We add a negative DEPS rule for
them with a comment, as well as mentioning it in the viz/README.md for
the client/ directory.

The ClientLayerTreeFrameSink from viz/client/ moves to cc/mojo_embedder/
which is a separate component from cc that is able to depend on mojo
bindings. This keeps viz/client/ and cc/ agnostic to the means for
communicating with viz, as webview uses classic IPC to get to the viz
process, and deprecated browser compositor uses in-process communication
with viz.

The public viz mojoms had dependencies on cc/ in their typemaps but they
were incorrect as the types have all moved to the viz component, so these
DEPS are updated to reflect that.

After this, allowed dependencies look like:
aura,content -> cc/mojo_embedder -> cc,mojo-bindings
cc -> viz/client,viz/common

R=kylechar@chromium.org
TBR=dcheng

Bug: 722935
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iec542fcc20f7b2bd2a42737c51dc30e0a4180de6
Reviewed-on: https://chromium-review.googlesource.com/1072314
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561965}
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/cc/BUILD.gn
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/cc/DEPS
[add] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/cc/mojo_embedder/BUILD.gn
[add] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/cc/mojo_embedder/DEPS
[add] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/cc/mojo_embedder/README.md
[rename] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/cc/mojo_embedder/async_layer_tree_frame_sink.cc
[add] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/cc/mojo_embedder/async_layer_tree_frame_sink.h
[rename] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/cc/mojo_embedder/async_layer_tree_frame_sink_unittest.cc
[add] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/cc/mojo_embedder/mojo_embedder_export.h
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/components/viz/README.md
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/components/viz/client/BUILD.gn
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/components/viz/client/DEPS
[delete] https://crrev.com/bb1d85e4c9eebf9744c11248d4d4f42e0d2de05f/components/viz/client/client_layer_tree_frame_sink.h
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/components/viz/client/hit_test_data_provider_draw_quad_unittest.cc
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/components/viz/common/BUILD.gn
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/content/browser/BUILD.gn
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/content/browser/compositor/viz_process_transport_factory.cc
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/content/renderer/BUILD.gn
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/content/renderer/mus/BUILD.gn
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/content/renderer/mus/mus_embedded_frame.cc
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/content/renderer/mus/renderer_window_tree_client.cc
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/services/viz/BUILD.gn
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/services/viz/public/cpp/compositing/begin_frame_args_for_blink.typemap
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/services/viz/public/cpp/compositing/compositor_frame.typemap
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/services/viz/public/cpp/compositing/compositor_frame_for_blink.typemap
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/services/viz/public/cpp/compositing/copy_output_request.typemap
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/services/viz/public/cpp/compositing/copy_output_result.typemap
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/services/viz/public/cpp/compositing/filter_operation.typemap
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/services/viz/public/cpp/compositing/filter_operations.typemap
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/services/viz/public/cpp/compositing/resource_settings.typemap
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/services/viz/public/interfaces/compositing/begin_frame_args.mojom
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/services/viz/public/interfaces/compositing/transferable_resource.mojom
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/ui/aura/BUILD.gn
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/ui/aura/mus/DEPS
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/ui/aura/mus/mus_context_factory.cc
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/ui/aura/mus/window_port_mus.cc
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/ui/aura/mus/window_port_mus.h
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/ui/aura/mus/window_port_mus_unittest.cc
[modify] https://crrev.com/7b631be2a32b3981b8c9160a5335372e4149e706/ui/compositor/BUILD.gn

Blockedon: -763377
Project Member

Comment 162 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57baa774bfecb02345e30c95ad8a6ddc3e6a0092

commit 57baa774bfecb02345e30c95ad8a6ddc3e6a0092
Author: danakj <danakj@chromium.org>
Date: Tue May 29 15:59:14 2018

Move LayerTreeResourceProvider to viz/client/ as ClientResourceProvider

As the LayerTreeResourceProvider now has no cc-specific things to it,
we can move it to viz/client/ where it is clear to be used by any and
all viz clients. It's renamed to not refer to LayerTree anymore also.

R=kylechar@chromium.org, pdr@chromium.org
TBR=thakis

Bug: 722935
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I07546622ad5482bf050403f8d6fe30769a05f4f4
Reviewed-on: https://chromium-review.googlesource.com/1073611
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562445}
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/BUILD.gn
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/layers/heads_up_display_layer_impl.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/layers/heads_up_display_layer_impl.h
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/layers/heads_up_display_layer_impl_unittest.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/layers/layer_impl.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/layers/layer_impl.h
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/layers/painted_overlay_scrollbar_layer_impl.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/layers/painted_overlay_scrollbar_layer_impl.h
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/layers/painted_scrollbar_layer_impl.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/layers/painted_scrollbar_layer_impl.h
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/layers/texture_layer_impl.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/layers/texture_layer_impl.h
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/layers/ui_resource_layer_impl.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/layers/ui_resource_layer_impl.h
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/layers/video_layer_impl.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/layers/video_layer_impl.h
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/paint/paint_op_buffer_serializer.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/raster/gpu_raster_buffer_provider.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/raster/one_copy_raster_buffer_provider.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/raster/one_copy_raster_buffer_provider.h
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/raster/raster_buffer_provider_perftest.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/raster/raster_buffer_provider_unittest.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/raster/zero_copy_raster_buffer_provider.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/resources/resource_pool.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/resources/resource_pool.h
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/resources/resource_pool_unittest.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/resources/video_resource_updater.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/resources/video_resource_updater.h
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/resources/video_resource_updater_unittest.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/test/fake_picture_layer_tiling_client.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/test/fake_picture_layer_tiling_client.h
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/test/fake_resource_provider.h
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/test/layer_test_common.h
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/test/pixel_test.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/test/pixel_test.h
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/test/render_pass_test_utils.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/test/render_pass_test_utils.h
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/test/resource_provider_test_utils.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/test/resource_provider_test_utils.h
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/tiles/picture_layer_tiling_set_unittest.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/trees/layer_tree_host_unittest_context.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/components/viz/client/BUILD.gn
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/components/viz/client/DEPS
[rename] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/components/viz/client/client_resource_provider.cc
[rename] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/components/viz/client/client_resource_provider.h
[rename] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/components/viz/client/client_resource_provider_unittest.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/components/viz/service/BUILD.gn
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/components/viz/service/display/DEPS
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/components/viz/service/display/display_resource_provider.h
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/components/viz/service/display/display_resource_provider_unittest.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/components/viz/service/display/gl_renderer_unittest.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/components/viz/service/display/overlay_unittest.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/components/viz/service/display/renderer_pixeltest.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/components/viz/service/display/software_renderer_unittest.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/third_party/blink/renderer/platform/graphics/DEPS
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/third_party/blink/renderer/platform/graphics/video_frame_resource_provider.cc
[modify] https://crrev.com/57baa774bfecb02345e30c95ad8a6ddc3e6a0092/third_party/blink/renderer/platform/graphics/video_frame_resource_provider.h

Project Member

Comment 163 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dda293b1b36a860264bfdde48c1aaf9cfea10868

commit dda293b1b36a860264bfdde48c1aaf9cfea10868
Author: danakj <danakj@chromium.org>
Date: Tue May 29 18:27:40 2018

Move cc::VideoResourceUpdater to media.

This class is used by the media (and blink) code directly to produce
video resources for submission to the viz display compositor.
cc::VideoLayerImpl also uses it for this, but is deprecated and
eventually cc won't use this class at all. So we move it out of cc/ to
the media/ component.

Also satisfies a TODO and moves the SharedBitmapReporter from
viz/common/ to viz/client/ as it is a part of the client library,
and expand on the class comment to explain how to use it more.

R=dalecurtis@chromium.org
TBR=kbr

Bug: 722935
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I5505b56c5fde79df0fe199dc14323fab07c3d292
Reviewed-on: https://chromium-review.googlesource.com/1073788
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562514}
[modify] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/cc/BUILD.gn
[modify] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/cc/layers/video_layer_impl.cc
[modify] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/cc/layers/video_layer_impl.h
[modify] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/cc/trees/layer_tree_frame_sink.h
[modify] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/components/viz/client/BUILD.gn
[modify] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/components/viz/client/DEPS
[rename] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/components/viz/client/shared_bitmap_reporter.cc
[add] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/components/viz/client/shared_bitmap_reporter.h
[modify] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/components/viz/common/BUILD.gn
[modify] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/components/viz/common/DEPS
[delete] https://crrev.com/9f14d81c9e6af5f111223a2e3355145af9df4aed/components/viz/common/resources/shared_bitmap_reporter.h
[modify] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/components/viz/service/display/DEPS
[modify] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/components/viz/service/display/renderer_pixeltest.cc
[modify] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/components/viz/test/DEPS
[modify] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/media/renderers/BUILD.gn
[add] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/media/renderers/DEPS
[rename] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/media/renderers/video_resource_updater.cc
[rename] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/media/renderers/video_resource_updater.h
[rename] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/media/renderers/video_resource_updater_unittest.cc
[modify] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/third_party/blink/renderer/platform/graphics/DEPS
[modify] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/third_party/blink/renderer/platform/graphics/video_frame_resource_provider.cc
[modify] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/third_party/blink/renderer/platform/graphics/video_frame_resource_provider.h
[modify] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/third_party/blink/renderer/platform/graphics/video_frame_submitter.cc
[modify] https://crrev.com/dda293b1b36a860264bfdde48c1aaf9cfea10868/third_party/blink/renderer/platform/graphics/video_frame_submitter.h

Project Member

Comment 164 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7167a9eac9d0f32675540f8ba623c601538c413e

commit 7167a9eac9d0f32675540f8ba623c601538c413e
Author: danakj <danakj@chromium.org>
Date: Thu May 31 15:25:10 2018

viz: Remove the global ServerSharedBitmapManager.

This moves ownership of the ServerSharedBitmapManager from a global
variable accessed thru a static current() method, to be a member on
BrowserMainLoop. This way random files can't instantiate a
ServerSharedBitmapManager by calling a static method, when there
should not even be one in the browser process with --enable-viz.

A SharedBitmapManager* is given to the FrameSinkManagerImpl which
always lives in the viz service process. The CompositorFrameSink
implementations can grab the pointer from there in order to
register software compositing bitmaps with the manager.

R=kylechar@chromium.org, piman@chromium.org
NOTRY=true

Bug: 730660, 722935
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I4c5be0a22ecef9d98012104b8e46678e8cd76617
Reviewed-on: https://chromium-review.googlesource.com/802574
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563241}
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/android_webview/browser/surfaces_instance.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/DEPS
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/client/DEPS
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/common/DEPS
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/host/DEPS
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/host/host_frame_sink_manager_unittest.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/DEPS
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/display/display_unittest.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/display/surface_aggregator_perftest.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/display/surface_aggregator_pixeltest.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/display_embedder/gpu_display_provider.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/display_embedder/gpu_display_provider.h
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/display_embedder/server_shared_bitmap_manager.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/display_embedder/server_shared_bitmap_manager.h
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/frame_sinks/compositor_frame_sink_support.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/frame_sinks/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/frame_sinks/direct_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/frame_sinks/frame_sink_manager_impl.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/frame_sinks/frame_sink_manager_impl.h
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/frame_sinks/frame_sink_manager_unittest.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/frame_sinks/surface_references_unittest.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/frame_sinks/surface_synchronization_unittest.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/frame_sinks/video_detector_unittest.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/hit_test/hit_test_aggregator_unittest.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/hit_test/hit_test_manager_fuzzer.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/main/viz_main_impl.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/main/viz_main_impl.h
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/surfaces/surface_hittest_unittest.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/service/surfaces/surface_unittest.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/components/viz/test/test_layer_tree_frame_sink.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/content/browser/browser_main_loop.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/content/browser/browser_main_loop.h
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/content/browser/compositor/gpu_process_transport_factory.h
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/content/browser/compositor/test/test_image_transport_factory.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/content/browser/compositor/test/test_image_transport_factory.h
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/content/browser/renderer_host/embedded_frame_sink_provider_impl_unittest.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/content/renderer/android/synchronous_layer_tree_frame_sink.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/third_party/blink/renderer/platform/graphics/offscreen_canvas_resource_provider.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/ui/android/DEPS
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/ui/android/delegated_frame_host_android_unittest.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/ui/aura/BUILD.gn
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/ui/aura/demo/DEPS
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/ui/aura/demo/demo_main.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/ui/compositor/test/context_factories_for_test.cc
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/ui/views/examples/BUILD.gn
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/ui/views/examples/DEPS
[modify] https://crrev.com/7167a9eac9d0f32675540f8ba623c601538c413e/ui/views/examples/examples_main.cc

Project Member

Comment 165 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15f067b9397284907bed914aaf97f85e1cceaf48

commit 15f067b9397284907bed914aaf97f85e1cceaf48
Author: danakj <danakj@chromium.org>
Date: Thu May 31 15:34:06 2018

Cleanup bitmap resource complexity in DisplayResourceProvider.

1. The SharedBitmap class does not need a sequence number.
2. The |shared_bitmap| in internal::Resource is always owned so
redundant with |owned_shared_bitmap|.
3. The |shared_bitmap_id| is always set when the Resource is a bitmap
type, so |has_shared_bitmap_id| is redundant with |type|.
4. We don't need virtual APIs on SharedBitmap if we can grab the
tracing GUID from the SharedBitmapManager, move the API there, and
store the GUID on the Resource.
5. The |pixels| always points to |shared_bitmap|'s pixels() now so it
is redundant.
6. No need to explicitly delete the resource's |owned_shared_bitmap|
as it will be destroyed when removed from the map with
resources_.erase().
7. g_next_sequence_number is unused by TestSharedBitmapManager.
8. SharedBitmap::id() is not used, as its just a wrapper for the
pixels() with the ability to control their lifetime.
9. GetSharedBitmapTracingGUIDFromId() is only used by a dead codepath
in ServerSharedBitmapManager, as BitmapData always has a SharedMemory
present in it.
10. viz::internal::Resource comments mention parents but parents of
DisplayResourceProvider can no longer exist.

R=kylechar@chromium.org
NOTRY=true

Bug: 722935
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4472105b6d5788d5539a0499598cb6c0611e3463
Reviewed-on: https://chromium-review.googlesource.com/1077079
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563249}
[modify] https://crrev.com/15f067b9397284907bed914aaf97f85e1cceaf48/components/viz/common/quads/shared_bitmap.cc
[modify] https://crrev.com/15f067b9397284907bed914aaf97f85e1cceaf48/components/viz/common/quads/shared_bitmap.h
[modify] https://crrev.com/15f067b9397284907bed914aaf97f85e1cceaf48/components/viz/common/resources/resource.cc
[modify] https://crrev.com/15f067b9397284907bed914aaf97f85e1cceaf48/components/viz/common/resources/resource.h
[modify] https://crrev.com/15f067b9397284907bed914aaf97f85e1cceaf48/components/viz/common/resources/shared_bitmap_manager.h
[modify] https://crrev.com/15f067b9397284907bed914aaf97f85e1cceaf48/components/viz/service/display/display_resource_provider.cc
[modify] https://crrev.com/15f067b9397284907bed914aaf97f85e1cceaf48/components/viz/service/display_embedder/server_shared_bitmap_manager.cc
[modify] https://crrev.com/15f067b9397284907bed914aaf97f85e1cceaf48/components/viz/service/display_embedder/server_shared_bitmap_manager.h
[modify] https://crrev.com/15f067b9397284907bed914aaf97f85e1cceaf48/components/viz/service/display_embedder/server_shared_bitmap_manager_unittest.cc
[modify] https://crrev.com/15f067b9397284907bed914aaf97f85e1cceaf48/components/viz/test/test_shared_bitmap_manager.cc
[modify] https://crrev.com/15f067b9397284907bed914aaf97f85e1cceaf48/components/viz/test/test_shared_bitmap_manager.h

Project Member

Comment 166 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce4fc2fe44bfda1e994326b17c1edae946e05a0f

commit ce4fc2fe44bfda1e994326b17c1edae946e05a0f
Author: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Date: Thu May 31 15:44:41 2018

Revert "Cleanup bitmap resource complexity in DisplayResourceProvider."

This reverts commit 15f067b9397284907bed914aaf97f85e1cceaf48.

Reason for revert: <INSERT REASONING HERE>
Compile error closing the tree: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/GPU%20Linux%20Builder/117949

Original change's description:
> Cleanup bitmap resource complexity in DisplayResourceProvider.
> 
> 1. The SharedBitmap class does not need a sequence number.
> 2. The |shared_bitmap| in internal::Resource is always owned so
> redundant with |owned_shared_bitmap|.
> 3. The |shared_bitmap_id| is always set when the Resource is a bitmap
> type, so |has_shared_bitmap_id| is redundant with |type|.
> 4. We don't need virtual APIs on SharedBitmap if we can grab the
> tracing GUID from the SharedBitmapManager, move the API there, and
> store the GUID on the Resource.
> 5. The |pixels| always points to |shared_bitmap|'s pixels() now so it
> is redundant.
> 6. No need to explicitly delete the resource's |owned_shared_bitmap|
> as it will be destroyed when removed from the map with
> resources_.erase().
> 7. g_next_sequence_number is unused by TestSharedBitmapManager.
> 8. SharedBitmap::id() is not used, as its just a wrapper for the
> pixels() with the ability to control their lifetime.
> 9. GetSharedBitmapTracingGUIDFromId() is only used by a dead codepath
> in ServerSharedBitmapManager, as BitmapData always has a SharedMemory
> present in it.
> 10. viz::internal::Resource comments mention parents but parents of
> DisplayResourceProvider can no longer exist.
> 
> R=​kylechar@chromium.org
> NOTRY=true
> 
> Bug: 722935
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I4472105b6d5788d5539a0499598cb6c0611e3463
> Reviewed-on: https://chromium-review.googlesource.com/1077079
> Commit-Queue: danakj <danakj@chromium.org>
> Reviewed-by: kylechar <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#563249}

TBR=danakj@chromium.org,kylechar@chromium.org

Change-Id: If702b59c5fcad7c4700795cd464f8ec4859a4331
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 722935
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1080375
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563252}
[modify] https://crrev.com/ce4fc2fe44bfda1e994326b17c1edae946e05a0f/components/viz/common/quads/shared_bitmap.cc
[modify] https://crrev.com/ce4fc2fe44bfda1e994326b17c1edae946e05a0f/components/viz/common/quads/shared_bitmap.h
[modify] https://crrev.com/ce4fc2fe44bfda1e994326b17c1edae946e05a0f/components/viz/common/resources/resource.cc
[modify] https://crrev.com/ce4fc2fe44bfda1e994326b17c1edae946e05a0f/components/viz/common/resources/resource.h
[modify] https://crrev.com/ce4fc2fe44bfda1e994326b17c1edae946e05a0f/components/viz/common/resources/shared_bitmap_manager.h
[modify] https://crrev.com/ce4fc2fe44bfda1e994326b17c1edae946e05a0f/components/viz/service/display/display_resource_provider.cc
[modify] https://crrev.com/ce4fc2fe44bfda1e994326b17c1edae946e05a0f/components/viz/service/display_embedder/server_shared_bitmap_manager.cc
[modify] https://crrev.com/ce4fc2fe44bfda1e994326b17c1edae946e05a0f/components/viz/service/display_embedder/server_shared_bitmap_manager.h
[modify] https://crrev.com/ce4fc2fe44bfda1e994326b17c1edae946e05a0f/components/viz/service/display_embedder/server_shared_bitmap_manager_unittest.cc
[modify] https://crrev.com/ce4fc2fe44bfda1e994326b17c1edae946e05a0f/components/viz/test/test_shared_bitmap_manager.cc
[modify] https://crrev.com/ce4fc2fe44bfda1e994326b17c1edae946e05a0f/components/viz/test/test_shared_bitmap_manager.h

Project Member

Comment 167 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/953c350bef0ccf28893d81862f8b8dab0448d2a7

commit 953c350bef0ccf28893d81862f8b8dab0448d2a7
Author: danakj <danakj@chromium.org>
Date: Thu May 31 20:56:03 2018

Reland "Cleanup bitmap resource complexity in DisplayResourceProvider."

This is a reland of 15f067b9397284907bed914aaf97f85e1cceaf48

TBR=kylechar
NOTRY=true

Original change's description:
> Cleanup bitmap resource complexity in DisplayResourceProvider.
>
> 1. The SharedBitmap class does not need a sequence number.
> 2. The |shared_bitmap| in internal::Resource is always owned so
> redundant with |owned_shared_bitmap|.
> 3. The |shared_bitmap_id| is always set when the Resource is a bitmap
> type, so |has_shared_bitmap_id| is redundant with |type|.
> 4. We don't need virtual APIs on SharedBitmap if we can grab the
> tracing GUID from the SharedBitmapManager, move the API there, and
> store the GUID on the Resource.
> 5. The |pixels| always points to |shared_bitmap|'s pixels() now so it
> is redundant.
> 6. No need to explicitly delete the resource's |owned_shared_bitmap|
> as it will be destroyed when removed from the map with
> resources_.erase().
> 7. g_next_sequence_number is unused by TestSharedBitmapManager.
> 8. SharedBitmap::id() is not used, as its just a wrapper for the
> pixels() with the ability to control their lifetime.
> 9. GetSharedBitmapTracingGUIDFromId() is only used by a dead codepath
> in ServerSharedBitmapManager, as BitmapData always has a SharedMemory
> present in it.
> 10. viz::internal::Resource comments mention parents but parents of
> DisplayResourceProvider can no longer exist.
>
> R=kylechar@chromium.org
> NOTRY=true
>
> Bug: 722935
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I4472105b6d5788d5539a0499598cb6c0611e3463
> Reviewed-on: https://chromium-review.googlesource.com/1077079
> Commit-Queue: danakj <danakj@chromium.org>
> Reviewed-by: kylechar <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#563249}

Bug: 722935
Change-Id: Ie5a19dbab38fbf471d58514352c218be6166a997
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1079739
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563374}
[modify] https://crrev.com/953c350bef0ccf28893d81862f8b8dab0448d2a7/components/viz/common/quads/shared_bitmap.cc
[modify] https://crrev.com/953c350bef0ccf28893d81862f8b8dab0448d2a7/components/viz/common/quads/shared_bitmap.h
[modify] https://crrev.com/953c350bef0ccf28893d81862f8b8dab0448d2a7/components/viz/common/resources/resource.cc
[modify] https://crrev.com/953c350bef0ccf28893d81862f8b8dab0448d2a7/components/viz/common/resources/resource.h
[modify] https://crrev.com/953c350bef0ccf28893d81862f8b8dab0448d2a7/components/viz/common/resources/shared_bitmap_manager.h
[modify] https://crrev.com/953c350bef0ccf28893d81862f8b8dab0448d2a7/components/viz/service/display/display_resource_provider.cc
[modify] https://crrev.com/953c350bef0ccf28893d81862f8b8dab0448d2a7/components/viz/service/display_embedder/server_shared_bitmap_manager.cc
[modify] https://crrev.com/953c350bef0ccf28893d81862f8b8dab0448d2a7/components/viz/service/display_embedder/server_shared_bitmap_manager.h
[modify] https://crrev.com/953c350bef0ccf28893d81862f8b8dab0448d2a7/components/viz/service/display_embedder/server_shared_bitmap_manager_unittest.cc
[modify] https://crrev.com/953c350bef0ccf28893d81862f8b8dab0448d2a7/components/viz/test/test_shared_bitmap_manager.cc
[modify] https://crrev.com/953c350bef0ccf28893d81862f8b8dab0448d2a7/components/viz/test/test_shared_bitmap_manager.h

Project Member

Comment 168 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a177c85468fee4809ba9adc42079962bab24f667

commit a177c85468fee4809ba9adc42079962bab24f667
Author: danakj <danakj@chromium.org>
Date: Fri Jun 01 00:03:42 2018

Make DisplayResourceProvider's Resource class hold TransferableResource

The TransferableResource can be const, and we avoid duplicating all the
fields of TransferableResource into the Resource structure. This makes
it much more clear what fields are inputs (those in the
TransferableResource) vs modified internal state of the
DisplayResourceProvider.

We clean up some of the logic around gpu-vs-software resources in the
DisplayResourceProvider, and ensure resources of the incorrect type
are rejected accurately, thus avoiding the need for null checks of
SharedBitmapManager later. Also DCHECK that the SharedBitmapManager
is present if the GL context is not.

After this, we can collapse the Resource back into the
DisplayResourceProvider class, as it is no longer used by clients as
well, and thus need not be in the viz/common/ component.

R=kylechar@chromium.org
NOTRY=true

Bug: 722935
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib87d0c3ee6afc9cd0a2f372cb70693249b639015
Reviewed-on: https://chromium-review.googlesource.com/1077601
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563447}
[modify] https://crrev.com/a177c85468fee4809ba9adc42079962bab24f667/components/viz/common/resources/resource.cc
[modify] https://crrev.com/a177c85468fee4809ba9adc42079962bab24f667/components/viz/common/resources/resource.h
[modify] https://crrev.com/a177c85468fee4809ba9adc42079962bab24f667/components/viz/service/display/display_resource_provider.cc
[modify] https://crrev.com/a177c85468fee4809ba9adc42079962bab24f667/components/viz/service/display/display_resource_provider_unittest.cc
[modify] https://crrev.com/a177c85468fee4809ba9adc42079962bab24f667/components/viz/service/display/surface_aggregator_unittest.cc

Project Member

Comment 169 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03882d2ab4630173954b1537481dc06267fd1e56

commit 03882d2ab4630173954b1537481dc06267fd1e56
Author: danakj <danakj@chromium.org>
Date: Fri Jun 01 02:29:58 2018

viz: Move service-only things out of components/viz/common/resources/

This moves the viz::internal::Resource back to being a nested struct
(named ChildResource, this time) in DisplayResourceProvider, now that
the LayerTreeResourceProvider (or ClientResourceProvider now) does not
use the type, so it is service-only.

The ResourceType is removed and replaced with a bool returning method
on DisplayResourceProvider

The ResourceFence and ResourceMetadata move to viz/service/display/
beside the DisplayResourceProvider.

R=piman@chromium.org

Bug: 722935
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Icfdc4cdb394850dbc592e5b9235a701c48430424
Reviewed-on: https://chromium-review.googlesource.com/1079375
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563498}
[modify] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/components/viz/common/BUILD.gn
[delete] https://crrev.com/2c7acec1c104ad4406fd92bd8a7d08db6a9e4949/components/viz/common/resources/resource.cc
[delete] https://crrev.com/2c7acec1c104ad4406fd92bd8a7d08db6a9e4949/components/viz/common/resources/resource.h
[delete] https://crrev.com/2c7acec1c104ad4406fd92bd8a7d08db6a9e4949/components/viz/common/resources/resource_type.h
[modify] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/components/viz/service/BUILD.gn
[modify] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/components/viz/service/display/DEPS
[modify] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/components/viz/service/display/display_perftest.cc
[modify] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/components/viz/service/display/display_resource_provider.cc
[modify] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/components/viz/service/display/display_resource_provider.h
[modify] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/components/viz/service/display/display_resource_provider_unittest.cc
[modify] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/components/viz/service/display/gl_renderer.cc
[rename] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/components/viz/service/display/resource_fence.h
[rename] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/components/viz/service/display/resource_metadata.cc
[rename] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/components/viz/service/display/resource_metadata.h
[rename] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/components/viz/service/display/shared_bitmap_manager.h
[modify] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/components/viz/service/display/software_renderer.cc
[modify] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/components/viz/service/display/sync_query_collection.cc
[modify] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/components/viz/service/display_embedder/DEPS
[modify] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/components/viz/service/display_embedder/server_shared_bitmap_manager.h
[modify] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/components/viz/service/display_embedder/skia_output_surface_impl.cc
[modify] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.h
[modify] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/components/viz/service/frame_sinks/compositor_frame_sink_support.cc
[modify] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/components/viz/service/frame_sinks/frame_sink_manager_impl.cc
[modify] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/components/viz/test/test_shared_bitmap_manager.h
[modify] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/content/browser/renderer_host/render_message_filter.h
[modify] https://crrev.com/03882d2ab4630173954b1537481dc06267fd1e56/media/blink/DEPS

Status: Fixed (was: Started)
Owner: danakj@chromium.org
Project Member

Comment 172 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1bc647d196c18a157716168d47070fc3e5a8424

commit c1bc647d196c18a157716168d47070fc3e5a8424
Author: danakj <danakj@chromium.org>
Date: Fri Jun 01 15:46:31 2018

Move viz::SharedBitmap header to viz/common/resources

It was placed in viz/common/quads/ because it is used with quads, but
fits better in resources/ with things like TransferableResource where
it actually appears.

R=piman@chromium.org
TBR=sky

Bug: 722935
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I39ada3a3fbefd22bfd819d4c10ecfceb59fc1d68
Reviewed-on: https://chromium-review.googlesource.com/1079384
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563649}
[modify] https://crrev.com/c1bc647d196c18a157716168d47070fc3e5a8424/cc/layers/texture_layer_unittest.cc
[modify] https://crrev.com/c1bc647d196c18a157716168d47070fc3e5a8424/cc/resources/cross_thread_shared_bitmap.h
[modify] https://crrev.com/c1bc647d196c18a157716168d47070fc3e5a8424/cc/resources/resource_pool.h
[modify] https://crrev.com/c1bc647d196c18a157716168d47070fc3e5a8424/cc/resources/shared_bitmap_id_registrar.h
[modify] https://crrev.com/c1bc647d196c18a157716168d47070fc3e5a8424/cc/test/pixel_test.cc
[modify] https://crrev.com/c1bc647d196c18a157716168d47070fc3e5a8424/cc/test/pixel_test.h
[modify] https://crrev.com/c1bc647d196c18a157716168d47070fc3e5a8424/components/viz/client/shared_bitmap_reporter.h
[modify] https://crrev.com/c1bc647d196c18a157716168d47070fc3e5a8424/components/viz/common/BUILD.gn
[rename] https://crrev.com/c1bc647d196c18a157716168d47070fc3e5a8424/components/viz/common/resources/shared_bitmap.cc
[rename] https://crrev.com/c1bc647d196c18a157716168d47070fc3e5a8424/components/viz/common/resources/shared_bitmap.h
[modify] https://crrev.com/c1bc647d196c18a157716168d47070fc3e5a8424/components/viz/common/resources/transferable_resource.h
[modify] https://crrev.com/c1bc647d196c18a157716168d47070fc3e5a8424/components/viz/service/display/display_resource_provider.h
[modify] https://crrev.com/c1bc647d196c18a157716168d47070fc3e5a8424/components/viz/service/display/display_resource_provider_unittest.cc
[modify] https://crrev.com/c1bc647d196c18a157716168d47070fc3e5a8424/components/viz/service/display/shared_bitmap_manager.h
[modify] https://crrev.com/c1bc647d196c18a157716168d47070fc3e5a8424/components/viz/service/display/software_renderer_unittest.cc
[modify] https://crrev.com/c1bc647d196c18a157716168d47070fc3e5a8424/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/c1bc647d196c18a157716168d47070fc3e5a8424/content/common/view_messages.h
[modify] https://crrev.com/c1bc647d196c18a157716168d47070fc3e5a8424/content/renderer/pepper/pepper_graphics_2d_host.cc
[modify] https://crrev.com/c1bc647d196c18a157716168d47070fc3e5a8424/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc
[modify] https://crrev.com/c1bc647d196c18a157716168d47070fc3e5a8424/third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.cc
[modify] https://crrev.com/c1bc647d196c18a157716168d47070fc3e5a8424/third_party/blink/renderer/platform/graphics/offscreen_canvas_resource_provider.cc
[modify] https://crrev.com/c1bc647d196c18a157716168d47070fc3e5a8424/third_party/blink/renderer/platform/graphics/video_frame_submitter.h

Showing comments 73 - 172 of 172 Older

Sign in to add a comment