New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 722933 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 618368



Sign in to add a comment

Position overlay properly in AVDACodecImage::ScheduleOverlayPlane

Project Member Reported by liber...@chromium.org, May 16 2017

Issue description

AVDACodecImage::ScheduleOverlayPlane should notify the overlay of position changes.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f989595632258d0cd667e7ef74ad5aec874329bc

commit f989595632258d0cd667e7ef74ad5aec874329bc
Author: liberato <liberato@chromium.org>
Date: Wed May 17 19:26:34 2017

Add multiple destruction callbacks to AndroidOverlay.

Rather than specify a single destruction callback in the config,
this CL replace it with AndroidOverlay::AddDestructionCallback().
Multiple callbacks are called starting with the most recently
registered.  This allows multiple interested parties to find out
when an overlay is destroyed.

Additionally, AndroidVideoSurfaceChooser no longer provides a 'stop
using overlay immediately' callback, since it was just aliased to
a destruction callback anyway from the overlay.  Instead, the client
may AddDestructionCallback, if desired, to find out about overlay
destruction when an overlay is provided by the chooser.

BUG= 722933 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2883913003
Cr-Commit-Position: refs/heads/master@{#472529}

[modify] https://crrev.com/f989595632258d0cd667e7ef74ad5aec874329bc/media/base/android/android_overlay.cc
[modify] https://crrev.com/f989595632258d0cd667e7ef74ad5aec874329bc/media/base/android/android_overlay.h
[modify] https://crrev.com/f989595632258d0cd667e7ef74ad5aec874329bc/media/base/android/mock_android_overlay.cc
[modify] https://crrev.com/f989595632258d0cd667e7ef74ad5aec874329bc/media/base/android_overlay_config.h
[modify] https://crrev.com/f989595632258d0cd667e7ef74ad5aec874329bc/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/f989595632258d0cd667e7ef74ad5aec874329bc/media/gpu/android_video_decode_accelerator_unittest.cc
[modify] https://crrev.com/f989595632258d0cd667e7ef74ad5aec874329bc/media/gpu/android_video_surface_chooser.h
[modify] https://crrev.com/f989595632258d0cd667e7ef74ad5aec874329bc/media/gpu/android_video_surface_chooser_impl.cc
[modify] https://crrev.com/f989595632258d0cd667e7ef74ad5aec874329bc/media/gpu/android_video_surface_chooser_impl.h
[modify] https://crrev.com/f989595632258d0cd667e7ef74ad5aec874329bc/media/gpu/android_video_surface_chooser_impl_unittest.cc
[modify] https://crrev.com/f989595632258d0cd667e7ef74ad5aec874329bc/media/gpu/content_video_view_overlay.cc
[modify] https://crrev.com/f989595632258d0cd667e7ef74ad5aec874329bc/media/mojo/clients/mojo_android_overlay.cc
[modify] https://crrev.com/f989595632258d0cd667e7ef74ad5aec874329bc/media/mojo/clients/mojo_android_overlay_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95c9282a9c8b5773f4f25f78fe829479d40304fa

commit 95c9282a9c8b5773f4f25f78fe829479d40304fa
Author: liberato <liberato@chromium.org>
Date: Wed May 17 22:36:21 2017

Position overlays in AVDACodecImage

This CL adds a call to ScheduleLayout from AVDACodecImage.

To get the overlay, AVDASharedState now holds a reference to the
surface bundle.  It registers for DestroyedCB notification from the
overlay, and drops the reference if this happens.  This will have
the side-effect of keeping the overlay around even if the decoder
is destroyed.  For CVV, that's a no-op, since leaving fullscreen
destroys the surface anyway, and the decoder is only destroyed when
not in fullscreen.

BUG= 722933 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2889603005
Cr-Commit-Position: refs/heads/master@{#472590}

[modify] https://crrev.com/95c9282a9c8b5773f4f25f78fe829479d40304fa/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/95c9282a9c8b5773f4f25f78fe829479d40304fa/media/gpu/avda_codec_image.cc
[modify] https://crrev.com/95c9282a9c8b5773f4f25f78fe829479d40304fa/media/gpu/avda_codec_image.h
[modify] https://crrev.com/95c9282a9c8b5773f4f25f78fe829479d40304fa/media/gpu/avda_picture_buffer_manager.cc
[modify] https://crrev.com/95c9282a9c8b5773f4f25f78fe829479d40304fa/media/gpu/avda_picture_buffer_manager.h
[modify] https://crrev.com/95c9282a9c8b5773f4f25f78fe829479d40304fa/media/gpu/avda_shared_state.cc
[modify] https://crrev.com/95c9282a9c8b5773f4f25f78fe829479d40304fa/media/gpu/avda_shared_state.h
[modify] https://crrev.com/95c9282a9c8b5773f4f25f78fe829479d40304fa/media/gpu/avda_surface_bundle.h
[modify] https://crrev.com/95c9282a9c8b5773f4f25f78fe829479d40304fa/media/gpu/content_video_view_overlay.cc

Status: Fixed (was: Started)

Sign in to add a comment