New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 722927 link

Starred by 13 users

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature



Sign in to add a comment

Dynamic tab shape

Project Member Reported by pkasting@chromium.org, May 16 2017

Issue description

A dynamic tab shape could help tabs stay more usable at small widths.

See https://docs.google.com/presentation/d/17_AjeagqThCof_LG1ApE8hqhFBJ-M_12mGgK_pcvkng/edit (Google-only, I believe).

Alex, you suggested this originally.  After some pondering, I think we should go ahead and try to do it.
 
Cc: edwardjung@chromium.org
Some things to consider:

* Widths at which shape change should start/stop (i.e. the "minimum fully-slanted" and "maximum fully-square" widths)
* Pinned tab shape: without other tabs present, with other tabs present of a similar width, with other tabs present of a dissimilar width, and the transitions between these states
* Gap between pinned and normal tabs
* Stacked tab shape
* New tab button shape, size, and gap
* Amount of padding within tab between content and side edges
* Roundedness of tab corners (they may look sharp now but are not; look at the tab with --force-device-scale-factor=4 to see, attached a screenshot), and similarly NTB corners
* Amount of space at left edge of tabstrip before tabs begin, and whether it changes as the tab shape changes
* Any transition differences that should be made as a result of opening or closing one or more tabs, versus shrinking or expanding the window
I uploaded a WIP patch at https://chromium-review.googlesource.com/c/507049 to demonstrate how this could be implemented.  It's nowhere near ready to go, and I'm not sure whether I'll continue on it, but if someone wanted to try to implement this I hope it would give them a big leg up.
Cc: bettes@chromium.org
Lots to think about, +bettes for visual design.


Cc: spqc...@chromium.org shrike@chromium.org jfincher@google.com
 Issue 637343  has been merged into this issue.
Cc: varkha@chromium.org
Labels: Proj-TabletChrome
Tagging with Proj-TabletChrome for tracking purposes. If implemented, I believe this would be a win for touch in the tabstrip:

* Less-angled tab borders would make tabs more touch-friendly, at least in appearance.

* Improved space efficiency would raise the number-of-open-tabs threshold at which stacked tab mode is triggered, or may even eliminate the need for stacked tabs at all.
Cc: ellyjo...@chromium.org
+CC ellyjones who apparently has some WIP Mac code.  Elly, see link in comment 2 for views.
For internal folks, I created a rough prototype to expand on ainslie's explorations. Gives an idea of the extra space created for more usable tabs versus our current tab strip.

go/dynamic-tabstrip-prototype

Keep clicking the new tab button or press 'T' to keep adding tabs. Toggles to explore ideas like removing borders, expanding the tab when hovering over tiny tabs and an tab overview list.

tabs-prototype.gif
752 KB View Download
Owner: malaykeshav@chromium.org
Working on computing dynamic control points, which intersects with some of what is required in this case as well. 

Tried the above patch from #2 with some modification. Got the following results (Does not include the modified corner curves).

When the minimum width for the tab is reached, the last tab gets pruned for paint due to its right() being greater than the tab_strip.width().
Dynamic Tabs.webm
1.6 MB View Download
Owner: pkasting@chromium.org
Apparently I'm now slated to own this.
Status: WontFix (was: Available)
Moot; latest proposals eliminate the need for dynamic tab shape in favor of other solutions.

Sign in to add a comment