"gclient validate" exceptions on official.desktop.continuous trunk builders |
|||||||
Issue descriptionIt looks like all the official trunk builders are failing gclient validate with the error: third_party.schema.schema.SchemaWrongKeyError: Wrong keys 'hooks_os' for example: https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fofficial.desktop.continuous%2Fmac64_trunk%2F250%2F%2B%2Frecipes%2Fsteps%2Fgclient_validate%2F0%2Fstdout AFAICT, that's coming directly from src.git/DEPS, but it doesn't look like it's causing 'gclient validate' to fail on the public builders. Any idea why it's behaving differently on the official ones?
,
May 16 2017
,
May 16 2017
We just added hooks_os to gclient; maybe you need to update your copy of depot_tools. Is it pinned on trunk, or auto-updating? https://chromium-review.googlesource.com/503534 was the change that added it.
,
May 16 2017
Also, gclient validate is supposed to be a non-fatal (i.e., informational only step). Is this actually failing the build? If so, we should fix that.
,
May 16 2017
It's not failing the build (although it is generating warnings). I was mostly concerned because a) it's been failing for a while, so I wasn't sure anybody was even aware, and b) I gather at some point it will strictly validate and then actually will fail the build, so I want to make sure it's cleaned up before that.
,
May 16 2017
If it's not failing the build, it probably shouldn't be a P0 then, right? Otherwise, yes, we absolutely want to get it cleaned up, but revving depot_tools should do this.
,
May 16 2017
Ugh, I meant it to be P1.
,
May 16 2017
OK, looks like the problem is that recipes weren't rolled because there was a non-trivial roll waiting for approval (which I did this morning). The latest roll (https://chrome-internal.googlesource.com/chrome/tools/release/scripts/+/8217d8bed9cf9afa6aced8c927f7ce622f0954c3) brought depot_tools up to your change, so hopefully that will fix it.
,
May 16 2017
Recent builds are passing 'gclient validate' now: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/63513
,
May 17 2017
Issue 723744 has been merged into this issue.
,
Jun 6 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mmoss@chromium.org
, May 16 2017Labels: OS-All