Issue metadata
Sign in to add a comment
|
emerge QA notice when building packages with non-C/C++ binaries |
||||||||||||||||||||||||
Issue descriptionI encountered this case when the package (dev-util/cargo) I was building was made with rustc. The error message: readelf: Warning: Section '.GCC.command.line' was not dumped because it does not exist! File not built with -frecord-gcc-switches: /var/tmp/portage/dev-util/cargo-0.17.0/image/usr/bin/cargo File not built with gold: /var/tmp/portage/dev-util/cargo-0.17.0/image/usr/bin/cargo Clearly the binchecks rely on binaries being built with a command line section in the elf. It would be nice if the binchecks would skip the steps that rely on that section if it is not present.
,
May 16 2017
It's correct to still have binchecks, but it appears this failing check is looking for a section labeled '.GCC.command.line' which, by my naive interpretation, is something only gcc-compatible compilers would include. It wouldn't even make sense for rustc to output that section as its command line options are totally different.
,
May 16 2017
which is mostly what issue 642230 is about the gold check does not rely on command line flag tracking
,
May 16 2017
I think this issue is totally independent of the one you mentioned. Fundamentally, it makes no sense to check certain GCC flags were used to build a binary that GCC had no part in producing. It's true that the binary was not built with gold because it was linked with x86_64-pc-linux-gnu-gcc (which seems like a contradiction of my previous sentence but this gcc invocation is purely for linking purposes), which after some interrogation with -print-prog-name=ld, said it uses the bfd version of ld.
,
May 16 2017
that issue covers builds by clang too which are impacted. i don't think special casing rust is worth the effort.
,
May 16 2017
So we're in agreement that disabling binchecks is the correct choice for non-gcc packages that build binaries?
,
May 16 2017
of course not. the *one* bad check you highlighted is just a single check. turning off all binchecks disables a lot more checks that do make sense. you should just ignore it and wait for issue 642230 to be resolved.
,
May 16 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by vapier@chromium.org
, May 16 2017