New issue
Advanced search Search tips

Issue 722899 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Popover content for long strings is not visible

Project Member Reported by alph@chromium.org, May 16 2017

Issue description

Please see the attached screenshot.
 
Screenshot from 2017-05-16 10:23:39.png
166 KB View Download
Cc: dgozman@chromium.org
Owner: l...@chromium.org

Comment 2 Deleted

Comment 3 by l...@chromium.org, May 18 2017

Other popover problem:
networkPopoverProblem.png
25.3 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7856682b892241cb9263140c56554880633b8d84

commit 7856682b892241cb9263140c56554880633b8d84
Author: luoe <luoe@chromium.org>
Date: Mon May 22 03:46:22 2017

DevTools: fix popover's account for scrollbar size when measuring content

When calculating the size of a popover with SizeBehavior == MeasureContent,
positioning logic accounts for either a vertical scrollbar or a horizontal one,
but not both. This led to cases where GlassPane allocated enough width, but not
enough height for wide content (e.g. hovering over a long string when paused).

This CL adjusts the constrained popover width/height for scrollbar size in both
directions.

BUG= 722899 

Review-Url: https://codereview.chromium.org/2889693008
Cr-Commit-Position: refs/heads/master@{#473499}

[modify] https://crrev.com/7856682b892241cb9263140c56554880633b8d84/third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js

Comment 5 by alph@chromium.org, May 22 2017

As per comment #4. The example in the report does not need a vertical scrtollbar. So the fix doesn't seem to apply to it.

Comment 6 by l...@chromium.org, May 22 2017

Status: Fixed (was: Assigned)
What I got from investigating the bug in the description was that the popover wasn't allocated enough height.  As you say, it doesn't need the vertical scrollbar, only the vertical one.

I believe the the fix should apply because it checks that there is not enough width and adds extra height for the vertical scrollbar.

Marking as fixed since it's no longer reproducible, but please reply if you still find it and I'll take another look :)

Sign in to add a comment