[WPT Dashboard] Set up code review for the wptdashboard repo. |
||||||
Issue descriptionSome Chromium-related repos on Github are using Rietveld for code reviews. (At least, I think https://github.com/catapult-project/catapult/ does). We could start doing code review for wptdashboard using Rietveld or Gerrit. Pros: Chromium committers are used to a code review process using a tool like Rietveld or PolyGerrit. Cons: Non-Chromium committers may not be used to this, and may be more comfortable making pull requests on GitHub. Jeff, what do you think?
,
May 18 2017
,
May 18 2017
Hi Aaron, what would be necessary for setting up Gerrit code review for this? We already have a mirror: https://chromium.googlesource.com/external/github.com/GoogleChrome/wptdashboard I see there's a file `codereview.settings` file and that Gerrit has an API endpoint for creating projects. Is there anything else we need to enable Gerrit code review and two-way sync between the GoB and GitHub repos? https://chromium.googlesource.com/external/github.com/luci/luci-go/+/9d852289caad98d19a53501c9cf22853f33d1351/codereview.settings
,
May 18 2017
Two-way sync doesn't work. Repos can be maintained on github only one of three ways: 1) Use native github pull requests 2) Do code review on Rietveld and push directly to github 3) Do code review on Gerrit and mirror the result back to github (This third option is not actually supported yet, but we hope to support it soon.) As long as the golden source of truth is the github repo, we cannot enable gerrit code review.
,
Jul 3 2017
,
Jul 3 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jeffcarp@chromium.org
, May 16 2017