New issue
Advanced search Search tips

Issue 722891 link

Starred by 1 user
Status: Fixed
Owner:
altimin@chromium.org
Closed: May 2017
Cc:
skyos...@chromium.org
altimin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

--disable-background-timer-throttling does not work with backgrounded renderer

Project Member Reported by altimin@chromium.org, May 16 2017 
--disable-background-timer-throttling command-line flag is not taken into account when setting renderer policies.

We also need to improve test coverage for this flag.
Project Member

Comment 1 by bugdroid1@chromium.org, May 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbe259ac4325ebdbce04e317b68324faabef440c

commit bbe259ac4325ebdbce04e317b68324faabef440c
Author: altimin <altimin@chromium.org>
Date: Fri May 19 16:57:29 2017

[scheduler] Fix --disable-background-timer-throttling flag.

Make RendererScheduler respect disable-background-timer-throttling flag
when calculating policies for background renderer.

This patch also adds a test to make sure that we do not regress again.
Also scheduler simulation tests are moved to web/tests/scheduler

R=skyostil@chromium.org,alexclarke@chromium.org
BUG= 722891 

Review-Url: https://codereview.chromium.org/2885313003
Cr-Commit-Position: refs/heads/master@{#473217}

[modify] https://crrev.com/bbe259ac4325ebdbce04e317b68324faabef440c/third_party/WebKit/Source/platform/scheduler/child/web_scheduler.h
[modify] https://crrev.com/bbe259ac4325ebdbce04e317b68324faabef440c/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/bbe259ac4325ebdbce04e317b68324faabef440c/third_party/WebKit/Source/platform/scheduler/renderer/renderer_web_scheduler_impl.cc
[modify] https://crrev.com/bbe259ac4325ebdbce04e317b68324faabef440c/third_party/WebKit/Source/platform/scheduler/renderer/renderer_web_scheduler_impl.h
[modify] https://crrev.com/bbe259ac4325ebdbce04e317b68324faabef440c/third_party/WebKit/Source/platform/wtf/Deque.h
[modify] https://crrev.com/bbe259ac4325ebdbce04e317b68324faabef440c/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/bbe259ac4325ebdbce04e317b68324faabef440c/third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp
[modify] https://crrev.com/bbe259ac4325ebdbce04e317b68324faabef440c/third_party/WebKit/Source/web/tests/HTMLImportSheetsTest.cpp
[modify] https://crrev.com/bbe259ac4325ebdbce04e317b68324faabef440c/third_party/WebKit/Source/web/tests/MediaElementFillingViewportTest.cpp
[rename] https://crrev.com/bbe259ac4325ebdbce04e317b68324faabef440c/third_party/WebKit/Source/web/tests/scheduler/ActiveConnectionThrottlingTest.cpp
[rename] https://crrev.com/bbe259ac4325ebdbce04e317b68324faabef440c/third_party/WebKit/Source/web/tests/scheduler/FrameThrottlingTest.cpp
[add] https://crrev.com/bbe259ac4325ebdbce04e317b68324faabef440c/third_party/WebKit/Source/web/tests/scheduler/OWNERS
[add] https://crrev.com/bbe259ac4325ebdbce04e317b68324faabef440c/third_party/WebKit/Source/web/tests/scheduler/README.md
[add] https://crrev.com/bbe259ac4325ebdbce04e317b68324faabef440c/third_party/WebKit/Source/web/tests/scheduler/ThrottlingTest.cpp
[modify] https://crrev.com/bbe259ac4325ebdbce04e317b68324faabef440c/third_party/WebKit/Source/web/tests/sim/SimTest.cpp
[modify] https://crrev.com/bbe259ac4325ebdbce04e317b68324faabef440c/third_party/WebKit/Source/web/tests/sim/SimTest.h

Comment 2 by skyos...@chromium.org, May 22 2017

Status: Fixed (was: Started)
►

Sign in to add a comment