New issue
Advanced search Search tips

Issue 722885 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Automate testing of CLs with disk_cache_perftest as much as possible.

Project Member Reported by morlovich@chromium.org, May 16 2017

Issue description

Right now the process is pretty work intensive, and fiddly.
Besides getting all the CLs for tests in, a bit of scripting
may help --- it also sets enough path knobs that the Android 
tests doesn't look for the JVM.

Attached is a start --- runs the bench for a given platform using the current source tree. 

(Might be an appropriate place for it in git, but I am not sure 
 of where, and this is public and more durable than my hard drive.)

 
Woops, screwed up the Android path when cleaning it up before upload.
This sure isn't a very good code review system.

run_disk_cache_bench.sh
2.2 KB View Download
Made it summarize stuff into a single .csv, rather than 5. 
run_disk_cache_bench.sh
2.4 KB View Download
xunjieli@ pointed me at:
https://codereview.chromium.org/2748073003/
which sets up automated running of net_perftests (on Linux)

And fixing some quoting that was breaking RUNS= on Android..
run_disk_cache_bench.sh
2.4 KB View Download
Made column names shorter and another helper to interleave columns of two runs --- makes plugging them into a spreadsheet and doing graphs really easy.

run_disk_cache_bench.sh
2.4 KB View Download
combine_runs.sh
330 bytes View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e701e32a7785efb6b77d42e6d2b838b4d4590c3

commit 1e701e32a7785efb6b77d42e6d2b838b4d4590c3
Author: morlovich <morlovich@chromium.org>
Date: Thu Jun 01 14:40:08 2017

Provide base::EvictFileFromSystemCache on Android on ARM32

This is needed to be able to run disk_cache_perftest on the platform.

This just uses the Linux implementation, but provides a syscall wrapper
since NDK won't provide one at the API level we build for.

BUG=722885

Review-Url: https://codereview.chromium.org/2885423002
Cr-Commit-Position: refs/heads/master@{#476281}

[modify] https://crrev.com/1e701e32a7785efb6b77d42e6d2b838b4d4590c3/base/test/BUILD.gn
[modify] https://crrev.com/1e701e32a7785efb6b77d42e6d2b838b4d4590c3/base/test/test_file_util_linux.cc
[modify] https://crrev.com/1e701e32a7785efb6b77d42e6d2b838b4d4590c3/base/test/test_file_util_posix.cc

Version that hand-applies a .diff, and alternates patched and unpatched versions.
(That can help cancel some trends, but the test is probably too slow for it to help much).

run_disk_cache_bench.sh
4.3 KB View Download
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d29ed392cc031d617f582ff019e555e50c311e37

commit d29ed392cc031d617f582ff019e555e50c311e37
Author: morlovich <morlovich@chromium.org>
Date: Thu Jun 01 15:54:37 2017

diskcache_perftest: fully use base::EvictFileFromSystemCache on android,
now it's available there.

BUG=722885

Review-Url: https://codereview.chromium.org/2914203003
Cr-Commit-Position: refs/heads/master@{#476310}

[modify] https://crrev.com/d29ed392cc031d617f582ff019e555e50c311e37/net/disk_cache/disk_cache_perftest.cc

And fixes Windows support. Need to use gn.bat there, rather than have cygwin trying to Unix-up the usual gn wrapper.

run_disk_cache_bench.sh
4.3 KB View Download

Sign in to add a comment