New issue
Advanced search Search tips

Issue 722884 link

Starred by 1 user
Status: Verified
Owner:
hongchan@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Refactor audioparam-testing.js and layout tests that use it

Project Member Reported by hongchan@chromium.org, May 16 2017 
There are some globally exposed variables in audioparam-testing.js and this is causing conflicts with the variables in the actual test files.

Refactor the script code we can avoid duplicate declaration.

Comment 1 by hongchan@chromium.org, May 16 2017 

These files need to be checked:

LayoutTests/webaudio/resources/audioparam-testing.js
LayoutTests/webaudio/AudioParam/audioparam-sampling.html
LayoutTests/webaudio/AudioParam/audioparam-method-chaining.html
LayoutTests/webaudio/AudioParam/audioparam-initial-event.html
LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime-sampling.html
LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime.html
LayoutTests/webaudio/AudioParam/audioparam-setValueAtTime.html
LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-duration.html
LayoutTests/webaudio/AudioParam/audioparam-linearRampToValueAtTime.html
LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime-continuous.html
LayoutTests/webaudio/AudioParam/audioparam-setValueCurveAtTime.html
LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime-limit.html
LayoutTests/webaudio/AudioParam/audioparam-exponentialRampToValueAtTime.html
LayoutTests/webaudio/AudioBufferSource/audiosource-time-limits.html
LayoutTests/webaudio/BiquadFilter/biquad-automation.html
LayoutTests/webaudio/AudioBuffer/audiobuffer-getChannelData.html
LayoutTests/webaudio/ConstantSource/constant-source-output.html
Project Member

Comment 2 by bugdroid1@chromium.org, May 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37ca59f82e27b113196d8427acade1b5f04b0f8b

commit 37ca59f82e27b113196d8427acade1b5f04b0f8b
Author: hongchan <hongchan@chromium.org>
Date: Tue May 16 20:15:09 2017

Refactor audioparam-testing.js

This CL refactors audioparam-testing.js so we can hide global variables
and functions from the window scope.

BUG= 722884 
TEST=(All layout tests passes after this change.)

Review-Url: https://codereview.chromium.org/2886883002
Cr-Commit-Position: refs/heads/master@{#472202}

[modify] https://crrev.com/37ca59f82e27b113196d8427acade1b5f04b0f8b/third_party/WebKit/LayoutTests/webaudio/resources/audioparam-testing.js

Comment 3 by hongchan@chromium.org, May 16 2017

Status: Verified (was: Started)
►

Sign in to add a comment