New issue
Advanced search Search tips

Issue 722882 link

Starred by 1 user
Status: Fixed
Owner:
tzik@chromium.org
Closed: May 2017
Cc:
danakj@chromium.org
tzik@chromium.org
dcheng@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

base::MakeShared should be base::MakeRefCounted

Project Member Reported by danakj@chromium.org, May 16 2017 
1.
MakeUnique returns unique_ptr
MakeShared does not return shared_ptr

2.
MakeUnique makes a unique thing and returns a smartptr for it.
MakeRefCounted makes a RefCounted thing and returns a smartptr for it.

Comment 1 by tzik@chromium.org, May 18 2017

Owner: tzik@chromium.org
Status: Started (was: Available)

Comment 2 by tzik@chromium.org, May 26 2017

Components: Internals>Core
Status: Fixed (was: Started)
Done as https://chromium.googlesource.com/chromium/src/+/36c517ded30b1b6050e3320dd8dbd9a28383b4b6

Comment 3 by danakj@chromium.org, May 26 2017 

Thanks :)
►

Sign in to add a comment