New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 722881 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Don't send phishguard pings from local IP addresses

Project Member Reported by jialiul@chromium.org, May 16 2017

Issue description

We should not trigger phishguard pings from local or private IP address/URL, e.g. 192.168.x.x, 10.0.x.x, and 127.0.0.1
 
Description: Show this description

Comment 2 by vakh@chromium.org, May 19 2017

Description: Show this description

Comment 3 by vakh@chromium.org, May 19 2017

Labels: SafeBrowsing-Triaged
Project Member

Comment 4 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8634cdd25aefa688d90bc1b14106d2a79ece395a

commit 8634cdd25aefa688d90bc1b14106d2a79ece395a
Author: jialiul <jialiul@chromium.org>
Date: Tue May 23 18:58:28 2017

Don't trigger Phishguard pings if we cannot compute URL reputation.

e.g.: private URL/IP addresses, hostname/IP in an IANA-reserved range,
hostname is a not-yet-assigned by ICANN gTLD, dotless domains

Also minor refactor in PasswordProtectionService and
PasswordProtectionService to pass in web_contents in preparation for
showing interstitial.

BUG= 722881 

Review-Url: https://codereview.chromium.org/2892093003
Cr-Commit-Position: refs/heads/master@{#474005}

[modify] https://crrev.com/8634cdd25aefa688d90bc1b14106d2a79ece395a/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/8634cdd25aefa688d90bc1b14106d2a79ece395a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/8634cdd25aefa688d90bc1b14106d2a79ece395a/components/safe_browsing/password_protection/password_protection_request.cc
[modify] https://crrev.com/8634cdd25aefa688d90bc1b14106d2a79ece395a/components/safe_browsing/password_protection/password_protection_request.h
[modify] https://crrev.com/8634cdd25aefa688d90bc1b14106d2a79ece395a/components/safe_browsing/password_protection/password_protection_service.cc
[modify] https://crrev.com/8634cdd25aefa688d90bc1b14106d2a79ece395a/components/safe_browsing/password_protection/password_protection_service.h
[modify] https://crrev.com/8634cdd25aefa688d90bc1b14106d2a79ece395a/components/safe_browsing/password_protection/password_protection_service_unittest.cc
[modify] https://crrev.com/8634cdd25aefa688d90bc1b14106d2a79ece395a/tools/metrics/histograms/enums.xml

Status: Fixed (was: Assigned)

Sign in to add a comment