New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 722878 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Shelf context menu does not spawn at cursor position

Project Member Reported by jamescook@chromium.org, May 16 2017

Issue description

Chrome ToT r472100

out/Default/chrome --ash-host-window-bounds="0+0-1366x768" --user-data-dir=/tmp/udd --ash-dev-shortcuts --ash-debug-shortcuts --login-manager

then log in. Right click on shelf.

The menu spawns inside the work area. See screenshot.

The lower-left corner of the menu ought to be at the cursor position.

msw, feel free to reassign.

+some people who might know about work area changes

 
shelf-menu-not-under-cursor.png
20.9 KB View Download

Comment 1 by msw@chromium.org, May 16 2017

Cc: sgabr...@chromium.org msw@chromium.org
Owner: minch@chromium.org
This is almost certainly from https://codereview.chromium.org/2861873002 for Issue 710601.
Assigning to minch@ and CC'ing sgabriel@ for triage (perhaps this is also intentional?)

Comment 2 by minch@chromium.org, May 16 2017

sgabriel@, I think this is what we want in Issue 710601. To make the context menu
align the edge of the shelf. Or do we only want to change it for touch events, 
not for mouse events?
It's pretty weird for mouse events. Context menus always spawn next to the mouse, to minimize mouse movement before selecting an item and to visually "tie" the menu to the click location.

Project Member

Comment 4 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d6beb026bad006fcac55b98bc12cfa4d11c6231

commit 3d6beb026bad006fcac55b98bc12cfa4d11c6231
Author: minch <minch@chromium.org>
Date: Wed May 17 18:17:30 2017

Shelf context menu should spawn at cursor position for mouse events.

BUG= 722878 

Review-Url: https://codereview.chromium.org/2885313002
Cr-Commit-Position: refs/heads/master@{#472504}

[modify] https://crrev.com/3d6beb026bad006fcac55b98bc12cfa4d11c6231/ash/shelf/shelf_view.cc

I'm comfortable keeping this menu's specific behavior similar for touch and mouse.

Comment 6 by minch@chromium.org, May 19 2017

Status: Fixed (was: Assigned)

Comment 7 by sontis@chromium.org, Sep 13 2017

Status: Verified (was: Fixed)
verified on build 9592.94.0

Sign in to add a comment