New issue
Advanced search Search tips

Issue 722868 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 722827



Sign in to add a comment

Make sure Cronet internal builders don't enable DCHECKs

Project Member Reported by mge...@chromium.org, May 16 2017

Issue description

chromium-dev is discussing turning on DCHECKs even for release builds when is_official_build=false. Cronet currently builds with is_official_build=false even on internal builders, so we need to either change that or set dcheck_always_on=false.
 

Comment 1 by mef@chromium.org, May 16 2017

Cc: jbudorick@chromium.org
Status: Available (was: Untriaged)
The change has landed and resulted in 21% increase of release binary size. 
I'm pretty sure that we need to set is_official_build=true on internal official bots.

I'm not sure what to do about ToTT continuous builders, but I think that it makes sense to set is_official_build=true on those as well, so they test same configuration as is built from official branch.
I'd agree that it makes sense to build external the same way as internal.

Comment 3 by gab@chromium.org, May 17 2017

Blocking: 722827
FWIW, is_official_build=true is purely an optimization step (is_chrome_branded is what makes it Google Chrome).

I'll flag 722827 on this, should we block on you resolving this issue?

Comment 4 by mef@chromium.org, May 17 2017

We don't need the branding, but we do need optimizations, so is_official_build=true seems like a good flag.

Comment 5 by mef@chromium.org, May 17 2017

WRT blocking 722827 on this, what would that mean? 
Would you rollback your CL until we add a is_official_build=true to cronet builders?
Project Member

Comment 6 by bugdroid1@chromium.org, May 17 2017

Comment 7 by mef@chromium.org, May 17 2017

Owner: mef@chromium.org
Status: Started (was: Available)
The CL for internal bots has landed, and public bots changes are going through CQ now.

Comment 8 by gab@chromium.org, May 17 2017

Re. "Would you rollback your CL until we add a is_official_build=true to cronet builders?"

The CL was reverted after hitting quirks in many directions, I'm using blocking bugs to track all of them. Thanks for fixing your side of things :)
Project Member

Comment 9 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c837199faf1546a1d7354eab6a9de9f66ec5f2b

commit 0c837199faf1546a1d7354eab6a9de9f66ec5f2b
Author: mef <mef@chromium.org>
Date: Wed May 17 21:43:17 2017

[Cronet] Use is_official_build=true for Cronet builds.

BUG= 722868 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2891533002
Cr-Commit-Position: refs/heads/master@{#472578}

[modify] https://crrev.com/0c837199faf1546a1d7354eab6a9de9f66ec5f2b/components/cronet/tools/cr_cronet.py
[modify] https://crrev.com/0c837199faf1546a1d7354eab6a9de9f66ec5f2b/tools/mb/mb_config.pyl

Comment 10 by mef@chromium.org, May 18 2017

Labels: M-60
Status: Fixed (was: Started)
The is_official_build = true is now set in dev scripts as well as on ToTT and official bots.

Comment 11 by mef@chromium.org, May 19 2017

Owner: jbudorick@chromium.org
Status: Started (was: Fixed)
The flag got applied to all official Cronet builders, including Debug builders, which have failed with assert that debug build cannot be official.
Project Member

Comment 12 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/9709c362f800ceeffd2be24edee6d398d68f18ac

commit 9709c362f800ceeffd2be24edee6d398d68f18ac
Author: John Budorick <jbudorick@chromium.org>
Date: Fri May 19 13:30:49 2017

[cronet] Don't use is_official_build universally on cronet bots.

Bug:  722868 
Change-Id: I1a5f3c30a8b73c7d601d406427fcd14feb37b741
Reviewed-on: https://chromium-review.googlesource.com/508246
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac/scripts/slave/recipes/cronet.expected/android_cronet_marshmallow_64bit_perf.json
[modify] https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac/scripts/slave/recipes/cronet.expected/android_cronet_marshmallow_64bit_builder.json
[modify] https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac/scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder__dbg_.json
[modify] https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac/scripts/slave/recipes/cronet.expected/android_cronet_data_reduction_proxy_builder.json
[modify] https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac/scripts/slave/recipe_modules/chromium_android/tests/configs.py
[modify] https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac/scripts/slave/recipes/cronet.expected/android_cronet_mips_builder.json
[modify] https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac/scripts/slave/recipes/cronet.expected/android_cronet_tester.json
[modify] https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac/scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json
[modify] https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac/scripts/slave/recipes/cronet.expected/android_cronet_kitkat_builder.json
[modify] https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac/scripts/slave/recipes/cronet.expected/android_cronet_armv6_builder.json
[modify] https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac/scripts/slave/recipes/cronet.expected/cronet_try.json
[modify] https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac/scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json
[modify] https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac/scripts/slave/recipes/cronet.expected/local_test.json
[modify] https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac/scripts/slave/recipe_modules/cronet/example.expected/local_test.json
[modify] https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac/scripts/slave/recipes/cronet.py
[modify] https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac/scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json
[modify] https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac/scripts/slave/recipe_modules/cronet/example.expected/gn_test.json
[modify] https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac/scripts/slave/recipes/cronet.expected/android_cronet_x86_builder.json
[modify] https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac/scripts/slave/recipe_modules/cronet/example.expected/mb_test.json
[modify] https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac/scripts/slave/recipes/cronet.expected/android_cronet_x86_builder__dbg_.json
[modify] https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac/scripts/slave/recipe_modules/chromium_android/chromium_config.py
[modify] https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac/scripts/slave/recipes/cronet.expected/android_cronet_lollipop_builder.json

Project Member

Comment 13 by bugdroid1@chromium.org, May 19 2017

Status: Fixed (was: Started)

Sign in to add a comment