chromium-dev is discussing turning on DCHECKs even for release builds when is_official_build=false. Cronet currently builds with is_official_build=false even on internal builders, so we need to either change that or set dcheck_always_on=false.
Cc: jbudorick@chromium.org Status: Available (was: Untriaged)
The change has landed and resulted in 21% increase of release binary size.
I'm pretty sure that we need to set is_official_build=true on internal official bots.
I'm not sure what to do about ToTT continuous builders, but I think that it makes sense to set is_official_build=true on those as well, so they test same configuration as is built from official branch.
FWIW, is_official_build=true is purely an optimization step (is_chrome_branded is what makes it Google Chrome).
I'll flag 722827 on this, should we block on you resolving this issue?
Re. "Would you rollback your CL until we add a is_official_build=true to cronet builders?"
The CL was reverted after hitting quirks in many directions, I'm using blocking bugs to track all of them. Thanks for fixing your side of things :)
Comment 1 by mef@chromium.org
, May 16 2017Status: Available (was: Untriaged)