New issue
Advanced search Search tips

Issue 722867 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

10.8%-36.6% regression in blink_perf.layout at 471206:471298

Project Member Reported by lanwei@chromium.org, May 16 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 16 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: winx64ati_perf_bisect
  Benchmark    : blink_perf.layout
  Metric       : floats_100_100/floats_100_100

Revision             Result                  N
chromium@471247      93.7155 +- 6.12544      21      good
chromium@471290      94.8575 +- 8.54434      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.layout

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979425435148761680

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=4834083458252800


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: WontFix (was: Untriaged)
Looks like the ref build jumped too. probably a change in the test?
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, May 17 2017

Cc: maxmorin@chromium.org
Owner: maxmorin@chromium.org

=== Auto-CCing suspected CL author maxmorin@chromium.org ===

Hi maxmorin@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Max Morin
  Commit : a50d914e18c636fb8a37bf622ef8bd8728c9d2b7
  Date   : Fri May 12 08:35:02 2017
  Subject: Revert "[reland] Support generation of component targets for Mojom C++ bindings"

Bisect Details
  Configuration: winx64ati_perf_bisect
  Benchmark    : blink_perf.layout
  Metric       : floats_100_100/floats_100_100
  Change       : 3.04% | 91.9491666667 -> 94.7458333333

Revision             Result                   N
chromium@471247      91.9492 +- 0.447257      6      good
chromium@471249      92.5223 +- 1.13489       6      good
chromium@471250      94.9545 +- 0.880077      6      bad       <--
chromium@471253      93.299 +- 1.64826        6      bad
chromium@471258      95.3053 +- 2.20293       6      bad
chromium@471269      93.1587 +- 0.533122      6      bad
chromium@471290      94.7458 +- 2.96992       6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.layout

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979401386486749072

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=4834083458252800


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
That CL (#471250) is a revert of CL #471238, but looking at the graphs it looks like the rise corresponds to a dip at about ~469150, so I don't think my revert is related.

Sign in to add a comment