New issue
Advanced search Search tips

Issue 722861 link

Starred by 1 user
Status: Fixed
Owner:
cjgrant@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature
Proj-VR
Proj-XR
Proj-XR-VR

Blocked on:
issue 727373


Sign in to add a comment

URL indicator should properly color and emphasize URL according to security guidelines

Project Member Reported by cjgrant@chromium.org, May 16 2017 
For BBB, conformance to Enamel's security guidelines may be reducible to two parts:

1. In VR, show whatever visual security state we can manage.
2. If we cannot manage sufficient visual affordance, bail out of VR.

This bug tracks the VR visual affordance.

For BBB, we will target the minimum possible bar as dictated by the Enamel team, and do better if we can.  The target must be specified by Enamel, and may initially be specified by a set of test cases (ie. when you visit this site, you should see this).  Further details are TBD.
Project Member

Comment 1 by bugdroid1@chromium.org, May 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f0095b330f52533f1cad17bb6df7f4480eadf0e

commit 6f0095b330f52533f1cad17bb6df7f4480eadf0e
Author: cjgrant <cjgrant@chromium.org>
Date: Fri May 26 18:27:34 2017

VR: Add URL bar security-related coloring and emphasis.

- Use url_formatter to format the URL string (eg. chop off http://)
- Use code similar to OmniboxView to emphasize and color the string.

BUG= 722861 

Review-Url: https://codereview.chromium.org/2902783002
Cr-Commit-Position: refs/heads/master@{#475065}

[modify] https://crrev.com/6f0095b330f52533f1cad17bb6df7f4480eadf0e/chrome/browser/android/vr_shell/BUILD.gn
[add] https://crrev.com/6f0095b330f52533f1cad17bb6df7f4480eadf0e/chrome/browser/android/vr_shell/textures/render_text_wrapper.cc
[add] https://crrev.com/6f0095b330f52533f1cad17bb6df7f4480eadf0e/chrome/browser/android/vr_shell/textures/render_text_wrapper.h
[modify] https://crrev.com/6f0095b330f52533f1cad17bb6df7f4480eadf0e/chrome/browser/android/vr_shell/textures/url_bar_texture.cc
[modify] https://crrev.com/6f0095b330f52533f1cad17bb6df7f4480eadf0e/chrome/browser/android/vr_shell/textures/url_bar_texture.h
[add] https://crrev.com/6f0095b330f52533f1cad17bb6df7f4480eadf0e/chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc
[modify] https://crrev.com/6f0095b330f52533f1cad17bb6df7f4480eadf0e/chrome/browser/android/vr_shell/ui_elements/url_bar.cc
[modify] https://crrev.com/6f0095b330f52533f1cad17bb6df7f4480eadf0e/chrome/browser/android/vr_shell/ui_elements/url_bar.h
[modify] https://crrev.com/6f0095b330f52533f1cad17bb6df7f4480eadf0e/chrome/browser/android/vr_shell/ui_interface.h
[modify] https://crrev.com/6f0095b330f52533f1cad17bb6df7f4480eadf0e/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/6f0095b330f52533f1cad17bb6df7f4480eadf0e/chrome/browser/android/vr_shell/ui_scene_manager.h
[modify] https://crrev.com/6f0095b330f52533f1cad17bb6df7f4480eadf0e/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/6f0095b330f52533f1cad17bb6df7f4480eadf0e/chrome/browser/android/vr_shell/vr_gl_thread.h
Project Member

Comment 2 by bugdroid1@chromium.org, May 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3181fb56c2c8a939c082f4711c985b7123e0b3e8

commit 3181fb56c2c8a939c082f4711c985b7123e0b3e8
Author: vollick <vollick@chromium.org>
Date: Sat May 27 02:34:37 2017

[vr] Bail on unhandled code points.

When we encounter a URL with glyphs we cannot render
we now exit VR mode. This CL also establishes an
"unsupported mode" enumeration and corresponding
metrics.

BUG= 722861 

Review-Url: https://codereview.chromium.org/2902393002
Cr-Commit-Position: refs/heads/master@{#475222}

[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/BUILD.gn
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/font_fallback.cc
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/font_fallback.h
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/textures/exit_warning_texture.cc
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/textures/insecure_content_permanent_texture.cc
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/textures/system_indicator_texture.cc
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/textures/ui_texture.cc
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/textures/ui_texture.h
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/textures/url_bar_texture.cc
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/textures/url_bar_texture.h
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/ui_elements/url_bar.cc
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/ui_elements/url_bar.h
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/ui_scene_manager.h
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
[add] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/ui_unsupported_mode.h
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/vr_browser_interface.h
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/3181fb56c2c8a939c082f4711c985b7123e0b3e8/tools/metrics/histograms/histograms.xml

Comment 3 by vollick@chromium.org, May 29 2017

Labels: Merge-Request-60
Project Member

Comment 4 by sheriffbot@chromium.org, May 29 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by vollick@chromium.org, May 29 2017

Blockedon: 727373

Comment 6 by cjgrant@chromium.org, May 29 2017

Status: Fixed (was: Assigned)
Changing scope of this specific bug to exclude proper eliding, as we don't have that for M-60, and this bug is merge-approved.  Separate bugs will track the "bail if we can't fit the hosthame" and later, proper eliding.

Bailing to 2D bug: crbug/727376

Comment 7 by cjgrant@chromium.org, May 29 2017

Summary: URL indicator should properly color and emphasize URL according to security guidelines (was: URL indicator should properly color and elide URL according to security guidelines)
Editing summary to avoid confusion (eliding is tracked separately).
Project Member

Comment 8 by bugdroid1@chromium.org, May 29 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2f7f8ae486a6a97b387de5306b5a851349b5808

commit f2f7f8ae486a6a97b387de5306b5a851349b5808
Author: Christopher Grant <cjgrant@google.com>
Date: Mon May 29 18:43:12 2017

VR: Add URL bar security-related coloring and emphasis.

- Use url_formatter to format the URL string (eg. chop off http://)
- Use code similar to OmniboxView to emphasize and color the string.

BUG= 722861 

Review-Url: https://codereview.chromium.org/2902783002
Cr-Original-Commit-Position: refs/heads/master@{#475065}
Review-Url: https://codereview.chromium.org/2907153003 .
Cr-Commit-Position: refs/branch-heads/3112@{#15}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/f2f7f8ae486a6a97b387de5306b5a851349b5808/chrome/browser/android/vr_shell/BUILD.gn
[add] https://crrev.com/f2f7f8ae486a6a97b387de5306b5a851349b5808/chrome/browser/android/vr_shell/textures/render_text_wrapper.cc
[add] https://crrev.com/f2f7f8ae486a6a97b387de5306b5a851349b5808/chrome/browser/android/vr_shell/textures/render_text_wrapper.h
[modify] https://crrev.com/f2f7f8ae486a6a97b387de5306b5a851349b5808/chrome/browser/android/vr_shell/textures/url_bar_texture.cc
[modify] https://crrev.com/f2f7f8ae486a6a97b387de5306b5a851349b5808/chrome/browser/android/vr_shell/textures/url_bar_texture.h
[add] https://crrev.com/f2f7f8ae486a6a97b387de5306b5a851349b5808/chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc
[modify] https://crrev.com/f2f7f8ae486a6a97b387de5306b5a851349b5808/chrome/browser/android/vr_shell/ui_elements/url_bar.cc
[modify] https://crrev.com/f2f7f8ae486a6a97b387de5306b5a851349b5808/chrome/browser/android/vr_shell/ui_elements/url_bar.h
[modify] https://crrev.com/f2f7f8ae486a6a97b387de5306b5a851349b5808/chrome/browser/android/vr_shell/ui_interface.h
[modify] https://crrev.com/f2f7f8ae486a6a97b387de5306b5a851349b5808/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/f2f7f8ae486a6a97b387de5306b5a851349b5808/chrome/browser/android/vr_shell/ui_scene_manager.h
[modify] https://crrev.com/f2f7f8ae486a6a97b387de5306b5a851349b5808/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/f2f7f8ae486a6a97b387de5306b5a851349b5808/chrome/browser/android/vr_shell/vr_gl_thread.h
Project Member

Comment 9 by bugdroid1@chromium.org, May 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86a8661f2efe60271e9311d0cb9f03ecd8499940

commit 86a8661f2efe60271e9311d0cb9f03ecd8499940
Author: Christopher Grant <cjgrant@google.com>
Date: Mon May 29 18:59:35 2017

[vr] Bail on unhandled code points.

When we encounter a URL with glyphs we cannot render
we now exit VR mode. This CL also establishes an
"unsupported mode" enumeration and corresponding
metrics.

BUG= 722861 

Review-Url: https://codereview.chromium.org/2902393002
Cr-Original-Commit-Position: refs/heads/master@{#475222}
Review-Url: https://codereview.chromium.org/2914543002 .
Cr-Commit-Position: refs/branch-heads/3112@{#17}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/BUILD.gn
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/font_fallback.cc
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/font_fallback.h
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/textures/exit_warning_texture.cc
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/textures/insecure_content_permanent_texture.cc
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/textures/system_indicator_texture.cc
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/textures/ui_texture.cc
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/textures/ui_texture.h
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/textures/url_bar_texture.cc
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/textures/url_bar_texture.h
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/ui_elements/url_bar.cc
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/ui_elements/url_bar.h
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/ui_scene_manager.h
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
[add] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/ui_unsupported_mode.h
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/vr_browser_interface.h
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/86a8661f2efe60271e9311d0cb9f03ecd8499940/tools/metrics/histograms/histograms.xml

Comment 10 by ddorwin@chromium.org, Jun 6 2017

Labels: Proj-VR-Shell
►

Sign in to add a comment