New issue
Advanced search Search tips

Issue 722856 link

Starred by 1 user
Status: Duplicate
Merged: issue 724180
Owner:
jeffcarp@chromium.org
Closed: Jun 2017
Cc:
qyears...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 707006



Sign in to add a comment

[WPT Export] Add failing status to provisional PRs to prevent manual merging

Project Member Reported by jeffcarp@google.com, May 16 2017 
Since anyone can come along and merge provisional PRs, and the workflow is new to people, someone might merge a provisional PR before it's landed upstream. We should figure out how to block the PR, either by requiring a review or by adding something to WPT CI, so that this doesn't happen.

It happened on our first provisional export:
https://chromium-review.googlesource.com/c/506009/

Comment 1 by jeffcarp@chromium.org, Jun 1 2017

Labels: -Type-Bug -Pri-3 Pri-2 Type-Feature
Summary: [WPT Export] Add failing status to provisional PRs to prevent manual merging (was: [WPT Export] We need way of blocking provisional PRs upstream)
jgraham suggested the best way to do this is to add a failing status to the PR:
https://developer.github.com/v3/repos/statuses/

Comment 2 by jeffcarp@chromium.org, Jun 1 2017

Mergedinto: 724180
Status: Duplicate (was: Assigned)

Comment 3 by foolip@chromium.org, Jul 3 2017

Components: Blink>Infra>Ecosystem

Comment 4 by foolip@chromium.org, Jul 3 2017

Components: -Blink>Infra>Predictability
►

Sign in to add a comment