Chrome displays this JPEG image badly |
||||
Issue descriptionIn 60.0.3100.0, the attached JPEG image (“22nd Street Closed Posting.JPG”) displays badly. See bad.png. It displays correctly in the current stable version, 58.0.3029.110. See ok.png. macOS 10.12.5 16F73 on a MacBookPro11,3.
,
May 17 2017
(Matt are you on the list for Internals>Images>Codecs?)
,
May 17 2017
@scroggo, I'm not on that list. Do you know how I can subscribe?
,
May 17 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/e31d8a148467a56fd01e0ae0afa2a733f9dbf90e commit e31d8a148467a56fd01e0ae0afa2a733f9dbf90e Author: Matt Sarett <msarett@google.com> Date: Wed May 17 19:56:10 2017 SkColorSpace_ICC: classify two entry tables as linear The bug linked in this CL was caused by the switch to SkJumper - where we decided to stop interpolating table-lookups. In this case, the image has tables with two entries: 0, 1. This fixes the bug by optimizing away the table lookup for these trivial no-op tables. I think this is a good change on its own. We see these tables fairly regularly. A more robust fix would expand "small" tables into larger ones through interpolation. Should we also do this? Bug: 722855 Change-Id: I3881734c6f28b5519cbe593dd05cc7b6b1b8a9d0 Reviewed-on: https://skia-review.googlesource.com/17272 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Matt Sarett <msarett@google.com> [modify] https://crrev.com/e31d8a148467a56fd01e0ae0afa2a733f9dbf90e/src/core/SkColorSpace_ICC.cpp
,
May 18 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/9d2d7bfc920772b5e8ec31eae8e3ec88704e943f commit 9d2d7bfc920772b5e8ec31eae8e3ec88704e943f Author: Matt Sarett <msarett@google.com> Date: Thu May 18 16:15:05 2017 Expand small tables in SkColorSpaceXform_A2B Bug: 722855 Change-Id: Id3661be1e9747ac0de1e35b60d334ee8187a5be5 Reviewed-on: https://skia-review.googlesource.com/17312 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> [modify] https://crrev.com/9d2d7bfc920772b5e8ec31eae8e3ec88704e943f/src/core/SkColorSpaceXform_A2B.h [modify] https://crrev.com/9d2d7bfc920772b5e8ec31eae8e3ec88704e943f/infra/bots/assets/skimage/VERSION [modify] https://crrev.com/9d2d7bfc920772b5e8ec31eae8e3ec88704e943f/infra/bots/tasks.json [modify] https://crrev.com/9d2d7bfc920772b5e8ec31eae8e3ec88704e943f/src/core/SkColorSpaceXform_A2B.cpp
,
May 19 2017
,
May 23 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by schenney@chromium.org
, May 17 2017Labels: -Pri-1 -M-60 BugSource-Chromium PaintTeamTriaged-20170517 Pri-2