New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 722836 link

Starred by 0 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Input/screen capture notifications

Project Member Reported by acondor@google.com, May 16 2017

Issue description

In VR browsing mode, when the tab is capturing audio, video or screen, notifications need to be shown to the user.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60119e7d384db63360b0e6f4f50edb7dcebf57e5

commit 60119e7d384db63360b0e6f4f50edb7dcebf57e5
Author: asimjour <asimjour@chromium.org>
Date: Wed May 17 22:38:00 2017

VR: Update UiSceneManager with audio/video capturing flags

UiSceneManager is updated to receive the capturing flags and show
the indicators accordingly.

BUG= 722836 

Review-Url: https://codereview.chromium.org/2890563003
Cr-Commit-Position: refs/heads/master@{#472592}

[modify] https://crrev.com/60119e7d384db63360b0e6f4f50edb7dcebf57e5/chrome/browser/android/vr_shell/ui_interface.h
[modify] https://crrev.com/60119e7d384db63360b0e6f4f50edb7dcebf57e5/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/60119e7d384db63360b0e6f4f50edb7dcebf57e5/chrome/browser/android/vr_shell/ui_scene_manager.h
[modify] https://crrev.com/60119e7d384db63360b0e6f4f50edb7dcebf57e5/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
[modify] https://crrev.com/60119e7d384db63360b0e6f4f50edb7dcebf57e5/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/60119e7d384db63360b0e6f4f50edb7dcebf57e5/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/60119e7d384db63360b0e6f4f50edb7dcebf57e5/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/60119e7d384db63360b0e6f4f50edb7dcebf57e5/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/60119e7d384db63360b0e6f4f50edb7dcebf57e5/chrome/browser/android/vr_shell/vr_shell_gl.h

Project Member

Comment 3 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9d264174d41df066ab32166e4495f19da8c6d9c

commit f9d264174d41df066ab32166e4495f19da8c6d9c
Author: acondor <acondor@google.com>
Date: Fri May 19 18:35:13 2017

VR: UiElement for Screen Capture indicator

- Screen share icon was moved from ash resources to a more common place (ui).

BUG= 722836 
TBR=blundell@chromium.org

Review-Url: https://codereview.chromium.org/2891503002
Cr-Commit-Position: refs/heads/master@{#473254}

[modify] https://crrev.com/f9d264174d41df066ab32166e4495f19da8c6d9c/ash/BUILD.gn
[modify] https://crrev.com/f9d264174d41df066ab32166e4495f19da8c6d9c/ash/DEPS
[modify] https://crrev.com/f9d264174d41df066ab32166e4495f19da8c6d9c/ash/resources/vector_icons/BUILD.gn
[modify] https://crrev.com/f9d264174d41df066ab32166e4495f19da8c6d9c/ash/system/screen_security/screen_tray_item.cc
[modify] https://crrev.com/f9d264174d41df066ab32166e4495f19da8c6d9c/chrome/app/generated_resources.grd
[modify] https://crrev.com/f9d264174d41df066ab32166e4495f19da8c6d9c/chrome/browser/android/vr_shell/BUILD.gn
[add] https://crrev.com/f9d264174d41df066ab32166e4495f19da8c6d9c/chrome/browser/android/vr_shell/ui_elements/screen_capture_indicator.cc
[add] https://crrev.com/f9d264174d41df066ab32166e4495f19da8c6d9c/chrome/browser/android/vr_shell/ui_elements/screen_capture_indicator.h
[modify] https://crrev.com/f9d264174d41df066ab32166e4495f19da8c6d9c/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/f9d264174d41df066ab32166e4495f19da8c6d9c/chrome/browser/android/vr_shell/ui_scene_manager.h
[add] https://crrev.com/f9d264174d41df066ab32166e4495f19da8c6d9c/components/vector_icons/BUILD.gn
[add] https://crrev.com/f9d264174d41df066ab32166e4495f19da8c6d9c/components/vector_icons/OWNERS
[rename] https://crrev.com/f9d264174d41df066ab32166e4495f19da8c6d9c/components/vector_icons/screen_share.1x.icon
[rename] https://crrev.com/f9d264174d41df066ab32166e4495f19da8c6d9c/components/vector_icons/screen_share.icon
[add] https://crrev.com/f9d264174d41df066ab32166e4495f19da8c6d9c/components/vector_icons/vector_icons.cc.template
[add] https://crrev.com/f9d264174d41df066ab32166e4495f19da8c6d9c/components/vector_icons/vector_icons.h.template

Project Member

Comment 4 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3410b8cf2a5048561552018a9b3ca10c14698a5a

commit 3410b8cf2a5048561552018a9b3ca10c14698a5a
Author: asimjour <asimjour@chromium.org>
Date: Thu May 25 18:25:16 2017

VR: keep track of all pages that are recording audio/video/screen

When enter VR, keep track of all pages that are captureing audio/video/screen.

BUG= 722836 

Review-Url: https://codereview.chromium.org/2902813003
Cr-Commit-Position: refs/heads/master@{#474712}

[modify] https://crrev.com/3410b8cf2a5048561552018a9b3ca10c14698a5a/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/3410b8cf2a5048561552018a9b3ca10c14698a5a/chrome/browser/android/vr_shell/vr_shell.h

Labels: Merge-Request-60
Labels: -Merge-Request-60
Labels: Merge-Request-60
Project Member

Comment 8 by sheriffbot@chromium.org, May 29 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: There is .grd file changes and we are only 63 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please tag with applicable OSs.  Thanks.
Labels: OS-Android
Labels: -Merge-Review-60 Merge-Approved-60
Merge of 3410b8cf2a5048561552018a9b3ca10c14698a5a approved for M60 branch 3112.  Please note that it appears you are merging new counters, I assume for UMA or other debugging purposes - in the future, these types of changes will be rejected, as the expectation is that we land all relevant metrics by feature freeze.  Plan accordingly for M61 and other new features.
I was asking for approval to merge this CL: https://codereview.chromium.org/2903673002/

For some reason it doesn't show up here!

3410b8cf2a5048561552018a9b3ca10c14698a5a was already landed and it wasn't a new feature.
I see - in the future please be specific with merge requests to avoid confusion.  Please also add context as to why this is important to the user.  Simply adding the "merge request" tag gives someone who has no context on the issue very little to work with.

The CL you are requesting is OK for a merge as well.
Cc: -asimjour@chromium.org
Owner: asimjour@chromium.org
Status: Fixed (was: Started)
Labels: Proj-VR-Shell
Status: Verified (was: Fixed)
Verified that a notification does appear while capturing microphone in  60.0.3112.78.

However,  bug 738209  still blocks the test case where a notification appears after enabling it withing Chrome VR.

Sign in to add a comment