New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 722828 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: May 2017
Cc:
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

ContentSuggestionsCells are over constrained

Project Member Reported by gambard@chromium.org, May 16 2017 
(1) Open ContentSuggestions
(2) Scroll down
(3) Scroll up

A constraint is broken by iOS and an error appears in the debugger info.
This comes from the difference between the suggestions with subtitle and the others. When a cell is reused, the subtitle is not yet removed, taking too much space in the cell.
Project Member

Comment 1 by bugdroid1@chromium.org, May 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/592962e6471424fd4c33950d7345fb6dca802f11

commit 592962e6471424fd4c33950d7345fb6dca802f11
Author: gambard <gambard@chromium.org>
Date: Tue May 16 14:12:18 2017

Fix the ContentSuggestionsCell reuse cleanup

The ContentSuggestionsCell can have different layout. The -prepareForReuse
should do cleanup to make sure the layout used after this call is small
enough to fit all possible layout.

BUG= 722828 

Review-Url: https://codereview.chromium.org/2889573002
Cr-Commit-Position: refs/heads/master@{#472096}

[modify] https://crrev.com/592962e6471424fd4c33950d7345fb6dca802f11/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.mm

Comment 2 by gambard@chromium.org, May 16 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment