Media controls tests runAfterHideMediaControlsTimerFired is a slow hack |
||
Issue description14 media controls layout tests use the runAfterHideMediaControlsTimerFired function[1] to wait until the media controls timer hides the media controls. This function is very slow (it sleeps for 3700ms), and causes some of these tests to timeout or have to be listed in SlowTests. It would be more efficient to fast forward time instead of sleeping. [1]: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/media/media-controls.js?l=205&rcl=ff7a2feb08b4ef4127d3affabde41f77dbbc636d&q=runAfterHideMediaControlsTimerFired
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f9a4ddd4e17adce15d7e8e55a4554d7a420d1e3 commit 7f9a4ddd4e17adce15d7e8e55a4554d7a420d1e3 Author: Xida Chen <xidachen@chromium.org> Date: Mon Apr 23 15:45:52 2018 Mark video-enter-exit-fullscreen-while-hovering-shows-controls.html timeout It has been timing out for a while: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=video-enter-exit-fullscreen-while-hovering-shows-controls.html TBR=thestig@chromium.org NOTRY=true Bug: 722825 Change-Id: Ic8983434ac695a8afe42b5ec740f0ca80c84a96c Reviewed-on: https://chromium-review.googlesource.com/1023983 Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#552708} [modify] https://crrev.com/7f9a4ddd4e17adce15d7e8e55a4554d7a420d1e3/third_party/WebKit/LayoutTests/SlowTests [modify] https://crrev.com/7f9a4ddd4e17adce15d7e8e55a4554d7a420d1e3/third_party/WebKit/LayoutTests/TestExpectations
,
Aug 1
|
||
►
Sign in to add a comment |
||
Comment 1 by mlamouri@chromium.org
, May 17 2017Owner: mlamouri@chromium.org
Status: Available (was: Untriaged)