New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 722811 link

Starred by 1 user
Status: Fixed
Owner:
afakhry@chromium.org
Closed: May 2017
Cc:
█ fjhenigman@chromium.org
weiliangc@chromium.org
tapted@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

generate_build_files failing on Linux ChromiumOS Ozone Builder

Project Member Reported by cwallez@chromium.org, May 16 2017 
The failure starts at this build, which has only one commit that looks very related: https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/14485

The commit: https://chromium.googlesource.com/chromium/src/+/e3880da51bf9da14f748d00ac7b5741989107696

The failure:
ERROR at //chrome/browser/ui/views/harmony/chrome_typography.h:13:11: Include not allowed.
#include "ash/public/cpp/ash_typography.h"
          ^------------------------------
It is not in any dependency of
  //chrome/browser/ui:ui
The include file is in the target(s):
  //ash/public/cpp:ash_public_cpp
which should somehow be reachable.
___________________
ERROR at //chrome/browser/ui/views/harmony/harmony_typography_provider.cc:12:11: Include not allowed.
#include "ash/public/cpp/ash_typography.h"
          ^------------------------------
It is not in any dependency of
  //chrome/browser/ui:ui
The include file is in the target(s):
  //ash/public/cpp:ash_public_cpp
which should somehow be reachable.

tapted@, can you take a look? It looks like the error is triggered by a block in a USE_ASH guard, which is a bit weird. Also ccing fjhenigman@ that knows more about this bot.

Comment 1 by tapted@chromium.org, May 22 2017

Cc: tapted@chromium.org
Owner: afakhry@chromium.org
#c0 was fixed in r472384

But there's a new one from r472400 "[Night Light] CL3: Initial System Settings work"


/b/c/b/Linux_ChromiumOS_Ozone_Builder/src/buildtools/linux64/gn gen //out/Release --check
  -> returned 1
ERROR at //chrome/browser/extensions/api/settings_private/prefs_util.cc:36:11: Include not allowed.
#include "ash/public/cpp/ash_pref_names.h"
          ^------------------------------
It is not in any dependency of
  //chrome/browser/extensions:extensions
The include file is in the target(s):
  //ash/public/cpp:ash_public_cpp
which should somehow be reachable.
GN gen failed: 1
step returned non-zero exit code: 1
Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6510e3d00f827f2f071d333a47a560fa9fe41dbf

commit 6510e3d00f827f2f071d333a47a560fa9fe41dbf
Author: tapted <tapted@chromium.org>
Date: Mon May 22 04:06:37 2017

Add nogncheck to OS_CHROMEOS-guarded #include from r472400.

gn check doesn't understand preprocessor directives.

Currently a failure results on the Ozone FYI builders.

BUG= 722811 
TBR=afakhry@chromium.org, dbeam@chromium.org

Review-Url: https://codereview.chromium.org/2892423002
Cr-Commit-Position: refs/heads/master@{#473501}

[modify] https://crrev.com/6510e3d00f827f2f071d333a47a560fa9fe41dbf/chrome/browser/extensions/api/settings_private/prefs_util.cc
►

Sign in to add a comment