New issue
Advanced search Search tips

Issue 722792 link

Starred by 1 user
Status: Fixed
Owner:
hajimehoshi@chromium.org
Closed: May 2017
Cc:
tasak@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocking:
issue 635419



Sign in to add a comment

DCHECK failure in histogram_base.cc

Project Member Reported by jkummerow@chromium.org, May 16 2017 
Chrome Version: ToT (c7131815b9cd8ff / 472044)
OS: Linux (x64)

What steps will reproduce the problem?
(1) Compile ToT in Debug mode
(2) open a few tabs (e.g. a Google Doc, Maps, a CNN.com article)
(3) go for lunch (I believe it doesn't matter what you eat)
(4) Come back to find a DCHECK failure:

[89127:89127:0516/130820.824865:FATAL:histogram_base.cc(73)] Check failed: histogram_name() == name (PurgeAndSuspend.Experimental.MemoryGrowth.PartitionAllocKB.30min vs. PurgeAndSuspend.Experimental.MemoryGrowth.PartitionAllocKB.60min)

Please fix urgently; running into failing DCHECKs while chasing after something else is annoying.

Comment 1 by tasak@google.com, May 16 2017

Cc: tasak@google.com
Owner: hajimehoshi@chromium.org
Status: Assigned (was: Untriaged)
Yeah, obviously this is caused by my path: https://codereview.chromium.org/2843373004/

I tried to revert the patch but codereview said that I have to use manual revert...
Since I'm visiting MTV office, it is a little difficult to create the patch.

hajimehoshi@, would you take a look at this issue?
I think, just disabling the following lines to avoid this issue:
---
  // record how many memory usage increases after purged.
  // Since RenderThreadImpl is kept alive while its render process is alive,
  // it is possible to use base::Unretained(this) here.
  GetRendererScheduler()->DefaultTaskRunner()->PostDelayedTask(
      FROM_HERE,
      base::Bind(&RenderThreadImpl::RecordPurgeAndSuspendMemoryGrowthMetrics,
                 base::Unretained(this), "30min", process_foregrounded_count_),
      base::TimeDelta::FromMinutes(30));
  GetRendererScheduler()->DefaultTaskRunner()->PostDelayedTask(
      FROM_HERE,
      base::Bind(&RenderThreadImpl::RecordPurgeAndSuspendMemoryGrowthMetrics,
                 base::Unretained(this), "60min", process_foregrounded_count_),
      base::TimeDelta::FromMinutes(60));
  GetRendererScheduler()->DefaultTaskRunner()->PostDelayedTask(
      FROM_HERE,
      base::Bind(&RenderThreadImpl::RecordPurgeAndSuspendMemoryGrowthMetrics,
                 base::Unretained(this), "90min", process_foregrounded_count_),
      base::TimeDelta::FromMinutes(90));
---
I will investigate deeply after the bussiness trip.
Project Member

Comment 3 by bugdroid1@chromium.org, May 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1870aebe1a769e4220a3ba1025bed28d19300c71

commit 1870aebe1a769e4220a3ba1025bed28d19300c71
Author: hajimehoshi <hajimehoshi@chromium.org>
Date: Thu May 18 07:54:28 2017

Disable recoding purge-and-suspend memory growth temporarily

Recoding purge-and-suspend memory growth introduced at
crrev.com/2843373004 causes DCHECK errors. This CL removes them
temporarily.

BUG= 722792 , 670539, 635419

Review-Url: https://codereview.chromium.org/2893863002
Cr-Commit-Position: refs/heads/master@{#472729}

[modify] https://crrev.com/1870aebe1a769e4220a3ba1025bed28d19300c71/content/renderer/render_thread_impl.cc

Comment 4 by hajimehoshi@chromium.org, May 19 2017

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, May 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a27961af152737aeb934c77180b9667e51bbee06

commit a27961af152737aeb934c77180b9667e51bbee06
Author: tasak <tasak@google.com>
Date: Wed May 24 07:33:25 2017

Reenable Purge+Suspend Memory Growth metrics.

Fix DCHECK failure in base::HistogramBase::CheckName(). We need to use different
scope for each histogram name, because UMA_HISTOGRAM macro defines a static variable and checks whether the histogram name stored in the variable is the same as newly given histogram names or not.

BUG= 722792 , 670539, 635419

Review-Url: https://codereview.chromium.org/2899683002
Cr-Commit-Position: refs/heads/master@{#474197}

[modify] https://crrev.com/a27961af152737aeb934c77180b9667e51bbee06/content/renderer/render_thread_impl.cc
►

Sign in to add a comment