New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 722779 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

No way to pull Render Test results directly onto local computer.

Project Member Reported by peconn@chromium.org, May 16 2017

Issue description

If the --gs_results_bucket option is provided the results are uploaded to Google storage, which is good for trybot results. However it would also be handy to allow a developer to get the screenshots directly.

The render tests are run locally and the outputs get put into render_test_output_dir which is removed once the tests are run [1].

We could not delete this directory after running the tests and allow the developer to pull the images off the device manually - potentially clearing that directory before running tests so images from different test runs are not mixed.

Alternatively, we could pull the images to the computer (similar to how screenshot_dir works).

[1] - https://cs.chromium.org/chromium/src/build/android/pylib/local/device/local_device_instrumentation_test_run.py?l=408
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39e3f9e3bdd92088ebf9c48bfd9395ebe38d7801

commit 39e3f9e3bdd92088ebf9c48bfd9395ebe38d7801
Author: mikecase <mikecase@chromium.org>
Date: Thu May 18 04:57:46 2017

Add --render-results-dir arg to store render results locally.

If --render-results-dir is specified, the render result images
will get pulled from the device and stored there locally.

BUG= 722779 

Review-Url: https://codereview.chromium.org/2889663003
Cr-Commit-Position: refs/heads/master@{#472670}

[modify] https://crrev.com/39e3f9e3bdd92088ebf9c48bfd9395ebe38d7801/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/39e3f9e3bdd92088ebf9c48bfd9395ebe38d7801/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/39e3f9e3bdd92088ebf9c48bfd9395ebe38d7801/build/android/test_runner.py

Status: Fixed (was: Assigned)

Sign in to add a comment