Favicon are different between the NTP and the ContentSuggestions surface |
|||
Issue descriptionThe favicon used in ContentSuggestions are not the same of the one used in the NTP. The only difference between the two, is that the ContentSuggestions allows smaller favicon. The service exposing the favicon does not seem to return the biggest favicon possible.
,
May 17 2017
The problem is: I am accepting small favicon. But I want the favicon with a size as close as possible from the desired size. The current code will return the first favicon bigger than the minimal size even if it is much smaller than the desired size. So the idea is to change the code to return either the first favicon bigger than the desired size, or the biggest favicon for all possible type.
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8572898d2d9bab32c5888e87d1e779cd8d4c291 commit d8572898d2d9bab32c5888e87d1e779cd8d4c291 Author: gambard <gambard@chromium.org> Date: Fri Jun 09 08:19:14 2017 LargeIconService returns icon of the desired size For now LargeIconService returns the an icon bigger than the minimal size. If the page has multiple type of favicon, it might not be the biggest favicon, and it might be smaller than the desired size. This CL changes the service to return an icon bigger than the desired size and the minimum size, or the biggest possible. BUG= 722770 Review-Url: https://codereview.chromium.org/2883293002 Cr-Commit-Position: refs/heads/master@{#478235} [modify] https://crrev.com/d8572898d2d9bab32c5888e87d1e779cd8d4c291/components/favicon/core/large_icon_service.cc [modify] https://crrev.com/d8572898d2d9bab32c5888e87d1e779cd8d4c291/components/favicon/core/large_icon_service.h
,
Jun 9 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by pkotw...@chromium.org
, May 17 2017