Non-Regression:BUY MORE STORAGE button gets chopped in My Files app when zoomed out. |
||||||||||||||||||||
Issue descriptionChrome Version:60.0.3100.0/9556.0.0 dev-channel Daisy,Candy,Minnie OS:chrome What steps will reproduce the problem? (1)Sign in to user ->Open Files app ->Go to My Drive. (2)Press Ctrl-- till minimum zoom level(33%) and Observe the BUY MORE STORAGE button(kindly refer video) Actual :BUY MORE STORAGE button gets chopped when zoomed out. Expected:BUY MORE STORAGE button shouldn't appear chopped when zoomed-out. This is a Non-Regression issue seen from M-55(#55.0.2883.105/8872.76.0) Note: ----- Issue is not seen in Windows and Linux OS checked with version #60.0.3100.0 dev @Fukino: Please confirm the above issue.
,
Dec 8 2017
,
Feb 7 2018
,
Feb 16 2018
,
Feb 28 2018
,
Feb 28 2018
,
Feb 28 2018
,
Mar 1 2018
This one might be an easy fix :)
,
Mar 1 2018
,
Mar 7 2018
,
Mar 7 2018
,
Mar 8 2018
Attaching screenshots of before (from HEAD) and after my changes at 100% zoom and the smallest zoom. I also fixed an grey bar that was appearing between the two banners (see screenshots). CL: http://crrev.com/c/954803
,
Mar 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30ea8e31a31a3d835394e983f7eedf6ced06d9b0 commit 30ea8e31a31a3d835394e983f7eedf6ced06d9b0 Author: Luciano Pacheco <lucmult@chromium.org> Date: Mon Mar 12 03:34:39 2018 Fix button text when zooming Change button height to "em" unit to match padding unit, to fix button text being chopped. Move background color to parent element to remove gray line between the two banners. See bug for screenshots. Bug: 722766 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7d153e39fdfc0065918feaeb07672c58be37b662 Reviewed-on: https://chromium-review.googlesource.com/954803 Reviewed-by: Sasha Morrissey <sashab@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#542420} [modify] https://crrev.com/30ea8e31a31a3d835394e983f7eedf6ced06d9b0/ui/file_manager/file_manager/foreground/css/common.css [modify] https://crrev.com/30ea8e31a31a3d835394e983f7eedf6ced06d9b0/ui/file_manager/file_manager/foreground/css/drive_welcome.css [modify] https://crrev.com/30ea8e31a31a3d835394e983f7eedf6ced06d9b0/ui/file_manager/file_manager/foreground/css/file_manager.css
,
Mar 12 2018
As per previous comment fix has been merged. |
||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||
Comment 1 by weifangsun@chromium.org
, Nov 16 2017