New issue
Advanced search Search tips

Issue 722761 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: May 2017
Cc:
pdr@chromium.org
chrishtr@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

DCHECK failure in FindPaintOffsetAndVisualRectNeedingUpdate.h

Project Member Reported by jkummerow@chromium.org, May 16 2017 
Chrome Version: ToT (c7131815b9cd8ff / 472044)
OS: Linux (x64)

What steps will reproduce the problem?
(1) Compile ToT in Debug mode
(2) open http://edition.cnn.com/2017/05/15/design/superbenches-kvarnbacken-stockholm-definitive-design/index.html
(3) scroll a tiny little bit

The following DCHECK fails:

[95199:95199:0516/111513.855552:FATAL:FindPaintOffsetAndVisualRectNeedingUpdate.h(104)] Check failed: (old_visual_rect_.IsEmpty() && new_visual_rect.IsEmpty()) || object_.EnclosingLayer()->SubtreeIsInvisible() || old_visual_rect_ == new_visual_rect || (InflatedRect(old_visual_rect_).Contains(new_visual_rect) && InflatedRect(new_visual_rect).Contains(old_visual_rect_)). Visual rect changed without needing update object="LayoutSVGImage image" old="-884,-432 300x461" new="-884,-296 300x461"

Reproducibility: three times out of three attempts.

Please fix urgently; running into failing DCHECKs while chasing after something else is annoying.

Comment 1 by wangxianzhu@chromium.org, May 16 2017

Status: Started (was: Untriaged)

Comment 2 by wangxianzhu@chromium.org, May 16 2017

Cc: pdr@chromium.org
Components: Blink>SVG
Reduced test case.
cnn1.html
214 bytes View Download
frame.html
139 bytes View Download

Comment 3 by pdr@chromium.org, May 16 2017 

Nice! I bet that was not fun to minimize :)

Comment 4 by wangxianzhu@chromium.org, May 16 2017 

The problem is that a <rect> under <defs> changed visual rect on scroll.

Proposed CL: https://codereview.chromium.org/2893443002.

I still need to understand:
1. What are the visual rects of objects under LayoutSVGHiddenContainer for?
2. Why do the visual rects change on scroll when the svg root is composited?

Comment 5 by chrishtr@chromium.org, May 16 2017 

Re 1: they are not needed I believe. See
https://codereview.chromium.org/2768453003

Comment 6 by wangxianzhu@chromium.org, May 16 2017 

I vaguely remember that the descendants of a LayoutSVGHiddenContainer also needs object paint invalidation which might be triggered by visual rect change. Does this still apply?

I found the reason of question 2: we are using the root paint property tree state as the tree state of the <rect> (under <defs>), while still try to map to the paint invalidation container (<svg> in the case), so inverted scroll transform between the root and paintInvalidationContainer's content state are applied.

If visual rects are still needed to issue object paint invalidations, we need <defs> to be the paint invalidation container when setting kForcedSubtreeNoRasterInvalidation.

Comment 7 by chrishtr@chromium.org, May 16 2017 

Honestly my memory is becoming weak of the situation also..

Comment 8 by f...@opera.com, May 17 2017 

Descendants of LayoutSVGHiddenContainer shouldn't need to issue paint invalidations (it's pretty much the definition of these cases that they are "non-rendered".)

Comment 9 by f...@opera.com, May 17 2017 

(And the same goes for the LayoutSVGHiddenContainer itself of course...)

Comment 10 by schenney@chromium.org, May 17 2017

Labels: BugSource-Chromium PaintTeamTriaged-20170517

Comment 11 by schenney@chromium.org, May 17 2017

Labels: ReleaseBlock-Stable M-60

Comment 12 by wangxianzhu@chromium.org, May 17 2017 

For now we don't invalidate raster of LayoutSVGHiddenContainer and descendants, but invalidate paint (DisplayItemClients) of them. https://codereview.chromium.org/2883263003/ will still keep paint invalidation.

I just verified that we don't cache display items when recording SVG resources, so the paint invalidation is not used for now. Will display item caching of SVG resources be useful in the future, or should we remove paint invalidation of them at all? I'm inclined to keeping paint invalidation because the extra cost is small and we do need walk them at least to clear their paint invalidation flags.

Comment 13 by f...@opera.com, May 17 2017 

I don't see the caching being useful at least in a near future. I suspect we'll need some kind of sharing scheme in place for that to happen.
Project Member

Comment 14 by bugdroid1@chromium.org, May 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0357ef87967c4633b4d6c39de8362ed03831ef90

commit 0357ef87967c4633b4d6c39de8362ed03831ef90
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed May 17 20:28:36 2017

Map visual rects of descendants under LayoutSVGHiddenContainer to the temporary root

BUG= 722761 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
R=chrishtr@chromium.org

Review-Url: https://codereview.chromium.org/2883263003 .
Cr-Commit-Position: refs/heads/master@{#472551}

[modify] https://crrev.com/0357ef87967c4633b4d6c39de8362ed03831ef90/third_party/WebKit/Source/core/paint/PaintInvalidationTest.cpp
[modify] https://crrev.com/0357ef87967c4633b4d6c39de8362ed03831ef90/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

Comment 15 by wangxianzhu@chromium.org, May 17 2017

Status: Fixed (was: Started)

Comment 16 by wangxianzhu@chromium.org, May 17 2017

Status: Assigned (was: Fixed)
Still encountered this DCHECK failure when debugging  bug 723014 . Will disable visual rect update and paint invalidation for LayoutSVGHiddenContainer subtree.
Project Member

Comment 17 by bugdroid1@chromium.org, May 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f89bf147022cf532a6f2456d5fed109301296d6f

commit f89bf147022cf532a6f2456d5fed109301296d6f
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Fri May 19 09:18:08 2017

Skip both paint and raster invalidation for LayoutSVGHiddenContainer subtree

BUG= 722761 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2888253002
Cr-Commit-Position: refs/heads/master@{#473135}

[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/absolute-sized-document-no-scrollbars-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/clip-path-child-changes-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/clip-path-units-changes-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/deep-dynamic-updates-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-change-target-id-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-multiple-targets-id-change-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-reference-invalidation-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-remove-target-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-target-add-to-document-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-target-attribute-change-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-target-attribute-change-with-use-indirection-2-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-target-attribute-change-with-use-indirection-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-target-changes-id-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-target-id-change-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-target-inline-style-change-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-target-property-change-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-target-reappend-to-document-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-target-remove-from-document-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/feImage-target-style-change-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/fecomponenttransfer-in1-change-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/filter-refresh-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/filter-width-update-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/gradient-add-stops-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/gradient-stop-style-change-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/image-with-clip-path-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-late-marker-and-object-creation-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-late-marker-creation-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-late-mask-and-object-creation-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-late-mask-creation-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-gradient-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-pattern-child-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-pattern-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-stop-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-stop-linked-gradient-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/marker-child-changes-css-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/marker-child-changes-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/marker-viewBox-changes-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/mask-child-changes-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/mask-invalidation-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/paintorder-filtered-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/pending-resource-after-removal-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/relative-sized-document-scrollbars-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/repaint-paintorder-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/resource-client-removal-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/text-pattern-update-2-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/text-pattern-update-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/tspan-pattern-update-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/use-detach-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/use-disappears-after-style-update-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/paint/invalidation/svg/window-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/js-late-gradient-and-object-creation-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/js-late-pattern-and-object-creation-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/tabgroup-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/text-mask-update-expected.txt
[delete] https://crrev.com/19a83f8917e6a6df07d91cdaf3db4dc256f82390/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/use-detach-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/js-late-clipPath-and-object-creation-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/js-late-clipPath-creation-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/js-late-gradient-and-object-creation-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/js-late-gradient-creation-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/js-late-pattern-and-object-creation-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/js-late-pattern-creation-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/relative-sized-deep-shadow-tree-content-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/relative-sized-shadow-tree-content-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/tabgroup-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/text-mask-update-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/use-setAttribute-crash-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/js-late-clipPath-and-object-creation-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/js-late-clipPath-creation-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/js-late-gradient-and-object-creation-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/js-late-gradient-creation-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/js-late-pattern-and-object-creation-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/js-late-pattern-creation-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/relative-sized-deep-shadow-tree-content-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/relative-sized-shadow-tree-content-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/tabgroup-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/text-mask-update-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/use-setAttribute-crash-expected.txt
[add] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/clip-path-units-changes-expected.txt
[add] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/feImage-change-target-id-expected.txt
[add] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/feImage-reference-invalidation-expected.txt
[add] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/feImage-remove-target-expected.txt
[add] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/feImage-target-add-to-document-expected.txt
[add] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/feImage-target-changes-id-expected.txt
[add] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/feImage-target-id-change-expected.txt
[add] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/feImage-target-reappend-to-document-expected.txt
[add] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/feImage-target-remove-from-document-expected.txt
[add] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/fecomponenttransfer-in1-change-expected.txt
[add] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/filter-width-update-expected.txt
[add] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/gradient-add-stops-expected.txt
[add] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/gradient-stop-style-change-expected.txt
[add] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/js-update-gradient-expected.txt
[add] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/js-update-stop-expected.txt
[add] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/js-update-stop-linked-gradient-expected.txt
[add] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/relative-sized-document-scrollbars-expected.txt
[add] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/text-pattern-update-2-expected.txt
[add] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/text-pattern-update-expected.txt
[add] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/tspan-pattern-update-expected.txt
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/Source/core/layout/PaintInvalidationState.h
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/Source/core/paint/PaintInvalidationTest.cpp
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/Source/core/paint/PaintInvalidator.h
[modify] https://crrev.com/f89bf147022cf532a6f2456d5fed109301296d6f/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp

Comment 18 by wangxianzhu@chromium.org, May 22 2017

Status: Fixed (was: Assigned)

Comment 19 by jkummerow@chromium.org, May 22 2017 

Thanks!
►

Sign in to add a comment