Most of the layout tests for CSS Motion Path should move to become web platform tests.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb7632da4263f6fc7c97f120d2792282baf56770 commit fb7632da4263f6fc7c97f120d2792282baf56770 Author: ericwilligers <ericwilligers@chromium.org> Date: Wed May 17 10:21:10 2017 CSS Motion Path: calculate transform for simple ray() paths ray(<angle> <size>) indicates a ray with a bearing of the specified angle. For example, ray(0 closest-side) indicates a ray towards the top of the containing box. Spec: https://drafts.fxtf.org/motion-1/#offset-path-property Not yet implemented: calculating the transform when ray uses 'contain', or when offset-distance contains percentage, and thus the ray length must be determined. BUG=641245, 722757 Review-Url: https://codereview.chromium.org/2884943002 Cr-Commit-Position: refs/heads/master@{#472409} [add] https://crrev.com/fb7632da4263f6fc7c97f120d2792282baf56770/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/offset-path-ray-ref.html [add] https://crrev.com/fb7632da4263f6fc7c97f120d2792282baf56770/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/offset-path-ray.html [add] https://crrev.com/fb7632da4263f6fc7c97f120d2792282baf56770/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/offset-path-string-ref.html [add] https://crrev.com/fb7632da4263f6fc7c97f120d2792282baf56770/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/offset-path-string.html [add] https://crrev.com/fb7632da4263f6fc7c97f120d2792282baf56770/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/offset-rotate-001.html [add] https://crrev.com/fb7632da4263f6fc7c97f120d2792282baf56770/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/offset-rotate-002.html [add] https://crrev.com/fb7632da4263f6fc7c97f120d2792282baf56770/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/offset-rotate-ref.html [modify] https://crrev.com/fb7632da4263f6fc7c97f120d2792282baf56770/third_party/WebKit/Source/core/style/ComputedStyle.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffcd1042f667a55469747ab51345c699424ef1a3 commit ffcd1042f667a55469747ab51345c699424ef1a3 Author: ericwilligers <ericwilligers@chromium.org> Date: Fri May 26 02:20:48 2017 CSS Motion Path: Web Platform tests for longhand parsing We introduce web platform tests for parsing of - offset-position - offset-path - offset-distance - offset-rotate - offset-anchor The unshipped properties offset-position and offset-anchor currently fail a test because we have not yet updated position parsing for a recent CSS Values spec change (see http://crbug.com/717833 ). offset-rotate currently fails a test because we parse 0 as an angle. This was correct (but leads to shorthand parsing ambiguities) until https://github.com/w3c/csswg-drafts/issues/1162 offset-path fails some tests because we don't yet support url or basic-shape || geometry-box shapes. BUG= 722757 Review-Url: https://codereview.chromium.org/2886703002 Cr-Commit-Position: refs/heads/master@{#474881} [modify] https://crrev.com/ffcd1042f667a55469747ab51345c699424ef1a3/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/offset-path-ray-ref.html [modify] https://crrev.com/ffcd1042f667a55469747ab51345c699424ef1a3/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/offset-path-ray.html [modify] https://crrev.com/ffcd1042f667a55469747ab51345c699424ef1a3/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/offset-path-string-ref.html [modify] https://crrev.com/ffcd1042f667a55469747ab51345c699424ef1a3/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/offset-path-string.html [modify] https://crrev.com/ffcd1042f667a55469747ab51345c699424ef1a3/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/offset-rotate-001.html [modify] https://crrev.com/ffcd1042f667a55469747ab51345c699424ef1a3/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/offset-rotate-002.html [modify] https://crrev.com/ffcd1042f667a55469747ab51345c699424ef1a3/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/offset-rotate-ref.html [add] https://crrev.com/ffcd1042f667a55469747ab51345c699424ef1a3/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/parsing/offset-anchor-parsing-invalid.html [add] https://crrev.com/ffcd1042f667a55469747ab51345c699424ef1a3/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/parsing/offset-anchor-parsing-valid.html [add] https://crrev.com/ffcd1042f667a55469747ab51345c699424ef1a3/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/parsing/offset-distance-parsing-invalid.html [add] https://crrev.com/ffcd1042f667a55469747ab51345c699424ef1a3/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/parsing/offset-distance-parsing-valid.html [add] https://crrev.com/ffcd1042f667a55469747ab51345c699424ef1a3/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/parsing/offset-path-parsing-invalid.html [add] https://crrev.com/ffcd1042f667a55469747ab51345c699424ef1a3/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/parsing/offset-path-parsing-valid-expected.txt [add] https://crrev.com/ffcd1042f667a55469747ab51345c699424ef1a3/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/parsing/offset-path-parsing-valid.html [add] https://crrev.com/ffcd1042f667a55469747ab51345c699424ef1a3/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/parsing/offset-position-parsing-invalid.html [add] https://crrev.com/ffcd1042f667a55469747ab51345c699424ef1a3/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/parsing/offset-position-parsing-valid.html [add] https://crrev.com/ffcd1042f667a55469747ab51345c699424ef1a3/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/parsing/offset-rotate-parsing-invalid-expected.txt [add] https://crrev.com/ffcd1042f667a55469747ab51345c699424ef1a3/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/parsing/offset-rotate-parsing-invalid.html [add] https://crrev.com/ffcd1042f667a55469747ab51345c699424ef1a3/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/parsing/offset-rotate-parsing-valid.html [add] https://crrev.com/ffcd1042f667a55469747ab51345c699424ef1a3/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/parsing/resources/parsing-testcommon.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c507c83c82af7ccff20fa6b59c66750566172cad commit c507c83c82af7ccff20fa6b59c66750566172cad Author: Eric Willigers <ericwilligers@chromium.org> Date: Sat Aug 12 02:45:04 2017 CSS Motion Path: Web platform tests for animation We add animation tests for 4 of the 5 longhand properties defined by CSS Motion Path https://drafts.fxtf.org/motion-1/ offset-path is skipped for now, while CSS path interpolation semantics and serialization format are still being discussed. https://github.com/w3c/svgwg/issues/321 BUG= 722757 Change-Id: I4b31215c77a66316be849156bf63b6f1d45b374c Reviewed-on: https://chromium-review.googlesource.com/612000 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#493942} [add] https://crrev.com/c507c83c82af7ccff20fa6b59c66750566172cad/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/animation/offset-anchor-interpolation.html [add] https://crrev.com/c507c83c82af7ccff20fa6b59c66750566172cad/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/animation/offset-distance-interpolation.html [add] https://crrev.com/c507c83c82af7ccff20fa6b59c66750566172cad/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/animation/offset-position-interpolation.html [add] https://crrev.com/c507c83c82af7ccff20fa6b59c66750566172cad/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/animation/offset-rotate-interpolation.html [add] https://crrev.com/c507c83c82af7ccff20fa6b59c66750566172cad/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/animation/resources/interpolation-testcommon.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/724d2f3086730179aad5e8ff89b389637c1067d7 commit 724d2f3086730179aad5e8ff89b389637c1067d7 Author: Eric Willigers <ericwilligers@chromium.org> Date: Wed Aug 30 00:12:19 2017 CSS Motion Path: test calc support https://drafts.csswg.org/css-values-3/#calc-notation The calc() function ... can be used wherever <length>, <frequency>, <angle>, <time>, <percentage>, <number>, or <integer> values are allowed. We test calc support for CSS Motion Path and transforms properties. BUG= 722757 , 722696 Change-Id: If0f3791522f35b5fbd5f83b8fd6beda214600d96 Reviewed-on: https://chromium-review.googlesource.com/634086 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#498296} [add] https://crrev.com/724d2f3086730179aad5e8ff89b389637c1067d7/third_party/WebKit/LayoutTests/external/wpt/css/css-transforms-2/transforms-support-calc.html [add] https://crrev.com/724d2f3086730179aad5e8ff89b389637c1067d7/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/offset-supports-calc.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9157d8a435cde718b1e592de05c127bbdf21515c commit 9157d8a435cde718b1e592de05c127bbdf21515c Author: Eric Willigers <ericwilligers@chromium.org> Date: Thu Aug 31 07:28:40 2017 Specify owner for motion-1 tests Set ericwilligers as the initial owner for the CSS Motion Path web platform tests. Bug: 722757 Change-Id: I6906d8248e29ae630ba9d32058c584d5aca9bcce Reviewed-on: https://chromium-review.googlesource.com/633321 Reviewed-by: meade_UTC10 <meade@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#498776} [add] https://crrev.com/9157d8a435cde718b1e592de05c127bbdf21515c/third_party/WebKit/LayoutTests/external/wpt/css/motion-1/OWNERS
Web platform tests have been added. More tests will be added as features are implemented.
Comment 1 by ericwilligers@chromium.org
, May 16 2017