Issue metadata
Sign in to add a comment
|
Limit crowd consent reporting to official builds |
||||||||||||||||||||||||
Issue descriptionCurrently it isn't explicitly limited to official builds, but it should be.
,
May 17 2017
(just saw the other bug, seems like google branded official builds is indeed what we want to limit to)
,
May 17 2017
I don't think the backend rejects reports by U.A. On the client: We already have some #ifdefs in safe_browsing code to do different things for Official Chrome builds -- some lists we sync only on Chrome builds (search for kSyncOnlyOnChromeBuilds for e.g.). You could do the same. And in that case, you could skip compiling the code on Chromium.
,
May 18 2017
Cool, thanks.
,
May 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3422dd5e7cac07e39e06cca707c76eeaf4aa927 commit d3422dd5e7cac07e39e06cca707c76eeaf4aa927 Author: benwells <benwells@chromium.org> Date: Thu May 25 22:57:00 2017 Only collect Permission Action Reporting data in official builds BUG= 722730 Review-Url: https://codereview.chromium.org/2887613003 Cr-Commit-Position: refs/heads/master@{#474834} [modify] https://crrev.com/d3422dd5e7cac07e39e06cca707c76eeaf4aa927/chrome/browser/permissions/permission_uma_util.cc [modify] https://crrev.com/d3422dd5e7cac07e39e06cca707c76eeaf4aa927/chrome/browser/permissions/permission_uma_util.h [modify] https://crrev.com/d3422dd5e7cac07e39e06cca707c76eeaf4aa927/chrome/browser/permissions/permission_uma_util_unittest.cc [modify] https://crrev.com/d3422dd5e7cac07e39e06cca707c76eeaf4aa927/chrome/browser/safe_browsing/permission_reporter_browsertest.cc
,
May 25 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by benwells@chromium.org
, May 17 2017