New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 722730 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug
Team-Security-UX



Sign in to add a comment

Limit crowd consent reporting to official builds

Project Member Reported by benwells@chromium.org, May 16 2017

Issue description

Currently it isn't explicitly limited to official builds, but it should be.
 
Cc: nparker@chromium.org
nparker - Before I get too deep into this, you might have some useful info. This is using the SB backend - do you know if it does anything to drop reports from non-Google chromium builds, e.g. open source chromiums?

felt - is it non-official builds, or non-google builds that are the problem? I'm guessing it is google branded official builds we only want to report for?
(just saw the other bug, seems like google branded official builds is indeed what we want to limit to)
I don't think the backend rejects reports by U.A.

On the client: We already have some #ifdefs in safe_browsing code to do different things for Official Chrome builds -- some lists we sync only on Chrome builds (search for kSyncOnlyOnChromeBuilds for e.g.). You could do the same.  And in that case, you could skip compiling the code on Chromium.


Labels: M-60
Cool, thanks.
Status: Fixed (was: Assigned)

Sign in to add a comment