Reproducable on 60.0.3103.0 (Official Build) canary (64-bit) (cohort: 64-Bit)

SpellChecker::ReplaceMisspelledRange()? or DMC marker updates?

Please do bisect to identify the patch to make this...

Could not reproduce on 58.0.3029.110 (Official Build) (64-bit)

Repros for me on Mac Canary (yosin says he tested on Windows and it also repros there). Does not repro for me on:

- Linux Chrome built from master
- Linux binaries from bisect tool
- Mac binaries from bisect tool

This seems to indicate there's some sort of configuration issue involved.

Seems to only repro with idle-time spellchecking *disabled*

(can be toggled in chrome://flags)

Bisects to this range:
https://chromium.googlesource.com/chromium/src/+log/7cd3f1eb560d6d2478fd9caf0ae6e993ecb8d305..03323c74be50811df1ac0056087f19c7cf69a83

Most likely this CL (author: me)

Improve how DocumentMarkerController updates markers in response to text edits
https://chromium.googlesource.com/chromium/src/+/d6ef615a1a2154d3435b9a09afcd8f6cd929f275

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25c86433d672606b4daaceecc589664365d63ddf

commit 25c86433d672606b4daaceecc589664365d63ddf
Author: rlanday <rlanday@chromium.org>
Date: Wed May 24 10:54:37 2017

Split DMLEditor::ShiftMarkers() into content-dependent and -independent versions

I modified the logic that updates DocumentMarker in response to edit operations
in https://codereview.chromium.org/2755013004. However, it introduced a bug when
doing spellcheck replace (the old behavior removed the marker when the marked
text was changed and the new behavior doesn't).

This CL renames DocumentMarkerListEditor::ShiftMarkers() to
ShiftMarkersContentIndependent() and adds a new method that implements the old
behavior as ShiftMarkersContentDependent(). Spelling, Grammar, and TextMatch
markers should be removed when the text they mark changes, so those marker list
impls are being changed to use the old behavior. Composition markers don't
depend on the text they mark, so they're still using the new behavior (although
in practice it doesn't matter much since Composition markers are cleared by most
editing operations). Where we really need the new behavior is to implement
Android SuggestionSpan support (see  crbug.com/672259 ).

As all non-Composition markers currently use the ContentDependent behavior, I
had to remove/change the expected behavior for a lot of InputMethodController
tests that were testing the new update behavior.

BUG= 707867 , 722721 

Review-Url: https://codereview.chromium.org/2895353003
Cr-Commit-Position: refs/heads/master@{#474245}

[modify] https://crrev.com/25c86433d672606b4daaceecc589664365d63ddf/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
[modify] https://crrev.com/25c86433d672606b4daaceecc589664365d63ddf/third_party/WebKit/Source/core/editing/markers/CompositionMarkerListImpl.cpp
[modify] https://crrev.com/25c86433d672606b4daaceecc589664365d63ddf/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp
[modify] https://crrev.com/25c86433d672606b4daaceecc589664365d63ddf/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h
[modify] https://crrev.com/25c86433d672606b4daaceecc589664365d63ddf/third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.cpp
[modify] https://crrev.com/25c86433d672606b4daaceecc589664365d63ddf/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp

I can confirm it is fixed in:

Version 60.0.3112.0 dev (64-bit)
Platform 9592.0.0 (Official Build) dev-channel link
Firmware Google_Link.2695.1.169

Thanks for you help with this :-)

- Mike

I think we decided that merging the fix we ended up going with into the release branch would incur too much risk. So this bug will go out in M59 and be fixed in M60. yosin@, xiaochengh@, is that correct?

After discussing with yosin@ and xiaochengh@, we think this is safe to merge.

This bug requires manual review: We are only 3 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Only 3 days from stable? Hmm...

Will be fixed in M60

 Issue 733144  has been merged into this issue.

 Issue 735041  has been merged into this issue.