The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/9837fff5c57e251934b0d7273645addadebad8af

commit 9837fff5c57e251934b0d7273645addadebad8af
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue May 30 20:24:38 2017

hterm: make keybinding parsing more resilient to user inputs

The "in" keyword in JS is a messy beast.  Most people expect it to only
match entries in a dict they've added, but it also matches all members
of objects they've inherited (including Object).  That means a binding
like "__proto__-A" or "toString-B" will pass the parser, but throw weird
errors later on as we try to execute the keys.

Leverage the hasOwnProperty helper to avoid these sort of errors.

BUG= chromium:722718 

Change-Id: Icd359b00ff6ad1777520811ed576c9b4eee5cef1
Reviewed-on: https://chromium-review.googlesource.com/516746
Reviewed-by: Brandon Gilmore <varz@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/9837fff5c57e251934b0d7273645addadebad8af/hterm/js/hterm_parser.js
[modify] https://crrev.com/9837fff5c57e251934b0d7273645addadebad8af/hterm/js/hterm_parser_tests.js

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/80fb6416646870972c1407a337f8e5ace9530f26

commit 80fb6416646870972c1407a337f8e5ace9530f26
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue May 30 20:24:08 2017

hterm: document keyboard bindings

BUG= chromium:722718 

Change-Id: I090ad8c2ceaf8ad0f222c3706ad7d8f4d405748e
Reviewed-on: https://chromium-review.googlesource.com/516745
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Brandon Gilmore <varz@google.com>

[modify] https://crrev.com/80fb6416646870972c1407a337f8e5ace9530f26/hterm/js/hterm_preference_manager.js
[modify] https://crrev.com/80fb6416646870972c1407a337f8e5ace9530f26/nassh/doc/FAQ.md
[add] https://crrev.com/80fb6416646870972c1407a337f8e5ace9530f26/hterm/doc/KeyboardBindings.md
[modify] https://crrev.com/80fb6416646870972c1407a337f8e5ace9530f26/hterm/README.md

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/e672167a2a56288f31e538a564d11d31f1d04197

commit e672167a2a56288f31e538a564d11d31f1d04197
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue May 30 20:25:18 2017

hterm: make keybindings more flexible

There's no good reason to require exact capitalization with keys in
most cases.  We don't differentiate between "Ctrl" or "CTRL", so let
users roll with either by normalizing user inputs to uppercase.

One could make an argument about confusing "A", "a", "Shift-a", and
"Shift-A", but we already have that to some degree today with just
"A" and "Shift-A".  The benefits for other keys are outweighed imo
as requiring people to always write in uppercaps is not natural when
we require the modifiers to be mixed caps.  e.g. Ctrl-SPACE is OK,
but CTRL-Space is invalid?

We also add aliases for a lot of keys with longer names.  Many of
these keys don't have dominant forms, so accept e.g. Escape and Esc.

BUG= chromium:722718 

Change-Id: Ib80a2b65f01fab2fbbe100c53deb61e9217b9358
Reviewed-on: https://chromium-review.googlesource.com/516747
Reviewed-by: Brandon Gilmore <varz@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/e672167a2a56288f31e538a564d11d31f1d04197/hterm/js/hterm_parser.js
[modify] https://crrev.com/e672167a2a56288f31e538a564d11d31f1d04197/hterm/doc/KeyboardBindings.md
[modify] https://crrev.com/e672167a2a56288f31e538a564d11d31f1d04197/hterm/js/hterm_parser_identifiers.js
[modify] https://crrev.com/e672167a2a56288f31e538a564d11d31f1d04197/hterm/js/hterm_parser_tests.js

i plan on improving the options page parser, but i'll do that under issue 718670