New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 722717 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Do not share FBOs/VAOs/Transform feedback objects across contexts

Project Member Reported by c.pa...@samsung.com, May 16 2017

Issue description

Framebuffer, vertex array and transform feedback objects are not shared
across opengl contexts. However, this isn't the case in chromium.
Currently, we use ShareGroup's IdHandler to manage IDs for these objects.
Instead, we should manage IDs for these objects locally in GLES2Implementation itself.
All these objects should be moved out of share group.
 

Comment 1 by c.pa...@samsung.com, May 16 2017

Description: Show this description

Comment 2 by c.pa...@samsung.com, May 16 2017

Created a patch for this: https://codereview.chromium.org/2826043002/.
Project Member

Comment 3 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2dfc7029286f40d73b131760e3b7467c68b8bb17

commit 2dfc7029286f40d73b131760e3b7467c68b8bb17
Author: c.padhi <c.padhi@samsung.com>
Date: Thu May 18 18:40:36 2017

Do not share FBOs/VAOs/Transform feedback objects across contexts

Framebuffer, vertex array and transform feedback objects are not shared
across opengl contexts. Therefore, instead of using ShareGroup's IdHandler,
we can manage IDs for these objects locally in GLES2Implementation itself.

BUG= 722717 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2826043002
Cr-Commit-Position: refs/heads/master@{#472883}

[modify] https://crrev.com/2dfc7029286f40d73b131760e3b7467c68b8bb17/gpu/command_buffer/build_gles2_cmd_buffer.py
[modify] https://crrev.com/2dfc7029286f40d73b131760e3b7467c68b8bb17/gpu/command_buffer/client/gles2_implementation.cc
[modify] https://crrev.com/2dfc7029286f40d73b131760e3b7467c68b8bb17/gpu/command_buffer/client/gles2_implementation.h
[modify] https://crrev.com/2dfc7029286f40d73b131760e3b7467c68b8bb17/gpu/command_buffer/client/gles2_implementation_impl_autogen.h
[modify] https://crrev.com/2dfc7029286f40d73b131760e3b7467c68b8bb17/gpu/command_buffer/client/gles2_implementation_unittest.cc
[modify] https://crrev.com/2dfc7029286f40d73b131760e3b7467c68b8bb17/gpu/command_buffer/client/share_group.cc
[modify] https://crrev.com/2dfc7029286f40d73b131760e3b7467c68b8bb17/gpu/command_buffer/client/share_group.h
[modify] https://crrev.com/2dfc7029286f40d73b131760e3b7467c68b8bb17/gpu/command_buffer/common/gles2_cmd_format.h
[modify] https://crrev.com/2dfc7029286f40d73b131760e3b7467c68b8bb17/gpu/command_buffer/service/context_group.cc
[modify] https://crrev.com/2dfc7029286f40d73b131760e3b7467c68b8bb17/gpu/command_buffer/service/context_group.h
[modify] https://crrev.com/2dfc7029286f40d73b131760e3b7467c68b8bb17/gpu/command_buffer/service/context_group_unittest.cc
[modify] https://crrev.com/2dfc7029286f40d73b131760e3b7467c68b8bb17/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/2dfc7029286f40d73b131760e3b7467c68b8bb17/gpu/command_buffer/service/gles2_cmd_decoder.h
[modify] https://crrev.com/2dfc7029286f40d73b131760e3b7467c68b8bb17/gpu/command_buffer/service/gles2_cmd_decoder_mock.h
[modify] https://crrev.com/2dfc7029286f40d73b131760e3b7467c68b8bb17/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/2dfc7029286f40d73b131760e3b7467c68b8bb17/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h
[modify] https://crrev.com/2dfc7029286f40d73b131760e3b7467c68b8bb17/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
[modify] https://crrev.com/2dfc7029286f40d73b131760e3b7467c68b8bb17/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h
[modify] https://crrev.com/2dfc7029286f40d73b131760e3b7467c68b8bb17/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc
[modify] https://crrev.com/2dfc7029286f40d73b131760e3b7467c68b8bb17/gpu/command_buffer/service/texture_manager.cc
[modify] https://crrev.com/2dfc7029286f40d73b131760e3b7467c68b8bb17/gpu/command_buffer/service/texture_manager.h
[modify] https://crrev.com/2dfc7029286f40d73b131760e3b7467c68b8bb17/gpu/command_buffer/service/texture_manager_unittest.cc

Comment 4 by c.pa...@samsung.com, May 19 2017

Status: Fixed (was: Assigned)

Sign in to add a comment