New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 722715 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 721993
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unable to add breakpoints in 'console' section of devtools.

Reported by rp...@etouch.net, May 16 2017

Issue description

Version: 60.0.3100.0 f472642fd6c20b63b0f1a2f62564f2aad56f4be3-refs/heads/master@{#471639}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1)

What steps will reproduce the problem?
1. Launch chrome, navigate to NTP and open devtools
2. Now go to 'Console' section and type any text and pres 'Enter' key so error message is displayed
3. Now click on expand icon and open hyper link and try to add Break point by clicking on line no. and observe

Actual: Unable to add breakpoints 
Expected: Should be able to add breakpoints

This is regression issue, broken in ‘M 57’ and will soon update other info :
Good build:57.0.2939.0
Bad build: 57.0.2940.0

Note : If unable to reproduce at first instance kindly reopen NTP and follow the same steps.
 
Actual_video.mp4
923 KB View Download
Expected_video.mp4
630 KB View Download

Comment 1 by rp...@etouch.net, May 16 2017

Cc: ranjitkan@chromium.org msrchandra@chromium.org nyerramilli@chromium.org
Components: Platform>DevTools

Comment 2 by rp...@etouch.net, May 16 2017

Labels: hasbisect
Owner: kozyatinskiy@chromium.org
Status: Assigned (was: Unconfirmed)
The above issue is not reproduced on chromium builds hence providing suspect from Change Log.

Change Log :
https://chromium.googlesource.com/chromium/src/+log/57.0.2939.0..57.0.2940.0?pretty=fuller&n=10000

Suspecting : 436130 ? from CL.

@kozyatinskiy : Could you please help to reassign if your change is not the cause for this change.

Comment 3 by l...@chromium.org, May 16 2017

I'm unable to reproduce this on Linux 60.0.3101.0 and Mac 60.0.3100.0.  kozy@, maybe this has already been addressed?
Mergedinto: 721993
Status: Duplicate (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, May 19 2017

Labels: merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cf34f3a7413e2f7913ca2e7757cedcdb2079970

commit 0cf34f3a7413e2f7913ca2e7757cedcdb2079970
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri May 19 19:19:48 2017

[DevTools] breakpoint manager should be ready for location from different model

There is no gurantees for debugger model of location returned from uiLocationToRawLocation call.
BreakpointManager should be ready.

BUG= chromium:722715 , chromium:721993 
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2889853002
Cr-Original-Commit-Position: refs/heads/master@{#472648}
Review-Url: https://codereview.chromium.org/2898473002 .
Cr-Commit-Position: refs/branch-heads/3071@{#637}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[add] https://crrev.com/0cf34f3a7413e2f7913ca2e7757cedcdb2079970/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoints-in-anonymous-script-with-two-targets-expected.txt
[add] https://crrev.com/0cf34f3a7413e2f7913ca2e7757cedcdb2079970/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoints-in-anonymous-script-with-two-targets.html
[modify] https://crrev.com/0cf34f3a7413e2f7913ca2e7757cedcdb2079970/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

Comment 7 by dchau...@etouch.net, May 23 2017

Retested this issue on Windows, Mac and Linux machine using build# 60.0.3107.4, It seems to be fixed and working as intended i.e. able to add breakpoints.

Attaching screen-cast for the same.
60.0.3107.4 _ behavior.mp4
1.4 MB View Download
Labels: TE-Verified-M60 TE-Verified-60.0.3107.4
As per comment #7 adding TE-Verified label.
Labels: TE-Verified-59.0.3071.71 TE-Verified-M59
Rechecked this issue on Windows 10, Mac 10.12.4, Ubuntu 14.04 using chrome version 59.0.3071.71. Fix is working as intended. Adding TE verified labels.

Thanks.!

Sign in to add a comment