We need to implement GAIA-keyed logging of detected languages for URLs.
https://docs.google.com/document/d/1-q-vrxqNZDnwajpOwMWB_Z1YlzQUiApJZmSUzGkojv4/edit
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b301f711dbc495c3b552d083d0e6d88d0e9db73 commit 0b301f711dbc495c3b552d083d0e6d88d0e9db73 Author: renjieliu <renjieliu@chromium.org> Date: Fri May 19 06:58:00 2017 Initial proto for language detection. Design doc: https://docs.google.com/document/d/1-q-vrxqNZDnwajpOwMWB_Z1YlzQUiApJZmSUzGkojv4/edit#heading=h.3bxjhvo21dyq Integration Steps: https://docs.google.com/document/d/1es1cCRFhdag4ljGSPfXfSMlEx5lMgFZ3SGHMaBcU_D8/edit# BUG= 722679 Review-Url: https://codereview.chromium.org/2892553003 Cr-Commit-Position: refs/heads/master@{#473113} [modify] https://crrev.com/0b301f711dbc495c3b552d083d0e6d88d0e9db73/components/sync/protocol/proto_visitors.h [modify] https://crrev.com/0b301f711dbc495c3b552d083d0e6d88d0e9db73/components/sync/protocol/user_event_specifics.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8a3849678bf6750fa1a0a6cfbfeab9744070cc4 commit d8a3849678bf6750fa1a0a6cfbfeab9744070cc4 Author: renjieliu <renjieliu@chromium.org> Date: Fri May 26 09:03:50 2017 Implement client side logging for language detection. Integration steps described in: https://docs.google.com/document/d/1es1cCRFhdag4ljGSPfXfSMlEx5lMgFZ3SGHMaBcU_D8/edit#heading=h.qdctas2f6c6e BUG= 722679 Review-Url: https://codereview.chromium.org/2897563002 Cr-Commit-Position: refs/heads/master@{#474972} [modify] https://crrev.com/d8a3849678bf6750fa1a0a6cfbfeab9744070cc4/chrome/browser/translate/chrome_translate_client.cc [modify] https://crrev.com/d8a3849678bf6750fa1a0a6cfbfeab9744070cc4/components/sync/protocol/proto_visitors.h [modify] https://crrev.com/d8a3849678bf6750fa1a0a6cfbfeab9744070cc4/components/sync/protocol/user_event_specifics.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1e6a615e165c9ad4e33b4f50dd23e9ee9fab5be commit f1e6a615e165c9ad4e33b4f50dd23e9ee9fab5be Author: renjieliu <renjieliu@chromium.org> Date: Thu Jun 01 01:35:59 2017 Refactoring ConstructLanguageDetectionEvent. Refactoring the code so it can also be used by the iOS client. Also add a unit test. BUG= 722679 Review-Url: https://codereview.chromium.org/2912843003 Cr-Commit-Position: refs/heads/master@{#476135} [modify] https://crrev.com/f1e6a615e165c9ad4e33b4f50dd23e9ee9fab5be/chrome/browser/translate/chrome_translate_client.cc [modify] https://crrev.com/f1e6a615e165c9ad4e33b4f50dd23e9ee9fab5be/components/translate/DEPS [modify] https://crrev.com/f1e6a615e165c9ad4e33b4f50dd23e9ee9fab5be/components/translate/core/common/BUILD.gn [add] https://crrev.com/f1e6a615e165c9ad4e33b4f50dd23e9ee9fab5be/components/translate/core/common/language_detection_logging_helper.cc [add] https://crrev.com/f1e6a615e165c9ad4e33b4f50dd23e9ee9fab5be/components/translate/core/common/language_detection_logging_helper.h [add] https://crrev.com/f1e6a615e165c9ad4e33b4f50dd23e9ee9fab5be/components/translate/core/common/language_detection_logging_helper_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdce2652bc147496e6d53348d80f21c8d7e7dec6 commit cdce2652bc147496e6d53348d80f21c8d7e7dec6 Author: renjieliu <renjieliu@chromium.org> Date: Wed Jun 14 01:41:17 2017 Set up switches for user language detection and translation events. These two switches control logging language detection and translation events behavior. However, we still rely on SyncUserEvents as a centralized gateway to logging. BUG= 722679 , 728491 Review-Url: https://codereview.chromium.org/2932603002 Cr-Commit-Position: refs/heads/master@{#479247} [modify] https://crrev.com/cdce2652bc147496e6d53348d80f21c8d7e7dec6/components/sync/driver/sync_driver_switches.cc [modify] https://crrev.com/cdce2652bc147496e6d53348d80f21c8d7e7dec6/components/sync/driver/sync_driver_switches.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2fb02881eb16603ce55e9dbfdf73e1ae4daade3 commit e2fb02881eb16603ce55e9dbfdf73e1ae4daade3 Author: renjieliu <renjieliu@chromium.org> Date: Wed Jun 14 02:48:51 2017 Quick fix for logging. Currently two issues: 1) We shouldn't log event for chrome://* 2) The navigation id should comes from NavigationEntry. BUG= 722679 Review-Url: https://codereview.chromium.org/2916873004 Cr-Commit-Position: refs/heads/master@{#479263} [modify] https://crrev.com/e2fb02881eb16603ce55e9dbfdf73e1ae4daade3/chrome/browser/translate/chrome_translate_client.cc [modify] https://crrev.com/e2fb02881eb16603ce55e9dbfdf73e1ae4daade3/chrome/browser/translate/chrome_translate_client.h [add] https://crrev.com/e2fb02881eb16603ce55e9dbfdf73e1ae4daade3/chrome/browser/translate/chrome_translate_client_unittest.cc [modify] https://crrev.com/e2fb02881eb16603ce55e9dbfdf73e1ae4daade3/chrome/test/BUILD.gn [modify] https://crrev.com/e2fb02881eb16603ce55e9dbfdf73e1ae4daade3/components/translate/core/common/language_detection_logging_helper.cc [modify] https://crrev.com/e2fb02881eb16603ce55e9dbfdf73e1ae4daade3/components/translate/core/common/language_detection_logging_helper.h [modify] https://crrev.com/e2fb02881eb16603ce55e9dbfdf73e1ae4daade3/components/translate/core/common/language_detection_logging_helper_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/106a571ac7652839571550ae6738086a4e787c31 commit 106a571ac7652839571550ae6738086a4e787c31 Author: renjieliu <renjieliu@chromium.org> Date: Wed Jun 21 01:03:48 2017 Add switches for language detection and translation logging. Apply switches as previosuly discussed so we easily turn off language detection logging or translation logging if something goes wrong. BUG= 728491 , 722679 Review-Url: https://codereview.chromium.org/2941953002 Cr-Commit-Position: refs/heads/master@{#481054} [modify] https://crrev.com/106a571ac7652839571550ae6738086a4e787c31/chrome/browser/translate/chrome_translate_client.cc [modify] https://crrev.com/106a571ac7652839571550ae6738086a4e787c31/chrome/browser/translate/chrome_translate_client_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26d6e093ba10c2a922b4511c1e918c6cb399920c commit 26d6e093ba10c2a922b4511c1e918c6cb399920c Author: Renjie Liu <renjieliu@chromium.org> Date: Thu Jun 22 23:49:36 2017 Refactoring for ios record language event. I'm exposing a RecordLanguageDetection API in translate_client so different platforms can handle record language detection uniformly. Bug: 722679 Change-Id: I6df293b7d7d6ef81ffd5f46cb0885a28bf4bef19 Reviewed-on: https://chromium-review.googlesource.com/523882 Reviewed-by: Rachel Blum <groby@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Renjie Liu <renjieliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#481723} [modify] https://crrev.com/26d6e093ba10c2a922b4511c1e918c6cb399920c/chrome/browser/translate/chrome_translate_client.cc [modify] https://crrev.com/26d6e093ba10c2a922b4511c1e918c6cb399920c/chrome/browser/translate/chrome_translate_client.h [modify] https://crrev.com/26d6e093ba10c2a922b4511c1e918c6cb399920c/components/translate/core/browser/mock_translate_client.h [modify] https://crrev.com/26d6e093ba10c2a922b4511c1e918c6cb399920c/components/translate/core/browser/translate_client.h [modify] https://crrev.com/26d6e093ba10c2a922b4511c1e918c6cb399920c/components/translate/ios/browser/ios_translate_driver.mm [modify] https://crrev.com/26d6e093ba10c2a922b4511c1e918c6cb399920c/ios/chrome/browser/translate/chrome_ios_translate_client.h [modify] https://crrev.com/26d6e093ba10c2a922b4511c1e918c6cb399920c/ios/chrome/browser/translate/chrome_ios_translate_client.mm [modify] https://crrev.com/26d6e093ba10c2a922b4511c1e918c6cb399920c/ios/web_view/internal/translate/web_view_translate_client.h [modify] https://crrev.com/26d6e093ba10c2a922b4511c1e918c6cb399920c/ios/web_view/internal/translate/web_view_translate_client.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef37fe771b578f8abc44c9fb5a6e28500aee0353 commit ef37fe771b578f8abc44c9fb5a6e28500aee0353 Author: renjieliu <renjieliu@chromium.org> Date: Mon Jun 26 02:24:14 2017 Split translate_event.proto AUTOMATICALLY_TRANSLATED. Split AUTOMATICALLY_TRANSLATED into AUTO_TRANSLATION_BY_PREF and AUTO_TRANSLATION_BY_LINK to allow us more fine grained analysis. BUG= 728491 , 722679 Review-Url: https://codereview.chromium.org/2938133003 Cr-Commit-Position: refs/heads/master@{#482184} [modify] https://crrev.com/ef37fe771b578f8abc44c9fb5a6e28500aee0353/components/metrics/proto/translate_event.proto [modify] https://crrev.com/ef37fe771b578f8abc44c9fb5a6e28500aee0353/components/sync/protocol/proto_enum_conversions.cc [modify] https://crrev.com/ef37fe771b578f8abc44c9fb5a6e28500aee0353/components/sync/protocol/user_event_specifics.proto [modify] https://crrev.com/ef37fe771b578f8abc44c9fb5a6e28500aee0353/components/translate/core/browser/translate_manager.cc [modify] https://crrev.com/ef37fe771b578f8abc44c9fb5a6e28500aee0353/components/translate/core/common/translation_logging_helper.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a1c9af8a6715969608c575157685203742d777d commit 4a1c9af8a6715969608c575157685203742d777d Author: renjieliu <renjieliu@chromium.org> Date: Thu Jul 06 00:29:21 2017 Implement ios language detection logging. BUG= 722679 Review-Url: https://codereview.chromium.org/2962783003 Cr-Commit-Position: refs/heads/master@{#484417} [modify] https://crrev.com/4a1c9af8a6715969608c575157685203742d777d/ios/chrome/browser/translate/chrome_ios_translate_client.mm
Comment 1 by napper@chromium.org
, May 16 2017