Issue metadata
Sign in to add a comment
|
chrome.enterprise.platformKeys.getTokens API fails |
||||||||||||||||||||||
Issue descriptionChrome Version: 60.0.3098.0 Chrome OS Version: 9548.0.0 Chrome OS Platform: caroline, glimmer, reks (should be happening on other Chrome devices as well) chrome.enterprise.platformKeys.getTokens API was working in ChromeOS 9547.0.0 but fails starting in ChromeOS 9548.0.0 (FYI CL for FR crbug.com/715982 landed in ChromeOS 9548.0.0). Steps To Reproduce: (1) Enroll device in a domain with forced-installed extension "PlatformKeys Test Extension" (ID: hoppbgdeajkagempifacalpdapphfoai) (2) Launch the extension chrome-extension://hoppbgdeajkagempifacalpdapphfoai/main.html (3) Click on "Generate Key Pair" for Public key. Expected Result: Generated public key is displayed in the text field on the right. Actual Result: Status shows "Generated Key: Generating..." but the text field remains blank. How frequently does this problem reproduce? Always.
,
May 16 2017
I was able to reproduce it. What's worse, it actually crashes when opening the extension after reboot. I must have provisioned the system certificate with a previous chrome binary in my testing. Investigating now and trying to fix ASAP. Sorry for the delay.
,
May 16 2017
I believe this has been caused by an unrelated change which also went into 9548.0.0. It seems that one of the following changes could have broken something in Chaps: https://chromium-review.googlesource.com/c/503551/ https://chromium-review.googlesource.com/c/500667/ (Changes in 9548.0.0: https://crosland.corp.google.com/log/9547.0.0..9548.0.0) What I found out: - When I patch my chrome binary over 9547.0.0, system certificate enrollment with the given extension still works fine, so I don't think the chrome binary is the problem. - Listing slots with pkcs11-tool --module /usr/lib64/libchaps.so --list-slots as root on the chromebook works fine in 9547.0.0, but returns errors on 9548.0.0. - The crash happens in libnss3, sadly I didn't manage to get a crash report (not sure why).
,
May 16 2017
@ejcaruso: Could it be that one of the following changes broke something with how chaps works on chromeos devices? https://chromium-review.googlesource.com/c/503551/ https://chromium-review.googlesource.com/c/500667/ The symptoms I'm seeing: - When I ssh into the device as root (or use the console), I used to be able to list tokens using pcks11-tool. The output I usually got looked like: localhost ~ # pkcs11-tool --module /usr/lib64/libchaps.so --list-slots Available slots: Slot 0 (0x0): TPM Slot token label: System TPM Token token manuf: Chromium OS token model: token flags: rng, PIN initialized, PIN pad present, token initialized serial num : Not Available With 9548.0.0 (where those changes landed), I get something mentioning CKR_GENERAL_ERROR instead. Listing tokens from chrome seems to crash in libnss3 sometimes. Unfortunately, I wasn't able to get a crash dump or stack trace. I will try to reproduce again tomorrow and see if I can generate a stack trace.
,
May 16 2017
,
May 16 2017
CL:506385 up. Sorry about that, folks!
,
May 16 2017
,
May 16 2017
Not able to connect to Google-A due to this.
,
May 16 2017
Chrome is crashing, when adding certificates using "Import and bind" button in certificate manager. Is this related? or else will open a separate issue. Tested on Samus R60 9557.0.0 Logs attached.
,
May 16 2017
@ Aashutosh Not sure if this is same issue for crashing when adding any certificates using "Import and bind" button in certificate manager. It could be separate issue. @ejcaruso : Do you have any details on this?
,
May 17 2017
I do think it's the same issue - we see crashes in libnss3 invoked through: - Manual certificate import - Certificate import from ONC user policy - The getTokens API I expect these issues to have the same root cause and to be resolved when the commit queue picks up and commits the change mentioned in Comment #6. Thanks for your patience!
,
May 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/32bba00e97069389d8e7e2323cc4a8bb2657244c commit 32bba00e97069389d8e7e2323cc4a8bb2657244c Author: Eric Caruso <ejcaruso@chromium.org> Date: Wed May 17 21:42:13 2017 chaps: clear vectors before serializing protos Not sure where the D-Bus vectors come from, but they must have had some uninitialized data in them that was preventing us from deserializing the protos correctly on the other side and the unit tests failed to catch it. BUG= chromium:722677 TEST=pkcs11-tool --module libchaps.so --list-tokens and pkcs11-tool --module libchaps.so --list-mechanisms both work and give expected output Change-Id: Ia92b2000e7538924d6aa6fdb0230b462dfa3ead1 Reviewed-on: https://chromium-review.googlesource.com/506385 Reviewed-by: Andrey Pronin <apronin@chromium.org> Commit-Queue: Eric Caruso <ejcaruso@chromium.org> Tested-by: Eric Caruso <ejcaruso@chromium.org> [modify] https://crrev.com/32bba00e97069389d8e7e2323cc4a8bb2657244c/chaps/chaps_adaptor.cc
,
May 17 2017
,
May 18 2017
I have just tested build 9562.0.0 and I can confirm that the chrome.enterprise.platformKeys API usecase works fine for me again. (I haven't tested certificate import through chrome://certificate-manager/ or ONC policy certificate import but I assume the root cause was the same so it should work again.)
,
May 18 2017
Issue 724214 has been merged into this issue.
,
May 18 2017
When can this new build be pushed to Asus C302CA for our testing?
,
May 18 2017
As verified in M60.0.3101.0: 9562.0.0 dev snappy, the issues with chrome.enterprise.platformKeys API have been fixed and the API is now working fine. I could generate the keys via the methods mentioned in #0 and did not encounter any error.
,
May 19 2017
Could connect to Google-A network now in M60/Peppy Device. M ChromeOS Chrome ARC Type Channel 60 9563.0.0 60.0.3102.0 (multiple) release dev
,
May 19 2017
Issue 724370 has been merged into this issue.
,
May 19 2017
Are there any workarounds for this bug?
,
May 20 2017
Issue 724470 has been merged into this issue.
,
May 20 2017
Re Comment #20: Not that I know of, sorry, short of waiting for the next dev channel update or manually flashing to a newer version.
,
May 22 2017
Issue 724952 has been merged into this issue.
,
May 23 2017
Issue 725343 has been merged into this issue.
,
May 23 2017
Issue 725547 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pmarko@chromium.org
, May 16 2017Owner: jingwee@chromium.org