New issue
Advanced search Search tips

Issue 722675 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

arc: cleanup converting legacy PlayStore position to new app id.

Project Member Reported by khmel@chromium.org, May 16 2017

Issue description

Such mapping is temporary and should be discarded in M64.
See chrome/browser/ui/app_list/app_list_syncable_service.cc
 

Comment 1 by khmel@chromium.org, May 16 2017

See also chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc and discard code to rename Legacy Play Store app info entry to new id.

Comment 2 by khmel@chromium.org, May 16 2017

remove also kLegacyPlayStoreAppId from
chrome/browser/ui/app_list/arc/arc_app_utils.h

Comment 3 by khmel@chromium.org, May 16 2018

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b72983659c7b1cad0f46cd9322004ca8d993797

commit 0b72983659c7b1cad0f46cd9322004ca8d993797
Author: khmel@google.com <khmel@google.com>
Date: Wed May 16 19:39:47 2018

arc: Cleanup legacy Play Store app id.

We switched to new unified (Android Play Store and ARC++ OptIn UI) Play
Store id year ago. Now it is time to clean up conversion code.

Test: Manually, no problem observed. Positions are preserved.
Bug:  722675 
Change-Id: Ief70ea26b6ec1b446c72fed63ffec8edf56bb956
Reviewed-on: https://chromium-review.googlesource.com/1062218
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Commit-Position: refs/heads/master@{#559232}
[modify] https://crrev.com/0b72983659c7b1cad0f46cd9322004ca8d993797/chrome/browser/ui/app_list/app_list_syncable_service.cc
[modify] https://crrev.com/0b72983659c7b1cad0f46cd9322004ca8d993797/chrome/browser/ui/app_list/app_list_syncable_service.h
[modify] https://crrev.com/0b72983659c7b1cad0f46cd9322004ca8d993797/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/0b72983659c7b1cad0f46cd9322004ca8d993797/chrome/browser/ui/app_list/arc/arc_app_utils.cc
[modify] https://crrev.com/0b72983659c7b1cad0f46cd9322004ca8d993797/chrome/browser/ui/app_list/arc/arc_app_utils.h

Sign in to add a comment