New issue
Advanced search Search tips

Issue 722673 link

Starred by 1 user
Status: Archived
Owner:
erikc...@chromium.org
Closed: Nov 9
Cc:
a...@chromium.org
glevin@chromium.org
primiano@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

ProcessMemoryMetricsEmitterTest.FetchDuringTrace failure on the Linux ChromiumOS Tests builder

Project Member Reported by afakhry@chromium.org, May 16 2017 
Link to the failed build: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/38598

Culprit CL is: https://codereview.chromium.org/2883693002, reverting shortly.

[ RUN      ] ProcessMemoryMetricsEmitterTest.FetchDuringTrace
[20780:20780:0515/182530.903651:WARNING:chrome_browser_main_chromeos.cc(492)] Running as stub user with profile dir: test-user
Xlib:  extension "RANDR" missing on display ":99".
[20780:20849:0515/182531.259848:WARNING:freezer_cgroup_process_manager.cc(61)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes.
../../chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc:27: Failure
Value of: success
  Actual: false
Expected: true
[20859:20878:0515/182534.472760:WARNING:trace_log.cc(1018)] The following threads haven't finished flush in time. If this happens stably for some thread, please call TraceLog::GetInstance()->SetCurrentThreadBlocksMessageLoop() from the thread to avoid its trace events from being lost.
[20859:20878:0515/182534.472830:WARNING:trace_log.cc(1026)] Thread: MemoryInfra
../../chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc:183: Failure
Expected: (events.size()) > (1u), actual: 1 vs 1
[  FAILED  ] ProcessMemoryMetricsEmitterTest.FetchDuringTrace, where TypeParam =  and GetParam() =  (3850 ms)
Project Member

Comment 1 by bugdroid1@chromium.org, May 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b

commit 6a9e77ef378c0c835fc9d3265addb0c0d7bd911b
Author: Ahmed Fakhry <afakhry@google.com>
Date: Tue May 16 02:23:04 2017

Revert "[Memory-UMA] Implement basic working prototype."

Manual revet due to too long file.

Reason for revert: Caused ProcessMemoryMetricsEmitterTest.FetchDuringTrace
failure on the Linux ChromiumOS Tests builder.
BUG= 722673 ,703184
TBR=rkaplow@chromium.org,avi@chrmium.org,erikchen@chromium.org,dcheng@chromium.org,primiano@chromium.org

This reverts commit 18ea873dd28c6b2f49b529e57c55898f5df1b4d2.

Review-Url: https://codereview.chromium.org/2884143002 .
Cr-Commit-Position: refs/heads/master@{#471985}

[modify] https://crrev.com/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b/chrome/browser/metrics/process_memory_metrics_emitter.cc
[modify] https://crrev.com/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
[modify] https://crrev.com/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b/content/browser/browser_main_loop.cc
[modify] https://crrev.com/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b/services/resource_coordinator/BUILD.gn
[modify] https://crrev.com/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b/services/resource_coordinator/memory/coordinator/coordinator_impl.cc
[modify] https://crrev.com/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b/services/resource_coordinator/memory/coordinator/coordinator_impl.h
[modify] https://crrev.com/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b/services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc
[delete] https://crrev.com/2b9536581f36776f9a9cc13462d4d7f369686734/services/resource_coordinator/memory/coordinator/process_map.cc
[delete] https://crrev.com/2b9536581f36776f9a9cc13462d4d7f369686734/services/resource_coordinator/memory/coordinator/process_map.h
[delete] https://crrev.com/2b9536581f36776f9a9cc13462d4d7f369686734/services/resource_coordinator/memory/coordinator/process_map_unittest.cc
[modify] https://crrev.com/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom
[modify] https://crrev.com/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b/tools/metrics/histograms/histograms.xml

Comment 2 by erikc...@chromium.org, May 16 2017

Cc: primiano@chromium.org
Interesting set of failures:
"""
../../chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc:27: Failure
Value of: success
  Actual: false
Expected: true
[20859:20878:0515/182534.472760:WARNING:trace_log.cc(1018)] The following threads haven't finished flush in time. If this happens stably for some thread, please call TraceLog::GetInstance()->SetCurrentThreadBlocksMessageLoop() from the thread to avoid its trace events from being lost.
[20859:20878:0515/182534.472830:WARNING:trace_log.cc(1026)] Thread: MemoryInfra
../../chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc:183: Failure
Expected: (events.size()) > (1u), actual: 1 vs 1
"""

Comment 3 by primiano@chromium.org, May 16 2017 

A deadlock in the test? feels like the memory-infra bg thread is getting stuck on something. seems to be farily reproducible though by looking at the bot.

Comment 4 by primiano@chromium.org, May 30 2017 

I don't see any other flakiness on the bot due to this test and I think that the rest of the code relanded in the meanwhile. erikchen if that's the case can we archive this bug?

Comment 5 by zalcorn@chromium.org, Sep 28 

Triage nag: This Chrome OS bug has an owner but no component. Please add a component so that this can be tracked by the relevant team.

Comment 6 by weifangsun@chromium.org, Nov 8 

<UI triage> Bug owners, please add the appropriate component to your bug. Thanks!

Comment 7 by weifangsun@chromium.org, Nov 8 

<UI triage> Bug owners, please add the appropriate component to your bug. Thanks!

Comment 8 by erikc...@chromium.org, Nov 9

Status: Archived (was: Assigned)
Archiving this bug as per c#4
►

Sign in to add a comment