New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 722647 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Notification cannot be expanded on popup

Project Member Reported by yoshiki@chromium.org, May 16 2017

Issue description

Notification can't be expanded on popup. Clicking an expand button doesn't expand but does open itself.

It looks a click event is not forwarded to Android side but handled in Chrome side.

Google Chrome	60.0.3100.0 (Official Build) canary (32-bit)
Platform	9554.0.0 (Official Build) canary-channel kevin
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f98677dc227b94e8101184484eb0c8959218a508

commit f98677dc227b94e8101184484eb0c8959218a508
Author: yoshiki <yoshiki@chromium.org>
Date: Tue May 23 08:34:52 2017

Make a layer for popup MessageView

Previously all MessageView had an own layer. And now, by http://crrev.com/2849523005, only non-popup MessageView, which is in the message center, has a layer.

But it causes a regression ( http://crbug.com/722647 ) so this CL reverts that part.

This CL breaks swiping on popup but it'll be fixed soon by http://crrev.com/2873553002.

BUG= 722647 
TEST=manual (issue doesn't happen)

Review-Url: https://codereview.chromium.org/2880243003
Cr-Commit-Position: refs/heads/master@{#473838}

[modify] https://crrev.com/f98677dc227b94e8101184484eb0c8959218a508/ui/message_center/views/message_view.cc

Labels: -M-60 Merge-Request-59 M-59
Project Member

Comment 3 by sheriffbot@chromium.org, May 23 2017

Labels: -Merge-Request-59 Merge-Review-59 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by gkihumba@google.com, May 23 2017

Labels: Merge-Approved-59
Project Member

Comment 5 by bugdroid1@chromium.org, May 25 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fd4ce201b7b35eb228833bcee64e5a62c48b145

commit 9fd4ce201b7b35eb228833bcee64e5a62c48b145
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Thu May 25 06:54:11 2017

Make a layer for popup MessageView

Previously all MessageView had an own layer. And now, by http://crrev.com/2849523005, only non-popup MessageView, which is in the message center, has a layer.

But it causes a regression ( http://crbug.com/722647 ) so this CL reverts that part.

This CL breaks swiping on popup but it'll be fixed soon by http://crrev.com/2873553002.

BUG= 722647 
TEST=manual (issue doesn't happen)

Review-Url: https://codereview.chromium.org/2880243003
Cr-Commit-Position: refs/heads/master@{#473838}
(cherry picked from commit f98677dc227b94e8101184484eb0c8959218a508)

Review-Url: https://codereview.chromium.org/2903213002 .
Cr-Commit-Position: refs/branch-heads/3071@{#692}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/9fd4ce201b7b35eb228833bcee64e5a62c48b145/ui/message_center/views/message_view.cc

Status: Fic (was: Assigned)
Status: Fixed (was: fic)

Comment 8 by gkihumba@google.com, Jun 16 2017

Labels: -Hotlist-Merge-Review -Merge-Review-59

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment