We should add UMA to better understand problems that our users are having with offline pages.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/753970e38dce9e1bdb45fbf87abb668684f8de5d commit 753970e38dce9e1bdb45fbf87abb668684f8de5d Author: petewil <petewil@chromium.org> Date: Wed May 17 20:25:39 2017 Add a param to MHTMLGenerationManager Add Page Problem Detectors variable to MHTMLGenerationParams Also sets the variable when using the BackgroundLoadingOffliner. Design Doc here: https://docs.google.com/document/d/1PWiu6PnLktkb-n-HgITR0EnEK6llKiJAJ9Xrk_2D6ts BUG= 722638 Review-Url: https://codereview.chromium.org/2880963005 Cr-Commit-Position: refs/heads/master@{#472549} [modify] https://crrev.com/753970e38dce9e1bdb45fbf87abb668684f8de5d/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc [modify] https://crrev.com/753970e38dce9e1bdb45fbf87abb668684f8de5d/chrome/browser/offline_pages/background_loader_offliner.cc [modify] https://crrev.com/753970e38dce9e1bdb45fbf87abb668684f8de5d/components/offline_pages/core/offline_page_archiver.h [modify] https://crrev.com/753970e38dce9e1bdb45fbf87abb668684f8de5d/components/offline_pages/core/offline_page_model.h [modify] https://crrev.com/753970e38dce9e1bdb45fbf87abb668684f8de5d/components/offline_pages/core/offline_page_model_impl.cc [modify] https://crrev.com/753970e38dce9e1bdb45fbf87abb668684f8de5d/components/offline_pages/core/offline_page_model_impl_unittest.cc [modify] https://crrev.com/753970e38dce9e1bdb45fbf87abb668684f8de5d/content/public/common/mhtml_generation_params.h
We have added two of the three problem detectors we originally intended. The last is significantly more complicated to build. We're leaving this bug open to remind us to create the blank page detector and turn it on.
WW're giving up on the blank page detector as not worth the effort, so marking the bug fixed to account for the two that we built.
Comment 1 by fgor...@chromium.org
, May 17 2017Status: Assigned (was: Untriaged)