New issue
Advanced search Search tips

Issue 722638 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 24
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Add Offline Pages Problem Metrics

Project Member Reported by petewil@chromium.org, May 16 2017

Issue description

We should add UMA to better understand problems that our users are
having with offline pages.
 
Labels: OS-Android
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/753970e38dce9e1bdb45fbf87abb668684f8de5d

commit 753970e38dce9e1bdb45fbf87abb668684f8de5d
Author: petewil <petewil@chromium.org>
Date: Wed May 17 20:25:39 2017

Add a param to MHTMLGenerationManager

Add Page Problem Detectors variable to MHTMLGenerationParams
Also sets the variable when using the BackgroundLoadingOffliner.

Design Doc here: https://docs.google.com/document/d/1PWiu6PnLktkb-n-HgITR0EnEK6llKiJAJ9Xrk_2D6ts

BUG= 722638 

Review-Url: https://codereview.chromium.org/2880963005
Cr-Commit-Position: refs/heads/master@{#472549}

[modify] https://crrev.com/753970e38dce9e1bdb45fbf87abb668684f8de5d/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc
[modify] https://crrev.com/753970e38dce9e1bdb45fbf87abb668684f8de5d/chrome/browser/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/753970e38dce9e1bdb45fbf87abb668684f8de5d/components/offline_pages/core/offline_page_archiver.h
[modify] https://crrev.com/753970e38dce9e1bdb45fbf87abb668684f8de5d/components/offline_pages/core/offline_page_model.h
[modify] https://crrev.com/753970e38dce9e1bdb45fbf87abb668684f8de5d/components/offline_pages/core/offline_page_model_impl.cc
[modify] https://crrev.com/753970e38dce9e1bdb45fbf87abb668684f8de5d/components/offline_pages/core/offline_page_model_impl_unittest.cc
[modify] https://crrev.com/753970e38dce9e1bdb45fbf87abb668684f8de5d/content/public/common/mhtml_generation_params.h

Status: Started (was: Assigned)
We have added two of the three problem detectors we originally intended.  The last is significantly more complicated to build.  We're leaving this bug open to remind us to create the blank page detector and turn it on.
Status: Fixed (was: Started)
WW're giving up on the blank page detector as not worth the effort, so marking the bug fixed to account for the two that we built.

Sign in to add a comment